| Time |
Nick |
Message |
| 00:24 |
|
RKINGLEGEND joined #minetest-dev |
| 00:25 |
|
octacian joined #minetest-dev |
| 00:43 |
paramat |
added docs to #6019 , retested and will merge in a few mins |
| 00:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/6019 -- Mgv5/v7/fractal: Add 'large_cave_depth' parameter to replace fixed value by paramat |
| 00:51 |
paramat |
will also merge #5774 |
| 00:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/5774 -- Make addItem for empty ItemStacks respect max stack size by nybble41 |
| 00:52 |
|
Fritigern joined #minetest-dev |
| 01:01 |
paramat |
merging |
| 01:09 |
paramat |
complete |
| 01:20 |
|
Ighalli left #minetest-dev |
| 01:37 |
|
Tmanyo joined #minetest-dev |
| 02:09 |
|
Zeno` joined #minetest-dev |
| 02:10 |
|
YuGiOhJCJ joined #minetest-dev |
| 02:14 |
|
octacian_ joined #minetest-dev |
| 02:35 |
|
TC02 joined #minetest-dev |
| 02:47 |
|
octacian joined #minetest-dev |
| 03:20 |
|
Hunterz joined #minetest-dev |
| 03:38 |
|
bigfoot547 joined #minetest-dev |
| 03:56 |
|
ssieb joined #minetest-dev |
| 04:37 |
|
benrob0329 joined #minetest-dev |
| 05:10 |
|
Hunterz joined #minetest-dev |
| 05:38 |
|
nerzhul joined #minetest-dev |
| 05:50 |
nerzhul |
merging trivial #6023 |
| 05:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/6023 -- Fix console resize issue when maximising game window by Ezhh |
| 05:56 |
\o` |
thanks. I actually did that change the other day and somehow it was omitted from my PR :/ |
| 05:56 |
\o` |
I have too many branches :) |
| 05:56 |
nerzhul |
hey \o` :) |
| 05:57 |
nerzhul |
can you test & approve #6008 , #6012 and #6021 please ? :) |
| 05:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/6008 -- Fix render order of overlays by juhdanad |
| 05:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/6012 -- C++11 cleanup on constructors dir client by Dumbeldor |
| 05:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/6021 -- C++11 cleanup on constructors dir network by Dumbeldor |
| 05:57 |
\o` |
looking |
| 05:58 |
nerzhul |
and #6022 |
| 05:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/6022 -- Cpp11 initializers: last src root changeset by nerzhul |
| 05:59 |
nerzhul |
the merged PR fix the console not fiting height when maximimizing for me it's nice :) no width problem |
| 05:59 |
\o` |
https://github.com/minetest/minetest/pull/6008/files#diff-37ea431d4de34ca3cc1fb0c79a36d1fbR477 <-- why is that int? |
| 06:03 |
\o` |
I'll review 6022 in a bit (it's larger than the others) |
| 06:03 |
\o` |
+1 on 6012 and 6021 |
| 06:04 |
\o` |
fine with 6008 if int is actually an appropriate type (see comment) |
| 06:04 |
nerzhul |
oh yes it should be std::time_t |
| 06:04 |
nerzhul |
merging 6012 & 6021 |
| 06:05 |
nerzhul |
not 6021 :) |
| 06:05 |
nerzhul |
waiting for braces :p |
| 06:07 |
nerzhul |
i fixed them, faster than waiting :p |
| 06:07 |
\o` |
well, int might be ok but if it is it needs a comment at least. I'd rather see it using time_t though |
| 06:13 |
\o` |
nerzhul, some minor comments on 6022 |
| 06:17 |
\o` |
other than the questions/comments it seems straightforward |
| 06:17 |
nerzhul |
i can fix some code style |
| 06:17 |
nerzhul |
for magic values i kept original magic values |
| 06:18 |
nerzhul |
i don't take a look at their meaning, it's only a conversion |
| 06:18 |
\o` |
yeah I guessed that. And kept some original formatting as well I see. It's no big deal, just comments in general ;) |
| 06:18 |
\o` |
but the formatting on the lines I indicated may as well be fixed since they're so trivial |
| 06:19 |
\o` |
(and close to modified lines anyway heh) |
| 06:19 |
\o` |
I'll +1 it when you're ready |
| 06:21 |
nerzhul |
time_t is not a int it's a u64 in many systems since some years (2038 bug) |
| 06:22 |
\o` |
correct |
| 06:22 |
\o` |
which is why it's better to use time_t |
| 06:22 |
\o` |
but for small periods int *might* be ok, but why bother? |
| 06:23 |
nerzhul |
in 2038 we will have some problems haha :p |
| 06:23 |
nerzhul |
i fixed the style on 6022 |
| 06:23 |
\o` |
+1 |
| 06:24 |
nerzhul |
i will merge 6022 when CI will finish the build |
| 06:24 |
nerzhul |
i can merge 6021 now if you are okay |
| 06:25 |
\o` |
oh. braces fixed. Yep go ahead |
| 06:31 |
nerzhul |
i fixed the time_t on 6008 |
| 06:32 |
\o` |
+1'd |
| 06:39 |
nerzhul |
ty |
| 06:39 |
nerzhul |
i will merge both at work after travis pass |
| 07:06 |
|
octacian_ joined #minetest-dev |
| 07:33 |
|
kilbith joined #minetest-dev |
| 07:39 |
|
red-001 joined #minetest-dev |
| 07:46 |
|
proller joined #minetest-dev |
| 08:09 |
|
jin_xi joined #minetest-dev |
| 08:12 |
|
est31 joined #minetest-dev |
| 08:32 |
|
nerzhul joined #minetest-dev |
| 08:35 |
nerzhul |
hello, merging #6008 & #6022 in ~5 mins |
| 08:35 |
ShadowBot |
https://github.com/minetest/minetest/issues/6008 -- Fix render order of overlays by juhdanad |
| 08:35 |
ShadowBot |
https://github.com/minetest/minetest/issues/6022 -- Cpp11 initializers: last src root changeset by nerzhul |
| 08:43 |
|
proller joined #minetest-dev |
| 09:02 |
|
red-001 joined #minetest-dev |
| 09:12 |
|
Raven262 joined #minetest-dev |
| 09:51 |
nerzhul |
can someone look at #5793 it's ready since aged |
| 09:51 |
nerzhul |
ages* |
| 09:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/5793 -- [CSM] Add callback on open inventory by Dumbeldor |
| 10:39 |
|
lisac joined #minetest-dev |
| 10:47 |
|
YuGiOhJCJ joined #minetest-dev |
| 11:00 |
red-001 |
#5532 seems to always get forgotten |
| 11:00 |
ShadowBot |
https://github.com/minetest/minetest/issues/5532 -- [CSM] Add tab autocompletion api by HybridDog |
| 11:24 |
|
jomat joined #minetest-dev |
| 12:02 |
|
proller joined #minetest-dev |
| 12:14 |
|
RobbieF joined #minetest-dev |
| 12:18 |
|
est31 left #minetest-dev |
| 13:08 |
|
johnnyjoy joined #minetest-dev |
| 13:11 |
|
DI3HARD139 joined #minetest-dev |
| 13:28 |
|
octacian joined #minetest-dev |
| 13:30 |
|
kilbith_ joined #minetest-dev |
| 13:46 |
|
Fixer joined #minetest-dev |
| 13:48 |
red-001 |
updated #5965 |
| 13:48 |
ShadowBot |
https://github.com/minetest/minetest/issues/5965 -- Load client-side mods into memory before executing them. by red-001 |
| 13:53 |
nerzhul |
red-001, maybe update title ? |
| 13:57 |
|
antims joined #minetest-dev |
| 14:05 |
|
DS-minetest joined #minetest-dev |
| 14:26 |
red-001 |
renamed #5965 |
| 14:26 |
ShadowBot |
https://github.com/minetest/minetest/issues/5965 -- Create a filesystem abstraction layer for CSM and only allow accessing files that are loaded into it. by red-001 |
| 14:27 |
Hijiri |
#5612 #5819 |
| 14:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/5612 -- Allow overriding tool capabilities through itemstack metadata by raymoo |
| 14:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/5819 -- Fix default item callbacks to work with nil users by raymoo |
| 14:28 |
Hijiri |
oh whoops, one of them has merge conflicts |
| 14:29 |
|
cx384 joined #minetest-dev |
| 15:30 |
|
proller joined #minetest-dev |
| 15:43 |
|
Hunterz joined #minetest-dev |
| 15:55 |
|
Lunatrius joined #minetest-dev |
| 16:11 |
Hijiri |
ok, rebased #5612 |
| 16:11 |
ShadowBot |
https://github.com/minetest/minetest/issues/5612 -- Allow overriding tool capabilities through itemstack metadata by raymoo |
| 16:31 |
|
bigfoot547 joined #minetest-dev |
| 16:32 |
|
kilbith_ joined #minetest-dev |
| 16:50 |
|
kilbith joined #minetest-dev |
| 16:55 |
|
bigfoot547 joined #minetest-dev |
| 17:03 |
|
Fixer joined #minetest-dev |
| 17:24 |
|
YuGiOhJCJ joined #minetest-dev |
| 17:29 |
|
CWz joined #minetest-dev |
| 17:29 |
|
CWz left #minetest-dev |
| 17:39 |
|
Krock joined #minetest-dev |
| 18:01 |
|
ssieb joined #minetest-dev |
| 18:19 |
|
nerzhul joined #minetest-dev |
| 18:24 |
|
octacian_ joined #minetest-dev |
| 18:24 |
|
Raven262 joined #minetest-dev |
| 18:24 |
|
octacian joined #minetest-dev |
| 18:29 |
|
Natechip joined #minetest-dev |
| 18:39 |
|
calcul0n joined #minetest-dev |
| 18:46 |
|
fwhcat joined #minetest-dev |
| 19:16 |
|
RobbieF left #minetest-dev |
| 19:28 |
|
QwertyDragon joined #minetest-dev |
| 19:31 |
|
bigfoot547 joined #minetest-dev |
| 19:33 |
|
fwhcat joined #minetest-dev |
| 19:37 |
nerzhul |
merging #6014 in ~5 mins |
| 19:37 |
ShadowBot |
https://github.com/minetest/minetest/issues/6014 -- Add color values to hex string function minetest.rgba by HybridDog |
| 19:54 |
|
halt_ joined #minetest-dev |
| 20:00 |
|
halt_ joined #minetest-dev |
| 20:25 |
|
kaeza joined #minetest-dev |
| 21:09 |
red-001 |
huh looks like there is a way to only open the lua libs you need |
| 21:13 |
red-001 |
but it's somewhat diffrent in lua and luajit |
| 21:14 |
|
Darcidride joined #minetest-dev |
| 21:16 |
|
Lunatrius` joined #minetest-dev |
| 21:18 |
nerzhul |
you mean the require keyword ? yes we should use that in lua |
| 21:18 |
nerzhul |
CSM |
| 21:19 |
red-001 |
I meant loading luas builtin libraries like IO and OS |
| 21:20 |
red-001 |
I don't really understand how require is suppose to be diffrent from dofile/loadfile etc |
| 21:21 |
red-001 |
so I don't know how to implement it correctly for CSM |
| 21:26 |
|
Raven262 joined #minetest-dev |
| 21:36 |
|
proller joined #minetest-dev |
| 21:44 |
ShadowNinja |
red-001: I reviewed your patch. Overall it looks quite good, but there are still a few things to polish it off. |
| 21:48 |
|
jin_xi joined #minetest-dev |
| 22:00 |
red-001 |
ok |
| 22:53 |
|
est31 joined #minetest-dev |
| 22:56 |
|
est31 left #minetest-dev |
