Time |
Nick |
Message |
00:00 |
sapier1 |
hmm the 256 actually set's the color to 0 if it's below 0 |
00:08 |
|
STHGOM joined #minetest-dev |
00:10 |
|
YuGiOhJCJ joined #minetest-dev |
00:11 |
|
Zeno` joined #minetest-dev |
00:43 |
|
red-001 joined #minetest-dev |
00:47 |
|
sapier1 left #minetest-dev |
01:11 |
|
STHGOM joined #minetest-dev |
01:20 |
|
octacian joined #minetest-dev |
01:46 |
paramat |
will merge #5046 in a moment, trivial docs |
01:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/5046 -- Documentation: Correct biome heat / humidity noise parameters by paramat |
01:48 |
paramat |
i'll merge #5044 too |
01:48 |
ShadowBot |
https://github.com/minetest/minetest/issues/5044 -- Add color names from web page referenced in luaapi doc by sapier |
02:07 |
paramat |
now merging |
02:10 |
paramat |
complete |
03:13 |
|
Miner_48er joined #minetest-dev |
03:16 |
|
kaeza joined #minetest-dev |
03:44 |
YuGiOhJCJ |
paramat, I thought you was neutral about this PR https://github.com/minetest/minetest/pull/4622 but in fact it seems not because you removed it from the 0.4.16 milestone :p |
03:49 |
paramat |
i am neutral |
03:49 |
paramat |
it was removed from the milestone only because the milestone was redundant and pointless |
03:50 |
paramat |
i deleted the milestone which caused that message on all PRs which had been part of that milestone |
03:52 |
paramat |
so that 'removal' was not restricted to your PR. the PR seems a good idea to me |
03:56 |
paramat |
i see, 22 days ago was just after release. before release the 0.4.16 milestone was used to label PRs that are to be delayed until after release. then at release that milestone becomes pointless so it was deleted :] |
03:56 |
YuGiOhJCJ |
oh so that's fine, anyway I must admit that I am not 100% satisfied of this PR (because I prefer a boolean ENABLE_LUAJIT variable: "true" -> error when luajit is not installed and luajit is used, "false" -> no error and luajit is not used, "not set" -> no error and luajit can be used or not automatically depending of what is installed on the system, it makes more sense to me but not for other people in the discussion) |
03:59 |
paramat |
if you describe your new idea in the thread people might like it and support it :] |
03:59 |
YuGiOhJCJ |
well I think I have already proposed it but I can try to explain it better :p |
03:59 |
YuGiOhJCJ |
my proposal has been rejected |
04:00 |
YuGiOhJCJ |
so I modified the commit |
04:00 |
YuGiOhJCJ |
now everybody is happy with that |
04:00 |
YuGiOhJCJ |
(but I am not 100% happy :p) |
04:00 |
YuGiOhJCJ |
that's better than nothing anyway |
04:01 |
paramat |
ok cool |
04:02 |
YuGiOhJCJ |
OK I will just give my advice in the PR discussion to say that this solution is a compromise |
04:15 |
paramat |
looks like it could be merged soon |
04:17 |
YuGiOhJCJ |
nice |
04:17 |
YuGiOhJCJ |
OK I updated the discussion just to give my advice |
04:17 |
YuGiOhJCJ |
I hope it will convince :p |
04:20 |
paramat |
will merge game#1511 game#1513 in a moment |
04:20 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1511 -- Explosions should extinguish fire by lhofhansl |
04:20 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1513 -- Tree log decorations: Replace lua tables with .mts files by paramat |
04:20 |
YuGiOhJCJ |
At least, when I am reading it, it convinces myself which is a good point |
04:31 |
paramat |
now merging |
04:36 |
paramat |
complete |
04:50 |
|
DFeniks joined #minetest-dev |
06:22 |
|
lumidify joined #minetest-dev |
06:54 |
|
Zeno` joined #minetest-dev |
07:27 |
|
Hunterz joined #minetest-dev |
08:27 |
|
YuGiOhJCJ joined #minetest-dev |
08:38 |
|
nrzkt joined #minetest-dev |
08:45 |
|
fwhcat joined #minetest-dev |
08:50 |
|
Krock joined #minetest-dev |
08:50 |
|
Krock joined #minetest-dev |
08:54 |
|
Thomas-S joined #minetest-dev |
08:56 |
|
Thomas-S joined #minetest-dev |
09:02 |
|
Thomas-S joined #minetest-dev |
09:08 |
|
red-001 joined #minetest-dev |
09:12 |
|
red-001 joined #minetest-dev |
10:17 |
|
xunto joined #minetest-dev |
10:30 |
|
sapier joined #minetest-dev |
10:37 |
|
lisac joined #minetest-dev |
10:45 |
|
Fixer joined #minetest-dev |
10:52 |
|
Human_G33k joined #minetest-dev |
11:10 |
|
lumidify joined #minetest-dev |
11:15 |
|
red-001 joined #minetest-dev |
11:39 |
|
proller joined #minetest-dev |
12:24 |
|
fwhcat joined #minetest-dev |
12:33 |
|
nrzkt joined #minetest-dev |
12:36 |
nrzkt |
merging #5043 |
12:36 |
ShadowBot |
https://github.com/minetest/minetest/issues/5043 -- Added lua tracebacks to some errors where you have been blind to what… by sapier |
12:42 |
sapier |
nice, thanks :-) |
12:42 |
nrzkt |
thanks to you :) |
12:43 |
sapier |
I'm closing the mentioned issue too |
12:44 |
nrzkt |
sapier, don't forget to add Fixes #XXX to your commit it permit to auto close them |
12:44 |
nrzkt |
commitmsg* |
12:44 |
sapier |
as I added a traceback to the check macro all of the invalid parameter issues without lua traceback should be fixed now |
12:45 |
Krock |
but it spams the target issue when you force-push a new commit (amend) |
12:45 |
sapier |
ok I'll do it that way next time |
12:45 |
nrzkt |
Krock, depend if you squash or not, squashing is not required now on github, we can do it ourselves when merging, but it's a good practice |
12:46 |
Krock |
ah okay |
12:53 |
Zeno`` |
we could always squash when merging |
12:53 |
Zeno`` |
devs were just lazy |
12:55 |
Zeno`` |
I actually don't like the new github feature :3 |
13:11 |
kaeza |
would be nice if the commit message was fixed before merging |
13:11 |
kaeza |
meh |
13:13 |
* Krock |
has never used the merge/squash button yet and feels like a newbee |
13:15 |
|
blaze joined #minetest-dev |
13:27 |
|
Zeno` joined #minetest-dev |
13:33 |
|
DFeniks joined #minetest-dev |
13:37 |
|
fwhcat joined #minetest-dev |
13:44 |
Pingus |
Hello. Where does one get entity's name and mod? (default:cobble) |
13:44 |
Pingus |
from C++ |
13:47 |
sapier |
defaut:cobble is a node registration not an entity |
13:50 |
Pingus |
It's an example. |
13:50 |
Pingus |
Entities have <name>:<mod> too, right? |
13:50 |
Pingus |
*<mod>:<name> |
13:52 |
Krock |
yes, they follow the same scheme |
13:54 |
Pingus |
or rather, how to get it from inside GenericCAO? |
13:55 |
Krock |
I've the feeling that m_name is only for players, but I'm not sure |
13:56 |
sapier |
yes m_name is player only |
13:57 |
sapier |
for what i know that information is only present in lua you could call the lua function to return it to c++ |
13:58 |
Pingus |
Okay. |
14:00 |
Krock |
yes, it looks up the table core.luaentities[id] |
14:00 |
Krock |
that's done in the C++ function luaentity_get in c_content.cpp |
14:04 |
|
STHGOM joined #minetest-dev |
14:04 |
|
STHGOM joined #minetest-dev |
14:10 |
|
proller joined #minetest-dev |
14:10 |
|
nrzkt joined #minetest-dev |
14:18 |
|
diemartin joined #minetest-dev |
14:25 |
|
Taoki joined #minetest-dev |
14:34 |
|
STHGOM joined #minetest-dev |
15:41 |
|
nrzkt joined #minetest-dev |
15:51 |
|
betterthanyou710 joined #minetest-dev |
15:52 |
|
Fixer joined #minetest-dev |
15:59 |
|
octacian joined #minetest-dev |
16:47 |
|
turtleman joined #minetest-dev |
17:01 |
|
juhdanad joined #minetest-dev |
17:12 |
|
red-001 joined #minetest-dev |
17:12 |
|
red-001 joined #minetest-dev |
17:52 |
|
red-001 joined #minetest-dev |
17:55 |
|
nrzkt joined #minetest-dev |
18:10 |
|
rubenwardy joined #minetest-dev |
18:51 |
|
^v joined #minetest-dev |
20:04 |
|
Miner_48er joined #minetest-dev |
20:18 |
sapier |
Is anone here who can tell me how param2 for liquids works? I assumed the higher the more close to source but that's not exactly true |
20:19 |
rubenwardy |
hey sapier! wb |
20:19 |
sapier |
hello rubenwardy |
20:20 |
sapier |
how are you ? :-) |
20:21 |
rubenwardy |
good thanks, you? |
20:21 |
sapier |
I'm fine, I almost forgot how strange some things are handled in minetest ;-) |
20:22 |
sapier |
ok param2 for liquids does contain more then distance from source |
20:23 |
sapier |
I sometimes wonder how mod developers can do their work. Without looking to c++ code lot's of things just don't work |
20:36 |
|
red-001 joined #minetest-dev |
20:36 |
|
red-001 joined #minetest-dev |
20:52 |
|
octacian_ joined #minetest-dev |
20:56 |
|
octacian joined #minetest-dev |
21:01 |
|
Tmanyo joined #minetest-dev |
21:30 |
juhdanad |
I think the WIP label can now be removed from #4986. |
21:30 |
ShadowBot |
https://github.com/minetest/minetest/issues/4986 -- Hardware node coloring by juhdanad |
22:19 |
|
DFeniks joined #minetest-dev |
22:22 |
|
DI3HARD139 joined #minetest-dev |
22:58 |
|
Player_2 joined #minetest-dev |
23:01 |
|
sapier1 joined #minetest-dev |
23:15 |
|
STHGOM joined #minetest-dev |
23:38 |
|
red-001 joined #minetest-dev |
23:38 |
|
red-001 joined #minetest-dev |
23:51 |
|
red-001 joined #minetest-dev |
23:51 |
|
red-001 joined #minetest-dev |
23:56 |
|
red-001 joined #minetest-dev |
23:56 |
|
red-001 joined #minetest-dev |
23:57 |
red-001 |
can the server check the protocol version of the client? |