| Time |
Nick |
Message |
| 00:05 |
|
turtleman joined #minetest-dev |
| 00:37 |
|
YuGiOhJCJ joined #minetest-dev |
| 00:49 |
|
Tmanyo joined #minetest-dev |
| 01:08 |
|
DI3HARD139 joined #minetest-dev |
| 01:33 |
|
STHGOM_ joined #minetest-dev |
| 01:35 |
|
crazyR_ joined #minetest-dev |
| 02:00 |
|
Foz1 joined #minetest-dev |
| 02:03 |
|
Tmanyo joined #minetest-dev |
| 02:05 |
|
Foz joined #minetest-dev |
| 02:22 |
|
kaeza joined #minetest-dev |
| 02:37 |
|
Tmanyo joined #minetest-dev |
| 02:39 |
|
STHGOM joined #minetest-dev |
| 02:39 |
|
STHGOM joined #minetest-dev |
| 03:00 |
|
crazyR joined #minetest-dev |
| 03:31 |
|
froike joined #minetest-dev |
| 03:43 |
|
Taose joined #minetest-dev |
| 03:43 |
Taose |
...familiar names all over the place |
| 03:44 |
Taose |
heads up 504 errors on the website |
| 03:47 |
Taose |
VanessaE how big is that texture pack 250MB and rising so far? |
| 03:47 |
Taose |
(the 512 one) |
| 03:48 |
VanessaE |
er... |
| 03:48 |
VanessaE |
I think you answered your own question (also, wrong channel) :) |
| 03:50 |
Taose |
Oh I thought that was a reference to pixel density |
| 03:50 |
Taose |
Both channels pretty dead at the moment >.< |
| 03:51 |
|
Taose left #minetest-dev |
| 03:52 |
VanessaE |
512px is 512x512 for most images (some are larger, all inventory images are 64x64). 523MB, not including git history |
| 03:54 |
|
ptv joined #minetest-dev |
| 04:09 |
|
Zeno` joined #minetest-dev |
| 04:25 |
hmmmm |
too many commits and pull requests to keep track of them all |
| 04:26 |
hmmmm |
https://github.com/minetest/minetest/commit/52ba1f867e5edb579a59a44fbb8286d4f1e54931#diff-da1e28445fc732755d2b64683bd94ee4R948 |
| 04:26 |
hmmmm |
is it correct for a PlayerSAO object to send packets? |
| 04:28 |
|
lhofhansl joined #minetest-dev |
| 04:29 |
Zeno` |
hmm, not sure |
| 04:29 |
Zeno` |
thinking about it |
| 04:29 |
hmmmm |
well the fact that i asked the question means no |
| 04:29 |
Zeno` |
Oh, it was a rhetorical question. Jolly good |
| 04:29 |
hmmmm |
anyway i've been noticing a particular trend with nerzhul's changes |
| 04:30 |
Zeno` |
which is... |
| 04:30 |
hmmmm |
some change tends to conflate object concerns and then destroy the separation of concerns |
| 04:30 |
hmmmm |
it now sends packets |
| 04:30 |
hmmmm |
which makes unit testing harder |
| 04:30 |
hmmmm |
solution? add an optional boolean "send = true" and make this boolean false in the unit tests |
| 04:30 |
hmmmm |
this is not the first change that did this |
| 04:31 |
hmmmm |
there were 2 other commits with similar modifications |
| 04:31 |
Zeno` |
what is bool send_recommended? |
| 04:31 |
Zeno` |
doesn't seem to be used |
| 04:32 |
Zeno` |
lots of functions have "bool send_recommended" but none of them use it |
| 04:32 |
Zeno` |
weird |
| 04:32 |
hmmmm |
i don't know but the second you start getting your Server * from the m_env |
| 04:32 |
hmmmm |
you know you weren't supposed to do that |
| 04:33 |
hmmmm |
i'm not gonna pick on nerzhul in particular here, but i've noticed there's a large portion of people who try to make it a game or something on how to accomplish their immediate goal without changing the classes' interface at all |
| 04:34 |
hmmmm |
which involves some combination of reading pseudo-private variables, casting, etc. basically banging on it with a wrench until they get the object they need to do the thing they need inside the wrong object |
| 04:34 |
hmmmm |
if you object, you'll get a reply along the lines of, "but it works!" |
| 04:34 |
hmmmm |
"i tested it!" |
| 04:35 |
Zeno` |
heh |
| 04:36 |
Zeno` |
may as well not have classes |
| 04:36 |
Zeno` |
just a whole bunch of globals |
| 04:37 |
hmmmm |
yes, i feel like the structure of minetest has been eroded an incredible amount by contributors who just don't have enough exposure to the codebase or don't care to make sure the object relations are correct, and concerns are appropriately separated |
| 04:38 |
hmmmm |
it's frustrating when you're me because i really want to work on one thing and then i see all this stupid stuff happening elsewhere |
| 04:39 |
hmmmm |
i think if i ever make my own minetest i will not allow outside contributions |
| 04:54 |
sofar |
yes, but you're not retired yet :) |
| 04:56 |
hmmmm |
well when i say 'my own minetest' i mean my own project that i'd nurture like minetest |
| 04:57 |
Zeno` |
it shall be called hmmmmtest? |
| 04:59 |
sofar |
Zeno`: what do you think about my lower-light just means slower-growth idea? |
| 05:00 |
sofar |
I think that could be a nice compromise |
| 05:01 |
hmmmm |
sofar, I actually like that. was that really your idea? lol |
| 05:01 |
hmmmm |
i thought the jhuawhatever guy said it first |
| 05:01 |
sofar |
it's not a brilliant thought |
| 05:02 |
hmmmm |
really? |
| 05:02 |
sofar |
the nice thing is that because everything is nodetimer based, it's darn easy to implement |
| 05:02 |
sofar |
just change the nodetimer length |
| 05:02 |
hmmmm |
simple thoughts are sometimes brilliant because of their simplicity |
| 05:02 |
Zeno` |
sofar I like it |
| 05:03 |
sofar |
just have to make sure we handle saplings planted at night |
| 05:03 |
Zeno` |
sofar that is, IMO, the better way to do it |
| 05:03 |
Zeno` |
it's a better balance |
| 05:03 |
Zeno` |
microherbs, btw, are grown underground |
| 05:03 |
Zeno` |
in complete darkness :) |
| 05:04 |
hmmmm |
microherbs |
| 05:04 |
hmmmm |
is that some kind of new marijuana strain? |
| 05:04 |
Zeno` |
lol nah... basically seedlings of herbs that are trendy at posh restaurants |
| 05:05 |
Zeno` |
we could add MJ to the game though |
| 05:05 |
Zeno` |
if you really think it will be accepted |
| 05:05 |
hmmmm |
they'll lose the game if they do |
| 05:05 |
sofar |
unlikely, as it's still illegal for minors |
| 05:05 |
hmmmm |
remember? "Winners don't do drugs" |
| 05:05 |
Zeno` |
best not to |
| 05:05 |
hmmmm |
- Jeff Sessions, F.B.I. Director |
| 05:06 |
sofar |
same reason we avoid alcohol and (chriek) sex in minetest ;) |
| 05:06 |
Zeno` |
hmmmm, I mean for making hemp ropes and stuff! |
| 05:06 |
sofar |
we wouldn't want kids to actually enjoy themselves now, wouldn't we? |
| 05:06 |
hmmmm |
haha |
| 05:06 |
Zeno` |
no. naughty |
| 05:07 |
hmmmm |
ok back to work |
| 05:08 |
|
QwertyDragon joined #minetest-dev |
| 06:07 |
|
Hunterz joined #minetest-dev |
| 06:07 |
|
YuGiOhJCJ joined #minetest-dev |
| 06:16 |
|
jordan4ibanez joined #minetest-dev |
| 06:43 |
|
nrzkt joined #minetest-dev |
| 07:08 |
|
lumidify joined #minetest-dev |
| 07:19 |
Zeno` |
has the way world/worldmods/ loads changed? |
| 07:21 |
|
lhofhansl left #minetest-dev |
| 07:44 |
|
minetester joined #minetest-dev |
| 08:03 |
|
lumidify joined #minetest-dev |
| 08:16 |
|
Human_G33k joined #minetest-dev |
| 08:19 |
OldCoder |
hmmmm, sofar, Zeno` yesterday I demonstrated MT for a 6 year old and 4 year old |
| 08:19 |
OldCoder |
Parents and great grandparents |
| 08:19 |
OldCoder |
would most likely |
| 08:19 |
OldCoder |
have considered such additions to be non standard :-) |
| 08:21 |
Zeno` |
which additions? |
| 08:21 |
Zeno` |
oh hemp? |
| 08:21 |
Zeno` |
yeah that was a joke :) |
| 08:21 |
OldCoder |
It is fine for ropes :-) |
| 08:21 |
OldCoder |
Hm |
| 08:22 |
OldCoder |
Dispensary would be a useful building |
| 08:22 |
Zeno` |
there are other fibrous plants to make ropes out of hehe |
| 08:22 |
OldCoder |
But it would need a MT ID card |
| 08:22 |
Zeno` |
although help is traditionally good |
| 08:22 |
OldCoder |
help? |
| 08:22 |
Zeno` |
OldCoder, if you want to write an ID mod |
| 08:22 |
OldCoder |
Typo? |
| 08:22 |
Zeno` |
hemp* |
| 08:22 |
OldCoder |
Little card certifying one is 21 in MT years. Hm. |
| 08:22 |
Zeno` |
I was thinking one thing and typing of something else I was thinking of haha |
| 08:23 |
* OldCoder |
dozes. Night. |
| 08:24 |
|
Fritigern joined #minetest-dev |
| 08:55 |
|
nrzkt joined #minetest-dev |
| 09:04 |
|
lumidify joined #minetest-dev |
| 09:26 |
|
Zeno`` joined #minetest-dev |
| 09:27 |
|
Zeno`` joined #minetest-dev |
| 09:29 |
|
Krock joined #minetest-dev |
| 09:29 |
|
Krock joined #minetest-dev |
| 09:36 |
|
Thomas-S joined #minetest-dev |
| 09:45 |
|
Zeno` joined #minetest-dev |
| 09:46 |
|
dzho joined #minetest-dev |
| 09:49 |
|
cheapie joined #minetest-dev |
| 09:53 |
|
Marko10_000 joined #minetest-dev |
| 09:57 |
|
Marko10_000 joined #minetest-dev |
| 10:02 |
|
fling joined #minetest-dev |
| 10:08 |
|
Zeno` joined #minetest-dev |
| 10:19 |
jordan4ibanez |
What does vector.normalize do? |
| 10:23 |
Marko10_000 |
i guess it's normalize an vector? |
| 10:24 |
Marko10_000 |
aka. direction of the vector will be hold, but the vector size is 1 |
| 10:24 |
Krock |
means, the hypotenuse of x y and z is 1 |
| 10:25 |
jordan4ibanez |
Thank you |
| 10:25 |
Krock |
then it's backwards calculated to each length |
| 10:32 |
|
emptty joined #minetest-dev |
| 10:38 |
|
juhdanad joined #minetest-dev |
| 10:39 |
juhdanad |
Hi! Implementing light-based plant growth is not as easy as changing a node timer's time, if you want to do it work in every situation! |
| 10:40 |
juhdanad |
If you plant a seed in darkness, then place a torch next to it, the plant will still grow slowly. |
| 11:08 |
Krock |
I think updating it once per timer step does it |
| 11:09 |
Krock |
where it = the timer |
| 11:10 |
juhdanad |
Yes, it does it. Just one step will be slower because the plant was placed in a dimmer area. |
| 11:43 |
|
lumidify joined #minetest-dev |
| 12:04 |
|
Zeno` joined #minetest-dev |
| 12:08 |
|
Fixer joined #minetest-dev |
| 12:21 |
|
lumidify joined #minetest-dev |
| 12:22 |
|
minetester joined #minetest-dev |
| 12:22 |
|
Fixer_ joined #minetest-dev |
| 12:24 |
|
Fritigern joined #minetest-dev |
| 12:35 |
|
Fixer joined #minetest-dev |
| 13:04 |
|
crazyR joined #minetest-dev |
| 13:11 |
|
juhdanad joined #minetest-dev |
| 13:29 |
nrzkt |
http://www.phoronix.com/scan.php?page=news_item&px=SQLite-3.16-Released interesting for sqlite owners :) |
| 13:34 |
|
DFeniks joined #minetest-dev |
| 14:00 |
sfan5 |
#4952 rebase, one review still needed (ping nore Zeno`) |
| 14:00 |
ShadowBot |
https://github.com/minetest/minetest/issues/4952 -- TileAnimation refactor & 2D sheet animation by sfan5 |
| 14:07 |
Zeno` |
19 files |
| 14:08 |
nore |
sfan5: can't test it now, but code looks good |
| 14:09 |
sfan5 |
thanks |
| 14:09 |
nore |
(there is just that small rebase problem about the TOSERVER_BREATH packet) |
| 14:10 |
Zeno` |
is this protocol bump compatible with what nore just mentioned? |
| 14:11 |
nore |
Zeno`: we're taking advantage that we're protocol bumping to merge that as well |
| 14:11 |
sfan5 |
^ |
| 14:11 |
nore |
if we wait too long, we would need another protocol bump |
| 14:11 |
Zeno` |
yeah which is what I guessed |
| 14:11 |
Zeno` |
which I asked if it was compatible :) |
| 14:11 |
Zeno` |
is why I * |
| 14:13 |
Zeno` |
it looks fine |
| 14:13 |
* Zeno` |
thinks |
| 14:13 |
Zeno` |
so how to test? |
| 14:14 |
Zeno` |
I guess there is not much need to test |
| 14:14 |
Calinou |
the Minetest mobile app from F-Droid does not seem to save settings in 0.4.15, is this normal? |
| 14:14 |
Zeno` |
if it didn't work it's look wrong |
| 14:14 |
Calinou |
(no minetest.conf on device, quitting and restarting app resets all settings to their defaults) |
| 14:15 |
Zeno` |
testing now |
| 14:16 |
sfan5 |
Zeno`: use minimal game and see if lava_source animates correctly |
| 14:16 |
sfan5 |
oh you probably meant the android thing |
| 14:17 |
Calinou |
I'm running Android 7 (custom ROM) on LG G3 |
| 14:19 |
est31 |
I think we need no extra bump on dev versions |
| 14:19 |
Zeno` |
sfan5, I'll do that next... checking on a server atm |
| 14:19 |
est31 |
as long as people still can connect and stuff it should be okay |
| 14:19 |
sfan5 |
i've tested compat before, so if it breaks now then it's caused by the rebase |
| 14:22 |
Zeno` |
lava looks fine on a 0.4.13 server |
| 14:22 |
Zeno` |
so try minimal? |
| 14:22 |
sfan5 |
the only thing that breaks is new server (+ sheet_2d anim) & old client |
| 14:25 |
Zeno` |
what's happened to all the lava in mgv7? |
| 14:25 |
Zeno` |
found some (finally) |
| 14:25 |
Fixer |
0.4.15 from fdroid saves settings fine for me on android 4.4.2 |
| 14:26 |
Zeno` |
sfan5, has the lava animation changed? |
| 14:26 |
sfan5 |
in minimal? no |
| 14:26 |
Zeno` |
I think it looks fine |
| 14:27 |
Zeno` |
yeah I'll +1 it |
| 14:27 |
|
An0n3m0us joined #minetest-dev |
| 14:27 |
sfan5 |
merging it then |
| 14:35 |
|
Player_2 joined #minetest-dev |
| 14:40 |
|
STHGOM joined #minetest-dev |
| 15:09 |
|
jordan4ibanez joined #minetest-dev |
| 15:45 |
|
rubenwardy joined #minetest-dev |
| 15:46 |
rubenwardy |
game#1483 |
| 15:46 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1483 -- Add /killme chat command by rubenwardy |
| 15:47 |
|
turtleman joined #minetest-dev |
| 15:56 |
|
paramat joined #minetest-dev |
| 15:57 |
paramat |
hi :] please can anyone review #4965 ? fairly simple bugfix and tested |
| 15:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/4965 -- Map generation limit: Fix checks for block/sector over-limit by paramat |
| 16:55 |
rubenwardy |
game#1484 |
| 16:55 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1484 -- Add LICENSE.txt by rubenwardy |
| 17:00 |
paramat |
will look soon |
| 17:04 |
|
lisac joined #minetest-dev |
| 17:13 |
|
Hunterz joined #minetest-dev |
| 17:18 |
rubenwardy |
WIP: http://dev.minetest.net/User:Rubenwardy/Minetest_Game_Development |
| 17:18 |
rubenwardy |
Trying to summarise MTG's goals better |
| 17:18 |
rubenwardy |
some of that is my own opinion, feel free to argue |
| 17:34 |
|
Warr1024 joined #minetest-dev |
| 17:43 |
rubenwardy |
game##1486 |
| 17:43 |
rubenwardy |
game#1486 |
| 17:43 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1486 -- Add default.can_use_locked_node by rubenwardy |
| 17:44 |
Fixer |
it is great time to start thinking about ability to label stuff in game, that will be very handy for introduced keys in MT |
| 17:44 |
Fixer |
G |
| 17:46 |
|
turtleman joined #minetest-dev |
| 17:47 |
rubenwardy |
needs engine change |
| 17:47 |
Fixer |
yes |
| 17:47 |
|
AcidNinjaFWHR joined #minetest-dev |
| 17:48 |
rubenwardy |
argh, why do doors use "doors_owner"? "owner" is standard amongst pretty much everything |
| 17:49 |
|
xunto joined #minetest-dev |
| 17:53 |
|
Darcidride joined #minetest-dev |
| 17:56 |
|
dmurph joined #minetest-dev |
| 17:57 |
rubenwardy |
updated game#1486 |
| 17:57 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1486 -- Add default.can_use_locked_node by rubenwardy |
| 17:58 |
paramat |
i'll merge game#1472 game#1481 later, and probably game#1484 too, now looking .. |
| 17:58 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1472 -- Papyrus, Cactus: Only make them grow in bright places by SmallJoker |
| 17:58 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1481 -- Default: More generous meselamp recipe by paramat |
| 17:58 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1484 -- Add LICENSE.txt by rubenwardy |
| 18:02 |
paramat |
1484 +1 |
| 18:07 |
|
nrzkt joined #minetest-dev |
| 18:10 |
|
lumidify joined #minetest-dev |
| 18:20 |
paramat |
ok i'll merge those 3 in a moment |
| 18:20 |
rubenwardy |
excellent |
| 18:21 |
|
turtleman joined #minetest-dev |
| 18:24 |
|
emptty joined #minetest-dev |
| 18:24 |
|
lisac joined #minetest-dev |
| 18:28 |
|
hmmmm joined #minetest-dev |
| 18:33 |
|
juhdanad joined #minetest-dev |
| 18:39 |
|
blaze joined #minetest-dev |
| 18:42 |
paramat |
now merging .. |
| 18:48 |
paramat |
merged |
| 18:49 |
|
STHGOM joined #minetest-dev |
| 18:49 |
|
STHGOM joined #minetest-dev |
| 18:50 |
paramat |
rubenwardy if you open the new license.txt as raw or in a text editor some strange 'box' characters show up between paragraphs |
| 18:51 |
rubenwardy |
not in my text editors |
| 18:51 |
rubenwardy |
the invisible chars says it's just using \n |
| 18:52 |
sfan5 |
nah |
| 18:53 |
sfan5 |
there's a between paragraphs |
| 18:53 |
sfan5 |
a 0x0c |
| 18:53 |
rubenwardy |
0x0CFF, NP, form feed, \f |
| 18:54 |
sfan5 |
those might technically have some use, but nobody uses them |
| 18:55 |
juhdanad |
As I see, #4978 was merged. What happens when a protocol bump is merged? |
| 18:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/4978 -- Breath cheat fix: server side by nerzhul |
| 18:56 |
sfan5 |
what happens where? |
| 18:56 |
|
STHGOM joined #minetest-dev |
| 18:57 |
juhdanad |
The PR has a "protocol bump" label. Does that mean that the new server won't support old clients? |
| 18:58 |
sfan5 |
no |
| 18:58 |
sfan5 |
it just means that the change required a protocol bump |
| 18:59 |
sfan5 |
in most cases this means nothing for compatibility |
| 18:59 |
juhdanad |
Then protocol bump means increastng the network protocol version? |
| 18:59 |
sfan5 |
yes |
| 18:59 |
juhdanad |
Now I see, thanks. |
| 19:00 |
octacian |
jordan4ibanez: IK this is not the right channel, but this is the only one your in. https://forum.minetest.net/viewtopic.php?f=9&t=16319 |
| 19:01 |
octacian |
>_< wow me, I could've just sent him a PM... :rotfl: sorry |
| 19:01 |
rubenwardy |
game#1487 |
| 19:01 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1487 -- Make doors place when shift is help instead of calling on_rightclick by rubenwardy |
| 19:08 |
|
emptty joined #minetest-dev |
| 19:18 |
paramat |
anyway the 0x0c chars are a minor issue, might even clean those up myself sometime |
| 19:25 |
juhdanad |
Could someone tell me, what is 'correct place' there: https://github.com/minetest/minetest/blob/master/src/nodedef.cpp#L498 |
| 19:32 |
sfan5 |
probably the whole ContentFeatures serialisation should be re-ordered and legacy stuff removed |
| 19:33 |
paramat |
i guess the 'correct place' is the lines above 'try{' since those are new things |
| 19:33 |
sfan5 |
or that |
| 19:33 |
juhdanad |
I think they should be in the same order as in the declaration. |
| 19:42 |
paramat |
any more opinions on game#1464 ? has 2 disapprovals |
| 19:42 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1464 -- Buckets should not run out of water in creative |
| 19:46 |
juhdanad |
I added my opinion too. |
| 19:47 |
|
STHGOM joined #minetest-dev |
| 19:50 |
sfan5 |
paramat: buckets don't really matter in creative since you have the raw water nodes |
| 19:51 |
juhdanad |
sfan5: except when you have to remove liquid nodes. |
| 19:51 |
sfan5 |
you propose making empty buckets in creative into a black hole? :P |
| 19:52 |
paramat |
sfan5 i agree |
| 19:52 |
paramat |
i'm neutral about black hole buckets |
| 19:53 |
juhdanad |
Well, it would be good to have a tool to remove water fast. Not necessarily buckets. |
| 19:53 |
paramat |
another one that i'd love to see closed game#1389 |
| 19:53 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1389 -- Don't automatically pick up blocks When broken If in Creative |
| 19:54 |
paramat |
maybe a mod should do fast source removal instead |
| 19:57 |
Shara |
I really like that in creative you auto-pick up things when digging them |
| 19:58 |
Shara |
Often saves me searching inventory for things |
| 19:58 |
sfan5 |
that feature is pretty useful |
| 19:58 |
sfan5 |
+1 for keeping it |
| 19:58 |
Shara |
Yes, please no change for this behaviour. |
| 19:58 |
juhdanad |
Yes, keep that. |
| 20:01 |
Shara |
Added comment there |
| 20:03 |
paramat |
thanks |
| 20:04 |
paramat |
so 3 disapprovals, lets close it |
| 20:08 |
paramat |
done |
| 20:13 |
rubenwardy |
yay |
| 20:20 |
octacian |
I'm starting on a PR creating a command to clear a players inventory. where should the code go? default? new mod? |
| 20:21 |
rubenwardy |
builtin, probably |
| 20:21 |
rubenwardy |
it's not related to gameplay but is an admin command |
| 20:21 |
sfan5 |
whats the usecase for such a command in on-creative? |
| 20:21 |
sfan5 |
non-creative* |
| 20:21 |
rubenwardy |
"a players inventory" => another player? |
| 20:21 |
rubenwardy |
or self |
| 20:23 |
|
turtleman joined #minetest-dev |
| 20:25 |
octacian |
builtin? huh ok |
| 20:25 |
octacian |
so that's MT "core," not game, correct? |
| 20:26 |
paramat |
yeah it's lua in engine |
| 20:26 |
octacian |
sfan5: use is mostly for creative. get a full inventory and want to clear it. or maybe for adventure maps once people actually start making them :S |
| 20:27 |
Shara |
I was making one... it takes.... time. |
| 20:27 |
octacian |
Shara: it's easy.. |
| 20:27 |
Shara |
But a clear command wouldn't be bad. |
| 20:28 |
octacian |
I already have a mod that does it, mostly gotta copy-paste and optimize. |
| 20:28 |
Shara |
I was talking about an adventure map :) |
| 20:28 |
octacian |
ohk. |
| 20:30 |
octacian |
what's the best way to develop in builtin? I've messed with MTG and mods, haven't every done anything with the core yet. |
| 20:31 |
octacian |
I would assume that for builtin I should modify it in /usr/local/share/minetest then transfer to repo. IDK though, which is why I'm asking lol |
| 20:32 |
sfan5 |
if you want to dev builtin you should be using a "dev copy" |
| 20:32 |
sfan5 |
instead of editing your system-wide minetest installation |
| 20:32 |
octacian |
ok, how do I set up a "dev copy?" portable installation? |
| 20:38 |
sfan5 |
just clone the repo and compile it |
| 20:38 |
sfan5 |
instructions can be found in the forums |
| 20:38 |
octacian |
..and you can run it right from there? |
| 20:38 |
octacian |
can you give me a link/ |
| 20:39 |
sfan5 |
e.g. this https://forum.minetest.net/viewtopic.php?f=42&t=3837 |
| 20:40 |
rubenwardy |
octacian: builtin/game/chatcommand.lua |
| 20:40 |
sfan5 |
this "hurrr durr paramat will oppose to this concept" shitposting in the issues section is getting pretty intense |
| 20:40 |
sfan5 |
i'll be deleting those comments |
| 20:40 |
octacian |
yep, that's the guide I always use for compiling. what I'm asking though, is which do I compile? I assume the portable version? |
| 20:40 |
paramat |
:] lol |
| 20:41 |
rubenwardy |
est31: #4806 |
| 20:41 |
ShadowBot |
https://github.com/minetest/minetest/issues/4806 -- Add search to advanced settings by rubenwardy |
| 20:42 |
rubenwardy |
Would you say pressing enter to open/edit a setting is an important feature? By implementing searching again goes to the next result, I've removed that |
| 20:42 |
octacian |
rubenwardy: personally, I don't think it's important. |
| 20:43 |
rubenwardy |
A possible solution is to not search again using enter, and require clicking the button |
| 20:43 |
sfan5 |
search using return key is pretty convienient though |
| 20:43 |
rubenwardy |
like, pressing enter when the search text hasn't changed causes open/edit |
| 20:43 |
rubenwardy |
I'd argue the it's harder to find a setting than to click [Edit] |
| 20:43 |
octacian |
search using enter is much more important to me than pressing enter to open/edit a setting. |
| 20:49 |
juhdanad |
What if either the settings or the search bar would be selected? If you press enter and the search bar was selected, it does the search and makes the settings active. |
| 20:50 |
juhdanad |
If the settings are active, then enter opens the setting for edit, all other keys start typing into the search bar. |
| 20:50 |
rubenwardy |
pressing enter only searches if the text field is in focus |
| 20:50 |
rubenwardy |
but the text field is always in focus |
| 20:50 |
rubenwardy |
wait, I'm just going to test this |
| 20:52 |
rubenwardy |
scratch that, it goes out of focus when you click on the tree view |
| 20:52 |
rubenwardy |
I'll just keep the current behaviour then |
| 20:53 |
juhdanad |
Then in my opinion pressing a letter while the tree view is active should activate the text field, if it is not much work. |
| 20:56 |
rubenwardy |
formspec don't submit key presses currently |
| 20:56 |
rubenwardy |
even for the main menu |
| 20:56 |
rubenwardy |
so out of scope for this PR |
| 21:21 |
rubenwardy |
I'd appreciate any reviews for #4806 |
| 21:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/4806 -- Add search to advanced settings by rubenwardy |
| 21:21 |
Warr1024 |
is there a way in the lua API to tell if something is exposed to sky? |
| 21:21 |
rubenwardy |
or any of my other PRs |
| 21:21 |
Warr1024 |
er, a node position, I mean |
| 21:21 |
rubenwardy |
Warr1024: minetest.get_light_level(pos).day == minetest.LIGHT_MAX |
| 21:21 |
rubenwardy |
or similar |
| 21:21 |
rubenwardy |
1 sec |
| 21:22 |
Warr1024 |
that would almost work, except that just tells me that it's exposed to a light source |
| 21:22 |
rubenwardy |
minetest.get_node_light(pos, 0.5) == minetest.LIGHT_MAX |
| 21:22 |
Warr1024 |
so it seems like there's no way to tell how much sunlight e.g. a torch node is receiving |
| 21:23 |
rubenwardy |
As long as `pos` is not a sunlamp, it should work |
| 21:23 |
Warr1024 |
so if it IS, then what? |
| 21:24 |
rubenwardy |
use the air node above (Which will be an air node if it's exposed to sky) |
| 21:24 |
Warr1024 |
hm, seems a tad hackish, but I guess it could work |
| 21:24 |
rubenwardy |
I've never tried this, only read this as a tip |
| 21:24 |
rubenwardy |
</disclaimer> |
| 21:24 |
Warr1024 |
yeah, seems like an actual API for this would be nice |
| 21:24 |
rubenwardy |
also, this isn't #minetest |
| 21:25 |
Warr1024 |
oh, did they move API development out of here? |
| 21:25 |
juhdanad |
Warr1024: minetest.get_node_light(pos, 0.5)==LIGHT_SUN (15) |
| 21:25 |
Warr1024 |
ah, LIGHT_MAX < LIGHT_SUN? |
| 21:26 |
Warr1024 |
thanks |
| 21:26 |
Warr1024 |
been a while since I've been in the loop. |
| 21:26 |
juhdanad |
yes, it is. |
| 21:31 |
rubenwardy |
merging #4982 in 10 mins... |
| 21:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/4982 -- Display Gamma: Fix documentation by Thomas--S |
| 21:42 |
rubenwardy |
merging... |
| 21:43 |
rubenwardy |
done |
| 21:43 |
rubenwardy |
I suggest merging the first two commits from #4472, and opening another PR to add search filters |
| 21:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/4472 -- Make serverlist searchable. by red-001 |
| 21:44 |
rubenwardy |
The first two commits have two approvals |
| 21:55 |
nrzkt |
maybe but we review the whole PR not partially |
| 21:58 |
rubenwardy |
no need to be so rigid |
| 21:58 |
rubenwardy |
if it scratches your itch I'll post a PR with just the first two |
| 22:00 |
nrzkt |
not my itch but hmmmm itch :p |
| 22:00 |
Fixer |
please don't forget about invulnerability in boats/carts/etc |
| 22:01 |
rubenwardy |
is there an issue? |
| 22:03 |
|
Marko10_000 joined #minetest-dev |
| 22:08 |
|
Marko10_000 joined #minetest-dev |
| 22:20 |
|
Eater4 joined #minetest-dev |
| 22:20 |
|
paramat joined #minetest-dev |
| 22:52 |
rubenwardy |
#4987 |
| 22:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/4987 -- Expose and document chatcommands as minetest.registered_chatcommands by rubenwardy |
| 22:59 |
Fixer |
rubenwardy: yes, i will search for it |
| 23:00 |
Fixer |
https://github.com/minetest/minetest/issues/4484 "Player immortal while attached" |
| 23:00 |
rubenwardy |
If anyone's wondering why I've made 5 PRs today, it's because I bought coffee and I'm supposed to be revising |
| 23:01 |
Fixer |
rubenwardy: then take some more and dive into 4484 |
| 23:01 |
Fixer |
^_> |
| 23:07 |
paramat |
heh, was wondering |
| 23:09 |
rubenwardy |
Minetest is 100x more fun than recurrence relations |
| 23:18 |
paramat |
another, game#1489 |
| 23:18 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1489 -- License.txt: Clean up by paramat |
| 23:23 |
|
Tmanyo joined #minetest-dev |
| 23:43 |
|
Tmanyo joined #minetest-dev |
| 23:50 |
|
STHGOM joined #minetest-dev |
