Time |
Nick |
Message |
00:04 |
|
turtleman joined #minetest-dev |
00:07 |
Hijiri |
est31: I don't see anything on the line you linke |
00:07 |
Hijiri |
when you talked about krock's suggestion |
00:07 |
Hijiri |
I didn't update it since I linked the PR either |
00:07 |
Hijiri |
push anything, I mean |
00:08 |
Hijiri |
oh |
00:08 |
Hijiri |
the suggestion was in IRC |
00:09 |
Hijiri |
I'll try doing the change, though the code there I copy pasted I'm pretty sure |
00:10 |
Hijiri |
hmm, but isn't it possible to lose precision? |
00:11 |
Hijiri |
well, that's assuming doing float * stuff will keep precision when the output is a integer |
00:13 |
Hijiri |
bleh |
00:13 |
Hijiri |
gcc6 pie stuff errors |
00:14 |
Hijiri |
what flags do I set to fix |
00:18 |
Hijiri |
do you fix your liquid bugs with liquid types? |
00:19 |
|
turtleman joined #minetest-dev |
00:25 |
|
angelo1123_ joined #minetest-dev |
00:30 |
est31 |
Hijiri: thanks |
01:22 |
|
turtleman joined #minetest-dev |
01:24 |
|
KaadmY joined #minetest-dev |
01:30 |
|
sarene joined #minetest-dev |
01:31 |
|
sarene joined #minetest-dev |
01:38 |
|
sarene left #minetest-dev |
01:38 |
|
sarene joined #minetest-dev |
01:40 |
|
sarene left #minetest-dev |
01:44 |
|
sarene joined #minetest-dev |
01:44 |
sarene |
hello |
01:44 |
sarene |
i'm having problems with formspecs and i'm 99% sure it's just me being stupid |
01:45 |
est31 |
sarene: ask your question in #minetest |
01:45 |
sarene |
k |
01:45 |
|
sarene left #minetest-dev |
01:45 |
est31 |
this channel is for development of minetest itself |
01:56 |
|
Zeno` joined #minetest-dev |
02:28 |
|
Tmanyo joined #minetest-dev |
03:56 |
|
ElectronLibre joined #minetest-dev |
03:57 |
|
hiradur joined #minetest-dev |
04:34 |
|
paramat joined #minetest-dev |
05:59 |
OldCoder |
Is there a reason minetest.sound_stop would have no effect? |
06:01 |
paramat |
i don't know of any issues with it |
06:04 |
OldCoder |
paramat, O.K. I have a simple test where the handle seems correct but stop has no effect. Only unusual issue is that the sound clip is 3 minutes long. |
06:04 |
OldCoder |
Does stop take effect at the end of a sound clip? That might be it |
06:05 |
OldCoder |
Hm. Another netsplit? Very low ratio of voiced. |
06:07 |
paramat |
stop should stop immediately |
06:08 |
OldCoder |
Ok thanks. Odd issue. |
06:08 |
paramat |
looped sound? |
06:12 |
OldCoder |
Hm? It does not stop |
06:12 |
paramat |
i mean is the 'loop' parameter set to true? |
06:12 |
OldCoder |
It was, yes |
06:12 |
OldCoder |
But stop does not cause a restart... I don't think that's it. Will narrow down. |
06:13 |
paramat |
apparently looped sounds have to be attached to an object |
06:13 |
OldCoder |
Hm? Explain? |
06:13 |
OldCoder |
Or link to API? |
06:14 |
OldCoder |
You mean, turn loop off may help? |
06:14 |
paramat |
https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L464 |
06:14 |
OldCoder |
Hm; but latest jukebox mod also sets loop=true. Reviewing. |
06:15 |
paramat |
in the fire mod looped sounds are not attached to objects and sound bugs are reported |
06:15 |
OldCoder |
Experimenting, will report back, thank you |
06:19 |
OldCoder |
Turning loop off makes no difference. Will need to isolate this. |
06:25 |
paramat |
no netsplit, only 8 here have a little yellow light next to their name on my irc client (which i assume means voiced) |
06:26 |
OldCoder |
Hm |
06:27 |
OldCoder |
paramat, in on_rightclick, the node parameter should be an objectref of the type needed to associate with a sound, correct? |
06:27 |
paramat |
not sure |
06:28 |
OldCoder |
OK |
06:35 |
|
Hunterz joined #minetest-dev |
06:37 |
paramat |
#4724 needs more review, good PR |
06:37 |
ShadowBot |
https://github.com/minetest/minetest/issues/4724 -- Improve number of blocks sent and occlusion culling. by lhofhansl |
06:49 |
|
AntumDeluge joined #minetest-dev |
06:57 |
Hijiri |
what was the client-side limit on digging, was it one node per 0.1 seconds or per 0.2 seconds? |
07:02 |
|
CWz joined #minetest-dev |
07:07 |
OldCoder |
paramat that syntax { object = <an ObjectRef>, simply crashes when the node is used... do you know if anybody has ever tested it? |
07:07 |
OldCoder |
Or if any mod uses it? |
07:08 |
paramat |
ah, i haven't used it, perhaps a bug |
07:08 |
paramat |
could you open an issue? |
07:08 |
OldCoder |
Eventually I owe MT several of them |
07:09 |
OldCoder |
Can't tonight, thanks; exhausted |
07:09 |
OldCoder |
Running on empty for sleep |
07:16 |
OldCoder |
The stop-sound issue is more significant. Stop of a MT sound definitely does not work even with latest git; regardless of the sound-table mode used. |
07:40 |
Zeno` |
OldCoder, nothing to do with #1984 ? |
07:40 |
ShadowBot |
https://github.com/minetest/minetest/issues/1984 -- Rename testsounds/ directory to sounds/ by Calinou |
07:44 |
paramat |
not related |
07:44 |
Zeno` |
wouldn't have thought so, but *shrug* |
07:44 |
paramat |
afaik |
07:45 |
paramat |
t4im has not been around, so i might complete #4630 |
07:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/4630 -- Fix sandslides and node destruction by falling nodes. by t4im |
07:45 |
Zeno` |
I don't think it can be because the sound is still playing |
07:45 |
paramat |
stop sound is working for me |
07:45 |
Zeno` |
weird |
07:46 |
OldCoder |
Stop-sound is fixed |
07:46 |
Zeno` |
OldCoder, are you using a "standard" build or those libs you custom built? |
07:46 |
Zeno` |
oh. sorry, and cool :) |
07:46 |
OldCoder |
Zeno`, Hi. To explain briefly: |
07:47 |
OldCoder |
#1 There does seem to be a mismatch between an API document that paramat linked and git-current. Error message suggests a core as opposed to a mod issue. |
07:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/1 -- GlowStone code by anonymousAwesome |
07:47 |
OldCoder |
#2 However, the stop-sound issue was in OpenAL on the client side and is now corrected. |
07:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/2 -- Burned wood |
07:47 |
OldCoder |
Thank you. I will research #1 further. |
07:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/1 -- GlowStone code by anonymousAwesome |
07:47 |
Zeno` |
thank you |
07:47 |
* OldCoder |
bows |
07:49 |
OldCoder |
Zeno`, BTW C PM |
07:54 |
|
OldCoder joined #minetest-dev |
08:11 |
paramat |
heh |
08:14 |
|
Krock joined #minetest-dev |
08:14 |
|
Krock joined #minetest-dev |
08:23 |
paramat |
will merge game#1365 in a moment |
08:23 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1365 -- Default: Add 'acacia leaves simple' texture by paramat |
08:26 |
Krock |
wait what? we have bushes now? |
08:26 |
paramat |
yeah, well just the nodes so far. merging |
08:30 |
paramat |
merged |
08:30 |
paramat |
changes to biomes get done all at once and before release |
08:32 |
|
AcidNinjaFWHR joined #minetest-dev |
08:42 |
|
nrzkt joined #minetest-dev |
08:49 |
|
pinetree joined #minetest-dev |
08:54 |
|
pinetree joined #minetest-dev |
08:55 |
|
red-001 joined #minetest-dev |
09:34 |
paramat |
please can anyone review #4740 ? |
09:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/4740 -- Builtin/../falling: Fix bugs caused by 'ignore' nodes by paramat |
09:38 |
Krock |
https://github.com/minetest/minetest/pull/4740/files#diff-a93e20fc47b20484bdc9d6f539b9d631R161 unnecessary to change this. "d_bottom" is nil, when n_bottom is nil ;) |
09:39 |
Krock |
but otherwise looks fine. You adapted T4im's changes, right? |
09:43 |
paramat |
well, n_bottom can be true and d_bottom can be false |
09:43 |
paramat |
yes |
09:43 |
paramat |
er, i think |
09:44 |
paramat |
anyway need others to check that |
09:51 |
paramat |
i wondered about that myself |
10:06 |
|
jin_xi joined #minetest-dev |
10:45 |
paramat |
game#1340 seems good now |
10:45 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1340 -- flint-and-steel: trigger node on_ignite, add it to tnt, gunpowder, coal by Ferk |
11:23 |
|
Fixer joined #minetest-dev |
11:35 |
|
sfan5 joined #minetest-dev |
12:26 |
|
DI3HARD139 joined #minetest-dev |
12:39 |
|
Foghrye4 joined #minetest-dev |
12:44 |
|
RichardTheTurd joined #minetest-dev |
13:06 |
|
red-001 joined #minetest-dev |
13:20 |
|
fling joined #minetest-dev |
13:50 |
|
hmmmm joined #minetest-dev |
13:52 |
|
Taoki joined #minetest-dev |
14:16 |
|
STHGOM joined #minetest-dev |
14:16 |
|
STHGOM joined #minetest-dev |
14:25 |
|
blaze joined #minetest-dev |
14:52 |
|
ElectronLibre joined #minetest-dev |
14:55 |
Krock |
hmmmm, would you have a minute to review #4674 ? It's a trivial 2-line change to generate a debug symbol file for release builds |
14:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/4674 -- MSVC: Improve compiler flags by SmallJoker |
15:03 |
|
crazyR joined #minetest-dev |
15:16 |
paramat |
#4740 now tested, can anyone review this simple PR? after this i'll add nodeupdate functions to core namespace |
15:17 |
ShadowBot |
https://github.com/minetest/minetest/issues/4740 -- Builtin/../falling: Fix bugs caused by 'ignore' nodes by paramat |
15:25 |
Krock |
LGTM |
15:41 |
sfan5 |
est31: bugs with mod security are not feature requests |
15:41 |
sfan5 |
you don't go removing lots of functions and then "oh you want them back? that's a feature request" |
15:41 |
est31 |
sfan5: its a missing feature |
15:41 |
sfan5 |
no it's a bug |
15:41 |
est31 |
and it can be entirely worked around |
15:41 |
sfan5 |
yes |
15:41 |
sfan5 |
that doesn't make it a feature request |
15:41 |
est31 |
also, its a good security practice to make API surface small |
15:42 |
sfan5 |
mod security is removing additonal functions not related to securing stuff |
15:42 |
sfan5 |
uh no |
15:42 |
est31 |
because then your chance gets lower for bugs to pop up |
15:42 |
est31 |
and ruin your show |
15:42 |
sfan5 |
mod security is supposed to secure mods |
15:42 |
sfan5 |
not redesign the whole lua standard lib |
15:42 |
sfan5 |
and arbitrarily remove stuff |
15:43 |
sfan5 |
when you design a new api then you can apply that principle |
15:43 |
sfan5 |
but not when securing an additional one |
15:43 |
sfan5 |
s/additional/existing/ |
15:43 |
est31 |
okay |
15:43 |
est31 |
its an API break |
15:44 |
est31 |
and for no good reason |
15:44 |
est31 |
so a bug it is |
15:44 |
est31 |
but no blocker IMO |
15:44 |
est31 |
mod writers can work around it |
15:44 |
thePalindrome |
I disagree there |
15:44 |
sfan5 |
you know what makes minetests api so nice? |
15:44 |
thePalindrome |
Ever heard of Minecraft 1.8? |
15:44 |
sfan5 |
the fact that we DONT break it every release |
15:45 |
est31 |
guess how stuff looks like, we won't ship with mod security after all. |
15:45 |
sfan5 |
mod security may be nice |
15:45 |
thePalindrome |
We aren't gnome :P |
15:45 |
sfan5 |
but in the current state we CANT leave it enabled on release |
15:47 |
est31 |
sfan5: agreed |
15:47 |
sfan5 |
it breaks (at least) 3 quite unrelated things for no reason |
15:48 |
sfan5 |
it's unfortunate that mod security has not received enough testing |
15:48 |
sfan5 |
but in this state it's not very usable |
15:53 |
|
Player_2 joined #minetest-dev |
15:53 |
Krock |
hmmmm, so a Lenovo Thinkstation S10 is not good enough? Quad Processor @2.66 GHz and 35 Gigaflops aren't good enough to run a minetest debug build? |
15:54 |
Krock |
c'mon |
15:54 |
sfan5 |
have you considered not using windows xp? |
15:54 |
Krock |
does that change anything? I really doubt it |
15:54 |
Krock |
there can't be auch a huge speed improvement |
15:55 |
Krock |
but to answer your question: yes I did. Sadly I'm somehow blocking myself from switching to Linux for some reason |
15:59 |
thePalindrome |
don't really know why |
16:00 |
Krock |
hmm? |
16:19 |
|
turtleman joined #minetest-dev |
16:20 |
thePalindrome |
Why would you choose xp over anything else :P |
16:22 |
LiquidBugs |
it is insanely fast on current hardware |
16:23 |
sfan5 |
linux is too |
16:23 |
LiquidBugs |
since vista it is much heavier on I/O, it just won't leave my hard drive alone |
16:24 |
LiquidBugs |
also this crap with search for updates for hours taking one core, reading 1gig database occasionally, indexing, whatever |
16:24 |
LiquidBugs |
takes faaar less space |
16:26 |
LiquidBugs |
much more responsive in general |
16:26 |
LiquidBugs |
simple interface |
16:26 |
LiquidBugs |
no bullshit |
16:26 |
Krock |
same wavelength, LiquidBugs :) |
16:26 |
LiquidBugs |
it needs some caution in terms of security though |
16:27 |
* Krock |
hides |
16:27 |
LiquidBugs |
best way is to make image of OS + general backup of stuff, and you will be fine (nice thing to have for everybody) |
16:28 |
LiquidBugs |
on seperate removable disk |
16:29 |
LiquidBugs |
or use linux |
16:30 |
LiquidBugs |
seriosly, switch to linux |
16:34 |
Foghrye4 |
Don't do it, dude! Wine is a pain in ass! |
16:40 |
thePalindrome |
Since when? |
16:41 |
thePalindrome |
The only things I find wine has trouble with are .net and DirectX 10+ |
16:42 |
|
Volkj joined #minetest-dev |
16:48 |
Foghrye4 |
Hey, a serious question here. What if player attached to LuaEntity and log off and then log in back? |
16:49 |
Foghrye4 |
did he will be attached again? |
16:49 |
Foghrye4 |
*Will he |
16:50 |
|
paramat joined #minetest-dev |
16:59 |
thePalindrome |
I don't believe so |
16:59 |
thePalindrome |
Since there's no meaningful way to express that |
17:00 |
thePalindrome |
I may be wrong though :P |
17:00 |
Krock |
no, attachments are cleared |
17:01 |
Foghrye4 |
Thanks, Krock. |
17:01 |
Krock |
(or at least they should be cleared) |
17:03 |
|
nrzkt joined #minetest-dev |
17:08 |
|
Darcidride joined #minetest-dev |
17:11 |
|
Player_2 joined #minetest-dev |
17:19 |
|
KaadmY joined #minetest-dev |
17:38 |
nrzkt |
#4738 is ready to merge, paramat you can merge if you want |
17:38 |
ShadowBot |
https://github.com/minetest/minetest/issues/4738 -- Only give singleplayer 4 basic privs by default by Wuzzy2 |
17:39 |
nrzkt |
#4701 is okay too now |
17:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/4701 -- Windows: Add manifest file and set "High DPI Aware" true (fixes #4287) by adrido |
17:41 |
paramat |
ok |
17:57 |
paramat |
#4745 part of an unmerged PR by RBA. hmmmm highlighting you since you approved of this part of the original PR |
17:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/4745 -- Digging cracks: Make crack animation optional by paramat |
18:06 |
paramat |
too tired to merge stuff now |
18:17 |
|
AcidNinjaFWHR joined #minetest-dev |
18:29 |
|
rubenwardy joined #minetest-dev |
18:35 |
|
paramat left #minetest-dev |
19:12 |
|
Karazhan joined #minetest-dev |
19:47 |
|
Human joined #minetest-dev |
19:57 |
LiquidBugs |
!tell paramat so what about that "get biome info" thing? |
19:57 |
ShadowBot |
LiquidBugs: O.K. |
20:08 |
|
octacian joined #minetest-dev |
20:17 |
sfan5 |
!tell paramat https://github.com/minetest/minetest_game/pull/1314 |
20:17 |
ShadowBot |
sfan5: O.K. |
20:45 |
|
proller joined #minetest-dev |
21:17 |
|
proller joined #minetest-dev |
21:20 |
|
rubenwardy joined #minetest-dev |
21:47 |
|
OldCoder joined #minetest-dev |
21:50 |
|
CWz joined #minetest-dev |
21:54 |
|
ElectronLibre joined #minetest-dev |
23:26 |
|
Tmanyo joined #minetest-dev |
23:48 |
|
ElectronLibre joined #minetest-dev |