Time |
Nick |
Message |
00:24 |
|
DI3HARD139 joined #minetest-dev |
00:33 |
|
RichardTheTurd joined #minetest-dev |
00:43 |
|
paramat joined #minetest-dev |
01:09 |
|
yang2003 joined #minetest-dev |
01:11 |
|
paramat left #minetest-dev |
01:51 |
|
est31 joined #minetest-dev |
02:05 |
|
RichardTheTurd joined #minetest-dev |
02:11 |
|
Miner_48er joined #minetest-dev |
02:16 |
|
misprint joined #minetest-dev |
03:17 |
|
Void7 joined #minetest-dev |
03:50 |
|
DI3HARD139 joined #minetest-dev |
04:05 |
|
est31 joined #minetest-dev |
04:20 |
|
xunto joined #minetest-dev |
05:08 |
|
Hunterz joined #minetest-dev |
05:11 |
|
xunto joined #minetest-dev |
05:23 |
|
nrzkt joined #minetest-dev |
05:47 |
|
xunto joined #minetest-dev |
06:02 |
|
xunto joined #minetest-dev |
06:10 |
|
Megal joined #minetest-dev |
06:12 |
|
xunto joined #minetest-dev |
06:23 |
|
xunto joined #minetest-dev |
06:38 |
|
xunto joined #minetest-dev |
06:58 |
|
xunto joined #minetest-dev |
07:25 |
|
nore joined #minetest-dev |
07:34 |
|
nrzkt joined #minetest-dev |
07:36 |
|
jin_xi joined #minetest-dev |
08:13 |
|
Taoki joined #minetest-dev |
08:44 |
|
Lunatrius joined #minetest-dev |
11:10 |
|
hmmmm joined #minetest-dev |
11:46 |
|
lisac joined #minetest-dev |
12:13 |
|
lisac joined #minetest-dev |
12:19 |
|
Fixer joined #minetest-dev |
12:28 |
|
Zeno` joined #minetest-dev |
12:31 |
|
STHGOM joined #minetest-dev |
12:37 |
|
Thomas-S joined #minetest-dev |
12:50 |
|
damiel joined #minetest-dev |
13:06 |
|
paramat joined #minetest-dev |
13:08 |
paramat |
can any MTGame review game#1076 ? < nore |
13:08 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1076 -- Fire: Ignite tnt, gunpowder, permanent flame above coalblock by paramat |
13:11 |
paramat |
wow hmmmm you're up early, here's one for you #4174 |
13:11 |
ShadowBot |
https://github.com/minetest/minetest/issues/4174 -- Mgv7: Always carve river channels in mountain terrain by paramat |
13:15 |
|
Fixer joined #minetest-dev |
13:46 |
|
Samson1 joined #minetest-dev |
13:47 |
|
ElectronLibre joined #minetest-dev |
14:40 |
|
rubenwardy joined #minetest-dev |
14:47 |
|
Void7 joined #minetest-dev |
15:02 |
|
troller joined #minetest-dev |
15:36 |
|
paramat left #minetest-dev |
16:10 |
|
Hunterz joined #minetest-dev |
16:14 |
|
Player_2 joined #minetest-dev |
16:15 |
|
Krock joined #minetest-dev |
16:24 |
|
KaadmY joined #minetest-dev |
16:41 |
|
Void7 joined #minetest-dev |
17:22 |
|
DonBatman joined #minetest-dev |
17:23 |
|
nrzkt joined #minetest-dev |
17:34 |
|
Amaz joined #minetest-dev |
17:54 |
|
rubenwardy joined #minetest-dev |
18:11 |
|
twoelk joined #minetest-dev |
18:18 |
|
Void7 joined #minetest-dev |
18:24 |
|
lisac joined #minetest-dev |
18:26 |
|
Calinou joined #minetest-dev |
18:31 |
|
edgrey joined #minetest-dev |
18:35 |
|
DI3HARD139 joined #minetest-dev |
18:36 |
|
Void7 joined #minetest-dev |
18:38 |
|
paramat joined #minetest-dev |
18:45 |
paramat |
please is anyone able to review game#1076 ? nore sfan5 |
18:45 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1076 -- Fire: Ignite tnt, gunpowder, permanent flame above coalblock by paramat |
18:45 |
sfan5 |
not right now, busy |
18:50 |
|
RichardTheTurd joined #minetest-dev |
18:57 |
|
ThatGuyWho joined #minetest-dev |
19:10 |
|
nrzkt joined #minetest-dev |
19:11 |
|
MillersMan joined #minetest-dev |
19:14 |
|
Fixer_ joined #minetest-dev |
19:20 |
MillersMan |
hi, any updates on whether #4065 will be merged? |
19:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/4065 -- Performance improvement and small fixes for flow issues in Mapgen::updateLiquid by MillersMan |
19:22 |
paramat |
aha, sorry, we're still very interested in this. i want to review this myself too |
19:22 |
paramat |
i'll look at both PRs |
19:23 |
paramat |
as usual we're a bit overwhelmed and understaffed |
19:23 |
MillersMan |
i want to improve the other one once this one got merged, otherwise reflow might show different behavior |
19:24 |
MillersMan |
theres also the bug that sometimes blocks aren't added to reflow, which i will solve then too |
19:26 |
MillersMan |
maybe I'll create another PR that would already fit to the 4065 changes and supersede 4061 |
19:26 |
paramat |
so you want 4065 reviewing first? |
19:29 |
nrzkt2 |
MillersMan, i pushed some comments to your PR |
19:29 |
nrzkt2 |
and you forget spaces |
19:43 |
|
swaaws joined #minetest-dev |
19:44 |
MillersMan |
nrzkt2: updateLiquidHelper was originaly part of Mapgen, I've changed it as it doesn't matter performance-wise and sofar asked whether it makes sense to have it a standalone static inline |
19:45 |
MillersMan |
as a static inline it will not polute any namespace unlike a public method |
19:52 |
nrzkt2 |
a method into and objet can be static and inline too :) |
19:54 |
MillersMan |
static for a non-member function has a different meaning than static for a method, such a function would only be visible for the source file that contains it, so it is possible to have multiple functions with the same name in different files, one of the strange C/C++ behaviors |
19:55 |
nrzkt2 |
MillersMan, having multiple function with the same name is just... headhache |
19:56 |
nrzkt2 |
and the visibility of this function is not a problem if you make it inline in the .cpp because we cannot use it elsewhere |
19:57 |
MillersMan |
ok, i'll revert the change |
20:00 |
|
misprint joined #minetest-dev |
20:13 |
MillersMan |
is it possible to detach the player from an object and move him at the same time in lua? sometimes it works but most times the player is just detached? |
20:22 |
|
DFeniks joined #minetest-dev |
20:24 |
|
proller__ joined #minetest-dev |
20:25 |
|
xunto joined #minetest-dev |
20:27 |
|
Amaz joined #minetest-dev |
20:28 |
|
Void7 joined #minetest-dev |
20:29 |
paramat |
maybe use minetest.after() to delay the moving |
20:29 |
MillersMan |
paramat: thanks, this works |
20:30 |
paramat |
that trick is used in boats mod |
20:31 |
paramat |
https://github.com/minetest/minetest_game/blob/master/mods/boats/init.lua#L49 |
20:41 |
|
Tmanyo joined #minetest-dev |
20:45 |
MillersMan |
nrzkt2: i pushed an update |
21:17 |
|
Puka_ joined #minetest-dev |
21:50 |
|
DFeniks joined #minetest-dev |
22:12 |
|
DI3HARD139 joined #minetest-dev |
22:25 |
|
torgdor joined #minetest-dev |
23:18 |
|
ssieb joined #minetest-dev |
23:20 |
|
Void7 joined #minetest-dev |
23:24 |
|
yang2003 joined #minetest-dev |
23:36 |
|
Puka joined #minetest-dev |
23:36 |
|
Void7 joined #minetest-dev |