Time  Nick       Message
13:08 paramat    can any MTGame review game#1076 ? < nore
13:08 ShadowBot  https://github.com/minetest/minetest_game/issues/1076 -- Fire: Ignite tnt, gunpowder, permanent flame above coalblock by paramat
13:11 paramat    wow hmmmm you're up early, here's one for you #4174
13:11 ShadowBot  https://github.com/minetest/minetest/issues/4174 -- Mgv7: Always carve river channels in mountain terrain by paramat
18:45 paramat    please is anyone able to review game#1076 ? nore sfan5
18:45 ShadowBot  https://github.com/minetest/minetest_game/issues/1076 -- Fire: Ignite tnt, gunpowder, permanent flame above coalblock by paramat
18:45 sfan5      not right now, busy
19:20 MillersMan hi, any updates on whether #4065 will be merged?
19:20 ShadowBot  https://github.com/minetest/minetest/issues/4065 -- Performance improvement and small fixes for flow issues in Mapgen::updateLiquid by MillersMan
19:22 paramat    aha, sorry, we're still very interested in this. i want to review this myself too
19:22 paramat    i'll look at both PRs
19:23 paramat    as usual we're a bit overwhelmed and understaffed
19:23 MillersMan i want to improve the other one once this one got merged, otherwise reflow might show different behavior
19:24 MillersMan theres also the bug that sometimes blocks aren't added to reflow, which i will solve then too
19:26 MillersMan maybe I'll create another PR that would already fit to the 4065 changes and supersede 4061
19:26 paramat    so you want 4065 reviewing first?
19:29 nrzkt2     MillersMan, i pushed some comments to your PR
19:29 nrzkt2     and you forget spaces
19:44 MillersMan nrzkt2: updateLiquidHelper was originaly part of Mapgen, I've changed it as it doesn't matter performance-wise and sofar asked whether it makes sense to have it a standalone static inline
19:45 MillersMan as a static inline it will not polute any namespace unlike a public method
19:52 nrzkt2     a method into and objet can be static and inline too :)
19:54 MillersMan static for a non-member function has a different meaning than static for a method, such a function would only be visible for the source file that contains it, so it is possible to have multiple functions with the same name in different files, one of the strange C/C++ behaviors
19:55 nrzkt2     MillersMan, having multiple function with the same name is just... headhache
19:56 nrzkt2     and the visibility of this function is not a problem if you make it inline in the .cpp because we cannot use it elsewhere
19:57 MillersMan ok, i'll revert the change
20:13 MillersMan is it possible to detach the player from an object and move him at the same time in lua? sometimes it works but most times the player is just detached?
20:29 paramat    maybe use minetest.after() to delay the moving
20:29 MillersMan paramat: thanks, this works
20:30 paramat    that trick is used in boats mod
20:31 paramat    https://github.com/minetest/minetest_game/blob/master/mods/boats/init.lua#L49
20:45 MillersMan nrzkt2: i pushed an update