| Time |
Nick |
Message |
| 00:09 |
rubenwardy |
#4121 |
| 00:09 |
ShadowBot |
https://github.com/minetest/minetest/issues/4121 -- Failed to save block: attempt to write a readonly database |
| 00:11 |
Zeno` |
thanks rubenwardy |
| 00:33 |
|
torgdor joined #minetest-dev |
| 01:46 |
|
Void7 joined #minetest-dev |
| 01:50 |
|
STHGOM joined #minetest-dev |
| 02:07 |
|
yang2003 joined #minetest-dev |
| 02:16 |
|
Void7 joined #minetest-dev |
| 02:57 |
rubenwardy |
I propose delaying the android release or giving android maintainers the right to release patches before 0.4.15 |
| 02:58 |
rubenwardy |
Preferably both if there is a regression, and the later if there is no regression |
| 02:58 |
rubenwardy |
*latter |
| 03:02 |
Wayward_One |
That sounds good |
| 03:07 |
|
misprint joined #minetest-dev |
| 03:07 |
DonBatman |
I wonder if any of the changes effect the new build? Many things Like new call backs will make players wonder why they can not do certain things on android even though they have they latest |
| 03:07 |
|
paramat joined #minetest-dev |
| 03:24 |
paramat |
i feel we should concentrate on PR 4086/4119, and release this weekend, even though android will still have minor issues |
| 03:30 |
|
paramat left #minetest-dev |
| 03:35 |
Zeno` |
paramat I'm ok with 4086 |
| 03:35 |
Zeno` |
I was initially concerned about the status = device->postEventFromUser(event) ? 1 : 0; but after looking at the irrlicht source code that makes sense |
| 03:37 |
Zeno` |
and est31 added that anyway, so I guess he looked into it also |
| 03:37 |
DonBatman |
I agree with Zeno. The issues with 4086 are minor enough that it could be released with it |
| 03:39 |
DonBatman |
4119 iirc is because Monte didn't/couldn't respond fast enough. I suggest 4086 be merged |
| 05:30 |
|
jin_xi joined #minetest-dev |
| 06:08 |
|
Krock joined #minetest-dev |
| 06:24 |
|
nrzkt joined #minetest-dev |
| 06:30 |
|
Hunterz joined #minetest-dev |
| 07:19 |
|
dmurph joined #minetest-dev |
| 08:06 |
|
blaze joined #minetest-dev |
| 08:06 |
|
Demonette joined #minetest-dev |
| 08:26 |
nrzkt |
i will backport my postgresql backend from my forked version to MT for next release |
| 08:26 |
nrzkt |
and i will do a little PR i think which should be merged before release to improve a little bit map loading perf |
| 08:29 |
|
est31 joined #minetest-dev |
| 08:29 |
est31 |
sofar, are you there |
| 08:33 |
est31 |
I am wondering about this "back closes the application" bug |
| 08:34 |
est31 |
because for me, back does not close the application, at least ingame |
| 08:34 |
est31 |
even with 4119 applied |
| 08:43 |
est31 |
And back should close the application if inside the main menu |
| 08:44 |
est31 |
because otherwise minetest will still render the clouds in the background |
| 08:44 |
est31 |
and this will drain the battery |
| 08:44 |
est31 |
or at least I think it will drain it |
| 08:44 |
|
troller joined #minetest-dev |
| 08:44 |
est31 |
I highly doubt whether we have implemented this "activity" stuff android has |
| 08:45 |
est31 |
so that we go to "sleep" mode if sb presses back |
| 08:52 |
Zeno` |
est31, #4114 |
| 08:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/4114 -- Android: enable parallelism for main target too by est31 |
| 08:53 |
Zeno` |
est31, there seems to be confusion that you may need to clear up ;) |
| 08:54 |
Zeno` |
est31, unless I am blind? |
| 08:58 |
est31 |
Zeno`, I have added a + |
| 08:58 |
Zeno` |
just noticed that |
| 08:58 |
Zeno` |
oops |
| 08:58 |
est31 |
Zeno`, see the commit linked in the commit message |
| 08:59 |
est31 |
It added lots of +'s |
| 08:59 |
Zeno` |
yeah |
| 08:59 |
Zeno` |
I just looked at the file with the patch applied |
| 08:59 |
Zeno` |
the diff confused me :( |
| 09:00 |
Zeno` |
why can't that be merged now? |
| 09:00 |
Zeno` |
it's not really a feature... It's practically a bug fix |
| 09:01 |
est31 |
If that's your opinion, merge it :) |
| 09:02 |
Zeno` |
building now |
| 09:03 |
nrzkt |
Zeno`, est31 i backported my backend in #4123 if you want to look at this to review :) |
| 09:03 |
ShadowBot |
https://github.com/minetest/minetest/issues/4123 -- Implement a PostgreSQL backend by nerzhul |
| 09:04 |
nrzkt |
erf i pushed it to MT repository instead of my repository :) i redo the request |
| 09:05 |
Zeno` |
est31, this is certainly not a "feature" |
| 09:05 |
Zeno` |
when build finishes I will merge |
| 09:06 |
Zeno` |
well I'll wait 30 minutes and then merge in case someone else wants to comment :) |
| 09:07 |
nrzkt |
Zeno`, est31 #4124 :) |
| 09:07 |
ShadowBot |
https://github.com/minetest/minetest/issues/4124 -- Implement a PostgreSQL backend by nerzhul |
| 09:07 |
est31 |
cool nrzkt |
| 09:08 |
nrzkt |
it's a strongly tested backport on my fork but maybe further testing could be done on db creation because i didn't use this method on my fork, but this should be working well without problem :) |
| 09:08 |
nrzkt |
db table creation, not db creation :) |
| 09:11 |
Zeno` |
err will look in a bit... my computer is being weird again |
| 09:12 |
Zeno` |
firefox is using 25% cpu :/ |
| 09:15 |
Zeno` |
est31, you think that a change like that to the Makefile is a "feature"? |
| 09:17 |
est31 |
well its just a speedup |
| 09:17 |
Zeno` |
hmm |
| 09:17 |
est31 |
stuff works perfectly before |
| 09:17 |
Zeno` |
I've changed my mind |
| 09:17 |
Zeno` |
make -j freezes computer |
| 09:17 |
Zeno` |
make -j8 is ok, but make -j should work as well |
| 09:18 |
nrzkt |
est31, personally the current behaviour is okay for me |
| 09:18 |
est31 |
make -j is evil |
| 09:18 |
Zeno` |
I like evil :) |
| 09:18 |
est31 |
it freezes my computer too |
| 09:18 |
Zeno` |
it doesn't freeze my computer when compiling minetest *not* for android |
| 09:19 |
est31 |
it freezes my computer there too |
| 09:19 |
Zeno` |
hmm |
| 09:19 |
est31 |
perhaps you have more RAM than me |
| 09:19 |
Zeno` |
I dunno |
| 09:19 |
est31 |
how much ram do you have |
| 09:19 |
Zeno` |
Mem: 15G |
| 09:19 |
Zeno` |
(it's really 16) |
| 09:19 |
est31 |
you have more than me then |
| 09:20 |
Zeno` |
I'll try again with make -j8 |
| 09:20 |
Zeno` |
it's not a big deal |
| 09:20 |
est31 |
I really should upgrade my hardware |
| 09:20 |
Zeno` |
probably my mistake for always using -j and not specifying max threads tbh |
| 09:22 |
Zeno` |
est31, the reason I don't see it as a feature is because it's not part of minetest after build |
| 09:22 |
Zeno` |
I see it more like renaming a file |
| 09:23 |
Zeno` |
works fine |
| 09:25 |
nrzkt |
make -j8 on my 8 core CPU AMD works well :D |
| 09:25 |
Zeno` |
-j10 is even working well |
| 09:25 |
Zeno` |
I can't see why it should be delayed |
| 09:27 |
nrzkt |
est31, i updateed my pgsql pr with doc & travis fixes should be good now :) |
| 09:27 |
Zeno` |
it's not part of the "release" so I will merge in a bit |
| 09:28 |
Zeno` |
make[1]: Leaving directory '/home/crobbins/minetest/build/android' |
| 09:28 |
Zeno` |
real 0m10.539s |
| 09:28 |
Zeno` |
-j8 was 8.57s |
| 09:29 |
Zeno` |
vroooom |
| 09:30 |
Zeno` |
(this is excluding deps... make clean and make on minetest only :P) |
| 09:30 |
est31 |
cool seems we have another fork https://github.com/kmfreeminer/kmfreeminer |
| 09:30 |
est31 |
or well freeminer has |
| 09:33 |
Zeno` |
a forked fork |
| 09:33 |
Zeno` |
like lightning |
| 09:33 |
Zeno` |
I wonder if it's fractal in nature |
| 09:34 |
Zeno` |
we could use l-system to automatically create forks |
| 09:35 |
est31 |
hehe |
| 10:16 |
nrzkt |
Zeno`, i will push a PR to improve a little bit map backends and remove a mapblock copy, will you review ? |
| 10:17 |
nrzkt |
it's not a featur but a fix :) |
| 10:21 |
nrzkt |
i think it should be merged for 0.4.14 |
| 10:25 |
nrzkt |
Zeno`, kahrl, nore can you look at #4125 it's a trivial enhancement for 0.4.14 i forgot to send |
| 10:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/4125 -- DB::loadBlock copy removal & DB backend cleanup by nerzhul |
| 10:40 |
|
MillersMan joined #minetest-dev |
| 10:45 |
|
est31 joined #minetest-dev |
| 10:46 |
est31 |
nrzkt, i dont think that #4125 is a bug fix |
| 10:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/4125 -- DB::loadBlock copy removal & DB backend cleanup by nerzhul |
| 10:46 |
est31 |
I +1 it but it should not be merged for 0.4.14 |
| 10:46 |
est31 |
it really looks harmless, but still it would be better to have it wait for after the freeze |
| 10:52 |
est31 |
man this guy is fucking arrogant |
| 10:52 |
est31 |
https://github.com/minetest/minetest/pull/4086#issuecomment-219211655 |
| 10:52 |
est31 |
i dont care anymore |
| 10:52 |
est31 |
i will now promote my pr |
| 10:52 |
est31 |
fuck monte |
| 10:54 |
nrzkt |
est31, agreed for monte |
| 10:54 |
nrzkt |
est31, as you want, if you want to wait, no problem for me, change the milestone and merge it after release. When will the release happen ? Tomorrow ? |
| 10:55 |
est31 |
nrzkt, yes that's the plan but the announcement is for may 16, that's monday |
| 10:55 |
est31 |
the announcement can be ignored :) |
| 10:56 |
nrzkt |
okay |
| 11:09 |
est31 |
you know usually i like monte but i do not like this kind of behaviour |
| 11:09 |
est31 |
he comes with a pr and he should try to explain why he does stuff and what for |
| 11:15 |
Zeno` |
We just need some new rules. Being aggressive -> PR closed. Refusing to answer simple questions -> PR closed |
| 11:16 |
Zeno` |
It's hard enough as it is within feeling like you're being attacked all the time |
| 11:16 |
nrzkt |
superb comment from monte48 "i shit on you" |
| 11:21 |
|
MoNTE48 joined #minetest-dev |
| 11:31 |
Zeno` |
MoNTE48, the approach you took was not exactly the most productive way to get a PR merged :) |
| 11:31 |
Zeno` |
People, in general, don't like being attacked and sworn at. It really doesn't make anybody comfortable :( |
| 11:34 |
Zeno` |
The PR is good... why make it difficult for people to feel comfortable merging it? |
| 11:46 |
|
Krock joined #minetest-dev |
| 11:48 |
est31 |
ahha |
| 11:48 |
est31 |
seems this has exposed a bug |
| 11:50 |
est31 |
in #4119 vs #4086 |
| 11:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/4119 -- Android: Let the OS handle the hardware buttons by est31 |
| 11:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/4086 -- Fix locked hardware buttons on Android by MoNTE48 |
| 11:51 |
est31 |
I have the same observation as sofar now |
| 11:51 |
est31 |
dunno why didnt have it before |
| 11:51 |
est31 |
we seem to say to irrlicht that we dont handle key events |
| 11:52 |
est31 |
so every key is given to the os |
| 11:52 |
est31 |
thats bad obviously |
| 11:52 |
est31 |
4086 only fixes it on android |
| 11:52 |
est31 |
it should be fixed for whole minetest |
| 11:52 |
est31 |
I'll try to do it |
| 12:12 |
MoNTE48 |
I did not want to offend anyone, but I made two very simple changes (all the complexity of this bugfix - find the problem). If no one can check it out and find in google answers to your questions - I do not have to explain it yourself. |
| 12:13 |
est31 |
MoNTE48, my main problem was that I couldnt reproduce what you wrote |
| 12:13 |
est31 |
so I wondered what you talk about |
| 12:13 |
est31 |
but now I can and I think while your fix is not proper it should be included for release |
| 12:13 |
est31 |
a proper fix needs more time |
| 12:14 |
MoNTE48 |
When someone asks a stupid question "why do we need this code?" - It's annoying. Friend simply put far this part of the code and test it. You see the problem and you will not waste time on someone else's explanation of the basic things a few times. |
| 12:14 |
est31 |
MoNTE48, in the best case I dont have to ask the question at all |
| 12:14 |
est31 |
you should explain why you do the code the way you do it yourself |
| 12:15 |
est31 |
Otherwise I waste time trying to find out myself why you do it :) |
| 12:15 |
MoNTE48 |
Or do not waste it and trust that have already done so :) |
| 12:16 |
est31 |
trust is good but checking is better :) |
| 12:17 |
MoNTE48 |
I understand. Unfortunately now minetest no android dev which is not required to look for something to check or ask a lot of questions. |
| 12:17 |
est31 |
MoNTE48, I was well aware that android by default puts the current activity into the background |
| 12:18 |
MoNTE48 |
It has nothing to do with the background activity in general |
| 12:18 |
est31 |
but i did not know that you added this code to prevent it from getting into the background |
| 12:19 |
MoNTE48 |
When I click back, android close the current activity and moves to the previous. If it is the latter activity, it will close the app |
| 12:19 |
est31 |
no |
| 12:19 |
est31 |
it will move the app to the background, android doesnt close apps by default |
| 12:19 |
est31 |
in the case of minetest we added code to close manually when we go to the background |
| 12:20 |
est31 |
I feared that your change has disabled this code, and now minetest is in the background |
| 12:20 |
est31 |
but now I see you fixed a bug :) |
| 12:20 |
est31 |
MoNTE48, Lets say we merge your change and we are friends again? |
| 12:20 |
MoNTE48 |
Activity is restarted after re-opening. And then it stopped. |
| 12:20 |
est31 |
but next time be nicer to everybody. |
| 12:21 |
MoNTE48 |
If nativeactivity fell into the background (onPause), after the re-opening would be carried onResume. However NativeActivity restarted. |
| 12:22 |
MoNTE48 |
http://i.stack.imgur.com/2CP6n.png |
| 12:23 |
MoNTE48 |
HOME called onPause, BACK called onStop |
| 12:23 |
est31 |
I see. |
| 12:24 |
est31 |
Okay MoNTE48 one change is now needed, its from Zeno` |
| 12:24 |
est31 |
He wants to remove the "? 1 : 0" |
| 12:24 |
est31 |
so it should only be "status = device->postEventFromUser(event);" |
| 12:25 |
est31 |
Zeno`, do you +1 if that change happens? |
| 12:25 |
est31 |
(the 4086 PR) |
| 12:25 |
Zeno` |
yes, if it doesn't issue a warning (I'm 99% it won't) |
| 12:25 |
Zeno` |
will check now |
| 12:26 |
est31 |
watch out when editing patch files |
| 12:26 |
est31 |
they require consistent line endings |
| 12:26 |
Zeno` |
not going to :) |
| 12:26 |
est31 |
kate makes the patches have inconsistent line endings |
| 12:26 |
est31 |
i only can edit them with vim |
| 12:27 |
est31 |
and add ^M to where neccessary |
| 12:27 |
Zeno` |
oh man |
| 12:27 |
MoNTE48 |
I hate to do patches :) They do not always get to edit |
| 12:27 |
Zeno` |
heh |
| 12:27 |
Zeno` |
ok, can you just change that MoNTE48? |
| 12:27 |
Zeno` |
and I'll test |
| 12:28 |
DonBatman |
Zeno est31 if you need me to test I can. I just need the apk. |
| 12:28 |
Zeno` |
what's the PR number again? |
| 12:28 |
MoNTE48 |
Check what you're talking about, and if it works well, I will update the PR. I need to figure out how to install Kubuntu on my Microsoft Surface Pro 3 |
| 12:29 |
est31 |
Zeno`, #4086 |
| 12:29 |
ShadowBot |
https://github.com/minetest/minetest/issues/4086 -- Fix locked hardware buttons on Android by MoNTE48 |
| 12:30 |
Zeno` |
I don't need to test... just change it :) |
| 12:31 |
Zeno` |
http://dpaste.com/0E3P9RQ |
| 12:31 |
Zeno` |
it's as I thought |
| 12:31 |
Zeno` |
no cast necessary (as expected) |
| 12:31 |
Zeno` |
so just change :P |
| 12:32 |
MoNTE48 |
@Zeno` To change it I need a linux pc (for re-create patch). I'll try to install linux on my tablet now. |
| 12:35 |
|
maxela_ joined #minetest-dev |
| 12:38 |
|
STHGOM joined #minetest-dev |
| 12:47 |
|
rubenwardy joined #minetest-dev |
| 12:50 |
|
Fixer joined #minetest-dev |
| 13:03 |
|
loggingbot_ joined #minetest-dev |
| 13:03 |
|
Topic for #minetest-dev is now Minetest core development and maintenance. Feature freeze since 2016-05-01, release on 16th. Last release: 0.4.13, Aug 20 2015. Chit-chat goes to #minetest. Consider this instead of /msg celeron55. http://irc.minetest.net/minetest-dev/ http://dev.minetest.net/ |
| 13:09 |
|
MillersMan joined #minetest-dev |
| 13:22 |
|
john_cephalopoda joined #minetest-dev |
| 13:23 |
|
louiloui left #minetest-dev |
| 13:23 |
|
john_cephalopoda left #minetest-dev |
| 13:24 |
|
damiel joined #minetest-dev |
| 13:37 |
Zeno` |
am merging this very shortly: https://github.com/Zeno-/minetest/commit/fbccf09b827bb412f9fea7103033d18aa2bfb4f9 |
| 13:37 |
Zeno` |
est31, ok? |
| 13:39 |
est31 |
yes |
| 13:43 |
Zeno` |
ok, merging in 5 minutes or so (just checking build again) |
| 13:44 |
Zeno` |
<-- paranoid about these whitespaces in the patch files hehe |
| 13:44 |
Zeno` |
they seem to be there but may as well build once more |
| 13:51 |
rubenwardy |
might be good to include a comment here: https://github.com/Zeno-/minetest/commit/fbccf09b827bb412f9fea7103033d18aa2bfb4f9#diff-63448d1f904a44470e4229b78424978cR23 |
| 13:52 |
Zeno` |
such as? |
| 13:53 |
Zeno` |
actually it might be but I don't want to spend more time on it. It's just overriding with a blank function to do nothing |
| 13:53 |
rubenwardy |
// Used to disable default back button action |
| 13:53 |
|
Obani joined #minetest-dev |
| 13:53 |
rubenwardy |
but not important at all |
| 13:53 |
|
Obani left #minetest-dev |
| 13:53 |
rubenwardy |
nevermind, just leave it |
| 13:53 |
est31 |
its a workaround for a minetest bug |
| 13:54 |
Zeno` |
ok |
| 13:55 |
Zeno` |
b906ed4 |
| 13:55 |
Zeno` |
can someone close the PRs? :) |
| 13:56 |
Zeno` |
I need to do something, otherwise I can do it in 5 or so |
| 13:56 |
rubenwardy |
done |
| 13:56 |
Zeno` |
thanks |
| 13:56 |
Zeno` |
bb in 5 |
| 13:56 |
est31 |
b906ed4 basically replaces an improper fix by a less improper fix |
| 13:57 |
est31 |
and fixes an irrlicht bug |
| 13:59 |
rubenwardy |
just one more PR: #4125 |
| 13:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/4125 -- DB::loadBlock copy removal & DB backend cleanup by nerzhul |
| 14:03 |
rubenwardy |
and #4120 |
| 14:03 |
ShadowBot |
https://github.com/minetest/minetest/issues/4120 -- Android: missing "delete world" button |
| 14:05 |
|
Zeno` joined #minetest-dev |
| 14:05 |
est31 |
4125 is not ready for the release |
| 14:05 |
rubenwardy |
I agree, but it's on the milestone |
| 14:06 |
est31 |
does somebody want to do it |
| 14:06 |
Zeno` |
it's not now |
| 14:06 |
est31 |
i think i dont want to do it |
| 14:06 |
est31 |
and about doing a separate android release: no thats messy |
| 14:06 |
est31 |
we would need a separate branch and so on |
| 14:07 |
est31 |
its just far too complicated to get it done on the git side |
| 14:07 |
est31 |
rather no |
| 14:08 |
rubenwardy |
I think that 6 months is too long for Android to receive bug fixes and UI improvements |
| 14:10 |
est31 |
HexChat: 2.10.2 ** OS: Linux 4.4.0-22-generic x86_64 ** Distro: Ubuntu "xenial" 16.04 ** CPU: 4 x Intel(R) Pentium(R) CPU N3520 @ 2.16GHz (GenuineIntel) @ 1,79GHz ** RAM: Physical: 3,7GiB, 59,1% free ** Disk: Total: 908,3GiB, 52,3% free ** VGA: 8086:0f31 ** Sound: HDA-Intel - HDA Intel PCH ** Ethernet: None found ** Uptime: 3h 50m 36s ** |
| 14:10 |
est31 |
what the shit |
| 14:11 |
rubenwardy |
interesting |
| 14:11 |
est31 |
why has hexchat posted this bs |
| 14:11 |
est31 |
stupid garbage |
| 14:12 |
est31 |
but yeah if you ever wondered about my hw setup, here it is |
| 14:14 |
|
naltamur joined #minetest-dev |
| 14:14 |
naltamur |
Hello |
| 14:14 |
naltamur |
Can I have an account for wiki? |
| 14:14 |
rubenwardy |
Calinou, |
| 14:18 |
|
Player_2 joined #minetest-dev |
| 14:19 |
|
naltamur left #minetest-dev |
| 14:32 |
ShadowNinja |
rubenwardy: I think the Android build is updated occasionally but more often than releases. I'm not sure about that though. nrzkt: How often do you update it? |
| 14:33 |
ShadowNinja |
rubenwardy: Also, I can add users to the wiki BTW: http://wiki.minetest.net/index.php?title=Special:ListUsers&group=sysop |
| 14:33 |
est31 |
we can have a minetest nightly app |
| 14:33 |
est31 |
but there is one already, just not in the fdroid and play stores |
| 14:34 |
est31 |
nrzkt has the link i think |
| 14:37 |
Wayward_One |
I have a thread on the forum where I post new builds every few days |
| 14:38 |
Fixer |
lol |
| 14:38 |
Fixer |
Client: HexChat 2.12.0 • OS: Microsoft Windows 7 Ultimate (x64) • CPU: Intel(R) Core(TM) i3-2120 CPU @ 3.30GHz (3.30GHz) • Memory: 8.0 GiB Total (4.7 GiB Free) • Storage: 929.9 GiB / 1.1 TiB (234.4 GiB Free) • VGA: AMD Radeon HD 6800 Series • Uptime: 1h 50m 50s |
| 14:38 |
Fixer |
ah, it is sendsysteminfo command |
| 14:38 |
rubenwardy |
you can't expect users to manually find daily apps like that |
| 14:40 |
Fixer |
hmm, description of my hardware is pretty acurate i say |
| 14:40 |
nrzkt |
ShadowNinja, on each release except if there is a fix after a release |
| 14:42 |
ShadowNinja |
nrzkt: OK. |
| 14:42 |
est31 |
do we still need blockmen in that list |
| 14:43 |
est31 |
Zeno`, there is a problem |
| 14:43 |
est31 |
it fails for me! |
| 14:43 |
Wayward_One |
rubenwardy, true, although quite a few do, I've been told |
| 14:43 |
Wayward_One |
But I agree |
| 14:43 |
est31 |
1 out of 2 hunks FAILED -- saving rejects to file source/Irrlicht/Android/CIrrDeviceAndroid.cpp.rej |
| 14:43 |
est31 |
Hunk #1 FAILED at 486 (different line endings). |
| 14:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/1 -- GlowStone code by anonymousAwesome |
| 14:44 |
Krock |
^ fail |
| 14:45 |
Fixer |
it also has huge list of references |
| 14:45 |
est31 |
:) |
| 14:45 |
est31 |
#2 has too |
| 14:45 |
Zeno` |
huh |
| 14:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/2 -- Burned wood |
| 14:45 |
Fixer |
omg |
| 14:45 |
est31 |
Zeno`, i have a fix prepared |
| 14:45 |
Zeno` |
make clean; rm -rf build; rm -rf deps; make |
| 14:47 |
|
Obani joined #minetest-dev |
| 14:47 |
|
Obani left #minetest-dev |
| 14:48 |
est31 |
Zeno`, https://github.com/est31/minetest/commit/b25554c8d7260cdac6551c69900b78e24b0b48eb |
| 14:48 |
est31 |
wanna push ^ in 5 minutes |
| 14:48 |
Zeno` |
how could the patch work for me but not others? |
| 14:48 |
est31 |
are you on windows |
| 14:48 |
Zeno` |
no |
| 14:48 |
est31 |
weird |
| 14:49 |
est31 |
perhaps your patch program is more tolerant |
| 14:49 |
Zeno` |
are you sure you deleted deps before trying? |
| 14:49 |
est31 |
no |
| 14:49 |
est31 |
i did make clean_irrlicht |
| 14:49 |
est31 |
which is the same |
| 14:49 |
Zeno` |
are you sure? |
| 14:49 |
est31 |
(at least for irrlicht) |
| 14:50 |
est31 |
Zeno`, what does patch --version | head -n1 say |
| 14:50 |
est31 |
Zeno`, yes it deletes the whole irrlicht folder i dont see why it should not work |
| 14:50 |
Zeno` |
GNU patch 2.7.5 |
| 14:50 |
est31 |
thats the same version i have |
| 14:50 |
Zeno` |
I built it 3 times lol |
| 14:52 |
est31 |
fine with me pushing the patch? |
| 14:52 |
Zeno` |
yeah ok |
| 14:52 |
Zeno` |
I just don't understand |
| 14:53 |
Zeno` |
it's building again now |
| 14:53 |
Zeno` |
*shrug* |
| 14:54 |
Zeno` |
push away |
| 14:59 |
|
Obani joined #minetest-dev |
| 14:59 |
|
Obani left #minetest-dev |
| 14:59 |
Zeno` |
wth |
| 15:03 |
|
asl97 joined #minetest-dev |
| 15:06 |
est31 |
1959 |
| 15:06 |
est31 |
#1959 |
| 15:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/1959 -- Checking public serverlist checkbox causes minetest to freeze. |
| 15:06 |
Zeno` |
there is no checkbox |
| 15:07 |
est31 |
should be closed now |
| 15:07 |
Zeno` |
I wonder if my git is configure to fix whitespace when I push |
| 15:08 |
Zeno` |
'cause I just reapplied my patch and it still works lol |
| 15:08 |
est31 |
maybe |
| 15:10 |
|
hmmmm joined #minetest-dev |
| 15:19 |
|
PilzAdam joined #minetest-dev |
| 15:36 |
|
nicoalta01 joined #minetest-dev |
| 15:37 |
nicoalta01 |
Hey! Italian Channel for minetest is open |
| 15:37 |
nicoalta01 |
##minetest-it |
| 16:05 |
|
lisac joined #minetest-dev |
| 16:05 |
|
Sockbat joined #minetest-dev |
| 16:20 |
|
luizrpgluiz joined #minetest-dev |
| 16:22 |
luizrpgluiz |
managed to compile the new version of the game? Or are you still having problems? |
| 16:31 |
|
rubenwardy joined #minetest-dev |
| 16:44 |
|
electrodude512 joined #minetest-dev |
| 17:01 |
Wayward_One |
luizrpgluiz: nobody is having problems compiling it, it hasn't been released because it is not ready |
| 17:27 |
|
FungusAdam joined #minetest-dev |
| 17:29 |
|
EvergreenTree joined #minetest-dev |
| 17:35 |
|
est31 joined #minetest-dev |
| 17:42 |
|
johnnyjoy joined #minetest-dev |
| 17:52 |
EvergreenTree |
est31: I just saw your comment on my pull request, and I see what you mean |
| 17:53 |
EvergreenTree |
How should SendPlayerHPOrDie be made aware that there was a change in the player's health? |
| 17:53 |
EvergreenTree |
should an argument be added? |
| 17:53 |
EvergreenTree |
(like oldhealth) |
| 17:55 |
Krock |
There's a mess of the different damage stuff. This should be rewritten to one PlayerSAO->Damage(u16 damage) function |
| 17:55 |
Krock |
IMO |
| 17:56 |
Krock |
without knowing the previous HP it's imposs to do it with the SendPlayerHPOrDie function |
| 17:56 |
EvergreenTree |
Right |
| 17:56 |
EvergreenTree |
It is kind of a mess |
| 18:01 |
|
Obani joined #minetest-dev |
| 18:02 |
|
Obani left #minetest-dev |
| 18:03 |
EvergreenTree |
The only way to do it with SendPlayerHPOrDie would be to add an oldhp argument |
| 18:03 |
Krock |
I'd rather like to see a rewrite there |
| 18:03 |
Krock |
but yeah, you could do that |
| 18:05 |
EvergreenTree |
I can attempt it, but I don't know much c++. |
| 18:06 |
EvergreenTree |
Also, I have a question. I was looking at this function: https://github.com/minetest/minetest/blob/master/src/environment.cpp#L2879 |
| 18:07 |
EvergreenTree |
What would happen if the localplayer's health wasn't updated? |
| 18:10 |
EvergreenTree |
I just tried it, and nothing really seemed to happen. why is updating the localplayer's health necessary? |
| 18:11 |
EvergreenTree |
(and also why bother giving the option of not handling health when literally all calls to it that I can find pass true as an argument? |
| 18:14 |
luizrpgluiz |
Wayward_One: How long more will need yet? |
| 18:17 |
EvergreenTree |
Krock: do you think I should just try adding an argument to SendPlayerHPOrDie and move the code over there? |
| 18:17 |
EvergreenTree |
(and possibly do what est31 said with the setHP function, though that seems like it should be a separate PR) |
| 18:19 |
Krock |
EvergreenTree, yes. Do that and watch out if you find another, better solution |
| 18:20 |
|
Darcidride joined #minetest-dev |
| 18:21 |
|
edgrey joined #minetest-dev |
| 18:32 |
|
Sockbat joined #minetest-dev |
| 18:41 |
|
Samson1 joined #minetest-dev |
| 18:41 |
EvergreenTree |
Krock: I did it. Should I add it as a new commit instead of ammending the old one? |
| 18:41 |
EvergreenTree |
(it can be squashed later) |
| 18:41 |
Krock |
yes, that's good :) |
| 18:42 |
|
luizrpgluiz left #minetest-dev |
| 18:43 |
EvergreenTree |
Okay, done |
| 18:54 |
|
Darcidride joined #minetest-dev |
| 19:05 |
|
naltamur joined #minetest-dev |
| 19:35 |
|
est31 joined #minetest-dev |
| 19:41 |
|
lisac joined #minetest-dev |
| 19:42 |
est31 |
So, now I dont know of anything anymore that would stall the release |
| 19:43 |
est31 |
what does paramat think |
| 19:44 |
rubenwardy |
est31, #4120 |
| 19:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/4120 -- Android: missing "delete world" button |
| 19:44 |
|
VargaD joined #minetest-dev |
| 19:44 |
est31 |
I dont want to dive into android mainmenu code |
| 19:44 |
rubenwardy |
It's a regression |
| 19:45 |
rubenwardy |
it can't be left broken for 6 months |
| 19:46 |
est31 |
we *really* do need a nightlies repo |
| 19:46 |
est31 |
for android |
| 19:46 |
est31 |
which people use |
| 19:47 |
rubenwardy |
such a feature needs to be in the stable release |
| 19:47 |
rubenwardy |
doesn't have to be 0.4.14, but can't be left for 6 months |
| 19:47 |
est31 |
to prevent such bugs to appear and not be found |
| 19:47 |
rubenwardy |
I see what you mean, that would be helpful too |
| 19:58 |
|
naltamur left #minetest-dev |
| 20:03 |
est31 |
hrmm it seems everything is still there |
| 20:03 |
est31 |
seems to have been not added back by blockmen |
| 20:04 |
est31 |
i'll re-add the button at the place of the key change dialog and everything else can be decided later on |
| 20:13 |
est31 |
okay this one : https://github.com/est31/minetest/commit/f803362be83eb95e467368403bb5e8bd50ba763e |
| 20:19 |
|
Foghrye4 joined #minetest-dev |
| 20:20 |
|
Amaz joined #minetest-dev |
| 20:22 |
Foghrye4 |
Hello. I fixed issue #3681 and created pull request. https://github.com/minetest/minetest/pull/4128 |
| 20:22 |
ShadowBot |
https://github.com/minetest/minetest/issues/3681 -- After set_attach attached model may disappear |
| 20:24 |
|
est31 joined #minetest-dev |
| 20:25 |
est31 |
will push my commit in 10 minutes |
| 20:51 |
|
EvergreenTree joined #minetest-dev |
| 20:52 |
est31 |
so, and now I think I've done enough minetest for today |
| 20:56 |
|
electrodude512 joined #minetest-dev |
| 21:01 |
|
ptv joined #minetest-dev |
| 21:05 |
|
EvergreenTree joined #minetest-dev |
| 21:09 |
hmmmm |
blah |
| 21:09 |
hmmmm |
so what happened to the release |
| 21:09 |
hmmmm |
i thought we said saturday! |
| 21:09 |
rubenwardy |
all milestones are now done |
| 21:09 |
hmmmm |
that makes it 2 full weeks since the original freeze |
| 21:22 |
|
kaeza joined #minetest-dev |
| 21:25 |
|
torgdor joined #minetest-dev |
| 21:32 |
EvergreenTree |
Does another core dev have an opinion on #4127 |
| 21:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/4127 -- Avoid calling DiePlayer more than once by 4Evergreen4 |
| 22:05 |
|
diemartin joined #minetest-dev |
| 22:32 |
|
Lunatrius joined #minetest-dev |
| 22:40 |
|
diemartin joined #minetest-dev |
| 22:41 |
|
est31 joined #minetest-dev |
| 22:42 |
est31 |
hmmmm, release is fine with me as well |
| 22:42 |
est31 |
paramat is the release guy lets wait for his okay |
| 22:48 |
|
paramat joined #minetest-dev |
| 22:48 |
paramat |
go ahead |
| 22:50 |
diemartin |
#1689 ? |
| 22:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/1689 -- Add version API by ShadowNinja |
| 22:50 |
diemartin |
see nrz's comment |
| 22:51 |
paramat |
sorry i wasn't here earlier, just had a long sleep |
| 22:52 |
diemartin |
>Why this trivial fix hasn't been merged ? |
| 22:52 |
diemartin |
Could be useful to have it for this release. The call is trivial and 5 coredevs agreed |
| 22:54 |
|
Zeno` joined #minetest-dev |
| 22:59 |
|
est31 joined #minetest-dev |
| 22:59 |
est31 |
okay then |
| 22:59 |
est31 |
lets do it. |
| 23:00 |
est31 |
paramat, can you get mtgame ready? |
| 23:01 |
est31 |
(as in: tag it) |
| 23:01 |
|
torgdor joined #minetest-dev |
| 23:05 |
|
yang2003 joined #minetest-dev |
| 23:07 |
FungusAdam |
est31, paramat, please read and follow http://dev.minetest.net/Releasing_Minetest carefully to not mess something up during the release process |
| 23:07 |
est31 |
chabgelog ? |
| 23:08 |
paramat |
i don't know how tag, and i think this is not the time to learn (because i learn slowly) |
| 23:09 |
|
blaaaaargh joined #minetest-dev |
| 23:09 |
est31 |
so the latest commit e7a55734d3de051d6565ebe28a9dd53043f9b352 can become 0.4.14? |
| 23:09 |
paramat |
to be clear, i don't understand, and am not capable of doing, the technical process of release, so it's up to others now, sorry :} |
| 23:09 |
Fixer |
oh... |
| 23:09 |
asl97 |
guess there isn't gonna be a release name/title like always |
| 23:10 |
PilzAdam |
est31, yeah, I guess so |
| 23:11 |
PilzAdam |
"Currently built by BlockMen", lol |
| 23:11 |
PilzAdam |
who does MSVC builds? |
| 23:11 |
est31 |
that question is atm unanswered |
| 23:11 |
PilzAdam |
"Be sure that the Windows builds work before continuing to do anything!" |
| 23:12 |
est31 |
I dont have windows, cant help with that |
| 23:12 |
PilzAdam |
great |
| 23:13 |
blaaaaargh |
I can test on Windows |
| 23:14 |
PilzAdam |
so the release is stalled until we get someone who builds on MSVC? |
| 23:14 |
est31 |
seems so |
| 23:14 |
Fixer |
is not sfans has msvc on? >_> |
| 23:14 |
blaaaaargh |
can also do MinGW native builds just in case, but no MSVC :/ |
| 23:14 |
est31 |
i guess msvc is not as important though |
| 23:14 |
est31 |
generally we just need sb to do a win build |
| 23:14 |
PilzAdam |
Fixer, hes probably sleeping, it's very late in Germany currently |
| 23:15 |
Fixer |
wait for tommorrow? |
| 23:15 |
Zeno` |
sfan5 cross-compiles Windows builds usually using gcc |
| 23:15 |
PilzAdam |
est31, MSVC produces better results, doesn't it? |
| 23:15 |
est31 |
I think so |
| 23:16 |
PilzAdam |
we definitely can't release without testing if it even builds in MSVC |
| 23:16 |
Calinou |
"better" |
| 23:16 |
PilzAdam |
sometimes mingw builds, but MSVC doesn't |
| 23:16 |
Calinou |
it's 2016, GCC evolved quite a bit, also less people use crappy PCs than before |
| 23:16 |
Calinou |
IMO it doesn't matter |
| 23:18 |
PilzAdam |
paramat, now you have a non-technical task: get someone who builds on MSVC |
| 23:18 |
VanessaE |
before release, can someone fix one last thing please? |
| 23:18 |
paramat |
heh ok |
| 23:18 |
VanessaE |
Main menu -> Configure world -> enabled modpacks in the list are a very DARK green, hard to read against the black background. |
| 23:18 |
paramat |
nope |
| 23:19 |
|
hmmmmm joined #minetest-dev |
| 23:19 |
PilzAdam |
VanessaE, it's freezing like hell here |
| 23:20 |
VanessaE |
er, ookay |
| 23:21 |
est31 |
and optimally, the MSVC builder is somebody we can trust |
| 23:22 |
VanessaE |
anyway I'm serious, it's a usability issue that could probably be fixed in a matter of seconds: just brighten up the color by 25% or so. |
| 23:23 |
VanessaE |
(I so rarely have to go into that menu, let alone enable a modpack, that I didn't notice it before) |
| 23:25 |
paramat |
we're serious too :) |
| 23:25 |
PilzAdam |
paramat, the release probably has to be postponed anyway |
| 23:25 |
PilzAdam |
(until we find someone who can build it, that is) |
| 23:25 |
VanessaE |
just hoping I could get that in before release is all |
| 23:26 |
Fixer |
i don't want to install gigatons of ms gar...compilers etc, last time I compiled mt with it 5 years ago was already too fat |
| 23:27 |
PilzAdam |
I'm going to sleep now, if you are still in the release process when I come back (about 13 hours or so) then ping me so I can help out |
| 23:27 |
OldCoder |
Hi |
| 23:27 |
OldCoder |
Did somebody need a Windows build? |
| 23:27 |
paramat |
ko |
| 23:27 |
paramat |
ok |
| 23:27 |
sofar |
OldCoder: yes :) |
| 23:28 |
OldCoder |
I don't do MSVC; I can contribute a -O3 gcc version |
| 23:28 |
OldCoder |
^ fast |
| 23:28 |
OldCoder |
Will this do as a fallback? |
| 23:28 |
|
hmmmmmm joined #minetest-dev |
| 23:29 |
OldCoder |
Ah |
| 23:29 |
* OldCoder |
has scrolled up |
| 23:29 |
OldCoder |
Yes, you need a MSVC person... But I'll contribute my gcc builds regardless |
| 23:29 |
OldCoder |
How much does MSVC cost? |
| 23:29 |
OldCoder |
Or does somebody have a license etc. to transfer? |
| 23:29 |
OldCoder |
I'll install it on my Windows VM |
| 23:30 |
sofar |
is there a howto for doing a msvc build? |
| 23:30 |
VanessaE |
why, again, is msvc even needed? |
| 23:30 |
OldCoder |
Ought to be; if there is not, it is not as important as thought |
| 23:30 |
* OldCoder |
needs to nap but will build pre-release today to confirm it works |
| 23:30 |
est31 |
sofar, http://dev.minetest.net/Compiling_Minetest#Compiling_on_Windows |
| 23:30 |
VanessaE |
doesn't this same issue arise every time a release is scheduled? |
| 23:30 |
sofar |
just checking it out... |
| 23:31 |
OldCoder |
Hm |
| 23:31 |
OldCoder |
If anybody has a legal copy of MSVC to transfer, I will try this. Otherwise, I will build using OldCoder MaxGW |
| 23:32 |
|
hmmmmm joined #minetest-dev |
| 23:32 |
* OldCoder |
uses MaxGW instead of MinGW |
| 23:32 |
paramat |
does latest code need further testing on android? |
| 23:32 |
sofar |
maybe I can build at work |
| 23:32 |
est31 |
https://www.visualstudio.com/en-us/products/visual-studio-community-vs.aspx |
| 23:32 |
OldCoder |
sofar, aren't you Linux? |
| 23:32 |
sofar |
OldCoder: pretty much 100%, yes |
| 23:32 |
est31 |
paramat, i think android is ready for release now |
| 23:32 |
OldCoder |
Huh |
| 23:32 |
est31 |
now even rubenwardy is convinced :) |
| 23:32 |
OldCoder |
It's free now? |
| 23:33 |
est31 |
OldCoder, not all versions of it |
| 23:33 |
OldCoder |
But for MT? |
| 23:33 |
OldCoder |
MT is FOSS |
| 23:33 |
paramat |
ok |
| 23:33 |
est31 |
yes |
| 23:33 |
rubenwardy |
All is good |
| 23:33 |
OldCoder |
I need to nap an hour. If anybody remains to help later I will try this. |
| 23:33 |
est31 |
Visual Studio Community is free for individual developers, open source projects, academic research, education, and small professional teams. |
| 23:34 |
* OldCoder |
looks for link |
| 23:34 |
OldCoder |
Here, link, link |
| 23:34 |
OldCoder |
Found what looks like installer; will try after nap |
| 23:35 |
|
hmmmmmm joined #minetest-dev |
| 23:39 |
Zeno` |
you don't need it |
| 23:39 |
Zeno` |
it comes with .net |
| 23:40 |
Zeno` |
so you can build with the instructions on the forum without getting that community thing |
| 23:40 |
paramat |
mtgame looks good to go |
| 23:40 |
Zeno` |
krock taught me how :) |
| 23:40 |
Zeno` |
est31 ^ |
| 23:41 |
est31 |
Zeno`, can you build then |
| 23:41 |
Zeno` |
the release ones? |
| 23:41 |
est31 |
yes |
| 23:42 |
Zeno` |
I'd rather that Krock did it tbh |
| 23:42 |
Zeno` |
he has experience |
| 23:42 |
Zeno` |
I build on Windows once every 9 months heh |
| 23:42 |
est31 |
he can only do it for 32 bit |
| 23:42 |
Fixer |
Zeno`, i build it via .bat too |
| 23:42 |
Zeno` |
Fixer, you do it the same way as Krock? |
| 23:42 |
Fixer |
it was long ago and my code was even worse |
| 23:42 |
Zeno` |
with the command line that comes with .net? |
| 23:43 |
Zeno` |
vcmake or whatever it's called |
| 23:43 |
Calinou |
nmake |
| 23:43 |
Fixer |
Zeno`, long ago celeron posted a script to compile, i took it, hacked a little, ???, msvc |
| 23:43 |
Calinou |
you'd use CMake to generate a .sln anyway, typically |
| 23:43 |
Calinou |
(.sln = solution) |
| 23:43 |
Fixer |
Zeno`, yes with cmd, but needed hands at cmake |
| 23:43 |
Zeno` |
Calinou, yeah... the point is you don't need to download Visual Studio |
| 23:44 |
Fixer |
Zeno`, are you sure? |
| 23:44 |
Zeno` |
Fixer, positive |
| 23:44 |
Zeno` |
Fixer, krock walked me through it |
| 23:44 |
Fixer |
Zeno`, when I was on XP, it downloaded shit-ton of stuff |
| 23:44 |
Calinou |
well with VS, you can build the game using a GUI, it's a bit easier |
| 23:44 |
Zeno` |
nah, win vista onwards everything you need is in .net |
| 23:44 |
sofar |
would be nice to have that again |
| 23:44 |
Calinou |
you need Windows 7 to use VS 2015 |
| 23:45 |
Fixer |
I used this long ago: http://pastebin.com/raw/B8PeMe9D |
| 23:45 |
OldCoder |
Calinou, I have a Win7 VM |
| 23:46 |
Zeno` |
ah there it is |
| 23:46 |
Zeno` |
MSBuild.exe |
| 23:46 |
Zeno` |
/run/media/crobbins/WIN7/Windows/Microsoft.NET/Framework/v4.0.30319/MSBuild.exe |
| 23:47 |
Zeno` |
you use cmake and then MSBuild.exe |
| 23:47 |
Fixer |
right |
| 23:47 |
Fixer |
look at script i posted |
| 23:47 |
Zeno` |
I am... it's big :) |
| 23:47 |
Fixer |
07.04.2012 |
| 23:48 |
Fixer |
i remember that hot days of compiling on xp |
| 23:48 |
Zeno` |
hehe |
| 23:48 |
Fixer |
build 0.3.x with it |
| 23:49 |
Fixer |
or little older |
| 23:49 |
Fixer |
i think celeron gave this script, i just reworked it somewhat |
| 23:49 |
Fixer |
mingw builds worked shitty back then iirc |
| 23:50 |
Fixer |
it was ~0.3 days, i remember now |
| 23:50 |
Fixer |
occlusion stuff etc |
| 23:51 |
Fixer |
weedy builds |
| 23:53 |
Zeno` |
what krock showed me wasn't as complicated as that script :) |
| 23:55 |
|
damiel joined #minetest-dev |
