Time |
Nick |
Message |
00:02 |
Fixer |
have you guys noticed mainloop_dtime and mainloop_other making big 0.5 spike (freeze) on servers like Vanessa Basic Plus and Linux Gaming 2? |
00:21 |
est31 |
perhaps we can do some of this stuff: https://www.youtube.com/watch?v=EqlzMx66Lt4 |
00:55 |
|
d joined #minetest-dev |
01:36 |
|
misprint joined #minetest-dev |
01:58 |
|
Taoki_1 joined #minetest-dev |
05:13 |
|
paramat joined #minetest-dev |
05:16 |
RealBadAngel |
paramat, http://imgur.com/a/Bc6jf |
05:17 |
paramat |
yes saw that, something for MTHD i think, seems rather pointless to me |
05:17 |
paramat |
also makes the halo even darker, which is already a problem |
05:18 |
RealBadAngel |
im tryin to fine tune it now |
05:18 |
RealBadAngel |
http://imgur.com/a/13ihz |
05:18 |
RealBadAngel |
actually its pretty useable |
05:19 |
paramat |
ah colour is a good idea |
05:19 |
RealBadAngel |
you know where the node will be placed |
05:19 |
paramat |
i think players can see where the crosshair is :) |
05:20 |
RealBadAngel |
sometimes its problematic |
05:20 |
kaadmy |
RealBadAngel: could you just tint the faces on the selection side? |
05:20 |
RealBadAngel |
kaadmy, no i cant |
05:21 |
kaadmy |
paramat: with halo selection placing nodes below you on a cliff is really difficult |
05:21 |
RealBadAngel |
kaadmy, why so? |
05:22 |
kaadmy |
hard to see the selected face without falling :P |
05:22 |
kaadmy |
sneak works but is flaky |
05:23 |
RealBadAngel |
weird problem. halo makes the face actually more visible |
05:23 |
kaadmy |
hmm, maybe |
05:23 |
kaadmy |
had an idea |
05:24 |
kaadmy |
could there be a faded halo where the placed node should appear? |
05:24 |
kaadmy |
would be bad for nodes that change dir after placing, but... |
05:24 |
RealBadAngel |
http://imgur.com/a/UJcwJ |
05:25 |
RealBadAngel |
^^ small, but still a cliff ;) |
05:25 |
kaadmy |
nice |
05:25 |
kaadmy |
g'nite now tho |
05:26 |
paramat |
new blocker #3759 |
05:26 |
ShadowBot |
https://github.com/minetest/minetest/issues/3759 -- Remove 'new style water' and waving water. |
05:27 |
RealBadAngel |
not a problem, but to make it i need #3616 |
05:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/3616 -- Allow to set shader for a node, add special and normal texture defs f… by RealBadAngel |
05:28 |
RealBadAngel |
thx to 3616 we dont need hardcoding of shaders for specific nodes |
05:28 |
RealBadAngel |
thus mod just sets the shader to use |
05:29 |
RealBadAngel |
so all water nodes can pick up the same liquids shader |
05:30 |
paramat |
you mean for the new water shaders you need 3616, we can remove waving water withtout 3616 :) |
05:30 |
RealBadAngel |
partially true |
05:30 |
RealBadAngel |
atm its a mess, single shader for everything |
05:31 |
RealBadAngel |
with one exception: hardcoded water shader for default water |
05:31 |
paramat |
3616 might be ok now you've removed forcing filters |
05:31 |
RealBadAngel |
yes, also theres no ability to send shaders from server |
05:32 |
RealBadAngel |
so mod can pick only those which we have supplied |
05:33 |
RealBadAngel |
new style water on the other hand is not connected to shaders, its simpler |
05:34 |
RealBadAngel |
anyway, i can do both in an hour or so |
05:35 |
paramat |
is 3616 lightweight? |
05:35 |
RealBadAngel |
3616 is about 2 new tiledef props basically |
05:36 |
RealBadAngel |
and removing hardcoding water shader |
05:36 |
paramat |
anyway i might +1 it, but don't understand the issues well |
05:36 |
RealBadAngel |
tiledef things are textures |
05:36 |
RealBadAngel |
normal texture and special one. so you can predefine them for each tile |
05:38 |
RealBadAngel |
i will rebase 3616 (i think its needed) and will describe it better |
05:52 |
RealBadAngel |
paramat, ive added highlighting selected face to #3753 as separate commit (it depends on the fixed getPointedThing code) |
05:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/3753 -- Fix getting pointed node by RealBadAngel |
05:52 |
RealBadAngel |
so you may want to try it |
06:03 |
paramat |
ok |
06:06 |
paramat |
i don't think i can +1 3616, it adds 'normal texture' which we don't use anymore. also it's preparation for your new water shaders, which we're not sure about. i think the removeal of new style water and waving water has to be something seperate, so that temporarily we have no water shader, while we discuss its replacement |
06:10 |
paramat |
(removal) |
06:11 |
paramat |
we should change Fixer's name to Reporter |
06:13 |
paramat |
i might agree to 3616 eventually when i understand it better, just we shouldn't rush into merging it for the sake of enabling removal of current water shader |
06:18 |
RealBadAngel |
paramat, that you removed files from mt_game doesnt mean engine doesnt use normals |
06:20 |
RealBadAngel |
engine can handle that on its own even :P |
06:21 |
RealBadAngel |
and saying that a change is wrong because it can be used to code something else is rather stupid |
06:21 |
RealBadAngel |
block then shaders if you will find them not suitable |
06:21 |
RealBadAngel |
but dont block the change that cleans the mess |
06:22 |
RealBadAngel |
atm its like that "im against the hammers because you can hit some1 in the head with it" ;) |
06:23 |
paramat |
good point that other subgames can use normals |
06:23 |
RealBadAngel |
even minimal is using normals ;) |
06:23 |
RealBadAngel |
just enable bumpmapping :) |
06:23 |
paramat |
i mean normal textures |
06:23 |
paramat |
anyway as you can see i don't understand |
06:24 |
RealBadAngel |
its not any different if you supply them or generate them |
06:24 |
RealBadAngel |
as i said, i will describe 3166 better |
06:25 |
paramat |
ok |
06:25 |
RealBadAngel |
i mean 3616 |
06:25 |
RealBadAngel |
meanwhile i do have removal of new style water rsy |
06:25 |
RealBadAngel |
*rdy |
06:26 |
paramat |
ok pilzadam seems to support that too so that will hopefully go through soon |
06:30 |
RealBadAngel |
paramat, also water reflections etc can become matter of a subgame too (so just a fancy subgame) |
06:31 |
RealBadAngel |
just an idea |
06:35 |
RealBadAngel |
paramat, if i havent fucked up anything it should be ok #3760 |
06:35 |
ShadowBot |
https://github.com/minetest/minetest/issues/3760 -- Remove new style water by RealBadAngel |
06:35 |
RealBadAngel |
need to test it |
06:35 |
paramat |
ok |
06:36 |
RealBadAngel |
will test it after breakfast |
06:36 |
RealBadAngel |
atm i havent even checked if it compiles ;) |
07:00 |
|
Hunterz joined #minetest-dev |
07:03 |
|
Calinou joined #minetest-dev |
07:18 |
paramat |
top priority today is merging #3740 i'll test very soon |
07:18 |
ShadowBot |
https://github.com/minetest/minetest/issues/3740 -- Restore simple settings tab and add advanced settings as dialog by kilbith |
07:20 |
sofar |
anyone know by chance at what y elevations there is a chunk border? |
07:21 |
sofar |
I mean, is there a block border at -8 and 8, or 0 & 16? |
07:21 |
sofar |
and where is the chunk border? |
07:36 |
paramat |
lowest nodes of mapchunks are at -32 48 128 208 ... |
07:37 |
paramat |
you can irritate a mapgen dev by saying "y = 47" |
07:38 |
sofar |
that's what I was after |
07:38 |
paramat |
same for all axes |
07:38 |
sofar |
valleys doesn't handle it well, I think it's the mudslide code |
07:41 |
RealBadAngel |
paramat, the pr with new style water is ok, fixed the formatting too |
07:43 |
paramat |
mgv6 stops at y = 47 because it can't cope with a chunk border, mainly due to it's mudflow code |
07:43 |
paramat |
all other mapgens should cope, but valleys may not for some reason |
07:50 |
sofar |
these TNT commits are all conflicting |
07:50 |
sofar |
no wonder I haven't seen red-001 in a few days :) |
07:52 |
paramat |
it's a mess, something for after release |
07:53 |
sofar |
well, all but the last one are easily stackable |
07:53 |
sofar |
the vmanip one however |
08:05 |
sofar |
9 parameters in destroy() now :( |
08:16 |
sofar |
goodness, I actually made it work |
08:17 |
sofar |
<famous last words> |
08:32 |
sofar |
paramat: game#862, but feel free to entirely ignore it for now ;) |
08:32 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/862 -- Tnt: Improvements [WIP] by sofar |
08:33 |
paramat |
ok |
08:37 |
sofar |
ok, I've spent enough time now blowing stuff up |
08:37 |
* sofar |
hits the sack |
08:43 |
paramat |
will merge #3740 in a moment, just tested it |
08:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/3740 -- Restore simple settings tab and add advanced settings as dialog by kilbith |
08:48 |
|
Krock joined #minetest-dev |
08:49 |
paramat |
now merging |
09:00 |
paramat |
merged |
09:00 |
paramat |
at last |
09:17 |
paramat |
sfan5 or anyone, please review game#858 |
09:17 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/858 -- Door protection fix, and fallback compatibility code for mods. by sofar |
09:17 |
sfan5 |
sure |
09:18 |
sfan5 |
paramat: looks good |
09:18 |
paramat |
ok |
09:20 |
|
nrzkt joined #minetest-dev |
09:26 |
paramat |
sfan5 any thoughts on removing 'dig up' from cactus? https://github.com/minetest/minetest_game/pull/847#issuecomment-185653729 |
09:26 |
sfan5 |
wait what |
09:27 |
sfan5 |
we have branched cacti? |
09:28 |
paramat |
heh in all mapgens except mgv6 |
09:28 |
paramat |
a mix of old and larger branched |
09:29 |
sfan5 |
hm not sure |
09:30 |
paramat |
ok we'll wait for more input |
09:30 |
paramat |
is this needed? https://github.com/minetest/minetest_game/pull/846#issuecomment-183818197 |
09:31 |
sfan5 |
not really |
09:31 |
paramat |
ok thanks |
09:34 |
paramat |
sfan5 another one i'm unsure about game#785 |
09:34 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/785 -- Move character.png to textures. by sofar |
09:34 |
sfan5 |
seems ok |
09:35 |
sfan5 |
if minetest never looks into models/ why not move it to the correct path |
09:35 |
paramat |
ok |
09:37 |
paramat |
sfan5 this is tested just needs a +1 game#792 |
09:37 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/792 -- Snow footsteps: lower volume by sofar |
09:38 |
sfan5 |
looks good |
09:38 |
paramat |
ok |
09:43 |
paramat |
i plan to adjust tree decoration noises so we have more forest clearings (in mgv7 etc) |
09:43 |
paramat |
currently they're just a little too 'solid' |
09:44 |
|
kilbith joined #minetest-dev |
09:44 |
kilbith |
hello, this medium-priority fix should go in : https://github.com/minetest/minetest_game/pull/860 |
09:49 |
paramat |
looking |
09:53 |
paramat |
+1 |
09:53 |
kilbith |
you can class it as trivial and i'm the author of that code |
09:53 |
kilbith |
i know precisely what are the risks |
09:58 |
paramat |
i closed game#447 , long overdue :) |
09:58 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/447 -- Add Pies by C1ffisme |
09:59 |
paramat |
hm it is fairly simple and trivial, sfan5 do you want to check it? (game 860) |
10:00 |
kilbith |
nore approved already |
10:00 |
paramat |
i'll do some merging in an hour or 2 |
10:00 |
paramat |
oh yeah |
10:00 |
paramat |
ok i'll merge later |
10:01 |
sfan5 |
paramat: i approve too |
10:04 |
|
xeranas joined #minetest-dev |
10:07 |
xeranas |
hi, why I cant see particles througth block where use_texture_alpha is true? Did I miss something? |
10:08 |
Calinou |
xeranas, because transparency is a complex topic |
10:08 |
Calinou |
yes, there exists various "order-independent transparency" methods but those are costy and tricky to apply |
10:08 |
xeranas |
Calinou: in other worlds its a bug |
10:09 |
xeranas |
words |
10:09 |
xeranas |
? |
10:09 |
Calinou |
it's more of a technical limitation of the engine than a bug |
10:11 |
xeranas |
Calinou: so there no way to see rain drops from colored glass? |
10:11 |
Calinou |
probably not |
10:23 |
|
ud1_ joined #minetest-dev |
10:27 |
|
DevBox joined #minetest-dev |
10:37 |
|
kilbith left #minetest-dev |
11:00 |
|
paramat joined #minetest-dev |
11:00 |
|
celeron55 joined #minetest-dev |
11:05 |
|
Obani joined #minetest-dev |
11:05 |
paramat |
nore sfan5 i'll link some game PRs that could possibly be closed if we get 3 -1s |
11:05 |
paramat |
game#312 |
11:05 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/312 -- Faster movement speeds for less boring gameplay by Calinou |
11:06 |
paramat |
game#401 |
11:06 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/401 -- Add an outlined crosshair by Calinou |
11:06 |
paramat |
game#352 sorry to the author :) |
11:06 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/352 -- Make it possible to craft sticks into wood by Calinou |
11:07 |
nore |
paramat: ok for closing 352 |
11:13 |
paramat |
ok, i think blockmen was a dev at the time so that's -3, i'll close it |
11:17 |
|
ud1 joined #minetest-dev |
11:27 |
|
RealBadAngel joined #minetest-dev |
11:47 |
|
Lunatrius` joined #minetest-dev |
12:00 |
|
Lunatrius joined #minetest-dev |
12:16 |
|
Samson1 joined #minetest-dev |
12:29 |
|
Obani joined #minetest-dev |
12:30 |
|
Lunatrius` joined #minetest-dev |
12:35 |
|
Fixer joined #minetest-dev |
12:36 |
|
Lunatrius` joined #minetest-dev |
13:20 |
|
NewReasonz joined #minetest-dev |
13:47 |
paramat |
#3762 |
13:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/3762 -- Sheet Ore: Eliminate crash caused by PcgRandom range max < min by paramat |
13:56 |
|
rubenwardy joined #minetest-dev |
14:06 |
Fixer |
RealBadAngel, have you seen this https://github.com/minetest/minetest/issues/3757 |
14:06 |
RealBadAngel |
Fixer, i know what it is |
14:06 |
Obani |
Yes he has |
14:06 |
RealBadAngel |
water is fucked up in many aspects |
14:07 |
Fixer |
RealBadAngel, but that was lava issue %) |
14:08 |
RealBadAngel |
the screenies are about what happens when 2 liquids meets (which is fucked up) plus new style enabled which makes it fucked up ^2 |
14:08 |
RealBadAngel |
im refering now to what you have just wrote in response to my comment |
14:08 |
Fixer |
RealBadAngel, ah, i mean look my link with lava fountain, it is problem with shaders on |
14:09 |
RealBadAngel |
Fixer, thats easy to fix |
14:09 |
RealBadAngel |
will do that |
14:09 |
Fixer |
ok, ty |
14:15 |
Obani |
What's up with #3535 |
14:15 |
ShadowBot |
https://github.com/minetest/minetest/issues/3535 -- fix #2876 (fix player teleportation bug) by HybridDog |
14:15 |
Obani |
? |
14:16 |
RealBadAngel |
kahrl, nore, nrzkt, sfan5 can anybody vote on bugfixes commits? |
14:17 |
RealBadAngel |
#3753, #3751 |
14:17 |
ShadowBot |
https://github.com/minetest/minetest/issues/3753 -- Fix getting pointed node by RealBadAngel |
14:17 |
ShadowBot |
https://github.com/minetest/minetest/issues/3751 -- Dont make fastface if tile is not seamless by RealBadAngel |
14:22 |
Obani |
RealBadAngel, is face highlighting in halo a MT.conf parameter ? |
14:23 |
Obani |
I know it's not a really important feature and it will only contribute to increase mt.conf's size, but, anyway, just askin' :p |
14:23 |
RealBadAngel |
face highilighting is not an official PR yet, so it doesnt have any options to control it |
14:23 |
RealBadAngel |
ive put the commit in 3753 only because i wanted folks to test it (it depends on 3753) |
14:24 |
Obani |
I think it should be with it |
14:24 |
Obani |
What purpose having node higlighting if it's to do nearly the same thing as linear selection box ? |
14:25 |
RealBadAngel |
huh? |
14:25 |
RealBadAngel |
do you find halo lookin the same as boxes? |
14:25 |
Obani |
no, but it does the same thing |
14:26 |
RealBadAngel |
then use boxes |
14:26 |
Obani |
But highlighting faces would add a difference between them, and help to see what face is selected |
14:26 |
Obani |
RealBadAngel, that's what do :p |
14:26 |
Obani |
I* |
14:26 |
RealBadAngel |
for me boxes look like pure shit, almost invisible on most of the nodes |
14:27 |
Fixer |
halo is good for building |
14:27 |
RealBadAngel |
on droids it gets even worse |
14:27 |
Obani |
RealBadAngel, that's why I usually tweak them in mt.conf |
14:28 |
Fixer |
halo has only one side-effect, view from the windows is slightly obscured by it (so people like to view from windows (like me) can disable it) |
14:28 |
Obani |
to make line larger and grey-violet |
14:28 |
RealBadAngel |
Obani, tell that to android users |
14:28 |
Fixer |
RealBadAngel, android users are mazo anyway |
14:28 |
Obani |
RealBadAngel, Android users can't even jump properly :p |
14:28 |
Obani |
And don't have any use button ^^ |
14:28 |
RealBadAngel |
thats not related |
14:28 |
Fixer |
even I got bigger screen with my spectrum |
14:29 |
Obani |
Android users have always been disadvantaged :p |
14:29 |
Fixer |
kids need proper PC later |
14:29 |
Obani |
proper PC isn't needed |
14:29 |
Obani |
With my Pentium I still can play MT |
14:30 |
Obani |
just need to desactivate shaders :) |
14:30 |
Fixer |
you are mazo too (sorry for offtopic) |
14:31 |
RealBadAngel |
Obani, also try to highlight node with MANY nodeboxes with halo and wireframes |
14:31 |
RealBadAngel |
you will see the difference |
14:33 |
RealBadAngel |
regular selection boxes looks more like debug mode to show wireframes than actual way to show selected things |
14:33 |
RealBadAngel |
imho not acceptable in a game |
14:33 |
RealBadAngel |
ofc if you care about quality of visuals |
14:34 |
RealBadAngel |
if you do not, then propably wireframes are just for you ;) |
14:34 |
Obani |
RealBadAngel, it's not that I do not |
14:34 |
Obani |
But first, I played MT since 0.3.1 |
14:35 |
RealBadAngel |
and btw, that what you do, changing thickness and color is actually attempt to fix shitty lookin thing |
14:35 |
Obani |
So 3d model and animations have been for a long time something impossible to imagine |
14:35 |
Fixer |
i use node_highlighting = box, perfectly good for me, halo is good for builders |
14:35 |
Obani |
2 - I don't have a proper computer for high quality graphics |
14:36 |
Obani |
3 - regular box is tweakable, and I could have nice things with it |
14:36 |
RealBadAngel |
you call halo a demanding stuff? |
14:36 |
Obani |
4 - Halo is not really fitting with Minetest style |
14:37 |
RealBadAngel |
ad 4. LOL |
14:37 |
Obani |
5 - Don't care about graphical effects if they do not fit with the style of your game |
14:37 |
Obani |
6 - it can hide other ndoes |
14:37 |
RealBadAngel |
anyway, its an option, dont like dont use |
14:37 |
Obani |
Don't like :) |
14:37 |
RealBadAngel |
dont use |
14:37 |
RealBadAngel |
!next |
14:37 |
ShadowBot |
Another satisfied customer. Next! |
14:37 |
Obani |
Also, I don't think halo is tweakable, is it ? |
14:38 |
RealBadAngel |
way more than boxes |
14:38 |
Obani |
Really ? color and all that ? |
14:38 |
RealBadAngel |
you can texture it as you wish |
14:38 |
Obani |
Myabe you'll make me change my mind :) |
14:41 |
RealBadAngel |
http://i.imgur.com/cx7wk8M.png http://i.imgur.com/JX2COPv.png http://i.imgur.com/KMOqhEO.png |
14:41 |
RealBadAngel |
for example |
14:42 |
Fixer |
RealBadAngel, first one has fuzzy edges |
14:43 |
RealBadAngel |
those are examples, made just to show whats possible |
14:44 |
Obani |
What's up with this ? 0.o #3380 |
14:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/3380 -- Support nested modpacks in mainmenu by yyt16384 |
14:45 |
Obani |
#3448 ? |
14:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/3448 -- Faster insertion into table by Rui914 |
14:45 |
Obani |
Hey guys, what if I made some musics for Minetest ? :D |
14:47 |
paramat |
updated 3762 after testing |
14:56 |
|
kaadmy joined #minetest-dev |
15:00 |
RealBadAngel |
Obani, no way. Minetest spirit is deaf, sorry. |
15:02 |
rubenwardy |
Mercury rain just didn't match many peoples image of MT |
15:03 |
RealBadAngel |
its a general problem, ive proposed many tunes |
15:03 |
RealBadAngel |
simply minetest is not a game |
15:03 |
Fixer |
MTG needs very slight background wind sound, i have found few candidates already on freesounds |
15:03 |
|
iqualfragile joined #minetest-dev |
15:04 |
Fixer |
4 sounds actually, one for ocean, one for greeny, one for snow biome, one for caves |
15:04 |
RealBadAngel |
its something like BW movies from early XX century |
15:05 |
RealBadAngel |
when they was showing such movie there was a guy playin on piano next to the screen |
15:05 |
Fixer |
right |
15:05 |
RealBadAngel |
we do have XXI now, so one can fire up mp3 player instead |
15:06 |
Fixer |
with wind sounds |
15:06 |
RealBadAngel |
its nothing different |
15:07 |
|
iqualfragile joined #minetest-dev |
15:08 |
RealBadAngel |
but says something about mentality of the spirtit ;) |
15:08 |
Obani |
Ok so |
15:08 |
Obani |
I just made a music |
15:08 |
Obani |
<3 phasex |
15:08 |
Obani |
<3 ardour |
15:09 |
RealBadAngel |
make mp3 from it and play in the background |
15:09 |
RealBadAngel |
you will never get it in |
15:10 |
Obani |
I know it will never be in Minetest |
15:10 |
RealBadAngel |
you could be mozart and you will be accused of attempt to bloat the game only |
15:10 |
Obani |
But I want to make some for when it will have a proper music support :) |
15:10 |
RealBadAngel |
do you still believe in santa claus? or fairy tales? |
15:10 |
Obani |
Well you are our Santa Claus for graphics |
15:11 |
RealBadAngel |
upstream minetest will never have proper music |
15:11 |
Obani |
We can still believe some Santa Claus will come for sound |
15:11 |
Obani |
I don't mean music |
15:11 |
Obani |
Music support :) |
15:12 |
RealBadAngel |
nah, forget it, what for support if it wont be allowed to use? |
15:12 |
RealBadAngel |
nvm |
15:13 |
Obani |
heh |
15:13 |
Obani |
You don't understand |
15:13 |
RealBadAngel |
ive been trhough it too many times, gave up long time agon |
15:13 |
Obani |
It's music |
15:13 |
Obani |
If it's not accepted in Minetest |
15:13 |
Obani |
It can still be in other games :p |
15:13 |
Obani |
So I don't care :p |
15:14 |
RealBadAngel |
get client side modding so proper support will be possible |
15:14 |
Obani |
RealBadAngel, I know that :'( |
15:14 |
RealBadAngel |
im not the guy who can code such thing |
15:21 |
Obani |
RealBadAngel, check it out https://up1.ca/#ow4e3PyJV3W1BGvKuLyasg :) |
15:21 |
paramat |
will merge games 785 792 858 860 in a moment |
15:21 |
Fixer |
nice |
15:22 |
RealBadAngel |
Obani, will check later, atm speakers are connected to the radio |
15:22 |
|
est31 joined #minetest-dev |
15:22 |
RealBadAngel |
i do play mt only on my PC, dont need to have speakers connected |
15:23 |
RealBadAngel |
there are no sound here |
15:24 |
RealBadAngel |
est31, hi |
15:24 |
est31 |
hello |
15:25 |
paramat |
now merging those 4 |
15:25 |
est31 |
paramat, what do you merge? |
15:25 |
est31 |
game prs? |
15:25 |
Obani |
yes |
15:25 |
paramat |
yes i listed them just before you arrived |
15:25 |
Obani |
<paramat> will merge games 785 792 858 860 in a moment |
15:25 |
est31 |
ok |
15:25 |
paramat |
thanks |
15:26 |
Obani |
est31, check this out :p https://up1.ca/#ow4e3PyJV3W1BGvKuLyasg |
15:26 |
RealBadAngel |
est31, can you check my last PRs? |
15:27 |
RealBadAngel |
est31, 3748, 3749, 3751, 3753 |
15:29 |
est31 |
I agree with paramat and nrz, the commit where the selected face is highlighted is good for debugging and should be kept around, but it shouldnt be merged into master |
15:29 |
RealBadAngel |
est31, i can add option for it |
15:29 |
Obani |
\o/ |
15:30 |
RealBadAngel |
code for it is dead simple |
15:30 |
RealBadAngel |
its just changing vertex color based on face normal |
15:30 |
est31 |
why do you add braces everywhere |
15:30 |
est31 |
its fine without braces too |
15:31 |
RealBadAngel |
when i do not hmmm is asking me why do i change style |
15:31 |
RealBadAngel |
so i keep one style everywhere |
15:32 |
est31 |
well, shrug its no big issue |
15:32 |
est31 |
so oka |
15:32 |
est31 |
y |
15:32 |
RealBadAngel |
also those brackets save you from stupid bugs |
15:32 |
RealBadAngel |
ive spent once a few hours because of that lol |
15:33 |
est31 |
it just would be bad if everybody edited as they want |
15:33 |
est31 |
changing back and forth etc |
15:34 |
RealBadAngel |
next time i will be asked by hmmm again to use them |
15:34 |
RealBadAngel |
so edit guideline or something |
15:35 |
RealBadAngel |
each one of you have different tastes just |
15:35 |
est31 |
:) |
15:37 |
paramat |
merged 3 of those as 4th has a possible mistake, waiting for sofar to check |
15:40 |
RealBadAngel |
est31, so highlighting face is not a part of actual bugfix, its here only if some1 would see in action |
15:42 |
RealBadAngel |
when bugfix is in i can make separate PR with it |
15:42 |
est31 |
RealBadAngel, I still wonder where the actual bugfix part of your PR is |
15:42 |
est31 |
I just see you moved some code around |
15:42 |
RealBadAngel |
first commit |
15:42 |
RealBadAngel |
est31, wanna me to explain it? |
15:42 |
est31 |
yes |
15:44 |
RealBadAngel |
ok. first of all the min_distance problem, it was messed |
15:45 |
RealBadAngel |
second problem was the number of boxes processed |
15:46 |
RealBadAngel |
if ray doesnt intersect with bounding box what for check individual boxes and even their face boxes |
15:46 |
RealBadAngel |
next thing why copy boxes to the result each time intersection is found? |
15:47 |
RealBadAngel |
that propapbly made the code lag with long range |
15:48 |
|
Player_2 joined #minetest-dev |
15:50 |
RealBadAngel |
so basically "the moving" as you called it fixed the problems the routine had |
15:55 |
est31 |
<RealBadAngel> if ray doesnt intersect with bounding box what for check individual boxes and even their face boxes |
15:55 |
est31 |
I see one problem with that |
15:55 |
est31 |
you calculate the distance without applying facedir |
15:55 |
RealBadAngel |
like? |
15:56 |
est31 |
https://github.com/RealBadAngel/minetestHD/commit/5c6ee4aea1d358fa9d7c76cea9c2b3abc72657d4#diff-18513665750ef5adf42b5ec29e14162eR386 |
15:56 |
est31 |
here |
15:58 |
RealBadAngel |
lemme check something, brb |
15:58 |
RealBadAngel |
need something not symetric |
16:01 |
|
Player_2 joined #minetest-dev |
16:03 |
RealBadAngel |
est31, it works perfectly fine |
16:03 |
|
blaze joined #minetest-dev |
16:05 |
RealBadAngel |
otherwise i couldnt point upside down slab |
16:05 |
RealBadAngel |
node selection boxes are prerotated i think |
16:08 |
RealBadAngel |
est31, http://imgur.com/a/nIRgV |
16:09 |
RealBadAngel |
and that distance is to center of bounding box |
16:10 |
RealBadAngel |
so i cant see anything wrong with the code and how it behaves |
16:12 |
RealBadAngel |
do note that i take care of faces only when im sure which node is actually pointed |
16:12 |
RealBadAngel |
that is needed to get pointed face and determine the node above surface pos |
16:14 |
RealBadAngel |
when you are checking all the nodes in range thats not important, only which bounding box is closest one |
16:15 |
RealBadAngel |
so its position is stored and finally faces checked |
16:27 |
|
ud1_ joined #minetest-dev |
16:42 |
est31 |
RealBadAngel, I agree with the PR #3749 except for the points stated |
16:42 |
ShadowBot |
https://github.com/minetest/minetest/issues/3749 -- Camera: remove auto tune FPS, single view range setting by RealBadAngel |
16:44 |
RealBadAngel |
est31, but its nothing new i think |
16:44 |
RealBadAngel |
15 was minimum before |
16:45 |
RealBadAngel |
at least you wanst able to turn off world at all |
16:45 |
est31 |
regardless it should be documented |
16:45 |
RealBadAngel |
no problemo |
16:48 |
|
nrzkt joined #minetest-dev |
16:51 |
RealBadAngel |
est31, done |
16:51 |
|
misprint joined #minetest-dev |
16:52 |
RealBadAngel |
ah, and the BS thingy |
16:54 |
est31 |
Can you put the "(Min = 20)" to a separate line? |
16:54 |
RealBadAngel |
sure |
16:57 |
RealBadAngel |
done |
16:58 |
est31 |
RealBadAngel, can you rebase the PR? |
16:58 |
est31 |
the commit doesnt apply |
16:59 |
RealBadAngel |
it was rebased recently |
17:00 |
|
STHGOM joined #minetest-dev |
17:00 |
|
hmmmm joined #minetest-dev |
17:00 |
RealBadAngel |
i will have to make another PR then with rebased one |
17:01 |
est31 |
RealBadAngel, you dont need a new PR to rebase |
17:01 |
est31 |
just do "git rebase upstream/master" |
17:01 |
est31 |
it will then rebase |
17:02 |
est31 |
then git push -f |
17:02 |
RealBadAngel |
ok |
17:02 |
RealBadAngel |
realbadangelHaven:~/GIT/minetest_mine$ git rebase upstream/master |
17:02 |
RealBadAngel |
Current branch camera3 is up to date. |
17:03 |
est31 |
do "git remote update" |
17:03 |
est31 |
before that |
17:03 |
est31 |
then rebase again |
17:05 |
RealBadAngel |
try now |
17:09 |
est31 |
sorry still does not work: https://paste.kde.org/p6qbi4z6g |
17:12 |
RealBadAngel |
http://pastebin.com/PqpVxApZ |
17:12 |
RealBadAngel |
est31, applies without any problems |
17:15 |
RealBadAngel |
http://pastebin.com/HY5r6yB0 |
17:15 |
RealBadAngel |
with cherry-pick also no problems |
17:17 |
RealBadAngel |
https://github.com/RealBadAngel/minetestHD/commits/master |
17:17 |
|
paramat left #minetest-dev |
17:23 |
|
ElectronLibre joined #minetest-dev |
17:30 |
|
misprint joined #minetest-dev |
17:33 |
|
Miner_48er joined #minetest-dev |
17:37 |
|
misprint joined #minetest-dev |
17:45 |
|
ud1_ joined #minetest-dev |
17:54 |
|
DevBox joined #minetest-dev |
18:10 |
|
Krock joined #minetest-dev |
18:12 |
|
Miner_48er joined #minetest-dev |
18:23 |
|
Taoki joined #minetest-dev |
18:23 |
|
casimir joined #minetest-dev |
18:25 |
|
Wayward1 joined #minetest-dev |
19:15 |
|
Taoki joined #minetest-dev |
19:17 |
|
Taoki joined #minetest-dev |
19:55 |
|
Taoki joined #minetest-dev |
19:56 |
|
Dragonop joined #minetest-dev |
20:38 |
Obani |
rubenwardy, "The real objects are above, the over use of factories and additional classes." |
20:38 |
Obani |
Isn't it avoidable ? |
20:39 |
rubenwardy |
no idea |
20:40 |
rubenwardy |
I did a bad thing opening that PR, I should have just put a diff on the old one instead |
20:40 |
Obani |
The old one is closed now |
20:57 |
|
DFeniks joined #minetest-dev |
21:02 |
|
est31 joined #minetest-dev |
21:50 |
|
kaeza joined #minetest-dev |
22:00 |
Obani |
https://forum.minetest.net/viewtopic.php?f=3&t=14093 |
22:01 |
|
Etzos joined #minetest-dev |
22:03 |
Obani |
I think it should be time to recruit some devs for MT-project |
22:04 |
Obani |
The modding community is getting larger |
22:04 |
Obani |
And the devs are becoming fewer |
22:05 |
|
kaadmy joined #minetest-dev |
22:06 |
est31 |
sad to hear :( |
22:06 |
kaeza |
adding more devs changes nothing if there's no clearly defined goal |
22:07 |
kaeza |
BlockMen's post asks for a change of attitude from (some) core devs, I believe |
22:07 |
Obani |
Yes |
22:07 |
Obani |
But tons of PRs fixing tons of things are here |
22:08 |
Obani |
And there are only few devs to handle them |
22:08 |
Obani |
Also most of them are forgotten |
22:08 |
Obani |
Devs have their work, they don't want to always look at the work of the others |
22:08 |
Obani |
As in every production activity |
22:09 |
|
Gael-de-Sailly joined #minetest-dev |
22:15 |
kaeza |
meh, it's hard to defend BM's position when he has been guilty of doing the things he complains about |
22:18 |
|
Obani joined #minetest-dev |
22:20 |
|
diemartin joined #minetest-dev |
22:28 |
diemartin |
<est31> Real_Bad_Angel, you dont need a new PR to rebase <-- http://xkcd.com/1597/ </offtopic> |
22:29 |
Obani |
#2375 |
22:29 |
ShadowBot |
https://github.com/minetest/minetest/issues/2375 -- Fix superflous shader setting updates by rubenwardy |
22:29 |
VanessaE |
diemartin: that xkcd is me all over. :) |
22:29 |
diemartin |
heh |
22:31 |
est31 |
hahah |
22:38 |
RealBadAngel |
est31, can see you managed to merge the camera one. have you deleted it and downloaded fresh copy? ;) |
22:39 |
est31 |
it worked with some help |
22:39 |
est31 |
but the am trick didnt |
22:40 |
RealBadAngel |
ah indeed i tried without "am" |
22:43 |
RealBadAngel |
est31, what about the pointed fix? |
22:45 |
est31 |
kaadmy, nolsen sfan5 ShadowNinja these two prs look good for me, can you give them a look too #3713 #3729 |
22:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/3713 -- Resend blocks when modified while sending to client by Jeija |
22:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/3729 -- Add scriptapi interface to HTTPFetchRequest with security by Jeija |
22:47 |
nolsen |
Looks good to me, espesially the 1st one. |
22:52 |
diemartin |
yay. now wiki mod can show Wikipedia articles with 3729? ;) |
22:53 |
est31 |
yeah |
22:56 |
diemartin |
on that topic, would be nice to have a textarea with basic markup (just colors would do for now) |
23:14 |
|
Ardonel joined #minetest-dev |
23:39 |
|
misprint joined #minetest-dev |
23:39 |
|
Taoki_1 joined #minetest-dev |
23:47 |
|
misprint_ joined #minetest-dev |
23:52 |
|
Taoki joined #minetest-dev |
23:55 |
RealBadAngel |
seems like i do have that stuttering now |
23:57 |
kaadmy |
wwhhat? |
23:57 |
Fixer |
._. |
23:57 |
RealBadAngel |
i just build current sources, added game + technic, mesecons, pipeworks, UI |
23:58 |
RealBadAngel |
can see dtime jitter up to 3,5k |
23:59 |
RealBadAngel |
FPS is like halved |
23:59 |
Fixer |
fps is jittery? |
23:59 |
kaadmy |
huh |
23:59 |
RealBadAngel |
actually its more like 1/3rd |
23:59 |
kaadmy |
nolsen just pointed out the license is 2010-2012 https://github.com/minetest/minetest/blob/master/README.txt#L365 |