Time |
Nick |
Message |
02:09 |
|
VanessaE joined #minetest-dev |
02:15 |
|
VanessaE joined #minetest-dev |
02:34 |
|
Icedream- joined #minetest-dev |
02:44 |
VanessaE |
I seem to have found a bug in list rings |
02:45 |
VanessaE |
take a look at the last two commits here: https://github.com/minetest-technic/unified_inventory/commits/master |
02:45 |
VanessaE |
shift-click is moving items to the crafting grid, even if the bags formspec is what's visible. shouldn't it only ever move stuff around in visible lists? |
02:48 |
VanessaE |
or it'll move to a bag's list when crafting is visible. I guess whatever's made visible first is what gets priority, regardless of what's currently on-screen? |
02:49 |
VanessaE |
seems it doesn't handle properly when a formspec is replaced by another formspec (instead of being closed) |
03:54 |
|
Miner_48er joined #minetest-dev |
06:05 |
hmmmm |
okay, I really don't like SN's thread "refactor" now |
06:05 |
hmmmm |
a lot of things were needed like the atomic intrinsics and unification, but there's a lot of really bad stuff here... mostly the way the code is structured |
06:06 |
hmmmm |
why are there so many preprocessor conditional clauses? why do certain variables exist only on certain platforms? |
06:06 |
hmmmm |
this code is extremely confusing and inflexible |
06:14 |
|
OldCoder joined #minetest-dev |
06:21 |
hmmmm |
like what is the point of getThreadHandle()? nothing outside of the class definition ever uses it |
06:23 |
hmmmm |
getReturnValue() doesn't give any distinction between a finished thread returning NULL and a failed request because the thread is still running |
07:28 |
|
VirusJones joined #minetest-dev |
07:58 |
|
nrzkt joined #minetest-dev |
08:11 |
|
Krock joined #minetest-dev |
08:16 |
|
jin_xi joined #minetest-dev |
08:26 |
|
Hunterz joined #minetest-dev |
09:20 |
|
Megaf_ joined #minetest-dev |
09:37 |
|
Darcidride joined #minetest-dev |
09:38 |
|
Darcidride joined #minetest-dev |
10:10 |
|
Amaz joined #minetest-dev |
10:21 |
|
CraigyDavi joined #minetest-dev |
10:23 |
|
Calinou joined #minetest-dev |
10:26 |
|
rubenwardy joined #minetest-dev |
10:30 |
|
Krock joined #minetest-dev |
10:31 |
|
Gael-de-Sailly joined #minetest-dev |
10:54 |
|
nerzhul_ joined #minetest-dev |
11:19 |
|
ElectronLibre joined #minetest-dev |
11:20 |
|
Amaz joined #minetest-dev |
12:10 |
|
Calinou joined #minetest-dev |
12:17 |
|
FR^2 joined #minetest-dev |
12:25 |
|
T4im joined #minetest-dev |
12:42 |
|
kaeza joined #minetest-dev |
13:03 |
|
paramat joined #minetest-dev |
13:06 |
paramat |
i'd like to merge these 2 later: game#698 i improved the bevel shading hope it's okay. game#700 more biomes tweaks |
13:07 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/698 -- New header image 'Minetest Game' by paramat |
13:07 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/700 -- Default/mapgen: Remove dunes biome. Sand for glacier seabed by paramat |
13:07 |
|
paramat left #minetest-dev |
13:08 |
|
32NAAI7K2 joined #minetest-dev |
13:08 |
|
Player_2 joined #minetest-dev |
13:11 |
Krock |
I really liked the old logo |
14:04 |
|
diemartin joined #minetest-dev |
14:06 |
|
est31 joined #minetest-dev |
14:07 |
est31 |
hmmmm, about what you complained about with formspecs, I don't think that's bad. Just not show it in the dropdown for worlds where the "experimental" mapgen isn't selected, and show it in the dropdown where "experimental" mapgen is selected. |
14:08 |
est31 |
And I dont really see a beauty in what you wanted: what if the user accidentially opened the dropdown, and doesn't know it can be closed with the button? |
14:08 |
est31 |
they have to select another mapgen now |
14:13 |
Taoki |
~seen RealBadAngel |
14:13 |
ShadowBot |
Taoki: I saw RealBadAngel in #minetest-dev 1 week, 0 days, 15 hours, 34 minutes, and 35 seconds ago saying "yeah, it wasnt documented at all, so its ok" |
14:55 |
|
Darcidride joined #minetest-dev |
14:56 |
|
blaaaaargh joined #minetest-dev |
15:08 |
|
paramat joined #minetest-dev |
15:11 |
est31 |
pushing in 20 minutes: https://github.com/est31/minetest/commit/41d896d5c248be18f87776433f126c43d7dbca9b |
15:11 |
paramat |
Krock the old MT header will still show in all the other menu pages |
15:12 |
Krock |
\o/ |
15:18 |
paramat |
est31 +1 on that if it works |
15:21 |
est31 |
I've tested, it does |
15:21 |
est31 |
pushing now |
15:26 |
paramat |
now merging game 698 and game 700 |
15:32 |
paramat |
done |
16:03 |
|
gravgun joined #minetest-dev |
16:11 |
|
paramat left #minetest-dev |
16:16 |
|
rubenwardy joined #minetest-dev |
16:18 |
|
zat joined #minetest-dev |
16:29 |
|
zat joined #minetest-dev |
16:58 |
|
Gael-de-Sailly joined #minetest-dev |
17:02 |
|
hmmmm joined #minetest-dev |
17:08 |
|
Miner_48er joined #minetest-dev |
17:27 |
|
Amaz joined #minetest-dev |
18:49 |
nanepiwo |
can craftitems have groups? |
18:49 |
Calinou |
yes |
18:49 |
Calinou |
look at sticks |
18:56 |
|
proller joined #minetest-dev |
19:07 |
|
H-H-H joined #minetest-dev |
19:30 |
|
paramat joined #minetest-dev |
19:32 |
|
gravgun joined #minetest-dev |
19:33 |
paramat |
it's a relief to discover the fractal mapgen bug was my coding error, half the parameters (the ones taking on weird values) were missing from here https://github.com/minetest/minetest/blob/master/src/mapgen_fractal.cpp#L66 hmmmm |
19:34 |
paramat |
*=P |
19:35 |
Krock |
Somehow I always got flat area with the fractal mapgen |
19:36 |
Krock |
(nearly flat= |
19:39 |
paramat |
sometimes it was missing due to the bug, also the julia set is 700 nodes east |
19:39 |
paramat |
so you got seabed only |
19:40 |
|
zat joined #minetest-dev |
19:41 |
paramat |
i'll prepare the fix |
19:41 |
hmmmm |
huh? |
19:41 |
hmmmm |
paramat: what was the error? |
19:42 |
hmmmm |
ohh, you weren't using sp->julua_x.. etc |
19:42 |
hmmmm |
or you didn't copy them over to your mapgen member variables |
19:42 |
hmmmm |
heh subtle |
19:43 |
hmmmm |
i was expecting it to be an issue with mapgen params pointer invalidation or something along those lines |
19:43 |
hmmmm |
maybe that's why my julia maps were always flat |
19:44 |
paramat |
yeah |
19:45 |
hmmmm |
not completely flat, but very boring |
20:07 |
paramat |
#3241 |
20:07 |
ShadowBot |
https://github.com/minetest/minetest/issues/3241 -- Fractal mapgen: Fix mysterious bug by paramat |
20:07 |
hmmmm |
if you've really fixed it, how is it mysterious? |
20:08 |
hmmmm |
you should name it something like... "Mapgen fractal: Fix uninitialized parameter values" |
20:08 |
paramat |
huhuh |
20:08 |
hmmmm |
(fixes #issuehere) |
20:13 |
paramat |
now the julia mode has become more interesting, and can do that crazy ribbon terrain seen in FM and requested for MT |
20:15 |
|
DFeniks joined #minetest-dev |
20:18 |
Krock |
\o/ |
20:18 |
Krock |
how about the mandelbrot? |
20:19 |
paramat |
it will be the same as before but the slice param will now work |
20:21 |
Krock |
fine :) |
20:25 |
paramat |
now merging |
20:25 |
|
kaeza joined #minetest-dev |
20:26 |
hmmmm |
erm by the way paramat, the way i designed the MapgenParams, you don't actually need to copy params to your mapgen structure |
20:27 |
hmmmm |
it's guaranteed to be a valid pointer for the lifetime of the mapgen object |
20:29 |
paramat |
done |
20:30 |
paramat |
what chunks of code can be left out? |
20:34 |
paramat |
Krock the julia set has moved, don't know where it is now, but should be within 1000 nodes of spawn. the new parameters may possibly make it non-existant, if so it's not a bug this time |
20:35 |
Krock |
Okay, thanks for the information, paramat :) |
20:35 |
|
Icedream joined #minetest-dev |
20:38 |
paramat |
hmmmmm never mind, chat about it another time i'm too super-tired |
20:42 |
|
Brains___ joined #minetest-dev |
20:42 |
|
paramat_the_seco joined #minetest-dev |
20:42 |
|
Megaf joined #minetest-dev |
20:43 |
|
H-H-H_ joined #minetest-dev |
20:44 |
|
misprint_ joined #minetest-dev |
20:44 |
paramat_the_seco |
ah i seem to be 'paramat the second' now |
20:44 |
|
paramat_the_seco left #minetest-dev |
20:45 |
|
gravgun_ joined #minetest-dev |
20:50 |
|
paramat_the_2nd joined #minetest-dev |
20:51 |
|
Icedream joined #minetest-dev |
20:52 |
paramat_the_2nd |
julia set is now at 800, 500 |
20:53 |
|
Xenoth joined #minetest-dev |
21:32 |
|
Darcidride joined #minetest-dev |
21:32 |
|
Teckla joined #minetest-dev |
21:35 |
|
JohannesG_ joined #minetest-dev |
21:36 |
|
VanessaE_ joined #minetest-dev |
21:37 |
|
leat joined #minetest-dev |
22:07 |
|
rubenwardy joined #minetest-dev |
22:13 |
|
CraigyDavi joined #minetest-dev |
22:34 |
|
diemartin joined #minetest-dev |
22:39 |
|
Teckla left #minetest-dev |
23:01 |
|
OldCoder joined #minetest-dev |
23:49 |
|
proller joined #minetest-dev |