Time |
Nick |
Message |
00:37 |
|
kaeza joined #minetest-dev |
01:10 |
|
Robby joined #minetest-dev |
03:10 |
|
rambomedic joined #minetest-dev |
03:10 |
|
smoke_fumus joined #minetest-dev |
03:12 |
|
OldCoder joined #minetest-dev |
03:18 |
|
Megaf joined #minetest-dev |
03:36 |
|
Exio4 joined #minetest-dev |
03:58 |
ShadowNinja |
!tell sapier "Fix typo" commits are fine. Or you can rewrite the commit with 'git rebase' since it's only a PR. |
03:58 |
ShadowBot |
ShadowNinja: O.K. |
04:02 |
ShadowNinja |
!tell Calinou It's in game.cpp, and it's called guitext_info IIRC. |
04:02 |
ShadowBot |
ShadowNinja: O.K. |
05:15 |
|
darkrose joined #minetest-dev |
05:40 |
|
nore joined #minetest-dev |
05:54 |
|
Exio4 joined #minetest-dev |
08:17 |
|
jin_xi joined #minetest-dev |
08:32 |
|
Fresh_me_ joined #minetest-dev |
09:17 |
|
proller joined #minetest-dev |
09:25 |
|
troller joined #minetest-dev |
09:35 |
|
TenPlus1 joined #minetest-dev |
09:41 |
|
Weedy joined #minetest-dev |
09:41 |
|
Weedy joined #minetest-dev |
09:46 |
|
diemartin joined #minetest-dev |
09:57 |
|
khonkhortisan joined #minetest-dev |
09:57 |
|
deltib joined #minetest-dev |
09:58 |
celeron55 |
12:52:31 <TenPlus1> thx :) when generating a new chunk, does the decoration |
09:58 |
celeron55 |
occur straight after that and then the ridges get cut |
09:58 |
celeron55 |
out ?? |
09:58 |
celeron55 |
12:55:41 <celeron55> what is a ridge? |
09:58 |
celeron55 |
12:56:22 <TenPlus1> in v7 mapgen it cuts sections out of the map on |
09:58 |
celeron55 |
generation, ridges are enabled by default and cannot be |
09:58 |
celeron55 |
turned off |
09:58 |
celeron55 |
12:56:40 <TenPlus1> mgv7_spflags = mountains, ridges |
09:58 |
celeron55 |
12:56:53 <TenPlus1> mgv7_np_ridge = 0, 1, (100, 100, 100), 6467, 4, 0.75 |
09:58 |
celeron55 |
12:58:21 <TenPlus1> was hoping if you knew a way to disable them, or make it |
09:58 |
celeron55 |
so that decoration (trees/plants/grass) can be placed |
09:58 |
celeron55 |
AFTER the ridges are cut out..... they seem to cause a |
09:58 |
celeron55 |
LOT of floating plants and grass on the map otherwise |
09:58 |
celeron55 |
12:59:56 <celeron55> it looks like the order is base terrain, mountains, |
09:58 |
celeron55 |
ridges, biomes, caves, dungeons, decorations, ores |
09:58 |
celeron55 |
12:59:56 <celeron55> https://github.com/minetest/minetest/blob/master/src/mapgen_v7.cpp#L225 |
09:58 |
celeron55 |
13:00:45 <TenPlus1> I wonder what's causing the floating grass and |
09:58 |
celeron55 |
decoration ??? |
09:59 |
TenPlus1 |
thx |
09:59 |
celeron55 |
https://github.com/minetest/minetest/blob/master/src/mapgen.cpp#L259 |
09:59 |
celeron55 |
it looks like it's using a heightmap for placing them |
10:00 |
TenPlus1 |
The way it generates at the moment it LOOKS as if the map is done first, decotation and then it cuts RIDGES out of the map and leaves all sorts floating in mid air |
10:00 |
celeron55 |
and the heightmap seems to be generated after all the terrain shape |
10:00 |
celeron55 |
so it should work |
10:02 |
TenPlus1 |
it's the same with every v7 map I've seen... always something cut out and floating... and there's no way to disable ridges to test otherwise |
10:03 |
celeron55 |
you need to ask this from hmmmm/kwolekr but he's not here atm |
10:03 |
celeron55 |
so maybe add an issue on github |
10:03 |
TenPlus1 |
will have to look into that, not so clear on github am afraid... |
10:03 |
TenPlus1 |
but thanks for your help :) |
10:04 |
celeron55 |
screenshots would be useful |
10:04 |
TenPlus1 |
also, it would be a good idea for a command to regenerate a chunk |
10:05 |
TenPlus1 |
I have a screenshot I posted in the forum, lemmie find it |
10:07 |
TenPlus1 |
here it is: https://forum.minetest.net/viewtopic.php?f=6&t=9048 |
10:26 |
|
Weedy joined #minetest-dev |
10:26 |
|
Weedy joined #minetest-dev |
10:28 |
|
SmugLeaf joined #minetest-dev |
10:30 |
|
Ritchie joined #minetest-dev |
10:32 |
TenPlus1 |
celeron55: I've posted an issue on github regarding the floating decor... thx again dude |
10:34 |
|
ImQ009 joined #minetest-dev |
10:36 |
|
Exio4 joined #minetest-dev |
10:49 |
|
PenguinDad joined #minetest-dev |
10:53 |
celeron55 |
oh that's a cave |
10:53 |
|
crazyR_ joined #minetest-dev |
10:54 |
celeron55 |
but that doesn't help much; i'll just leave this to hmmmm |
11:01 |
|
crazyR joined #minetest-dev |
11:38 |
|
PenguinDad joined #minetest-dev |
11:49 |
|
werwerwer joined #minetest-dev |
12:04 |
|
grrk-bzzt joined #minetest-dev |
12:16 |
|
Fresh_m__ joined #minetest-dev |
12:22 |
|
jin_xi joined #minetest-dev |
12:57 |
Taoki |
https://github.com/minetest/minetest/issues/1275 Someone please take a look at this soon. Pretty urgent problem I'd say... a Lua function often crashes the engine (makes one of my mods unplayable too) |
13:03 |
celeron55 |
i fixed something like that a week ago https://github.com/minetest/minetest/commit/8d315347100f1d261bb496b6c73f8cab5d2b7a41 |
13:13 |
|
hmmmm joined #minetest-dev |
13:37 |
|
Zeitgeist_ joined #minetest-dev |
13:37 |
|
Zeitgeist_ joined #minetest-dev |
13:49 |
|
BrandonReese joined #minetest-dev |
14:03 |
|
CraigyDavi_ joined #minetest-dev |
14:04 |
|
grrk-bzzt joined #minetest-dev |
14:06 |
|
PenguinDad joined #minetest-dev |
14:06 |
|
Sokomine joined #minetest-dev |
14:17 |
|
CraigyDavi_ joined #minetest-dev |
14:31 |
|
ImQ009_ joined #minetest-dev |
14:35 |
|
ImQ009 joined #minetest-dev |
14:42 |
|
grrk-bzzt joined #minetest-dev |
14:46 |
|
PenguinDad joined #minetest-dev |
14:48 |
|
mrtux joined #minetest-dev |
14:58 |
|
CraigyDavi_ joined #minetest-dev |
15:27 |
|
whiskers75 joined #minetest-dev |
15:28 |
|
whiskers75 joined #minetest-dev |
15:34 |
|
rubenwardy joined #minetest-dev |
15:38 |
|
BlockMen joined #minetest-dev |
15:39 |
BlockMen |
concerning #1265 |
15:39 |
BlockMen |
https://github.com/minetest/minetest/pull/1265#issuecomment-42318782 |
15:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/1265 -- Fix heart + bubble bar size on different texture packs by sapier |
15:40 |
BlockMen |
i think there are good reasons to include the default statbars to the game instead of builtin ^ |
15:45 |
|
NakedFury joined #minetest-dev |
15:54 |
|
PilzAdam joined #minetest-dev |
15:58 |
|
sapier joined #minetest-dev |
15:58 |
|
zat joined #minetest-dev |
15:59 |
sapier |
ShadowNinja: for what I remember rebasing a commit in the middle is always quite messy ... yes I assume git can do ... as everything is possible with git someway |
16:06 |
|
Calinou joined #minetest-dev |
16:20 |
|
PenguinDad joined #minetest-dev |
16:30 |
Calinou |
when you are unattached from entity, you get 3 second invicibility from fall damage |
16:31 |
Calinou |
that's too easy |
16:44 |
|
Jordach joined #minetest-dev |
16:52 |
|
rubenwardy joined #minetest-dev |
17:02 |
|
proller joined #minetest-dev |
17:14 |
|
ImQ009 joined #minetest-dev |
17:14 |
|
proller joined #minetest-dev |
17:17 |
BlockMen |
some/any opinions on what i said about #1265?? |
17:17 |
ShadowBot |
https://github.com/minetest/minetest/issues/1265 -- Fix heart + bubble bar size on different texture packs by sapier |
17:28 |
|
iqualfragile joined #minetest-dev |
17:30 |
|
proller joined #minetest-dev |
17:47 |
|
Jordach joined #minetest-dev |
18:17 |
|
rubenwardy joined #minetest-dev |
18:54 |
|
werwerwer_ joined #minetest-dev |
19:07 |
|
tomreyn joined #minetest-dev |
19:33 |
|
Megaf_ joined #minetest-dev |
19:33 |
Megaf_ |
Hi |
19:33 |
|
RealBadAngel joined #minetest-dev |
19:45 |
|
EvergreenTree joined #minetest-dev |
19:50 |
|
grrk-bzzt joined #minetest-dev |
19:52 |
|
tomasbrod joined #minetest-dev |
20:36 |
|
whiskers75 joined #minetest-dev |
20:51 |
CiaranG |
Not wasting my time with branching/rebasing just to add to the pull request mountain for minetest_game, but that there is just a bug (which happens all the time) - cherry pick if you like: https://github.com/CiaranG/minetest_game/commit/c691cbdeeaea4649d92dd8604ad1e9b91767c582 |
20:52 |
sapier |
CiaranG: how can there be bones without owner? |
20:53 |
CiaranG |
Because the owner gets set to "" when all the items are removed |
20:53 |
CiaranG |
And then, it tries to set it *again* to "" when the timer runs out (but first uses the blanked name to rewrite the info text) |
20:53 |
CiaranG |
So you get 's old bones |
20:53 |
CiaranG |
Almost always |
20:54 |
sapier |
I guess there ain't a way to stop the timer once it's emtied? |
20:54 |
ShadowNinja |
sapier: It isn't as easy as editing the HEAD commit, but it 'sn't terribly hard. Just run `git rebase -i HEAD~3` or so, change "pick" to "edit" in front of the commit, save, edit the files you want, run `git commit --amend` and run `git rebase --continue`. |
20:54 |
ShadowNinja |
isn't* |
20:55 |
sapier |
all of this work for a single typo? forget about it I'm gonna do a separate commit |
20:55 |
ShadowNinja |
Run `git add` or use the -a flag to `git commit` too of course. |
20:55 |
CiaranG |
sapier: Not that I can see |
20:57 |
CiaranG |
Well, actually, return true when owner == "" would be better |
20:57 |
sapier |
hmm missing feature ... but I yesterday complained about ppl requesting excessive bugfixing for a small bugfix so I wont do same thing ;-) |
20:57 |
CiaranG |
Actually, no, it's right already |
20:57 |
CiaranG |
It does stop the timer |
20:58 |
CiaranG |
Why on earth does it set the timer every 10 seconds anyway, instead of just setting it to 1200 (or whatever the config setting may be) |
20:59 |
sapier |
no idea I never did do any code around bones |
21:00 |
CiaranG |
Seems to be very silly to me. But anyway, that simple change fixes the bug. I'm not going to look in that file again unless something else is broken. |
21:03 |
sapier |
well if you feel it to be a bug please check if your feeling is right |
21:05 |
|
tomasbrod left #minetest-dev |
21:06 |
CiaranG |
The 10 second timer isn't a bug, it's just a waste of server resources, calling the timer handler 120 times (by default) instead of once. But it's probably insignificant. |
21:07 |
sapier |
wasting time for no reason is a bug as of my definition ... not a severe one of course |
21:08 |
|
proller joined #minetest-dev |
21:10 |
|
zat joined #minetest-dev |
21:23 |
|
SoniEx2 joined #minetest-dev |
21:25 |
SoniEx2 |
ugh this is for core dev stuff :/ |
21:25 |
|
SoniEx2 left #minetest-dev |
21:47 |
|
blaaaaargh joined #minetest-dev |
21:51 |
|
sapier left #minetest-dev |
22:22 |
|
cg72 joined #minetest-dev |
22:30 |
|
OnceOver joined #minetest-dev |
22:32 |
|
stormchaser3000 joined #minetest-dev |