| Time |
Nick |
Message |
| 00:10 |
|
Jordach joined #minetest-dev |
| 00:50 |
|
BlockMen left #minetest-dev |
| 01:17 |
|
BrandonReese joined #minetest-dev |
| 01:25 |
|
Taoki joined #minetest-dev |
| 01:38 |
Taoki |
https://forum.minetest.net/viewtopic.php?f=9&t=9240&p=140557#p140551 Seems like a mod of mine found a bug in the engine. Apparently it crashes MT, but no specific Lua function is indicated to be at fault. |
| 01:38 |
Taoki |
IIRC that likely means an engine bug |
| 01:42 |
ShadowNinja |
Taoki: Looks like inv:get_stack("foo", 12345678 --[[Index too big]] ) |
| 01:43 |
Taoki |
I don't use that function in my mod even... strange |
| 01:43 |
ShadowNinja |
A LuaError should be thrown instead though. |
| 01:48 |
ShadowNinja |
That isn't it. It's checked. |
| 01:48 |
Taoki |
Anyway, time to head off now. Maybe someone else can look at what's happening more in depth. |
| 01:48 |
Taoki |
As far as I'm aware though, if the engine crashes (doesn't exit with a Lua error) and a Lua function at fault isn't indicated, there's a problem in the engine |
| 01:49 |
Taoki |
So I guess something in my mod uncovered a new bug |
| 01:49 |
Taoki |
Especially since I don't get that crash myself. I do get a similar one occasionally, but assumed that might already be there (it's at a different time and with a different trigger though)_ |
| 01:49 |
ShadowNinja |
Yes, not showing a error would be a bug, even if your mod caused the error. |
| 01:49 |
Taoki |
But heading off now, night. Hope someone can fully figure it out |
| 02:44 |
|
rambomedic joined #minetest-dev |
| 03:33 |
|
Robby joined #minetest-dev |
| 03:36 |
|
smoke_fumus joined #minetest-dev |
| 03:40 |
|
Eater4 joined #minetest-dev |
| 03:47 |
|
us`0gb joined #minetest-dev |
| 03:47 |
|
Exio4 joined #minetest-dev |
| 03:58 |
|
OldCoder joined #minetest-dev |
| 04:01 |
|
Exio4 joined #minetest-dev |
| 04:08 |
|
Eater4 joined #minetest-dev |
| 04:20 |
|
daswort joined #minetest-dev |
| 04:44 |
|
kaeza joined #minetest-dev |
| 05:00 |
|
Exio4 joined #minetest-dev |
| 05:19 |
|
jin_xi joined #minetest-dev |
| 05:39 |
|
kahrl joined #minetest-dev |
| 05:46 |
RealBadAngel |
https://github.com/minetest/minetest/pull/1271 |
| 05:47 |
RealBadAngel |
going to merge it, any objections? |
| 05:48 |
VanessaE |
um |
| 05:48 |
VanessaE |
you're messing about with hud.cpp |
| 05:48 |
VanessaE |
this will probably break sapier's patch :P |
| 05:49 |
RealBadAngel |
easy enough to rebase |
| 05:50 |
RealBadAngel |
those changes are one liners in each file i touched |
| 05:51 |
RealBadAngel |
anyway he is waiting for my fix |
| 05:51 |
RealBadAngel |
i was supposed to push that yesterday |
| 05:54 |
VanessaE |
I guess if it works, go for it |
| 05:54 |
RealBadAngel |
going shopping now, will do that when back |
| 05:55 |
VanessaE |
pick me up some chocolate :) |
| 06:21 |
|
nore joined #minetest-dev |
| 06:31 |
RealBadAngel |
hi nore |
| 06:31 |
RealBadAngel |
fixed the issue with waypoints, #1271 |
| 06:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/1271 -- Bugfix: make waypoints respect camera offset by RealBadAngel |
| 06:32 |
RealBadAngel |
VanessaE, it was too late, i can give you a cookie instead ;) |
| 06:33 |
VanessaE |
heh |
| 06:33 |
RealBadAngel |
nore, are you ok with it? |
| 06:44 |
RealBadAngel |
hmm, what are those gnome_keyring errors on git? |
| 06:58 |
|
darkrose joined #minetest-dev |
| 07:04 |
|
RealBadAngel joined #minetest-dev |
| 07:05 |
RealBadAngel |
seems to be ubuntu issue, so nvm |
| 07:05 |
RealBadAngel |
pushing now 1271 |
| 07:08 |
RealBadAngel |
there was an issue opened about it, but i cant find it now, wtf? |
| 07:11 |
RealBadAngel |
found the issue and closed it |
| 07:12 |
RealBadAngel |
it was https://github.com/minetest/minetest/issues/1248 |
| 09:13 |
|
darkrose joined #minetest-dev |
| 09:56 |
|
crazyR joined #minetest-dev |
| 09:57 |
|
proller joined #minetest-dev |
| 10:27 |
|
ImQ009 joined #minetest-dev |
| 10:42 |
RealBadAngel |
ive made #1272 on VanessaE's request |
| 10:42 |
ShadowBot |
https://github.com/minetest/minetest/issues/1272 -- Move message about missing normal maps to infostream instead of errorstr... by RealBadAngel |
| 11:24 |
|
Jordach joined #minetest-dev |
| 12:46 |
|
restcoser joined #minetest-dev |
| 12:58 |
|
hmmmm joined #minetest-dev |
| 13:09 |
|
hmmmm joined #minetest-dev |
| 13:23 |
|
Megaf joined #minetest-dev |
| 13:23 |
Taoki |
If any devs are around at this hour: I discovered with one of my mods that player:hud_set_hotbar_itemcount() is currently broken, and using it often crashes the engine. Typically after changing inventory size... even if setting equal or less items in the hotbar to the inv size |
| 13:25 |
Taoki |
Someone please try something like the following, which should typically cause a crash: player:get_inventory():inv:set_size("main", 6) | player:hud_set_hotbar_itemcount(6) |
| 13:25 |
Taoki |
Sorry, |
| 13:25 |
Taoki |
player:get_inventory():set_size("main", 6) | player:hud_set_hotbar_itemcount(6) |
| 13:25 |
* Megaf |
looks at RealBadAngel sfan5 and ShadowNinja |
| 13:26 |
Megaf |
Morning everyone |
| 13:26 |
Megaf |
or Afternoon |
| 13:26 |
Taoki |
Funny thing is, PA's Nodetopia seems to change inventory size as well as hotbar size, but there are no crashes there |
| 13:26 |
Taoki |
Hi |
| 13:26 |
Megaf |
Taoki: Is Nodetopia running same version? |
| 13:27 |
Taoki |
Megaf: Tried it on GIT which is always what I run. No crash there |
| 13:27 |
Taoki |
Although in its case, inventory and hotbar are only set once when the player joins. Perhaps the engine has a problem with them being changed every now and then? |
| 13:29 |
Megaf |
Well, I actually have no idea about your issue |
| 13:36 |
|
iqualfragile joined #minetest-dev |
| 13:52 |
|
PilzAdam joined #minetest-dev |
| 13:54 |
Megaf |
What's wrong with my comment/issue? #1273 |
| 13:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/1273 -- "debug_log_level" in minetest.conf does not work. |
| 13:55 |
PilzAdam |
Megaf, fixed |
| 13:56 |
Megaf |
PilzAdam: How? Why? |
| 13:56 |
PilzAdam |
github uses a special markdown to format the comments |
| 13:57 |
PilzAdam |
I added ``` around the code to mark it as code block |
| 13:57 |
Megaf |
I see |
| 13:59 |
Megaf |
Thanks PilzAdam |
| 14:01 |
|
jin_xi joined #minetest-dev |
| 14:03 |
|
BrandonReese joined #minetest-dev |
| 14:11 |
sfan5 |
Megaf: hm? |
| 14:12 |
|
NakedFury joined #minetest-dev |
| 14:20 |
|
PenguinDad joined #minetest-dev |
| 14:50 |
|
Taoki joined #minetest-dev |
| 15:09 |
|
proller joined #minetest-dev |
| 15:30 |
|
sapier joined #minetest-dev |
| 15:47 |
|
troller joined #minetest-dev |
| 16:07 |
|
Zeitgeist_ joined #minetest-dev |
| 16:07 |
|
Zeitgeist_ joined #minetest-dev |
| 16:08 |
RealBadAngel |
any comments on #1272 ? |
| 16:08 |
ShadowBot |
RealBadAngel: Error: Delemiter not found. |
| 16:09 |
sapier |
hehe this time it's you ;-) |
| 16:09 |
RealBadAngel |
? |
| 16:09 |
sapier |
that's the infostream change true? |
| 16:09 |
RealBadAngel |
https://github.com/minetest/minetest/issues/1272 |
| 16:09 |
sapier |
the delimiter not found issue |
| 16:09 |
RealBadAngel |
yes |
| 16:10 |
sapier |
I'm not quite sure about spaces around << ... but to be honest I don't really care about them ;-) |
| 16:11 |
sapier |
but you should fix the inconsistent bracket style for if, do it for the if one line above your changes too |
| 16:17 |
RealBadAngel |
now better? |
| 16:20 |
|
crazyR joined #minetest-dev |
| 16:21 |
|
Eater4 joined #minetest-dev |
| 16:22 |
|
MichaelRpdx joined #minetest-dev |
| 16:24 |
|
Anchakor_ joined #minetest-dev |
| 16:25 |
RealBadAngel |
Megaf, seting another log level is working for me without any problems |
| 16:29 |
|
Calinou joined #minetest-dev |
| 16:33 |
|
Shardvexz joined #minetest-dev |
| 16:36 |
RealBadAngel |
Megaf, propably you got it wrong. it defines what will be written to debug file on hdd. in console you will still see usual messages like player actions etc. |
| 16:41 |
|
Anchakor_ joined #minetest-dev |
| 16:51 |
|
troller joined #minetest-dev |
| 16:52 |
sapier |
no :-( sorry guess I should've been more precise ;-) |
| 17:01 |
RealBadAngel |
sapier, what do you mean? |
| 17:02 |
sapier |
for what I remember style requested by our styleguide is "if () {" or even "if ()<newline>{" |
| 17:04 |
RealBadAngel |
ah ok |
| 17:04 |
RealBadAngel |
code around uses both styles... |
| 17:05 |
RealBadAngel |
i mean with and without newline |
| 17:07 |
sapier |
yes I'm not sure about that one maybe it's not exactly defined too |
| 17:07 |
sapier |
but I'm sure about the space ;-) |
| 17:08 |
RealBadAngel |
yeah, ive added them |
| 17:16 |
sapier |
seems to be fine push it |
| 17:16 |
RealBadAngel |
ok |
| 17:22 |
|
Megaf joined #minetest-dev |
| 17:25 |
|
CraigyDavi joined #minetest-dev |
| 17:27 |
RealBadAngel |
sapier, what do you think about #1273 ? |
| 17:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/1273 -- "debug_log_level" in minetest.conf does not work. |
| 17:29 |
sapier |
I don't know I didn't change anything log level related I jus used it |
| 17:29 |
RealBadAngel |
i think thats no issue at all |
| 17:30 |
RealBadAngel |
logging to disk and info shown in console are two different things |
| 17:32 |
sapier |
hmm you're right about that |
| 17:36 |
|
Guest99103 joined #minetest-dev |
| 17:36 |
Megaf |
13:36 <+RealBadAngel> Megaf, propably you got it wrong. it defines what will be written to debug file on hdd. in console you will still see usual messages |
| 17:36 |
Megaf |
I see |
| 17:36 |
Megaf |
I'd like an option to actually change what it prints to console |
| 17:37 |
sapier |
that'd be something like "console_log_level" |
| 17:37 |
whiskers75 |
sapier, do you have another MT for android build? |
| 17:37 |
sapier |
already published yesterday ;-) |
| 17:38 |
whiskers75 |
email pls |
| 17:38 |
sapier |
see minetest log |
| 17:38 |
sapier |
sorry I wont start mailing updates |
| 17:40 |
RealBadAngel |
so, im closing 1273 |
| 17:40 |
Megaf |
RealBadAngel: wait |
| 17:40 |
RealBadAngel |
yes? |
| 17:41 |
Megaf |
does it actually changes the info writen to debug.txt? |
| 17:42 |
RealBadAngel |
yes it does, my latest patch was about that for example |
| 17:43 |
RealBadAngel |
and messages about missing normal maps are recorded with log level >= 3 |
| 17:43 |
Megaf |
I see |
| 17:43 |
Megaf |
so my issue is not an issue |
| 17:44 |
Megaf |
RealBadAngel: Issue closed |
| 17:44 |
Megaf |
https://github.com/minetest/minetest/issues/1273#issuecomment-42215424 |
| 17:44 |
sapier |
can someone check #1269? |
| 17:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/1269 -- Scene draw cleanup + add various 3d modes by sapier |
| 17:45 |
sapier |
I just added the missing two 3d modes too, now minetest is capable of running all (current) known 3d formats ... but I don't have a device to test the two of them |
| 17:47 |
RealBadAngel |
https://github.com/sapier/minetest/commit/14d663af78e3cd4af5601822bb8174263e9bca6c#diff-722710b5ecd9db42e7dd785dd517e186R994 |
| 17:47 |
RealBadAngel |
typo |
| 17:47 |
sapier |
where? |
| 17:47 |
Megaf |
sapier: I have a TV capable of that, but not the glasses |
| 17:48 |
sapier |
sorry to me those long links are useless I don't see where they are pointing at |
| 17:49 |
VanessaE |
sapier: "handel" --> "handle" |
| 17:49 |
VanessaE |
line 994 |
| 17:49 |
sapier |
argh ... thats first commit ... |
| 17:49 |
VanessaE |
unless you mean to reference the musician of olde |
| 17:49 |
VanessaE |
:) |
| 17:50 |
sapier |
hmmm I claim this to be prior art |
| 17:51 |
sapier |
I don't wanna create a new pull request for a typo not even being my typo |
| 17:51 |
VanessaE |
just fix the typo in this pull then |
| 17:52 |
VanessaE |
no one's gonna bitch about it, especially if it's in a comment anyway |
| 17:52 |
sapier |
I can't because it'd belong to first commit unless you want a third commit message "Fix typo" |
| 17:53 |
VanessaE |
heh |
| 17:53 |
VanessaE |
well nothing wrong with that :) |
| 17:53 |
sapier |
come on that typo was in there before it wont harm anyone if it's still there |
| 17:54 |
sapier |
you could've told Blockmen when he added it ;-P |
| 17:54 |
VanessaE |
but..but...the ghost of Handel might come back to haunt Minetest... or something :P |
| 17:54 |
sapier |
well minetest would benefit from some spooky storys |
| 17:54 |
VanessaE |
lol |
| 17:55 |
VanessaE |
getting back to the topic I can't actually say anything about that code, I have no 3d-capable hardware here |
| 17:56 |
sapier |
well there's still one thing you can tell ... it doesn't break normal mode ;-) |
| 17:56 |
sapier |
btw I was right about the hud thingy ... even current mode wont be enough for android port |
| 18:04 |
|
Zeitgeist_ joined #minetest-dev |
| 18:04 |
|
Zeitgeist_ joined #minetest-dev |
| 18:04 |
Megaf |
sapier: just wait a bit for more changes and then create a request |
| 18:05 |
Megaf |
sapier: I good change would be an option in minetest.conf to change the amount of console output to match debug.txt |
| 18:05 |
PenguinDad |
#1269 fixes models glitching with 3d_armor \o/ |
| 18:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/1269 -- Scene draw cleanup + add various 3d modes by sapier |
| 18:08 |
sapier |
how does that fix the model glitching? |
| 18:09 |
PenguinDad |
I have no idea how but it is fixed with it |
| 18:11 |
PenguinDad |
maybe I was unclear about the glitching |
| 18:13 |
PenguinDad |
with glitching I mean that you can see your own model glitching in for a short moment in first person view |
| 18:13 |
sapier |
I don't believe in bugs suddenly disappearing, but of course it could've been a draw order issue, I had to switch some things to not have to copy too much code for different draw modes |
| 18:13 |
sapier |
oh that one yes I had to fix things related to it |
| 18:15 |
|
Shardvexz joined #minetest-dev |
| 18:17 |
|
Amaz_ joined #minetest-dev |
| 18:21 |
|
proller joined #minetest-dev |
| 18:23 |
Megaf |
RealBadAngel: sapier: Is it possible to add an option to change verbosity for console output? |
| 18:24 |
sapier |
everything is possible |
| 18:25 |
Megaf |
Is it easy for you? |
| 18:25 |
proller |
very easy, +1000 lines of sapiercode ;) |
| 18:26 |
Megaf |
proller: well, would you do a pull request for that? If you find that usefull as I do? |
| 18:26 |
Megaf |
you could do in 10 prollercode |
| 18:26 |
sapier |
I'm with megaf, let proller do it |
| 18:26 |
Megaf |
s/10/10 lines |
| 18:27 |
sapier |
most likely it's gonna limit line count to 17 and be located in mapblock.cpp ... but that's fine too ;-P |
| 18:28 |
Megaf |
heh |
| 18:28 |
sapier |
Yes I know I can do as silly comments as proller too ;-) |
| 18:30 |
Megaf |
sapier: one thing we really do need is some kind of console an Admin can actually administrate the server... |
| 18:31 |
Megaf |
where one could send messages to players, read the chat |
| 18:31 |
sapier |
I already wrote a mod to do this |
| 18:31 |
Megaf |
send commands |
| 18:31 |
Megaf |
did you? |
| 18:31 |
sapier |
yes |
| 18:31 |
Megaf |
Tell me more about it |
| 18:31 |
Megaf |
or just a link |
| 18:32 |
sapier |
I'll have to look for it but basically it's been a console interface to do same as you can do from chat |
| 18:33 |
|
rsiska joined #minetest-dev |
| 18:34 |
sapier |
it's only gonna work on linux too |
| 18:36 |
Megaf |
That's fine |
| 18:43 |
|
Megaf joined #minetest-dev |
| 18:43 |
|
Megaf joined #minetest-dev |
| 18:44 |
Megaf |
That's fine |
| 18:53 |
Megaf |
sapier: There's no public repo about that mod in your github |
| 18:54 |
sapier |
I know I haven't released it yet there wasn't any interest by that time |
| 18:54 |
sapier |
I'm gonna look for it and release it, but give me some time |
| 18:54 |
|
werwerwer_ joined #minetest-dev |
| 18:55 |
* Megaf |
takes some times and gives it to sapier |
| 19:12 |
|
Jordach_ joined #minetest-dev |
| 19:16 |
|
Jordach joined #minetest-dev |
| 19:20 |
|
Jordach joined #minetest-dev |
| 19:33 |
Calinou |
“Loaded mesh: <mesh name>†gets really obnoxious, please comment the code that prints such a thing by default |
| 19:33 |
Calinou |
it's unneeded |
| 19:33 |
Calinou |
it doesn't happen to textures and sounds |
| 19:34 |
* khonkhortisan |
agrees- |
| 19:34 |
sapier |
because textures and sounds aren't reloaded |
| 19:34 |
Calinou |
I know, but messages about meshes should only show on erroneous ones |
| 19:34 |
sapier |
I'm not exactly sure but for what I remember that message is printed by irrlicht not minetest |
| 19:34 |
Calinou |
they flood console and make it hard to read :/ |
| 19:35 |
sapier |
if it's irrlicht there's not much we can do about it |
| 19:35 |
sfan5 |
do it like the people at SuperTuxKart |
| 19:35 |
sfan5 |
fork irrlicht |
| 19:36 |
sapier |
we don't have enough manpower to fix our own bugs forking irrlicht will add another quite huge task |
| 19:38 |
sapier |
it's easy to demand a fork but keeping it alive is way more work then most ppl expect |
| 19:42 |
Calinou |
yeah, don't fork |
| 19:42 |
Calinou |
ask Irrlicht upstream to remove message? |
| 19:42 |
Calinou |
and to provide a patch, at least, for people who don't want message |
| 19:42 |
sapier |
that's a better option, can someone try to get this done? |
| 19:43 |
sapier |
or maybe first ask irrlicht guys if there's already a way to disable it ;-) |
| 19:45 |
|
tomreyn joined #minetest-dev |
| 19:47 |
RealBadAngel |
i think i found a solution |
| 19:48 |
sapier |
for the message problem or some other problem? |
| 19:48 |
sapier |
or do we have to find a matching issue for a cool solution ? ;-) |
| 19:50 |
|
EvergreenTree joined #minetest-dev |
| 19:50 |
RealBadAngel |
http://irrlicht.sourceforge.net/docu/classirr_1_1_i_logger.html |
| 19:51 |
sapier |
for what I remember we do already set this level ... but I don't know what level we set |
| 19:51 |
RealBadAngel |
lets check then |
| 19:51 |
|
grrk-bzzt joined #minetest-dev |
| 19:52 |
RealBadAngel |
grepping for "logger" gives no results |
| 19:52 |
sapier |
interesting |
| 19:53 |
RealBadAngel |
so we obviously are not using it |
| 19:53 |
sapier |
then give it a try it's gonna be quite easy to check |
| 19:54 |
|
ShadowBot` joined #minetest-dev |
| 19:57 |
|
Jordach joined #minetest-dev |
| 19:59 |
RealBadAngel |
ok, trying different log levels now |
| 20:12 |
RealBadAngel |
ILogger* logger = device->getLogger(); |
| 20:12 |
RealBadAngel |
logger->setLogLevel(ELL_ERROR); |
| 20:12 |
RealBadAngel |
Calinou, thats the whole patch needed |
| 20:12 |
sapier |
no it isn't |
| 20:13 |
sapier |
that's the thing to use the real patch is gonna map our loglevels to irrlicht loglevels |
| 20:14 |
RealBadAngel |
i just said thats all whats needed to disable message spam Calinou wanted |
| 20:14 |
sapier |
ok :-) but that's different from the patch to be added to minetest ;-) |
| 20:15 |
RealBadAngel |
i dont really think we should do some mapping |
| 20:15 |
RealBadAngel |
just add the setting default_irrlicht_log_level and thats all |
| 20:15 |
sapier |
of course we should do |
| 20:15 |
sapier |
I don't wanna set 20 debug levels for each different lib we use |
| 20:16 |
sapier |
at least in case there is a sane way to mapp the levels |
| 20:19 |
RealBadAngel |
why they should be bound at all? our records it to the file and the setting has no effect on what is displayed in console |
| 20:19 |
RealBadAngel |
the 2nd displays only to console |
| 20:20 |
sapier |
ours is displayed to console AND debug.txt ... and irrlicht log will be saved to file soon too |
| 20:20 |
RealBadAngel |
no |
| 20:21 |
RealBadAngel |
setting mt loglevel has no effect on what is displayed in console |
| 20:21 |
sapier |
of course the patch is already in android port ... well that's a part I took from a previous version, but it's quite important |
| 20:21 |
sapier |
we're mixing up things |
| 20:21 |
sapier |
actually there are two issues |
| 20:22 |
sapier |
the one requested earlier this day, "add a console_log_level" setting |
| 20:22 |
sapier |
and a second one what to do with irrlicht logging |
| 20:22 |
sapier |
imho later one is fix it to be logged to debug.txt |
| 20:23 |
sapier |
we don't need, and imho can't even handle having two different settings per lib |
| 20:24 |
sapier |
but that's an issue as complex as fixing hud the right way ... and as you there you believe it to be a "small" fix ;-) |
| 20:26 |
RealBadAngel |
as usual youre trying to overcomplicate things ;) |
| 20:27 |
sapier |
no I just want a solution suitable for what we need and not a quick hack forcing me to fix everything once I need to use the next broken part |
| 20:27 |
RealBadAngel |
instead of workin 2 liner we will end up with new class for logging that will be constantly in need of bugfixes ;) |
| 20:27 |
sapier |
e.g. irrlicht logging, how are we supposed to find issues on android or other mobile devices without logs? |
| 20:28 |
RealBadAngel |
just set the loglevel in config |
| 20:28 |
sapier |
well I'm gonna tell any android user to as you how to configure those hundereds of loglevels manually |
| 20:29 |
sapier |
but as usuall they wont get it right, resulting in not having any usfull log |
| 20:29 |
RealBadAngel |
huh, how do you want them to change any setting then? |
| 20:29 |
RealBadAngel |
mapped or not |
| 20:30 |
sapier |
one setting can be added to settings page but I can't add 50 dropdowns there |
| 20:30 |
RealBadAngel |
btw, setting the level to ELL_ERROR will display just errors |
| 20:30 |
RealBadAngel |
and shut up that spam only |
| 20:30 |
sapier |
do it right or don't do it at all |
| 20:31 |
RealBadAngel |
i have no idea how you want it to be done |
| 20:32 |
sapier |
minetest is full of crappy code meant to be a quick fix ... noone dared to clean it up later |
| 20:32 |
RealBadAngel |
so better you code it ;) |
| 20:32 |
sapier |
forget about it I did this mistake for hud |
| 20:33 |
sapier |
for which I know I have to do quite some additional work to make it work as good for android as it's working now for pc |
| 20:33 |
sapier |
because the current hud api is still not suitable for small screens |
| 20:34 |
sapier |
and you're a smart guy too RealBadAngel you're gonna find a way to do logging in a clean way ... it's almost as messed up as hud right now ;-) |
| 20:39 |
RealBadAngel |
create event recevier, and based on debug_log_level dump incoming irrlicht message into proper stream |
| 20:40 |
RealBadAngel |
this will shut up irrlicht logging to console too |
| 20:40 |
sapier |
we already have a event receiver |
| 20:40 |
sapier |
in android port it's handling log messages too |
| 20:41 |
sapier |
I don't know who did add it but at least now I know why it was added ;-) |
| 20:41 |
RealBadAngel |
can you link me to it? |
| 20:41 |
sapier |
I think so let me have a look |
| 20:43 |
RealBadAngel |
http://pastebin.com/5Z8RQ4CL |
| 20:46 |
RealBadAngel |
thats incoming message on event |
| 20:46 |
RealBadAngel |
and event: http://pastebin.com/UskigWX0 |
| 20:49 |
sapier |
https://github.com/sapier/minetest/blob/android_merge_branch_6/src/main.cpp around line 329 |
| 20:58 |
RealBadAngel |
that event receiver grabs the messages and puts them back into console |
| 20:59 |
sapier |
I didn't say it's best way to handle it I only said we have one ;-) |
| 21:00 |
RealBadAngel |
do we want irrlicht messages in console at all? |
| 21:01 |
Calinou |
[proposal] Center infotext below crosshair by default. Makes it much easier to do it. |
| 21:01 |
RealBadAngel |
or maybe it could be added with console_log_level |
| 21:01 |
Calinou |
if you think this is a good idea, you can post an issue about it |
| 21:02 |
Calinou |
(ideally: do that, and add minetest.conf settings for X and Y offset of infotext) |
| 21:02 |
sapier |
calinou there's not always a crosshait |
| 21:02 |
sapier |
-t+r |
| 21:02 |
Calinou |
just throwing this in here, because I fear an immediate issue closing if I post it on github already |
| 21:02 |
Calinou |
sapier, even if there's no crosshair, write it below |
| 21:02 |
Calinou |
it makes _sense_ |
| 21:02 |
Calinou |
especially for signs |
| 21:03 |
sapier |
relative or absolute positioning? ;-) |
| 21:03 |
Calinou |
the X and Y would probably be absolute positiions in minetest.conf |
| 21:04 |
Calinou |
anyway, I'd like to see this in, but if you don't, I'm going to try to haxor the game to have this as usual 8) |
| 21:04 |
sapier |
:-) calinou I'm asking because I know what issues this is gonna cause on different screen sizes and dpi's ... it sounds easy but everyone expects different things to happen |
| 21:05 |
sapier |
placing things at the edges or ecactly at center is simple but doing relative positioning to other elements isn't implemented (yet) |
| 21:06 |
Calinou |
ah |
| 21:07 |
sapier |
as usual I need this for something I wanna be done (android port) ... and as usual those wanting to do a quick fix only expect my solution to solve all issues about 2000 miles around the original issue ;-) |
| 21:07 |
sapier |
so expect it to be possible by the end of this month ;-) |
| 21:08 |
RealBadAngel |
sapier that event handler also causes irrlicht logs being saved to disk |
| 21:09 |
sapier |
I intend to add an additional parameter to hud definition, specifying the parent element, position for elements having a parent element isn't relative to screen but relative to parent with x=0,y=0 beeing upper left corner and x=1,1 beeing lower right one, any other values are calculated same way |
| 21:10 |
sapier |
RealBadAngel: that's what it is intended to do, but it's a unfinished hack similar to what you first intended to do |
| 21:10 |
sapier |
it's missing any loglevel handling |
| 21:11 |
Calinou |
grepping “infotext†returns nothing about its position |
| 21:11 |
sapier |
position of what? |
| 21:11 |
RealBadAngel |
sapier, and we do already possible levels of what is shown on console |
| 21:12 |
sapier |
sorry I don't understand this sentence |
| 21:12 |
Calinou |
position of the infotext |
| 21:12 |
RealBadAngel |
there are command line parameters |
| 21:12 |
Calinou |
maybe it's handled by Irrlicht itself and not modifiable? |
| 21:12 |
sapier |
ok maybe we should add those to settings too |
| 21:13 |
sapier |
at least once settings is available |
| 21:14 |
sapier |
I guess settings isn't available as soon as command line params |
| 21:14 |
RealBadAngel |
https://github.com/sapier/minetest/blob/android_merge_branch_6/src/main.cpp#L825 |
| 21:15 |
sapier |
yes so very very soon in startup process |
| 21:18 |
RealBadAngel |
idea, set irrlicht log level in logger to maximum |
| 21:18 |
sapier |
for what reason? |
| 21:18 |
RealBadAngel |
ah nvm |
| 21:19 |
sapier |
how much irrlicht loglevels are there? |
| 21:19 |
RealBadAngel |
5 |
| 21:20 |
sapier |
ok and we do have 4, + some debug trace level |
| 21:20 |
sapier |
that'd be a lmost a 1:1 match |
| 21:20 |
RealBadAngel |
http://irrlicht.sourceforge.net/docu/namespaceirr.html#aa2d1cac68606a25ed24cfffccfa30a92 |
| 21:21 |
sapier |
my suggestion is doing a 1:1 mapping, of course action to warning isn't a perfect match but to me it'd be good enough |
| 21:36 |
RealBadAngel |
ok, i know how to add console log level |
| 22:01 |
|
kaeza joined #minetest-dev |
