| Time |
Nick |
Message |
| 00:04 |
|
iqualfragile joined #minetest-dev |
| 00:40 |
|
hmmmm joined #minetest-dev |
| 00:49 |
PilzAdam |
proller, why do you disable rollback recording of finite liquids in liquid63old? |
| 00:49 |
PilzAdam |
also, can you remove the weather stuff? |
| 00:49 |
proller |
because it stuck server |
| 00:50 |
proller |
remove why? |
| 00:50 |
PilzAdam |
because its not related to liquids |
| 00:50 |
proller |
related |
| 00:50 |
proller |
melt when flowing |
| 00:51 |
proller |
and its because impossible make something big from slall parts |
| 00:51 |
proller |
small |
| 00:51 |
proller |
firs was weather, then liquid update |
| 00:53 |
PilzAdam |
its a very bad habit to have multiple features in one branch and want it to be merged at once |
| 00:53 |
proller |
finite liquid can touch 1000-10000-.... blocks, - rollback very bad with it |
| 00:53 |
proller |
PilzAdam, you want this before |
| 00:54 |
PilzAdam |
I dont understand that sentence |
| 00:55 |
proller |
and it was 2 branches before lines became intersect |
| 00:56 |
proller |
you wrote something developing in "fork" and never merge to upstream, bla bla bla .. |
| 00:57 |
PilzAdam |
well, a fork is different than a branch; in a fork you develop multiple features and finish them, and then merge it back to upstream |
| 00:58 |
PilzAdam |
and as far as I can see the weather and liquids are not finished in that branch |
| 00:58 |
proller |
now LIQUID_FLOW_DOWN_MASK limit old liquids to 8 levels, it can be moved to high bits, but it cause some small glitches |
| 00:59 |
PilzAdam |
the docs are unclear, can I use the "leveled" field for default liquids now? |
| 00:59 |
proller |
impossible to develop multiple features in separate branches if they touches same lines of code |
| 00:59 |
proller |
yes, can, |
| 00:59 |
proller |
but better for flowing and source |
| 01:00 |
PilzAdam |
how does that work? |
| 01:00 |
proller |
https://github.com/proller/minetest_game/compare/liquid63 |
| 01:01 |
proller |
look at lava |
| 01:01 |
PilzAdam |
so leveled = 4 is same as range = 4? |
| 01:01 |
proller |
visually - yes |
| 01:02 |
PilzAdam |
what about "possible values for liquids 2..63", is 0 not possible? |
| 01:02 |
proller |
need to test |
| 01:02 |
proller |
0 levels of liquid == air |
| 01:02 |
proller |
no sense |
| 01:03 |
PilzAdam |
and 1? |
| 01:03 |
proller |
1 level = full block |
| 01:03 |
proller |
look at sand |
| 01:03 |
proller |
it jump down if can if finite enabled |
| 01:04 |
proller |
maybe need to delete old commented code, or keep some time |
| 01:04 |
proller |
and i g to sleep |
| 01:04 |
proller |
05:04 aaaaa |
| 01:19 |
|
djdduty joined #minetest-dev |
| 01:32 |
|
darkrose joined #minetest-dev |
| 01:32 |
|
darkrose joined #minetest-dev |
| 02:11 |
|
werwerwer joined #minetest-dev |
| 02:41 |
|
OWNSyouAll_DESKT joined #minetest-dev |
| 06:01 |
|
Miner_48er joined #minetest-dev |
| 06:45 |
|
Calinou joined #minetest-dev |
| 07:13 |
|
adama_ joined #minetest-dev |
| 07:14 |
adama_ |
looking for help installing a few mods am i in the right place ?? |
| 07:18 |
|
adama_ left #minetest-dev |
| 08:15 |
|
darkrose joined #minetest-dev |
| 08:37 |
|
Calinou joined #minetest-dev |
| 08:57 |
|
darkrose joined #minetest-dev |
| 08:57 |
|
darkrose joined #minetest-dev |
| 09:41 |
|
john_minetest joined #minetest-dev |
| 09:41 |
|
john_minetest joined #minetest-dev |
| 09:55 |
|
Ritchie joined #minetest-dev |
| 10:12 |
|
proller joined #minetest-dev |
| 11:37 |
|
EdB joined #minetest-dev |
| 11:37 |
|
proller joined #minetest-dev |
| 11:42 |
|
PilzAdam joined #minetest-dev |
| 12:09 |
|
Calinou joined #minetest-dev |
| 12:42 |
|
werwerwer joined #minetest-dev |
| 12:58 |
|
djdduty joined #minetest-dev |
| 13:28 |
|
e1z0 joined #minetest-dev |
| 13:33 |
|
e1z0 joined #minetest-dev |
| 14:48 |
|
nyuszika7h joined #minetest-dev |
| 14:48 |
|
Zeitgeist_ joined #minetest-dev |
| 14:55 |
|
init joined #minetest-dev |
| 15:30 |
|
Jordach joined #minetest-dev |
| 15:30 |
|
Jordach_ joined #minetest-dev |
| 15:44 |
|
hmmmm joined #minetest-dev |
| 15:49 |
|
Miner_48er joined #minetest-dev |
| 16:15 |
|
Calinou joined #minetest-dev |
| 16:19 |
|
rubenwardy joined #minetest-dev |
| 16:33 |
|
OWNSyouAll_DESKT joined #minetest-dev |
| 17:09 |
|
AllegedlyDead joined #minetest-dev |
| 17:37 |
|
smoke_fumus joined #minetest-dev |
| 17:38 |
|
iqualfragile joined #minetest-dev |
| 18:05 |
proller |
PilzAdam, liquids wirks with all 63 lrvrls |
| 18:05 |
proller |
works |
| 18:06 |
proller |
place one and get 128x128 area flooded 8) |
| 18:07 |
|
neko259 joined #minetest-dev |
| 19:03 |
VanessaE |
shouldn't 64 levels only give you about an 8x8 area? |
| 19:10 |
lanxu |
Hi! I wanted to see what kind of beast minetest actually is so I added a cmake option to automatically generate doxyfile for the project |
| 19:14 |
lanxu |
Should I do pull request? or is this just a useless addition? :) |
| 19:15 |
PilzAdam |
like this: https://github.com/minetest/minetest/pull/459 ? |
| 19:17 |
thexyz |
what kind of docs does it generate? |
| 19:17 |
lanxu |
That is very similar I did. I didn't run doxygen automatically. |
| 19:18 |
lanxu |
https://github.com/lanxu/minetest/commit/773360f0bfe6f7460d69bfd854ba283224352ee1 |
| 19:25 |
lanxu |
Whoops. Actually, I didn't add the modifications done in CMakelist.txt there, so I made another commit for it (basically defining option for document creation). |
| 19:25 |
PilzAdam |
anyway, AFAIK we have decided to not use doxygen |
| 19:25 |
lanxu |
ok :) |
| 19:27 |
lanxu |
doxygen documentation is much more reasonable with libraries |
| 19:29 |
|
Ritchie joined #minetest-dev |
| 19:31 |
celeron55 |
feel free to maintain doxygen documentation by yourself, but it seems most of core devs don't want it in the codebase |
| 19:32 |
celeron55 |
(some people would probably be happy if somebody hosted such) |
| 19:33 |
|
proller joined #minetest-dev |
| 19:55 |
lanxu |
In case someone wants to check the doxygen output: http://koti.kapsi.fi/~nawulf/code/minetest/2013-09-12_doxygen/ |
| 19:57 |
lanxu |
btw. is there somekind of list of things that people are working on? |
| 20:03 |
celeron55 |
not really; it's generally so ad-hoc it would be tiresome to maintain |
| 20:04 |
celeron55 |
you get the best idea by occasionally looking at the pull requests and issues, and lurking on this channel |
| 20:05 |
lanxu |
alright. Thanks! :) |
| 20:08 |
|
djdduty joined #minetest-dev |
| 20:08 |
|
djdduty joined #minetest-dev |
| 20:09 |
celeron55 |
lanxu: is it possible to configure doxygen to not follow any formal rules for comments but rather use anything it can in any format? |
| 20:10 |
hmmmm |
i would be okay with doxygen comments in the headers |
| 20:14 |
|
john_minetest left #minetest-dev |
| 20:16 |
|
jojoa1997 joined #minetest-dev |
| 20:22 |
lanxu |
celeron55: I don't know about "mixed" situations, but yes, you can write the comments in any way which doxygen finds "valid" |
| 20:25 |
lanxu |
by far I have used doxygen in one project and I kept the same way of annotating the code (only headers with "javadoc" style comment blocks) |
| 20:32 |
lanxu |
It reduces the readability of the headers (so much comments!) and it's harder to get the idea of the class by checking the header. Luckily, I use IDE so I usually don't need to check the headers for class members :) |
| 21:01 |
|
jojoa1997 left #minetest-dev |
| 21:21 |
|
hmmmmm joined #minetest-dev |
| 21:50 |
|
proller joined #minetest-dev |
| 22:41 |
proller |
liquids63 ready! now with old liquid support! |
| 22:48 |
|
Anchakor_ joined #minetest-dev |
| 23:39 |
|
Anchakor_ joined #minetest-dev |
