Time |
Nick |
Message |
00:39 |
|
harrison joined #minetest-dev |
00:51 |
|
djdduty joined #minetest-dev |
00:51 |
|
djdduty joined #minetest-dev |
01:07 |
|
werwerwer joined #minetest-dev |
01:22 |
|
Anchakor_ joined #minetest-dev |
01:23 |
|
jojoa1997 joined #minetest-dev |
01:35 |
|
Kray joined #minetest-dev |
01:39 |
|
Anchakor_ joined #minetest-dev |
02:29 |
|
iqualfragile_ joined #minetest-dev |
02:44 |
|
harrison joined #minetest-dev |
04:54 |
|
neko259 joined #minetest-dev |
05:16 |
|
damiel joined #minetest-dev |
05:27 |
|
tango_ joined #minetest-dev |
06:07 |
|
Miner_48er joined #minetest-dev |
06:10 |
celeron55 |
https://github.com/minetest/minetest/pull/916 |
06:10 |
celeron55 |
i think this was not thought nearly enough |
06:14 |
celeron55 |
i think none of them are more correct than the other; the previous one was perfectly right if you think of it as padding |
06:14 |
celeron55 |
the new one is right if it's margin, not padding |
06:14 |
celeron55 |
(to speak in html/css terms) |
06:16 |
celeron55 |
i think we need to reserve a right to change this anytime when more fancy styling of the hotbar is enabled |
06:16 |
celeron55 |
because that gives a basis for making any kind of rational decision |
06:22 |
|
darkrose joined #minetest-dev |
06:22 |
|
darkrose joined #minetest-dev |
07:12 |
|
e1z0 joined #minetest-dev |
07:14 |
|
Calinou joined #minetest-dev |
07:29 |
|
Akien joined #minetest-dev |
07:49 |
|
Ritchie joined #minetest-dev |
07:54 |
|
Akien joined #minetest-dev |
08:19 |
|
AllegedlyDead joined #minetest-dev |
08:37 |
|
Calinou joined #minetest-dev |
08:47 |
|
darkrose joined #minetest-dev |
09:28 |
|
john_minetest joined #minetest-dev |
09:28 |
|
john_minetest joined #minetest-dev |
09:28 |
|
jojoa1997 joined #minetest-dev |
10:41 |
|
proller joined #minetest-dev |
11:23 |
|
proller joined #minetest-dev |
11:53 |
|
lanxu joined #minetest-dev |
11:53 |
|
djdduty joined #minetest-dev |
12:04 |
|
PilzAdam joined #minetest-dev |
12:04 |
|
Taoki joined #minetest-dev |
12:20 |
|
hmmmm joined #minetest-dev |
12:24 |
|
OWNSyouAll_DESKT joined #minetest-dev |
12:25 |
|
iqualfragile joined #minetest-dev |
12:38 |
|
rubenwardy joined #minetest-dev |
12:53 |
|
salamanderrake joined #minetest-dev |
13:01 |
PilzAdam |
thexyz, I have created pages for all the old minetest.env: methods in the dev wiki; can you remve the redirect to EnvRef for them? |
13:09 |
|
proller joined #minetest-dev |
13:19 |
|
jojoa1997 joined #minetest-dev |
13:37 |
|
proller joined #minetest-dev |
13:40 |
|
EdB joined #minetest-dev |
13:43 |
|
RNL joined #minetest-dev |
13:44 |
|
salamanderrake joined #minetest-dev |
13:53 |
|
proller joined #minetest-dev |
14:25 |
kahrl |
I'd like to get #884 merged so I can work more freely on mainmenu stuff |
14:25 |
kahrl |
https://github.com/sapier/minetest/commit/f1f34e5e37f5da9fd514b6db15a21201fb924014#L0R258 I'd remove this line and use "local screenshotfile,error =" on the next |
14:26 |
kahrl |
what is the error = nil for in line 274? |
14:28 |
kahrl |
can somebody explain what this function does? https://github.com/sapier/minetest/commit/3e242b7cc368aa1aec591431a9cc6fa08d6f3708#L0R209 |
14:28 |
thexyz |
my guess: it wraps long lines |
14:28 |
thexyz |
it should be rewritten, I think |
14:29 |
thexyz |
http://lua-users.org/wiki/StringRecipes check "Text Wrapping" section |
14:29 |
|
Zeitgeist_ joined #minetest-dev |
14:29 |
kahrl |
yeah that looks much better |
14:30 |
thexyz |
better ask sapier though, I'm not sure what does it do |
14:31 |
thexyz |
why's there so much code? |
14:31 |
thexyz |
https://github.com/minetest/minetest/pull/884/files#L1R283 you don't need table.insert here |
14:32 |
thexyz |
https://github.com/minetest/minetest/pull/884/files#L1R291 you don't need ",1" here |
14:32 |
thexyz |
https://github.com/minetest/minetest/pull/884/files#L1R280 random hardcoded values are bad |
14:33 |
|
jojoa1997 joined #minetest-dev |
14:33 |
thexyz |
this https://github.com/minetest/minetest/pull/884/files#L1R265 can be replaced by "or" |
14:34 |
kahrl |
yeah or just ipairs for the second thing you mentioned |
14:34 |
thexyz |
ipairs is even better, right |
14:35 |
PilzAdam |
https://github.com/PilzAdam/minetest/commits/slabs and https://github.com/PilzAdam/minetest_game/commits/slabs |
14:35 |
kahrl |
I wonder if the splittext thing could be avoided entirely by merging the textarea wordwrap patch |
14:35 |
thexyz |
I dunno, the whole formspec menu code seems to me like a total mess |
14:35 |
PilzAdam |
^^ this is a better way to achieve what #915 does |
14:36 |
kahrl |
thexyz: yeah it seems hard to get used to |
14:36 |
thexyz |
like here, https://github.com/minetest/minetest/blob/master/builtin/modmgr.lua, crazy random codestyle |
14:36 |
thexyz |
anyway, should stop whining right now |
14:40 |
|
Zeg9 joined #minetest-dev |
14:44 |
|
jojoa1997 joined #minetest-dev |
14:50 |
|
jojoa1997 joined #minetest-dev |
15:04 |
|
Jordach joined #minetest-dev |
15:40 |
|
Calinou joined #minetest-dev |
15:41 |
thexyz |
how about we bundle more games with the next release? |
15:41 |
PilzAdam |
that would be good |
15:47 |
proller |
+1 |
15:48 |
thexyz |
okay, now anyone volunteering to maintain those extra games? |
15:51 |
ShadowNinja |
technic_game is quite heavy, but vanessae_game? |
15:53 |
ShadowNinja |
Maybe release a light version without all the games. |
16:03 |
|
iqualfragile joined #minetest-dev |
16:37 |
|
neko259 joined #minetest-dev |
16:58 |
|
RNL left #minetest-dev |
17:43 |
|
iqualfragile joined #minetest-dev |
17:56 |
|
proller joined #minetest-dev |
18:09 |
kahrl |
wonder if I should simply add the table support now and mess with builtin later |
18:09 |
kahrl |
guess I'll do that |
18:11 |
|
jojoa1997 joined #minetest-dev |
18:24 |
|
e1z0 joined #minetest-dev |
18:24 |
|
e1z0 joined #minetest-dev |
18:28 |
|
e1z0_ joined #minetest-dev |
18:29 |
kahrl |
https://github.com/minetest/minetest/pull/920 |
18:33 |
thexyz |
woo, don't we already have color parser somewhere? |
18:34 |
thexyz |
only one table per formspec? |
18:34 |
kahrl |
I guess the color parser could be written simpler |
18:34 |
kahrl |
don't know if we have one already |
18:34 |
kahrl |
you can have multiple tables |
18:35 |
thexyz |
hm |
18:35 |
thexyz |
> displays cells as defined by the last tablecolumns[] |
18:35 |
kahrl |
yeah you can do tablecolumns[...] table[...] tablecolumns[...] table[...] |
18:35 |
thexyz |
oh, last before table definition |
18:35 |
kahrl |
maybe "previous" is better |
18:36 |
thexyz |
could you add some examples (with screenshots) to dev wiki? |
18:37 |
thexyz |
(after merging it, of course) |
18:37 |
kahrl |
yeah |
18:38 |
kahrl |
maybe simply those from tabletest |
18:38 |
thexyz |
I doubt anyone's going to review this so just merge it maybe? |
18:39 |
thexyz |
do those include all kinds of tables? |
18:39 |
kahrl |
I'll wait a bit |
18:39 |
thexyz |
right, right |
18:39 |
kahrl |
well they include every column type, but not every corner case I guess |
18:41 |
thexyz |
that's nice then |
18:41 |
|
e1z0 joined #minetest-dev |
18:42 |
|
jojoa1997|PC joined #minetest-dev |
18:42 |
|
BlockMen joined #minetest-dev |
18:51 |
|
Akien joined #minetest-dev |
18:54 |
|
e1z0 joined #minetest-dev |
18:54 |
|
e1z0 joined #minetest-dev |
18:57 |
|
Ritchie joined #minetest-dev |
19:04 |
|
e1z0 joined #minetest-dev |
19:19 |
|
iqualfragile joined #minetest-dev |
19:27 |
|
iqualfragile joined #minetest-dev |
19:45 |
|
hmmmm joined #minetest-dev |
19:45 |
|
iqualfragile joined #minetest-dev |
19:53 |
|
Anchakor_ joined #minetest-dev |
20:01 |
|
hmmmmm joined #minetest-dev |
20:11 |
|
jojoa1997 joined #minetest-dev |
20:15 |
|
ecube_ joined #minetest-dev |
20:20 |
|
hmmmmmm joined #minetest-dev |
20:29 |
|
hmmmmmm joined #minetest-dev |
20:52 |
|
hmmmm joined #minetest-dev |
21:13 |
|
hmmmm joined #minetest-dev |
21:23 |
VanessaE |
re: including more games with minetest, I'm not against adding mine, but as thexyz once said, mine kinda lacks direction |
21:23 |
VanessaE |
(I still haven't settled on a clear path I want it to take) |
21:26 |
VanessaE |
right now, it's basically "here's a whole bunch of shit to build with. Now go out and mine for the stuff you need to make it." |
22:01 |
|
jojoa1997 joined #minetest-dev |
22:05 |
|
damiel joined #minetest-dev |
22:15 |
|
Miner_48er joined #minetest-dev |
22:21 |
|
hmmmmm joined #minetest-dev |
23:45 |
|
Anchakor_ joined #minetest-dev |
23:48 |
|
BlockMen left #minetest-dev |