Minetest logo

IRC log for #minetest-dev, 2013-05-25

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:09 proller joined #minetest-dev
00:16 sapier1 joined #minetest-dev
00:37 sapier1 left #minetest-dev
01:47 ssieb joined #minetest-dev
02:01 dexter0 joined #minetest-dev
02:24 ShadowNinja I think that minetest nicks should be case insensitive. Any thoughts? It might cause issues if there are collisions on old servers.
02:35 BackupCoder joined #minetest-dev
02:37 mrtux joined #minetest-dev
03:10 BackupCoder joined #minetest-dev
03:17 ssieb joined #minetest-dev
03:24 ShadowNinja joined #minetest-dev
03:38 kaeza joined #minetest-dev
03:41 proller joined #minetest-dev
03:45 BackupCoder joined #minetest-dev
03:55 BackupCoder joined #minetest-dev
04:15 BackupCoder joined #minetest-dev
04:27 BackupCoder joined #minetest-dev
04:52 ssieb joined #minetest-dev
06:05 BackupCoder joined #minetest-dev
06:06 diemartin joined #minetest-dev
06:08 kaeza1 joined #minetest-dev
07:17 Calinou joined #minetest-dev
07:28 celeron55 joined #minetest-dev
07:53 EdB joined #minetest-dev
09:14 Zeg9 joined #minetest-dev
09:16 sapier joined #minetest-dev
09:23 ImQ009 joined #minetest-dev
09:32 serengeor joined #minetest-dev
10:22 Jordach joined #minetest-dev
10:22 Jordach joined #minetest-dev
10:43 sapier could someone plz merge this fix? https://github.com/minetest/minetest/pull/613 (update formname on form change)
11:02 PilzAdam joined #minetest-dev
12:37 NakedFury joined #minetest-dev
12:54 ImQ009 joined #minetest-dev
12:58 serengeor joined #minetest-dev
13:25 RealBadAngel joined #minetest-dev
14:11 BlockMen joined #minetest-dev
14:11 BlockMen https://github.com/minetest/minetest/commit/c67f72890c3f9154dd9124310c61ba55bc2806bd https://github.com/minetest/minetest_game/commit/c1cd24c37833822b2232064350d10b6dea4badb2
14:11 BlockMen the license is cc-by 3.0
14:12 BlockMen needs to be added...
14:12 BlockMen left #minetest-dev
14:21 sfan5 can I push the pngcrushed minetest_game textures?
14:22 PilzAdam last time I tested it was only 0.1 MiB less or so
14:22 PilzAdam dunno if its worth it
14:23 sfan5 most textures got compressed pretty good: http://pastie.org/7957768
14:23 sfan5 *many
14:29 sfan5 since pngcrushing things can't break anything, I'll just push it
14:37 Anchakor_ joined #minetest-dev
14:52 Calinou joined #minetest-dev
15:41 ssieb joined #minetest-dev
15:48 BackupCoder joined #minetest-dev
15:51 PilzAdam hm... is ItemStack:take_item() broken for anyone else?
15:51 PilzAdam I get pretty strange results when eating an apple
15:58 darkrose maybe the apple is soaked in lsd
16:01 Exio haha
16:05 ssieb joined #minetest-dev
16:11 kaeza PilzAdam, I can confirm that
16:11 kaeza apples are not consumed
16:13 Exio it works from me
16:13 Exio (lastest git)
16:15 PilzAdam I eat on apple from a stack of 10, it turns into 18, then 34, 66, 99
16:15 PilzAdam and 99 stays at 99
16:16 kaeza PilzAdam, same here
16:16 Exio with only one it worked
16:16 kaeza note: if you eat a single apple, it disappears
16:16 Exio now with more it doesn't work
16:17 kaeza it seems to grow exponentially
16:17 kaeza with a stack of 2, it doesn't even change
16:18 PilzAdam I guess its an bug caused by scriptapi seperation
16:18 PilzAdam -n
16:18 kaeza with 3, it goes to 4 -> 6 -> 10 -> 18 -> *
16:19 mrtux joined #minetest-dev
16:20 smoke_fumus joined #minetest-dev
16:23 jojoa1997 joined #minetest-dev
16:41 sapier RFC: http://dev.minetest.net/Script_Engine first try
16:51 sapier it's wrong for a single apple too ... its 2*n n beeing what you should have
16:51 Zeg9 joined #minetest-dev
16:51 sapier for a single apple this results in 0*2 --> 0 ;-)
16:51 Exio i see
17:23 sapier https://github.com/minetest/minetest/pull/737 fix for stack duplication on eat
17:26 PilzAdam lets wait for the travis build
17:27 sapier of course
17:27 sapier but I guess changing -2 to -1 won't break the build ;-)
17:28 * PilzAdam cant wait
17:29 PilzAdam merged
17:29 Exio lol
17:30 sapier I wonder how much of these of by one errors are still burried within the new code ... I already fixed tons of them
17:37 BlockMen joined #minetest-dev
17:37 PilzAdam BlockMen, can you include the license notice in your higher-res header pull request?
17:39 BlockMen PilzAdam, yes, but that would be a second commit then
17:39 PilzAdam Ill squash them when merging
17:39 PilzAdam I also found out why I didnt saw a difference, I have a version of it in textures/all/
17:40 BlockMen PilzAdam, lol
17:51 BlockMen PilzAdam, -> https://github.com/BlockMen/minetest_game/commit/6372dfb923dfece2323272a12c3122b52eeadf53 ok?
17:51 ImQ009 joined #minetest-dev
17:57 PilzAdam BlockMen, is this ok for the engine: https://github.com/PilzAdam/minetest/commit/ffcbbad0f03f6a795a9e988aeb6f74c6390fcc7e ?
17:57 Zeg9 joined #minetest-dev
17:59 sapier joined #minetest-dev
17:59 BlockMen PilzAdam, yes, but license is missing too
17:59 PilzAdam the README already says that all textures and sounds are CC BY-SA
17:59 PilzAdam (line 253)
18:04 BlockMen PilzAdam, -> http://creativecommons.org/licenses/by/3.0/ means it has to say somewhere that its created by me :P
18:06 PilzAdam well, erlehmann's textures are also there without naming the author
18:06 PilzAdam but if you insist on this...
18:06 BlockMen PilzAdam, then erlehmann should be added?
18:07 PilzAdam he has nothing against it
18:09 BlockMen how bout a readme in textures/base then?
18:09 PilzAdam https://github.com/PilzAdam/minetest/commit/12283c42e82f889ba7114828677f10e7a15de551
18:10 PilzAdam or https://github.com/PilzAdam/minetest/commit/d01dd0c74e823eb0b8d9a08c63b4fa13eeb81aee
18:10 celeron55 texutres 8)
18:11 BlockMen i prefer second, but at least your decision
18:12 celeron55 the second one seems appropriate (fix the typo though)
18:13 BlockMen PilzAdam, and i want to appologize if i was too insulting last days! although i still think that more than one person should decide on _game.
18:14 PilzAdam yea, I guess the whole thing was a communication fail
18:15 BlockMen PilzAdam, we are fine then?
18:15 PilzAdam sure
18:16 BlockMen good
18:20 sapier PilzAdam did you have time to check the optimzed buttons?
18:20 PilzAdam when I finished eating
18:20 sapier *smile*
18:27 BlockMen -this is just a question and not (!) a request to change- -> why uses the empty bucket on_use and the filled bucket on_place ?
18:28 PilzAdam if you pick up water with an empty bucket its like digging, so leftclick
18:28 PilzAdam and placing water is like placing, so rightclick
18:28 BlockMen ah, ok. from that perspective it makes sense. thx
18:39 PilzAdam sapier, the favorite/public server list is still broken
18:39 PilzAdam it always shows me the public list, but clicking an entry doesnt work
18:39 PilzAdam (it doesnt change adress/port field)
18:41 PilzAdam and it has loaded the wrong world once, but I cant reproduce it
18:42 PilzAdam also menuheader.png is not drawn
18:42 PilzAdam (only game/menu/header.png in Singleplayer)
18:47 PilzAdam sapier, also add newlines at the end of files
18:57 smoke_fumus|2 joined #minetest-dev
18:57 smoke_fumus|2 joined #minetest-dev
19:11 ssieb joined #minetest-dev
19:29 iqual|outisdes joined #minetest-dev
19:38 Jordach joined #minetest-dev
19:38 vals_ joined #minetest-dev
19:46 Jordach joined #minetest-dev
19:55 iqual|outisdes left #minetest-dev
19:56 john_minetest joined #minetest-dev
19:56 john_minetest left #minetest-dev
20:02 tango_ joined #minetest-dev
20:23 sfan5 sha1 interface for scriptapi, needs testing: http://git.io/hbxcAQ
20:42 BackupCoder joined #minetest-dev
20:53 kahrl joined #minetest-dev
21:28 sapier sfan5 what sha lib do you use?
21:29 kahrl is this OK to merge? https://github.com/minetest/minetest/pull/699
21:29 kahrl (I rebased it after the scriptapi separation)
21:30 sapier PilzAdam can you tell me how the favourite/public server list should work? I can't test it
21:30 celeron55 sapier: minetest contains an sha1 implementation
21:30 PilzAdam sapier, a button to switch between the two lists; state is saved
21:30 sapier wrong world ... maybe related to switching between single and server tab
21:31 celeron55 kahrl: it still modifies the existing network message in a not good way
21:31 sapier can you give me a screenshot where this button should be?
21:31 celeron55 i don't think anyone agrees in doing it like that
21:32 kahrl <kahrl> not sure if I should change it as I don't see much need to add more hud integer parameters in the future
21:32 kahrl <kahrl> I'd rather extend the lua hud system to make that more flexible
21:32 kahrl but I guess I could make it a separate message regardless
21:33 kahrl which seemed a bit excessive when I first wrote it
21:34 kahrl is there any pull request out there that reserves a new message ID?
21:34 kahrl or can I use 0x4d
21:40 sapier whats penalty for abusing admin rights? ;-)
22:11 kahrl celeron55: https://github.com/kahrl/minetest/commit/59419d963837e3fd14475da751efb878481fa795
22:12 PilzAdam tested, works
22:13 kahrl any other objections? I'll push in 10 minutes otherwise
22:25 kahrl aaaand pushed
22:27 PilzAdam aaaand MiniTest no officially has 9 hotbar slots :-)
22:27 PilzAdam *now
22:32 kahrl any objections to https://github.com/minetest/minetest/pull/734? Does it break any mods?
22:32 PilzAdam kahrl, it just follow lua-api.txt, so it doesnt break mods by definition :-)
22:33 PilzAdam +s
22:33 kahrl okay I think it's good then :)
22:33 kahrl I'll merge it
22:35 sapier what about this one? https://github.com/minetest/minetest/pull/613
22:41 kahrl sapier, looks good to me (though I didn't test it)
22:41 kahrl it's a bit hard to see why current_textdest is != NULL in line 2257 because the_game is so large
22:42 kahrl but that's a problem in that function as a whole so not a reason to reject that pull request
22:43 sapier yes whole formspec desing isn't as good as I would like it to be but at least it's consistent atm
22:46 kahrl maybe also add a comment behind the current_textdest declaration such as // deleted by GUIFormSpecMenu
22:47 kahrl to make it easier for future memory leak hunters
22:47 kahrl and I guess do the same after current_formspec
22:47 sapier yes but mid term this should be redone either
22:48 sapier it's good style that the one creating memory destorys it
22:48 kahrl I agree but such a comment doesn't hurt short term
22:52 kahrl I just saw where current_formspec is reset to 0
22:52 kahrl that's... a bit convoluted to say the least :P
22:53 sapier you say it ;-) I add a comment
23:04 Taoki joined #minetest-dev
23:05 sapier https://github.com/minetest/minetest/pull/613 added comment as well as an additional check
23:10 PilzAdam fun fact: only things that still leak memory in Minetest are shaders and sqlite
23:12 sapier and shaders can't be fixed as irrlicht doesn't support unloading of shaders
23:15 kahrl should we submit a feature request to irrlicht?
23:20 BlockMen left #minetest-dev
23:37 kahrl sapier: I made a simple test mod to test the formspec name bug
23:37 kahrl http://paste.dy.fi/I8v
23:38 kahrl I can reproduce the error
23:40 sapier I know :-) I've found it when trying to open a formspec from another one ... you can simply use minetest.show_formspec(name,formspec) ... a lot more easy ;-)
23:40 sapier most likely ppl use same modname everytime like i did a long time too so they don't even realize it
23:42 * PilzAdam looks at his workbench code
23:42 PilzAdam *nod*
23:44 kahrl I can confirm that https://github.com/minetest/minetest/pull/613 fixes the bug
23:44 kahrl objections to merging it?
23:44 PilzAdam nope
23:45 smoke_fumus joined #minetest-dev
23:48 kahrl I changed the commit message because it was a tiny bit too long
23:50 kahrl down to two pages of open pull requests!
23:50 PilzAdam yay!
23:50 * PilzAdam can remember when it was only 1 page...
23:50 kahrl I can't, when was that? :)
23:51 PilzAdam when I came here, IIRC

| Channels | #minetest-dev index | Today | | Google Search | Plaintext