| Time |
Nick |
Message |
| 00:21 |
|
paramat joined #minetest-dev |
| 01:12 |
|
Cornelia joined #minetest-dev |
| 01:29 |
|
GreenDimond joined #minetest-dev |
| 01:30 |
|
Cornelia joined #minetest-dev |
| 01:47 |
|
Lone-Star joined #minetest-dev |
| 03:28 |
|
calcul0n_ joined #minetest-dev |
| 03:43 |
|
Ruslan1 joined #minetest-dev |
| 05:19 |
ANAND |
Somewhat small anti-cheat PR: #8471 |
| 05:19 |
ShadowBot |
https://github.com/minetest/minetest/issues/8471 -- Anti-cheat: Add line-of-sight check for player interactions by ClobberXD |
| 05:29 |
|
nore joined #minetest-dev |
| 06:34 |
|
kaeza joined #minetest-dev |
| 07:20 |
|
YuGiOhJCJ joined #minetest-dev |
| 07:26 |
|
YuGiOhJCJ joined #minetest-dev |
| 08:29 |
ANAND |
How does one check if a v3f is null? |
| 08:42 |
|
fwhcat joined #minetest-dev |
| 08:52 |
|
Beton joined #minetest-dev |
| 09:26 |
ANAND |
Hmm, checking for null isn't even necessary in my case, as the v3f is always defined, lol |
| 09:30 |
|
ensonic joined #minetest-dev |
| 09:37 |
|
Krock joined #minetest-dev |
| 09:39 |
|
kaeza joined #minetest-dev |
| 10:02 |
|
proller joined #minetest-dev |
| 11:18 |
|
Fixer joined #minetest-dev |
| 11:22 |
|
Wuzzy joined #minetest-dev |
| 12:32 |
|
oil_boi_minetest joined #minetest-dev |
| 13:04 |
nerzhul |
we never use heap for such objects |
| 13:50 |
|
fwhcat joined #minetest-dev |
| 13:50 |
|
Ritchie joined #minetest-dev |
| 15:54 |
|
fwhcat joined #minetest-dev |
| 16:01 |
|
Ruslan1 joined #minetest-dev |
| 16:52 |
Krock |
nerzhul: please re-review #8261 sometime, the changes were made |
| 16:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/8261 -- Use player as starting point instead of camera when pointing node by srifqi |
| 16:53 |
Krock |
I'd also like to have bugfix #8246 merged soon. Any volunteers for a quick review and/or test? |
| 16:53 |
ShadowBot |
https://github.com/minetest/minetest/issues/8246 -- Correct the checkbox selection box position by SmallJoker |
| 17:10 |
|
Ritchie joined #minetest-dev |
| 17:22 |
|
kaeza joined #minetest-dev |
| 17:55 |
|
kaeza joined #minetest-dev |
| 18:16 |
|
Lone-Star joined #minetest-dev |
| 18:28 |
|
fwhcat joined #minetest-dev |
| 18:35 |
nerzhul |
Krock: approved |
| 18:39 |
|
T4im joined #minetest-dev |
| 18:39 |
p_gimeno |
I have that PR installed locally in my private branch. No issues so far. |
| 20:07 |
|
paramat joined #minetest-dev |
| 20:09 |
paramat |
sfan5 are you still +1 for #8125 ? it has changed since your review |
| 20:09 |
ShadowBot |
https://github.com/minetest/minetest/issues/8125 -- WIP: Network performance by osjc |
| 20:11 |
sfan5 |
yes |
| 20:21 |
|
proller joined #minetest-dev |
| 20:32 |
paramat |
ok will merge soon |
| 20:40 |
|
Lone-Star joined #minetest-dev |
| 20:52 |
|
Lone-Star joined #minetest-dev |
| 20:54 |
paramat |
merging that |
| 21:01 |
paramat |
for #8455 which has a commit by pgimeno and a commit by me, is there a way to merge using the github button without squashing? |
| 21:01 |
ShadowBot |
https://github.com/minetest/minetest/issues/8455 -- Fix regression in automatic_face_movement_max_rotation_per_sec by paramat |
| 21:02 |
paramat |
if not i can merge those the old way without squashing |
| 21:02 |
p_gimeno |
just rebase would do |
| 21:03 |
rubenwardy |
do you need to be credited for code style changes? |
| 21:03 |
rubenwardy |
but yeah - drop down and choose the rebase option |
| 21:08 |
paramat |
ok |
| 21:08 |
paramat |
i don't need to be credited, thought the author would prefer separation of commits |
| 21:11 |
p_gimeno |
it's not really necessary in this case |
| 21:15 |
paramat |
ok. if i 'merge and rebase' will it preserve you as the author? |
| 21:15 |
paramat |
sorry |
| 21:15 |
paramat |
'squash and merge' |
| 21:16 |
p_gimeno |
I think it takes the author of the first commit |
| 21:17 |
p_gimeno |
it wouldn't be a big deal if it gets merged with another name, anyway |
| 21:18 |
paramat |
i'll use 'rebase' |
| 21:19 |
p_gimeno |
hm, yeah, now that I remember, it took pauloue's author when he submitted a PR in my name |
| 21:22 |
paramat |
done |
| 21:29 |
p_gimeno |
thanks |
| 22:05 |
|
Fixer joined #minetest-dev |
| 23:15 |
|
oil_boi_minetest joined #minetest-dev |
| 23:30 |
|
Ruslan1 joined #minetest-dev |
| 23:30 |
|
fwhcat joined #minetest-dev |
