Time Nick Message 05:19 ANAND Somewhat small anti-cheat PR: #8471 05:19 ShadowBot https://github.com/minetest/minetest/issues/8471 -- Anti-cheat: Add line-of-sight check for player interactions by ClobberXD 08:29 ANAND How does one check if a v3f is null? 09:26 ANAND Hmm, checking for null isn't even necessary in my case, as the v3f is always defined, lol 13:04 nerzhul we never use heap for such objects 16:52 Krock nerzhul: please re-review #8261 sometime, the changes were made 16:52 ShadowBot https://github.com/minetest/minetest/issues/8261 -- Use player as starting point instead of camera when pointing node by srifqi 16:53 Krock I'd also like to have bugfix #8246 merged soon. Any volunteers for a quick review and/or test? 16:53 ShadowBot https://github.com/minetest/minetest/issues/8246 -- Correct the checkbox selection box position by SmallJoker 18:35 nerzhul Krock: approved 18:39 p_gimeno I have that PR installed locally in my private branch. No issues so far. 20:09 paramat sfan5 are you still +1 for #8125 ? it has changed since your review 20:09 ShadowBot https://github.com/minetest/minetest/issues/8125 -- WIP: Network performance by osjc 20:11 sfan5 yes 20:32 paramat ok will merge soon 20:54 paramat merging that 21:01 paramat for #8455 which has a commit by pgimeno and a commit by me, is there a way to merge using the github button without squashing? 21:01 ShadowBot https://github.com/minetest/minetest/issues/8455 -- Fix regression in automatic_face_movement_max_rotation_per_sec by paramat 21:02 paramat if not i can merge those the old way without squashing 21:02 p_gimeno just rebase would do 21:03 rubenwardy do you need to be credited for code style changes? 21:03 rubenwardy but yeah - drop down and choose the rebase option 21:08 paramat ok 21:08 paramat i don't need to be credited, thought the author would prefer separation of commits 21:11 p_gimeno it's not really necessary in this case 21:15 paramat ok. if i 'merge and rebase' will it preserve you as the author? 21:15 paramat sorry 21:15 paramat 'squash and merge' 21:16 p_gimeno I think it takes the author of the first commit 21:17 p_gimeno it wouldn't be a big deal if it gets merged with another name, anyway 21:18 paramat i'll use 'rebase' 21:19 p_gimeno hm, yeah, now that I remember, it took pauloue's author when he submitted a PR in my name 21:22 paramat done 21:29 p_gimeno thanks