Minetest logo

IRC log for #minetest-dev, 2019-04-09

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:11 Miner_48er joined #minetest-dev
00:30 ANAND joined #minetest-dev
02:15 paramat joined #minetest-dev
02:20 paramat merging #8458
02:20 ShadowBot https://github.com/minetest/minetest/issues/8458 -- Nodedef 'drop' documentation: Improve, add tool filtering by paramat
02:22 paramat good to see this sudden explosion of code frequency https://github.com/minetest/minetest/graphs/code-frequency =)
04:33 diemartin joined #minetest-dev
06:23 Unarelith joined #minetest-dev
06:52 Beton joined #minetest-dev
06:59 ensonic joined #minetest-dev
07:24 Darcidride joined #minetest-dev
07:25 proller joined #minetest-dev
08:12 karamel joined #minetest-dev
09:31 Fixer joined #minetest-dev
09:41 proller joined #minetest-dev
09:51 p_gimeno Regarding #8456, I've looked into the automatic_rotation code. We could have a new property, e.g. automatic_rel_rot, that specifies a rotation that is always relative to the object. For best effect, it should also work for attached objects, so it allows e.g. a plane with propellers. It's unclear what drawtypes it should apply to; probably only mesh.
09:51 ShadowBot https://github.com/minetest/minetest/issues/8456 -- Support configuring rotation axis for `automatic_rotate`
09:52 p_gimeno ^ @ANAND
09:52 p_gimeno Best of it, it can be implemented with minimal extra processing time, by just altering the rotation of the child node.
09:56 p_gimeno The idea is that it will rotate only on Y, so you design the model so that it should spin on a vertical axis (e.g. the blades of a propeller would be horizontal). Then you use set_rotation() to orient them as desired, e.g. 90° on X would make it rotate like a propeller blade.
09:59 p_gimeno Or for a globe, you rotate it by the axis inclination (23.5 degrees for the real Earth) over either the X or Z axis.
10:00 p_gimeno In fact, automatic_rotation should have been intrinsic. But it's probably too late for that.
10:05 ANAND Interesting
10:05 ANAND > automatic_rotation should have been intrinsic. But it's probably too late for that.
10:05 ANAND Yea, true :P
10:06 p_gimeno unless, well, it's regarded as a bug and fixed in 5.0.2 or 5.1
10:06 ANAND haha
10:07 ANAND There's no real reason for it to be there, tbh, since we have set_rotation
10:07 p_gimeno it would not be too much off the mark... I mean, vertical automatic_rotate does not make sense for models that use set_rotation
10:08 p_gimeno oh it has a reason, for sure
10:08 ANAND Convenience?
10:08 p_gimeno it's reasonable to have objects spin without the server having to send an update every frame to make it spin
10:09 ANAND Oh, I didn't know of that, nice!
10:09 p_gimeno however, making it spin only in the yaw direction is the problem, because when you use set_rotation, it will still spin over a vertical axis
10:10 ANAND o_O
10:10 ANAND Argh, rotations are confusing...
10:10 p_gimeno yeah, and that's what is not useful and can be regarded as a bug, and I don't think is too much of a stretch
10:10 ANAND I thought the axis of `automatic_rotate` was local to the object
10:11 p_gimeno if it was, I would have voted no to the issue because the functionality is already there
10:11 ANAND True
10:12 ANAND I think we should just modify it to work with local axes, and call it a day
10:13 ANAND Basically what you suggested, but without the extra property
10:13 p_gimeno there's a problem though, currently automatic_rotate does not work for attached objects, meaning it's not possible to make e.g. the blades of a helicopter
10:13 ANAND Argh, bug it is ._.
10:14 p_gimeno unfortunately, there may be mods that rely on it not working for attached objects
10:15 p_gimeno so I'm not sure if changing that is feasible
10:25 p_gimeno maybe we could add a new property automatic_rotate_attached which specifies the automatic rotation while attached
10:25 p_gimeno so, while unattached the rotation speed would be determined by automatic_rotation, and while attached, by automatic_rotation_attached
10:26 p_gimeno s/automatic_rotation/automatic_rotate/g
10:28 ANAND Good idea
10:37 Ruslan1 joined #minetest-dev
10:40 Ruslan1 joined #minetest-dev
10:55 w_laenger joined #minetest-dev
10:58 Ruslan1 joined #minetest-dev
10:59 rubenwardy <w_laenger> I've made a PR to give shaped craft recipes more priority than shapeless ones #8445
10:59 ShadowBot https://github.com/minetest/minetest/issues/8445 -- Prioritise craft recipes by HybridDog
11:00 rubenwardy from #minetest
11:02 w_laenger left #minetest-dev
11:06 ANAND Trivial bug-fix PR: #8462
11:06 ShadowBot https://github.com/minetest/minetest/issues/8462 -- PlayerSAO::punch - Abort if punched player is already dead by ClobberXD
11:06 calcul0n_ joined #minetest-dev
11:28 p_gimeno ANAND: https://notabug.org/pgimeno/minetest/commit/1b93e5dfd0b46513fc63721c45486af3a2528880 makes automatic_rotate relative
11:33 proller joined #minetest-dev
11:33 ANAND Yay!
11:36 kaeza joined #minetest-dev
11:38 p_gimeno https://notabug.org/pgimeno/Gists/src/minetest--mod-test-auto-rot/init.lua - test mod
11:39 p_gimeno use /entitytest to spawn a test entity
11:49 p_gimeno please consider #8046 for the next round of bugfixes, I came up with basically the same patch too: https://github.com/stujones11/wield3d/issues/2#issuecomment-459990306
11:49 ShadowBot https://github.com/minetest/minetest/issues/8046 -- Fix player's attachments not updating visibility correctly by PiezoU005F
11:51 p_gimeno sorry, #8342
11:51 ShadowBot https://github.com/minetest/minetest/issues/8342 -- Correctly set visibility of local player's attached objects by PiezoU005F
11:57 fluxflux joined #minetest-dev
12:02 thePalindrome joined #minetest-dev
12:10 p_gimeno by the way, the auto-rot patch is easy to modify if attached rotation is introduced in future, just change the 0.0f
12:14 ANAND Awesome, I'll test this in a bit
12:53 proller joined #minetest-dev
13:40 kaeza joined #minetest-dev
14:13 p_gimeno https://notabug.org/pgimeno/minetest/commit/caa6802b8403da78f2d81f094edbe1985efe4864 fixes rotation direction to match previous behaviour
14:31 Ruslan1 joined #minetest-dev
14:43 ensonic joined #minetest-dev
15:00 DI3HARD139 joined #minetest-dev
15:04 Wuzzy joined #minetest-dev
15:24 proller joined #minetest-dev
15:32 VanessaE joined #minetest-dev
15:52 VanessaE joined #minetest-dev
15:52 VanessaE joined #minetest-dev
15:52 VanessaE joined #minetest-dev
15:56 Lia joined #minetest-dev
16:01 Cornelia joined #minetest-dev
16:14 Lia joined #minetest-dev
16:26 proller joined #minetest-dev
16:39 johnnyjoy joined #minetest-dev
16:51 p_gimeno updated commit message https://notabug.org/pgimeno/minetest/commit/22c6c69b0607b2473feaeca52114656aade960b3
16:55 rubenwardy https://notabug.org/pgimeno/minetest/pulls/4 LGTM
16:57 proller joined #minetest-dev
17:11 p_gimeno woot, thanks
17:15 p_gimeno for those interested in the automatic_rotate patch, please grab the latest from https://notabug.org/pgimeno/minetest/pulls/5
17:39 Unarelith joined #minetest-dev
17:52 kaeza joined #minetest-dev
18:05 proller joined #minetest-dev
18:22 ensonic joined #minetest-dev
19:03 Ruslan1 joined #minetest-dev
19:41 Ruslan1 joined #minetest-dev
19:55 proller joined #minetest-dev
20:00 ssieb joined #minetest-dev
20:45 Ruslan1_ joined #minetest-dev
20:52 ssieb joined #minetest-dev
22:24 Fixer joined #minetest-dev
22:51 Wuzzy https://sun1-17.userapi.com/c847217/v847217230/1d9674/c8OwS23F5II.jpg
22:54 rubenwardy I suggest we adopt this as our code style, would be an improvement
22:56 VanessaE heh
22:57 p_gimeno 👍
23:16 Ruslan1_ joined #minetest-dev
23:18 Ruslan1 joined #minetest-dev
23:32 Cornelia joined #minetest-dev
23:45 p_gimeno @paramat https://notabug.org/pgimeno/minetest/pulls/4 updated
23:51 benrob0329 joined #minetest-dev
23:52 benrob0329 !tell paramat I think we need some formal CoC for contributors if you're going to be giving out warnings on Github
23:52 ShadowBot benrob0329: O.K.
23:58 ssieb joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext