Minetest logo

IRC log for #minetest-dev, 2016-07-26

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:05 cheapie joined #minetest-dev
00:09 troller joined #minetest-dev
00:13 paramat hmmmm sofar what's your opinion of this simple PR #4345 ?
00:13 ShadowBot https://github.com/minetest/minetest/issues/4345 -- Add core.MAP_BLOCKSIZE constant. by t4im
00:57 Grandolf joined #minetest-dev
00:57 ssieb joined #minetest-dev
00:58 Grandolf joined #minetest-dev
01:06 paramat hmmmm #4127 has been updated, perhaps addressing your issues
01:06 ShadowBot https://github.com/minetest/minetest/issues/4127 -- Avoid calling DiePlayer more than once by 4Evergreen4
01:29 halt_ joined #minetest-dev
01:30 halt_ joined #minetest-dev
01:30 halt_ joined #minetest-dev
01:31 sloanonhexchat joined #minetest-dev
01:57 whitephoenix joined #minetest-dev
02:13 paramat joined #minetest-dev
02:14 Miner_48er joined #minetest-dev
02:49 nolsen paramat: What does minetest use to hash passwords in auth.txt?
02:49 nolsen I accidently pasted my line in auth.txt and not sure if that is really hashed >.>
02:49 nolsen Damn copy and paste.
02:49 nolsen my auth.txt line in a channel/
02:50 paramat i don't know, sorry
03:10 Sand_Minetest joined #minetest-dev
03:11 paramat merging #4296 #4345
03:11 ShadowBot https://github.com/minetest/minetest/issues/4296 -- Builtin: Fix check for a player object in core.check_player_privs by t4im
03:11 ShadowBot https://github.com/minetest/minetest/issues/4345 -- Add core.MAP_BLOCKSIZE constant. by t4im
03:13 Sand_Minetest joined #minetest-dev
03:22 paramat merged
03:30 DI3HARD139 joined #minetest-dev
03:38 paramat left #minetest-dev
04:22 ptv joined #minetest-dev
04:47 Miner_48er joined #minetest-dev
04:50 Miner_48er joined #minetest-dev
04:51 Miner_48er joined #minetest-dev
05:05 Hunterz joined #minetest-dev
05:36 nrzkt joined #minetest-dev
06:01 RichardTheTurd joined #minetest-dev
06:12 SloanOnLinux joined #minetest-dev
07:05 jin_xi joined #minetest-dev
07:13 Icedream joined #minetest-dev
07:28 Krock joined #minetest-dev
07:30 Icedream joined #minetest-dev
07:42 edgrey joined #minetest-dev
07:44 nrzkt joined #minetest-dev
08:09 TheReaperKing joined #minetest-dev
10:03 Amaz joined #minetest-dev
10:31 SloanOnLinux joined #minetest-dev
10:51 Sockbat joined #minetest-dev
10:59 its100best joined #minetest-dev
11:00 Fixer joined #minetest-dev
12:03 Zeno` joined #minetest-dev
12:19 proller joined #minetest-dev
12:43 rubenwardy joined #minetest-dev
13:09 Sockbat joined #minetest-dev
13:25 burli joined #minetest-dev
13:29 Megaf joined #minetest-dev
13:41 STHGOM joined #minetest-dev
14:05 Darcidride joined #minetest-dev
14:12 Amaz joined #minetest-dev
14:24 blaze joined #minetest-dev
14:25 Sockbat joined #minetest-dev
14:28 Zeno` joined #minetest-dev
14:47 proller joined #minetest-dev
14:49 whitephoenix joined #minetest-dev
14:50 hmmmm joined #minetest-dev
15:07 Ashley_ joined #minetest-dev
15:11 T4im joined #minetest-dev
15:11 KaadmY joined #minetest-dev
15:14 Guest65943 joined #minetest-dev
15:25 SloanOnLinux joined #minetest-dev
15:43 DI3HARD139 joined #minetest-dev
15:53 ElectronLibre joined #minetest-dev
16:03 Hunterz joined #minetest-dev
16:15 halt_ joined #minetest-dev
16:15 Grandolf joined #minetest-dev
16:24 whitephoenix joined #minetest-dev
16:25 Sand_Minetest joined #minetest-dev
16:36 xunto joined #minetest-dev
17:06 paramat joined #minetest-dev
17:13 paramat nore sfan5 sofar rubenwardy T4im game#1208 is now complete and tested, please can anyone review?
17:13 ShadowBot https://github.com/minetest​/minetest_game/issues/1208 -- Default: Prevent placing sapling if grown tree intersects protection by paramat
17:20 Krock there's a vector.round function but that doesn't matter the functionality
17:20 Krock s/matter/affect/
17:22 paramat instead of math.floor(xf + 0.5)?
17:23 paramat yeah i see it
17:23 paramat ok i'll use that for shorter code
17:25 Krock another thing that I'm not sure about are the new lines between the node definition keys
17:25 paramat but then it might not be much shorter as the vector would need to be created first
17:25 Krock yes, that's true :/
17:26 paramat newlines for the functions in node def, will check other nodes
17:27 paramat newlines are common in node def for functions, i'll keep those
17:27 Krock Oh. Maybe I haven't looked enough into the other MTG code. I'm used to not make any new/empty lines
17:28 ssieb joined #minetest-dev
17:29 paramat i might close game#1218
17:29 ShadowBot https://github.com/minetest​/minetest_game/issues/1218 -- Hide Nyan Cat and Nyan Cat Rainbow from creative inventory
17:30 paramat seems obvious
17:31 paramat i'll merge game#965 game#1219 later, hopefully also game 1208
17:32 ShadowBot https://github.com/minetes​t/minetest_game/issues/965 -- Ability to Disable bones, drop items or keep inventory. by tenplus1
17:32 ShadowBot https://github.com/minetest​/minetest_game/issues/1219 -- Replace deprecated get_look_yaw/set_look_yaw by SmallJoker
17:32 paramat closed game 1218
17:34 Krock squashing 1219
17:34 Krock * 965 I mean
17:34 paramat thanks
17:53 Hijiri where is the global environment constructed?
17:54 T4im Krock: that would also prevent moving the floor out of the inner loop; not really necessary to recalculate z each time x changes there
17:55 Krock Hijiri, check out the builtin directory
17:55 T4im Hijiri: you mean for the mods?
17:57 nrzkt joined #minetest-dev
17:59 Hijiri T4im: yes
17:59 Hijiri Krock: alright
18:00 Amaz joined #minetest-dev
18:00 Krock paramat, are you sure that it's a good idea to leave the 'd' vector a decimal number in 'default.intersects_protection'? Using whole numbers would 1) save further rounding in the loop and 2) not checking a node two times
18:02 paramat it has to be a decimal due to how this works
18:02 paramat the loop steps are floats
18:04 Krock alright
18:09 paramat #4360 looks good and is simple, can any dev +1?
18:09 ShadowBot https://github.com/minetest/minetest/issues/4360 -- Horizontally flip player.png by SmallJoker
18:31 Void7 joined #minetest-dev
19:21 paramat T4im if we asked you sometime, would you be happy to be a mtgame dev?
19:26 T4im not sure yet how much time I'll be able to spend the coming months, but I gladly help out, when I can
19:27 paramat your help is very much appreciated, most devs are absent currently in engine and game
19:31 Hijiri does the C API for Lua contain a function for loading a module? Or is it normal to just find the standard "require" and put it on the stack to call?
19:32 Hijiri I am thinking of implementing #4337 since nobody has brought up any issues with it
19:32 ShadowBot https://github.com/minetest/minetest/issues/4337 -- Some kind of library-whitelisting configuration option
19:32 Hijiri would I be able to do lua_rawgeti(L, LUA_REGISTRYINDEX, CUSTOM_RIDX_GLOBALS_BACKUP); within sl_g_require?
19:35 Void7 joined #minetest-dev
19:38 Hijiri oh, I see push_original, I could use that
19:43 T4im how do you enforce mod_security if you allow the original require?
19:44 Fixer joined #minetest-dev
19:44 T4im I think shadowninja was generally ok with a require being there, but no one spend time in implementing a safe version, that would not load c modules yet still function like the real thing
19:46 paramat btw being a core dev will not commit you to any amount of work hours, some here disappear for months or work a few minutes a week, no problem
19:46 T4im :)
19:48 T4im Hijiri: https://github.com/minetest/minetes​t/pull/1606#issuecomment-110013854
19:53 sapier joined #minetest-dev
20:22 ElectronLibre joined #minetest-dev
20:24 celeron55 what the hell is going on
20:24 * VanessaE looks at celeron55
20:24 celeron55 i am getting some kind of "Hey there, we’re just writing to let you know that you’ve been automatically subscribed to a repository on GitHub." emails out of nowhere
20:25 sapier thought github was working on the email spaming issue in order to IMPROVE it :-) guess not everything works
20:26 celeron55 and the subscription configuration links that are contained in these emails don't work
20:26 sapier ok that sounds more like real spamers than github
20:26 T4im https://github.com/settings/notifications ->  "When you’re given push access to a repository, automatically receive notifications for it."
20:26 celeron55 and even then, my global github notification settings disallow any email notifications
20:27 T4im phishing maybe?
20:27 celeron55 wait, so this is about random people giving me push access to repositories?
20:27 sapier are those mails really form github or only someone claiming to be
20:27 T4im could be, happened to me in the past twice
20:27 VanessaE celeron55: yep, I got bunches of them from minetest-mods also
20:28 celeron55 why is github sending me emails about it, i couldn't care less
20:28 VanessaE after I transferred my repos to that sofar and hence that group, github sorta had to "reset" with each one
20:28 VanessaE s/to that/to /
20:28 T4im well if the links don't work, you might want to double check they aren't phising links though
20:29 T4im after all finding out your email over github and faking emails from github can't be that hard automatically
20:29 VanessaE it isn't. git clone; git log; scrape.
20:30 celeron55 well they seem to be fine and gmail isn't detecting them as phishing which is usually a fairly good indicator of them not being fake
20:31 celeron55 i think i'll get rid of these if just disable the auto-watch thing
20:31 celeron55 which i'm doing now and now i'll shut up
20:32 Void7 joined #minetest-dev
20:34 VargaD joined #minetest-dev
20:52 Krock Too bad. The silence is back
20:53 Krock I unchecked the two "Email" boxes and haven't got a single mail from github since I did that
20:54 Krock oh wait. there's still a notification about the push access
21:00 troller joined #minetest-dev
21:07 jin_xi joined #minetest-dev
21:09 T4im cool, some guy wants to measure EEG signals from people playing minetest and correlate it with positions. :o
21:10 * T4im wonders where that is heading
21:14 Hijiri T4im: my proposal puts the burden of determining what libraries are safe on the minetest user / server owner
21:14 Hijiri they just whitelist the libraries they want to allow
21:14 T4im Yea, but how do you enforce the whitelist?
21:15 Hijiri there is already a custom require function, I can change it to check if the argument is in the whitelist and call the original require on it
21:15 Hijiri (the current one just errors if you try to call it)
21:15 T4im I don't think anyone prevents package.* to be modified though, so if you reuse the existing require(), it might be convinced to load the wrong thing
21:15 Hijiri I thought package.* wasn't in the secure environment
21:16 Fixer paramat: new bone block = year of the roads in minetest
21:16 Hijiri actually I see package.searchpath and path are whitelisted
21:17 Hijiri so that is a problem, yeah
21:17 T4im cpath, too
21:18 Hijiri maybe I should just make a mod whose purpose is to export bit
21:19 T4im and then a serverowner could just whitelist that mod, yea, that actually seems like a pretty easy solution :D
21:19 Hijiri It's annoying to need to make a mod for each library though
21:19 T4im alternatively you'd have to implement a safe version of require()
21:20 T4im one that checks package.* itself and decides what to do with that
21:21 Hijiri Do you think it's safe enough to check if a search path is a subdirectory of the mod folder?
21:21 Hijiri maybe not, could be a subgame or modpack
21:21 Hijiri or just whether it's a subdirectory of any minetest directory
21:22 T4im you mean like of worldpath, where even untrusted mods might write to? ;)
21:22 Hijiri yeah
21:22 Hijiri I didn't think of worldpath though
21:27 Hijiri Why is package.* exposed in the secure environment?
21:27 Void7 joined #minetest-dev
21:32 T4im hm, Tesseract ^^?
21:33 T4im i could only guess :/
21:45 Player_2 joined #minetest-dev
22:03 DI3HARD139 joined #minetest-dev
22:09 GnomeKris joined #minetest-dev
22:31 paramat joined #minetest-dev
22:39 GnomeKris joined #minetest-dev
22:50 STHGOM joined #minetest-dev
22:56 sapier left #minetest-dev
23:04 paramat game PR 1208 is updated and tested
23:14 yang2003 joined #minetest-dev
23:52 whitephoenix joined #minetest-dev
23:58 TheReaperKing joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext