Minetest logo

IRC log for #minetest-dev, 2016-04-23

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:06 troller joined #minetest-dev
00:42 est31 joined #minetest-dev
00:44 est31 hmmmm, additionally to your comment on https://github.com/minetest/minetest/commi​t/c350cfb50b3bf81c075a80307adb15393ea773d0
00:44 est31 There is already a lock used inside that file
00:44 est31 it only needs to be extended to that methods
00:45 est31 or idk, we only lock the buffers, and then remove the lock on the thread
00:45 bugzapper joined #minetest-dev
01:07 ssieb joined #minetest-dev
01:33 jhcole here is my lbm solution https://github.com/FozLand/fozland if anyone was interested.
02:13 yang2003 joined #minetest-dev
02:17 Void7_ joined #minetest-dev
02:32 ShadowNinja O.K., I've got 21 open pull requests.  I've got to start merging or closing these things.
02:43 misprint joined #minetest-dev
03:19 nore ~tell est31 I am actually fine with using locks, I only was worried about how much it would affect performance, but hmmm said since then that it shouldn't be a problem; my commit message is also unfortunate since I wanted to say it makes the race condition non-fatal rather than avoids it; so if you think that should be changed, let me know and I will make a new commit
03:19 ShadowBot nore: O.K.
03:21 jhcole joined #minetest-dev
04:23 jhcole left #minetest-dev
05:09 lag01 joined #minetest-dev
05:16 Player_2 joined #minetest-dev
05:16 sofar oh goody I got my particle collision remove problem solved
05:17 sofar been a busy week, felt like I haven't done that much
05:17 sofar of course, I can honestly say work has been a bit of a drama this week
05:43 yang2003 joined #minetest-dev
05:46 Hunterz joined #minetest-dev
05:50 lag01 joined #minetest-dev
06:26 Zeno` joined #minetest-dev
06:28 blaze joined #minetest-dev
06:57 celeron55 joined #minetest-dev
07:29 sofar why is entity.get_staticdata called as the entity is being spawned but before activated?
07:30 sofar the on_activate() call is supposed to initialize staticdata stuff, now it's asking to save stuff before it's initialized by the mod?
07:36 sofar nvm
07:39 Zeno` glad I could help
07:43 jin_xi joined #minetest-dev
07:56 Krock joined #minetest-dev
08:56 proller joined #minetest-dev
08:59 MillersMan joined #minetest-dev
09:26 paramat joined #minetest-dev
09:41 damiel joined #minetest-dev
09:48 paramat *** freeze tomorrow (sunday) if possible ***
10:06 Zeno` joined #minetest-dev
10:09 sfan5 paramat: 2 weeks, right?
10:09 damiel joined #minetest-dev
10:09 paramat nore sfan5 i'll merge game#1050 as trivial unless objections
10:09 ShadowBot https://github.com/minetest​/minetest_game/issues/1050 -- Farming: Add quiet sounds to seeds by paramat
10:09 paramat yes 2
10:09 Topic for #minetest-dev is now Minetest core development and maintenance. Feature freeze (2 weeks): 2016-04-24. Last release: 0.4.13, Aug 20 2015. Chit-chat goes to #minetest. Consider this instead of /msg celeron55. http://irc.minetest.net/minetest-dev/ http://dev.minetest.net/
10:10 paramat thanks
10:10 Zeno` hi sfan5, paramat
10:11 paramat O/
10:11 Zeno` #4017 is pretty trivial also
10:11 ShadowBot https://github.com/minetest/minetest/issues/4017 -- Fix bug that was leading to oversized tooltips containing multiline text by hunterdelyx1
10:12 Zeno` I edited the title to make it a bit more readable... probably have to update that in the patch before committing
10:13 Zeno` I checked the irrlicht documentation (useless) and source code and the fix is correct
10:13 paramat yes that can be merged
10:14 paramat i'll change the commit message if i do
10:15 nore paramat: can we merge #3948 please?
10:15 ShadowBot https://github.com/minetest/minetest/issues/3948 -- Escape more strings: formspecs, item descriptions, infotexts... by Ekdohibs
10:16 Zeno` If you haven't done it in a little bit I can do it in 30 minutes or so... just checking something on windows and I don't really have git function well
10:16 nore All issues about it were addressed
10:16 Zeno` I mean I do... I just don't have all my repos up-to-date hehe
10:16 nore and it should be merged to avoid \v being used
10:17 Zeno` I think so
10:17 paramat nore i support it going in but am rather unqualified to review, maybe i'll do a code style check
10:17 nore thanks
10:18 paramat also i'll menyion it to hmmmm later
10:18 paramat (mention)
10:18 Zeno` oh it even has unit tests :) nice
10:18 Zeno` I checked it 2 days ago.. has much changed since then?
10:19 Zeno` nore: "Should be str_split_escaped then." (by ShadowNinja)
10:19 nore Zeno`: well, I did not touch any of that code
10:20 paramat nore sfan5 in game only game#1039 needs review, i'll test and review it later
10:20 ShadowBot https://github.com/minetest​/minetest_game/issues/1039 -- Tnt+: Changes for TNT mod after #862 by sofar
10:20 Zeno` nore, ah I see
10:20 nore But I could change the name if needed
10:20 Zeno` Well, I dunno if it *needs* changing at this time, but maybe just put a note there so the comment is addressed
10:21 nore however, I'm going to be away from my computer for a week: /
10:21 Zeno` nore, what's changed in the last 2 days?
10:21 Zeno` I'
10:21 Zeno` I'll review again in about 30 minutes though
10:21 nore ^ *** phone autocorrect messing with my spaces
10:22 nore Zeno`: only the name of the function
10:22 paramat : / <- long face
10:22 Zeno` oh is that all?
10:22 nore Yep
10:22 Zeno` I hardly need to re-review in that case, but I will
10:23 nore Ah, and the unittest that I removed was readded
10:24 Zeno` I have a problem. I forget now why I rebooted into Windows
10:25 Zeno` oh, that's right... brb
10:30 Zeno` joined #minetest-dev
10:36 Zeno` Just checked the last two commits on #3948 just to be paranoid
10:36 ShadowBot https://github.com/minetest/minetest/issues/3948 -- Escape more strings: formspecs, item descriptions, infotexts... by Ekdohibs
10:36 Zeno` is fine with me
10:37 paramat I'll ask hmmmm to review it later
10:37 Zeno` I'd already reviewed everything else 2 days ago
10:37 Zeno` cool
10:37 Zeno` we don't really need hmmmm to approve, but *shrug*
10:37 Zeno` maybe someone else can review before he gets here
10:37 Zeno` he'll probably be here soon anyway
10:38 paramat oh of course
10:39 paramat well just so he's happy with response to his comments
10:40 Zeno` yep
10:40 paramat that will leave just #4016
10:40 ShadowBot https://github.com/minetest/minetest/issues/4016 -- tile.cpp: Automatically resize overlaying texture to base dimensions by SmallJoker
10:41 Zeno` If you could do a quick style review that'd be helpful also (I'm not super-super-super-pedantic in my "style" checks... e.g. I'm not gonna say I prefer i++ or something else lol). It looks fine to me from that point of view also
10:41 paramat ok
10:47 Zeno` hey
10:47 Zeno` if I have commented on a PR and changes happen since I commented, github tells me!
10:47 Zeno` I should comment more often
10:47 Zeno` that's like magic!
10:48 Zeno` I wonder when they added that
11:13 DFeniks joined #minetest-dev
11:13 Zeno` 4017 merged
11:21 Darcidride joined #minetest-dev
11:26 Zeno` lol
11:26 Zeno` I didn't fix the commit message very well. Oh well
11:34 Krock Zeno`, sohuld I leave the square-check instead?
11:35 Zeno` Krock, I don't think so. And I'm also not sure that preserving aspect ratio is critical (I just meant it as a question)
11:36 Zeno` you can scale based on the longest side... but I don't know if that's required or not for the usage
11:36 Krock I thought about it too but without the check it will, like kahrl said, reduce the edge cases
11:36 Zeno` scaling based on longest side/edge may make things worse, I don't know
11:36 Krock for the longest side it could be that both textures must be resized at once
11:36 Zeno` yeah
11:37 Krock I think the current way is kept simple and shouldn't be extended
11:37 Zeno` I can't see it really being an issue
11:37 Zeno` if it is then I suppose people will just have to make their textures square
11:37 Fixer joined #minetest-dev
11:38 Krock right
11:38 Zeno` (if they want to avoid aspect ratio changing)
11:38 Zeno` so it's pretty minor
11:38 Krock at the beginning I wasn't sure if this way of pointer handling is correct but it works fine :)
11:39 Zeno` yep
12:54 turtleman joined #minetest-dev
12:55 jin_xi joined #minetest-dev
13:02 kaadmy joined #minetest-dev
13:20 paramat left #minetest-dev
13:56 jin_xi joined #minetest-dev
14:42 Void7_ joined #minetest-dev
14:47 hmmmm joined #minetest-dev
15:45 Void7_ joined #minetest-dev
15:48 ElectronLibre joined #minetest-dev
16:20 electrodude512 joined #minetest-dev
16:53 WarrTab joined #minetest-dev
17:10 nore Zeno`: I'm thinking, we shouldn't wait too much before merging #3948
17:10 ShadowBot https://github.com/minetest/minetest/issues/3948 -- Escape more strings: formspecs, item descriptions, infotexts... by Ekdohibs
17:10 nore since freeze is tomorrow...
17:18 davisonio joined #minetest-dev
17:29 Etzos joined #minetest-dev
17:31 Zeno` well, let's merge it now
17:31 Zeno` hmmmm, any comments?
17:31 nore Zeno`: I just fixed the style issue paramat mentionned
17:31 nore gtg now, can I let you merge it please?
17:31 nore (it needs squashing the commits though, sorry :/)
17:32 hmmmm alright looks good to me
17:36 Zeno` nore, can you squash and merge?
17:37 Zeno` I don't want to dealt with the conflict lol
17:37 Zeno` s/dealt/deal
17:37 nore Zeno`: not right now, in a few hours
17:37 nore Is there a conflict?
17:37 Zeno` error: src/guiFormSpecMenu.cpp: patch does not apply
17:37 Zeno` I suppose I can fix it
17:38 nore :/
17:44 Zeno` err
17:44 Zeno` I can't see what the conflict is
17:45 nore Line numbers changed maybe?
17:46 Zeno` maybe I can squash using a previous head and then rebease
17:47 Zeno` yeah that works
17:47 Zeno` just compiling to make sure and then will push
17:52 iangp joined #minetest-dev
17:53 paramat joined #minetest-dev
17:54 paramat i'll merge games 1029 1048 1050 soon, then later the tnt changes if approved
17:55 Zeno` nore, compiled ok... pushing in a sec
17:55 nore Ah, good, thanks :)
17:56 paramat for engine all that's left is PR #4016 and issue #4005
17:56 ShadowBot https://github.com/minetest/minetest/issues/4016 -- tile.cpp: Automatically resize overlaying texture to base dimensions by SmallJoker
17:56 ShadowBot https://github.com/minetest/minetest/issues/4005 -- Minetest.apk build failure
17:56 sofar I'd really like the texture fix
17:56 nore so do I
17:57 sofar it makes a hundred new texture packs available and look so much better
17:57 sofar they still work without it, just ... look a lot better :)
17:57 Zeno` 48939df
17:57 sofar fatal: ambiguous argument '48939df': unknown revision or path not in the working tree.
17:57 Zeno` err
17:57 Zeno` really?
17:57 Zeno` I just pushed it
17:57 sofar I haven't fetched ;P
17:58 Zeno` geez man
17:58 Zeno` are you trying to scare me to death?
17:58 Zeno` lol
17:58 Void7_ joined #minetest-dev
18:01 Fixer why nobody is trying to catch that funny bug with favourites? i'm still afk for some time
18:02 Zeno` Fixer, I can't reproduce it
18:02 Fixer maybe I can add some debug prints to it? if you can, hand me the edit cpp and i will compile with it
18:03 Fixer afk for sure
18:03 Zeno` It's 4AM here, but I can add some debugging stuff in my copy of the repo tomorrow
18:04 Zeno` I'm just wondering if it's an existing bug that has suddenly manifested itself because of kilbith's PR
18:04 Zeno` (like the race condition in logs)
18:05 Zeno` If so then it's a good thing that it finally gets exposed
18:05 Zeno` but it might not be related at all
18:06 Zeno` thanks for closing paramat... I forgot :-o
18:06 paramat heh
18:07 Zeno` I am so used to avoiding the Comment and Close button because I used to accidentally close so many things lol
18:09 davisonio joined #minetest-dev
18:14 Zeno` night all
18:15 paramat O/ and thanks
18:34 Void7_ joined #minetest-dev
18:39 paramat now merging game#1029 going to do this one seperately as the commits need cleaning up
18:39 ShadowBot https://github.com/minetest​/minetest_game/issues/1029 -- Add: New Heart Texture by KevDoy
18:48 ElectronLibre joined #minetest-dev
18:53 blaze joined #minetest-dev
18:53 rubenwardy joined #minetest-dev
19:03 Void7_ joined #minetest-dev
19:03 paramat phew merged
19:03 sofar that was a difficult merge conflict to resolve ;)
19:06 paramat now merging games 1048 1050
19:15 paramat merged
19:20 sofar wow, only one mtg open for 0.4.14
19:20 paramat hope to +1 that later
19:32 electrodude512 joined #minetest-dev
19:32 electrodude512 left #minetest-dev
19:34 Wayward_One I believe #3963 can be closed now, as it has been addressed
19:34 ShadowBot https://github.com/minetest/minetest/issues/3963 -- do not show box when looking to another player
19:34 electrodude512 joined #minetest-dev
19:37 paramat will check
19:40 paramat yeah
19:40 sofar yup, that one can be closed now
19:43 VargaD joined #minetest-dev
19:50 paramat +1 for tnt, sfan5 if possible could you review game#1039 tonight or tomorrow?
19:50 ShadowBot https://github.com/minetest​/minetest_game/issues/1039 -- Tnt+: Changes for TNT mod after #862 by sofar
19:53 jin_xi expiring particle spawners (as used by tnt) still broken. see #2602
19:53 ShadowBot https://github.com/minetest/minetest/issues/2602 -- move particle spawners to env by obneq
20:32 paramat ok will consider
20:35 jin_xi for a small test have your tnt mod print out the ids of its spawners. you will find you only ever see increasing ids
20:37 paramat 2602 might need redoing by someone else (i assume you are not obneq)
20:37 jin_xi yes thats me
20:37 sofar maybe I'll look into it
20:38 sofar no promises ;)
20:38 paramat ah. how essential is it for release?
20:38 jin_xi it is a memory leak and can cause high cpu load
20:38 sofar long standing bug
20:38 sofar I ran into it a while back too
20:39 paramat hm i'll add to milestones
20:39 sofar I added a torch particle. next morning had a hole in my floor where my PC used to be
20:39 jin_xi http://irc.minetest.net/minet​est-dev/2016-04-22#i_4590657
20:40 jin_xi sofar: i like your idea for delete on collide and am glad it works now. hope this gets in sometimes
20:40 paramat perhaps you could rebase the PR?
20:42 jin_xi argh. i suck so bad at git, but will try. but to be perfectly honest i think Zenos comment is valid and i go wtf when i try to understand the code i wrote. it does the right thing though ;)
20:42 jin_xi so maybe it would be better to redo this way
20:42 paramat anyone know if there's an issue for this?
20:43 paramat yes perhaps open a new PR
20:43 paramat rebasing can be difficult
20:54 ElectronLibre joined #minetest-dev
20:56 paramat created a new issue for this
20:58 jin_xi nice. would be good to have a fix in the release
20:58 paramat seems important to me
21:01 Void7_ joined #minetest-dev
21:05 turtleman joined #minetest-dev
21:32 electrodude512 I got a segfault from a allow_metadata_inventory_put that returned nil instead of a number
21:33 electrodude512 after the expected ERROR[Main]: ServerError: Lua: allow_metadata_inventory_put should return a number
21:39 Void7_ joined #minetest-dev
21:59 paramat left #minetest-dev
22:28 Calinou joined #minetest-dev
22:42 est31 joined #minetest-dev
22:43 est31 electrodude512, can you reproduce it? If yes, can you file a bug at github, best with some minimal code that reproduces it?
22:44 est31 or before you do that i should ask which kind of segfault it was
22:44 est31 because there are some lua errors which can be fatal for the server
23:01 yang2003 joined #minetest-dev
23:06 electrodude512 est31: the segfault was in GUIFormSpecMenu::OnEvent(irr::SEvent const&) according to gdb
23:07 electrodude512 I'll file a bug later.  I have a test mod almost ready.
23:07 est31 oh, a client crash
23:07 est31 thats bad
23:07 est31 really, bad
23:33 Fritigern joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext