| Time |
Nick |
Message |
| 00:06 |
|
leat1 joined #minetest-dev |
| 01:39 |
|
Zeno` joined #minetest-dev |
| 01:43 |
|
VanessaE joined #minetest-dev |
| 03:56 |
|
Miner_48er joined #minetest-dev |
| 04:40 |
|
Hunterz joined #minetest-dev |
| 05:16 |
|
selat joined #minetest-dev |
| 05:33 |
|
Tablet_One joined #minetest-dev |
| 06:16 |
|
Megaf_ joined #minetest-dev |
| 06:32 |
hmmmm |
MMMMMMMMMM |
| 06:32 |
hmmmm |
I just noticed I've been using uintXX_t :( |
| 06:46 |
|
Hunterz joined #minetest-dev |
| 07:01 |
|
Player_2 joined #minetest-dev |
| 07:39 |
|
Dartmouth joined #minetest-dev |
| 07:59 |
|
nrzkt joined #minetest-dev |
| 08:02 |
|
Calinou joined #minetest-dev |
| 08:05 |
|
kilbith joined #minetest-dev |
| 08:07 |
|
Calinou joined #minetest-dev |
| 08:12 |
|
VanessaE joined #minetest-dev |
| 08:18 |
|
selat joined #minetest-dev |
| 08:45 |
|
Dartmouth joined #minetest-dev |
| 08:48 |
|
FR^2 joined #minetest-dev |
| 08:54 |
nrzkt |
pushing #2495 now |
| 08:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/2495 -- Save creative_mode and enable_damage setting for each world in world.mt by fz72 |
| 08:57 |
|
blaze joined #minetest-dev |
| 09:04 |
|
rubenwardy joined #minetest-dev |
| 09:04 |
rubenwardy |
Does Minetest use TCP at all? |
| 09:10 |
|
neoascetic joined #minetest-dev |
| 09:14 |
nrzkt |
atm no |
| 09:15 |
nrzkt |
he uses a custom TCP implementation over UDP for reliable packets, but this will change in the future |
| 09:17 |
kilbith |
s/he/it |
| 09:17 |
rubenwardy |
Okay, I thought so |
| 09:17 |
rubenwardy |
s/it/she |
| 09:17 |
rubenwardy |
Programs are obviously shes |
| 09:17 |
rubenwardy |
Like boats |
| 09:18 |
blaze |
who said boats? |
| 09:18 |
blaze |
kancolle fans everywhere |
| 09:20 |
nrzkt |
#2511 guys, if you have comments, sfan5 for example ? users ? |
| 09:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/2511 -- Add a Lua call to do damages / heals by nerzhul |
| 09:23 |
nrzkt |
rubenwardy: "what about change damage and get damage" => what do you mean ? |
| 09:23 |
nrzkt |
the function name can be changed to a better name, no problem. apply_damage could be good |
| 09:24 |
|
cib0 joined #minetest-dev |
| 09:27 |
|
paramat joined #minetest-dev |
| 09:29 |
nrzkt |
paramat ? comments for #2511 ? |
| 09:29 |
ShadowBot |
https://github.com/minetest/minetest/issues/2511 -- Add a Lua call to do damages / heals by nerzhul |
| 09:29 |
* paramat |
looks |
| 09:33 |
paramat |
seems reasonable, but i feel needs input from others, such as sfan5 |
| 09:34 |
paramat |
i will push #2504 soon |
| 09:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/2504 -- Mgv6: Remove addDirtGravelBlobs. Desert stone y >= -32. Remove generateExperimental by paramat |
| 09:34 |
nrzkt |
no problem. This permit to solve many errors. |
| 09:35 |
nrzkt |
wait for the build paramat before push. |
| 09:35 |
paramat |
okay |
| 09:35 |
nrzkt |
sfan5: travis has a problem: https://github.com/minetest/minetest/pull/2504 |
| 09:35 |
nrzkt |
404 not found |
| 09:36 |
paramat |
oh yeah there was an error with travis, should i ignore? |
| 09:36 |
paramat |
it compiles for me |
| 09:36 |
nrzkt |
if freebsd and android pass, linux will pass. |
| 09:36 |
nrzkt |
and your change may pass on windows it's only a code cleanup. Just wait for jenkins :) |
| 09:37 |
nrzkt |
why not use a constant for -32 ? |
| 09:37 |
nrzkt |
this is better than a number without a definition. Can you add it to the mapgen_v6 ? |
| 09:37 |
nrzkt |
i haven't see this thing on the first review |
| 09:39 |
paramat |
i guess ideally it should be calculated from lowest possible sea depth, so calculated from noiseparams |
| 09:42 |
paramat |
or to match mgv5/v7 it should be set to the bottom of the surface chunk |
| 09:42 |
paramat |
that's easier to calculate |
| 09:45 |
nrzkt |
i don't say your value is wrong :) i only suggest to replace -32 by a #define :) |
| 09:49 |
paramat |
ah yes i was about to suggest that, will define it in mapgen_v6.h =) |
| 09:49 |
nrzkt |
thanks |
| 09:51 |
nrzkt |
if you agree with 2511 can you make a comment on github ? |
| 09:52 |
paramat |
sure |
| 09:53 |
nrzkt |
thanks :) |
| 09:53 |
paramat |
i'm a c++ newbie so may occasionally need some advice on good coding practice. appreciated |
| 09:54 |
nrzkt |
no problem, i'm not an expert too, but naming things and comments are helpful for everybody :) |
| 10:02 |
|
MinetestForFun joined #minetest-dev |
| 10:03 |
|
MinetestForFun joined #minetest-dev |
| 10:10 |
paramat |
okay the update has retriggered checks, hopefully this time.. |
| 10:54 |
paramat |
okay now pushing #2504 .. |
| 10:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/2504 -- Mgv6: Remove addDirtGravelBlobs. Desert stone y >= -32. Remove generateExperimental by paramat |
| 10:56 |
nrzkt |
tell me when okay, i will push a spelling fix |
| 10:58 |
paramat |
i will, roughly 5 minutes |
| 10:58 |
nrzkt |
how does minetest_game repo works ? in sync with master or it's different and need retrocompat to be used by many engines ? |
| 10:58 |
nrzkt |
in sync with core* |
| 11:00 |
VanessaE |
it needs to stay mostly in-sync |
| 11:01 |
VanessaE |
but it's a good idea to keep it compat with 0.4.12 |
| 11:01 |
VanessaE |
anything older isn't needed generally |
| 11:03 |
paramat |
push complete |
| 11:04 |
paramat |
it's usually impossible to keep it compatible with latest stable, that would stop progress |
| 11:04 |
VanessaE |
if there's some feature in current dev that _game can use to an obvois, major advantage, I guess it's best to use that |
| 11:04 |
VanessaE |
obvious* |
| 11:04 |
VanessaE |
or if an API feature changes of course. |
| 11:06 |
nrzkt |
okay, then it's simple, core <=> game in sync for a lua api change. It's good for us |
| 11:06 |
nrzkt |
i push the spelling changes now |
| 11:06 |
VanessaE |
spelling changes |
| 11:06 |
VanessaE |
? |
| 11:07 |
nrzkt |
not spells like a wizard :p |
| 11:07 |
nrzkt |
https://github.com/minetest/minetest/commit/8f2e9bfbc2bba03e4bf3c0fcc4d4a36ac0c9569e |
| 11:07 |
VanessaE |
ok |
| 11:10 |
paramat |
VanessaE, can i use your moretrees pine needles texture in a PR for MTGame? the current needles texture is, as you said, too dark |
| 11:11 |
VanessaE |
sure thing |
| 11:11 |
VanessaE |
go for it |
| 11:30 |
paramat |
thanks |
| 11:33 |
Hunterz |
Hi paramat, yours mapgens are very nice. Do you know TerrainControl bukkit plugin/mod? Something similar will be fantastic on the Minetest... |
| 11:34 |
Calinou |
what does that do, Hunterz? |
| 11:34 |
Calinou |
also this is better suited for #minetest |
| 11:35 |
paramat |
thanks, i'll research that |
| 11:35 |
Hunterz |
Calinou: oki, sorry |
| 11:43 |
|
paramat left #minetest-dev |
| 11:47 |
|
cib0 joined #minetest-dev |
| 12:24 |
|
Ritchie joined #minetest-dev |
| 12:32 |
|
guest365 joined #minetest-dev |
| 12:33 |
|
Dartmouth joined #minetest-dev |
| 12:40 |
sfan5 |
nrzkt: how am i supposed to see the travis build for a closed pull? |
| 12:41 |
sfan5 |
nrzkt: nvm, found it; no idea why that 404'd it seems to have fixed itself |
| 12:44 |
nrzkt |
sfan5 the 404 solved itself, maybe :). Strangely every request was a 404 on your server at this moment |
| 12:57 |
|
Dartmouth joined #minetest-dev |
| 12:59 |
|
Tablet_One joined #minetest-dev |
| 13:06 |
|
Zeno` joined #minetest-dev |
| 13:07 |
Zeno` |
Can we agree on what "low priority" is? Or is it already documented somewhere? |
| 13:08 |
Zeno` |
I ask this because lots of things (nearly everything) is given the label low priority, making the label almost useless :/ |
| 13:09 |
nrzkt |
right |
| 13:09 |
Zeno` |
e.g. https://github.com/minetest/minetest/issues/2502 was labeled low priority which I think is rubbish |
| 13:09 |
Zeno` |
sure you can still play the game... but with everything red? |
| 13:10 |
|
OldCoder joined #minetest-dev |
| 13:11 |
nrzkt |
Zeno`, let the android shader alone atm, our priority is to fix regular bugs for other users, there are many PR to comment/merge and many issues to fix |
| 13:12 |
Zeno` |
nrzkt, I know. But the thing is... everything is given the low priority label |
| 13:12 |
Zeno` |
unless it's a segfault :/ |
| 13:12 |
nrzkt |
it's not normal for a segfault |
| 13:12 |
Zeno` |
so all the label does is discourage contributors (IMO) |
| 13:12 |
Zeno` |
because they see "low priority" and think "meh, I won't bother in future" |
| 13:12 |
nrzkt |
and so many issues and PR discourage users because it's like we are doing nothing :( |
| 13:13 |
Zeno` |
heck, most of the maintenance PRs are labeled "low priority" |
| 13:13 |
Zeno` |
so, my question is... what is "normal" priority? :) |
| 13:15 |
nrzkt |
ls |
| 13:15 |
nrzkt |
oops :) |
| 13:15 |
Zeno` |
-al |
| 13:51 |
|
selat joined #minetest-dev |
| 13:52 |
nrzkt |
I push #2511 now |
| 13:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/2511 -- Add a Lua call to do damages / heals by nerzhul |
| 13:52 |
Zeno` |
ok |
| 13:57 |
nrzkt |
Zeno`: okay for using the call in minetest_game now ? https://github.com/minetest/minetest_game/pull/468 |
| 13:59 |
nrzkt |
also for everybody: what about https://github.com/minetest/minetest_game/pull/341 ? |
| 13:59 |
Zeno` |
I don't make decisions regarding minetest_game |
| 13:59 |
nrzkt |
i talked with c55 and we can do bugfixes only to minetest_game |
| 13:59 |
nrzkt |
this is a bugfix, this fix the TNT doing damages whereas enable_damage == false |
| 14:00 |
Zeno` |
I think add a comment that it's now supported in the engine and wait for a bit |
| 14:00 |
nrzkt |
okay |
| 14:01 |
Zeno` |
e.g. what if people are not using the latest engine but keep up-to-date with minetest_game |
| 14:01 |
Zeno` |
that might cause problems, I dunno |
| 14:01 |
nrzkt |
as i discussed minetest_game master is synced with minetest master |
| 14:01 |
Zeno` |
still, I'd like to hear comments :) |
| 14:01 |
nrzkt |
look at VanessaE comments on today IRC logs :p |
| 14:02 |
Zeno` |
the fix is obviously trivial, but... who knows who might explode in anger roflol |
| 14:03 |
Zeno` |
but yes, after some feedback I'd obviously merge that |
| 14:04 |
Zeno` |
bbiab |
| 14:13 |
|
OldCoder joined #minetest-dev |
| 14:14 |
|
Tablet_One joined #minetest-dev |
| 14:59 |
|
Guest10082 joined #minetest-dev |
| 15:03 |
|
elias___ joined #minetest-dev |
| 15:09 |
|
MinetestForFun joined #minetest-dev |
| 15:19 |
|
hmmmm joined #minetest-dev |
| 15:30 |
|
PilzAdam joined #minetest-dev |
| 15:31 |
PilzAdam |
nrzkt, enable_damage means that HP should have no effect on anything whatsoever |
| 15:32 |
PilzAdam |
so set_hp() should be a no-op if enable_damage is false |
| 15:33 |
nrzkt |
set hp = set any object HP |
| 15:34 |
nrzkt |
setting HP is a little bit different that doing damage. |
| 15:34 |
PilzAdam |
players do not have HP when enable_damage is false |
| 15:34 |
nrzkt |
this is wrong because players can die because of TNT |
| 15:34 |
nrzkt |
or any other mod |
| 15:34 |
PilzAdam |
that behavior is new |
| 15:34 |
PilzAdam |
someone broke the API then |
| 15:35 |
nrzkt |
the set_hp call don't moved |
| 15:35 |
nrzkt |
doesn't* |
| 15:36 |
PilzAdam |
"probably caused by nerzhul's recent damage related commits." https://github.com/minetest/minetest/issues/2501#issuecomment-82116307 |
| 15:36 |
nrzkt |
which related commit ? |
| 15:36 |
nrzkt |
i fix an issue which doesn't permit player to respawn if enable_damage = false |
| 15:37 |
PilzAdam |
I'll bisect it |
| 15:37 |
kilbith |
i also notice that the screen turn red when i fall, with enable_damage = false |
| 15:37 |
kilbith |
this is something new afaik |
| 15:38 |
nrzkt |
this is very very strange |
| 15:38 |
nrzkt |
damages are sent by the client |
| 15:40 |
nrzkt |
and the red screen is sent by client too |
| 15:42 |
PilzAdam |
b2801d8127f4b25fd96f981974763f33bc7ff42b is first bad commit for falling damage |
| 15:44 |
nrzkt |
Okay i think i understand the problem |
| 15:45 |
nrzkt |
the problem is on client side since this modification. |
| 15:45 |
nrzkt |
because i fix a problem there, but i think this have side effects on client because a variable is not rightly set |
| 15:46 |
nrzkt |
here is the triggered function: https://github.com/minetest/minetest/blob/master/src/network/clientpackethandler.cpp#L428 |
| 15:46 |
|
est31 joined #minetest-dev |
| 15:46 |
|
neoascetic joined #minetest-dev |
| 15:46 |
nrzkt |
i think the oldhp value is wrong somewhere or damage is triggered but mustn't on client side |
| 15:47 |
|
Calinou joined #minetest-dev |
| 15:49 |
nrzkt |
i don't find the redscreen creation call |
| 15:50 |
nrzkt |
=> https://github.com/minetest/minetest/blob/master/src/game.cpp#L3029 |
| 15:50 |
nrzkt |
this was triggered there, because we have a PLAYER_DAMAGE event |
| 15:51 |
PilzAdam |
because the server sends a damage message although enable_damage is false |
| 15:51 |
|
Tablet_One joined #minetest-dev |
| 15:51 |
PilzAdam |
the server side is the problem |
| 15:51 |
nrzkt |
but HP doesn't move |
| 15:51 |
PilzAdam |
the client doesn't know about enable_damage setting |
| 15:51 |
est31 |
merge #2482? SN's concerns are addressed now. |
| 15:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/2482 -- Fix bug that disabled game-based minetest.conf default setting by est31 |
| 15:52 |
nrzkt |
yeah i know, i'm searching how to fix the fixed bug and the red screen bug |
| 15:52 |
nrzkt |
because in each case we have a regression |
| 15:53 |
nrzkt |
oh, the function you mention is false |
| 15:53 |
nrzkt |
it's not a SendHP when damage was done, this function is called at client initialisation |
| 15:54 |
nrzkt |
are you sure this was the problematic commit ? |
| 15:54 |
PilzAdam |
yes |
| 15:54 |
nrzkt |
then the problem is more complex than expected |
| 15:54 |
PilzAdam |
after this commit the client starts getting falling and drowning damage |
| 15:54 |
nrzkt |
i must look at client init |
| 15:54 |
PilzAdam |
the TNT problem is older, though |
| 15:55 |
nrzkt |
okay, then i fixed it properly if you push my commit to minetest_game (i pushed the API call movement) |
| 15:55 |
nrzkt |
modification* |
| 15:55 |
PilzAdam |
I'm bisecting the TNT problem |
| 15:56 |
PilzAdam |
what did you fix properly? |
| 15:57 |
nrzkt |
not damages :p |
| 15:57 |
nrzkt |
https://github.com/minetest/minetest/commits/master |
| 16:01 |
PilzAdam |
64ff966bae99813229dff6629fd9131a91ba7484 is the first bad commit for the TNT problem |
| 16:01 |
nrzkt |
you are fast :o |
| 16:03 |
nrzkt |
okay. I must look at this. This damage handled by clients are a pain... This fix changes the old way which is calling every players in a loop instead of sending event when occurs |
| 16:03 |
nrzkt |
oh i see now |
| 16:03 |
nrzkt |
it's very simple... and hacky |
| 16:03 |
PilzAdam |
you ignore the enable_damage setting in that commit |
| 16:03 |
nrzkt |
if enable_damage == false the server was never sending any _HP packet to client |
| 16:04 |
nrzkt |
it's a very strange behaviour, but i understand now |
| 16:04 |
PilzAdam |
the client does not know about the setting, so the server needs to take care of not sending HP if its false |
| 16:04 |
nrzkt |
yes and player never die because we never change its hp |
| 16:04 |
nrzkt |
i understand the missing thing... it's a very very bad design |
| 16:05 |
PilzAdam |
feel free to redo the damage system in dev-0.5 |
| 16:05 |
PilzAdam |
but first fix the bugs in master ;-) |
| 16:05 |
nrzkt |
yeah i know |
| 16:05 |
nrzkt |
let me think about a workaround |
| 16:06 |
nrzkt |
if i can handle this differently |
| 16:06 |
PilzAdam |
for 0.5: https://github.com/minetest/minetest/issues/2370#issuecomment-83001132 |
| 16:06 |
nrzkt |
but i don't think, our damage system is broken |
| 16:06 |
PilzAdam |
generic stats are very good |
| 16:07 |
nrzkt |
i know |
| 16:07 |
PilzAdam |
if we had generic stats we would just not register it when enable_damage is false |
| 16:07 |
nrzkt |
i added it |
| 16:08 |
nrzkt |
but i we want compat in master... it will be impossible if we continue to add so many things :p |
| 16:08 |
nrzkt |
i can change the protocol but some things will be very difficult to maintain |
| 16:08 |
nrzkt |
like generic stats :p |
| 16:09 |
nrzkt |
then... i don't think i have choice, i must restore our HP hack, i will add it to packet senders |
| 16:09 |
nrzkt |
this is a bad design but no choice |
| 16:10 |
|
Zeno` joined #minetest-dev |
| 16:11 |
PilzAdam |
generic stats are for 0.5-dev, not master |
| 16:12 |
est31 |
isnt that closed? |
| 16:12 |
|
DFeniks joined #minetest-dev |
| 16:13 |
nrzkt |
i know PilzAdam but many developpers want retrocompat |
| 16:13 |
Zeno` |
what can we do to make #2375 easier (quicker) to merge? |
| 16:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/2375 -- Fix superflous shader setting updates by rubenwardy |
| 16:13 |
nrzkt |
and a so huge feature will be difficult to be compat |
| 16:13 |
PilzAdam |
isn't it the whole point of 0.5 to break everything? |
| 16:14 |
nrzkt |
it was but some developpers didn't agree and community doesn't want ... then it's a difficult choice to do |
| 16:14 |
PilzAdam |
which dev doesn't agree? |
| 16:14 |
nrzkt |
a minetest-reboot is required but retrocompat is required |
| 16:14 |
hmmmm |
Zeno`: I would suggest that somebody looks at what that commit actually does, and reimplement it more in-line with a KISS principle |
| 16:14 |
hmmmm |
nrzkt, maybe that could be a fork. |
| 16:15 |
hmmmm |
I realize you want to make these massive, sweeping changes, but that's not minetest |
| 16:15 |
Zeno` |
hmmmm, thanks for volunteering! |
| 16:15 |
hmmmm |
lol |
| 16:15 |
celeron55 |
what the fuck is going on now |
| 16:16 |
Zeno` |
celeron55, hmmmm is kissing the principal apparently |
| 16:16 |
hmmmm |
:( |
| 16:16 |
Zeno` |
heh |
| 16:16 |
hmmmm |
is reverse compat too much to ask for? |
| 16:17 |
Zeno` |
no, I think backward compat is good |
| 16:17 |
nrzkt |
i agree for retrocompat, but some designs are broken and nearly impossible to maintain |
| 16:17 |
hmmmm |
and uncomplicated code |
| 16:17 |
hmmmm |
none of these Setters and Providers and Factories |
| 16:17 |
nrzkt |
keeping 1 year retrocompat okay, 3 year no |
| 16:17 |
PilzAdam |
0.5 was meant to be the release where we break everything that needs to be broken because of unmaintainable design |
| 16:17 |
PilzAdam |
like protocol, some API stuff, etc. |
| 16:17 |
Zeno` |
hmmmm, so you think that a factory factory should be added? |
| 16:18 |
hmmmm |
maybe Terasology could use that |
| 16:18 |
Calinou |
nice troll hmmmm |
| 16:18 |
nrzkt |
yes PilzAdam, but some developpers and our community are against that, then we must add spaghettis to our salad |
| 16:18 |
nrzkt |
i hope we can eat this in 1 year :p |
| 16:18 |
PilzAdam |
no spaghetti, fuck community |
| 16:18 |
PilzAdam |
problem solved |
| 16:19 |
hmmmm |
that's a good way to alienate users |
| 16:19 |
hmmmm |
you don't want a GNOME 3, do you? |
| 16:19 |
nrzkt |
i want gnome 3 on my destkop, i hope gnome 3.16 will be available soon :D |
| 16:19 |
hmmmm |
well of course you would |
| 16:19 |
nrzkt |
but for minetest the two sides are valid |
| 16:20 |
nrzkt |
some concepts are broken and need a break and retrocompat is good for our users |
| 16:20 |
hmmmm |
the entirety of minetest is broken |
| 16:20 |
hmmmm |
honestly it'd be best to start off completely fresh |
| 16:20 |
Calinou |
using irrKlang, RakNet and UE4, hmmmm? |
| 16:20 |
Calinou |
/s |
| 16:20 |
hmmmm |
no |
| 16:20 |
nrzkt |
use unity :p |
| 16:21 |
hmmmm |
probably should be based off of buildat |
| 16:21 |
PilzAdam |
we should write our own OpenGL renderer |
| 16:21 |
Zeno` |
buildat has some awful code though |
| 16:21 |
Calinou |
too error-prone, PilzAdam |
| 16:21 |
Calinou |
there are tons of established 3D engines |
| 16:21 |
hmmmm |
that's hurting peoples feelings |
| 16:21 |
est31 |
buildat still has lua |
| 16:21 |
hmmmm |
build dat, yo |
| 16:21 |
Calinou |
if you're writing your own renderer, you need to fix bugs for all drivers |
| 16:21 |
hmmmm |
build at? |
| 16:21 |
PilzAdam |
Calinou, all of them are overkill |
| 16:21 |
Calinou |
overkill? you keep complaining about Irrlicht's lack of features |
| 16:22 |
nrzkt |
PilzAdam, will push the fix now |
| 16:22 |
celeron55 |
so guys |
| 16:22 |
PilzAdam |
nrzkt, can I see it first? |
| 16:22 |
nrzkt |
okay |
| 16:22 |
nrzkt |
i let you test it, i send you pastie, sait a minute |
| 16:23 |
hmmmm |
what people normally do is push it to their private repository first and then paste the link |
| 16:23 |
nrzkt |
http://pastie.org/10035483 |
| 16:24 |
nrzkt |
hmmmm: please help to fix the broken concepts. |
| 16:24 |
nrzkt |
there are many and many issues to do. Only speaking on IRC doesn't solve issues. |
| 16:25 |
hmmmm |
I'm working right now |
| 16:25 |
PilzAdam |
error: src/server.cpp: patch does not apply |
| 16:25 |
PilzAdam |
can you use a pastebin that does not convert tabs to spaces? |
| 16:25 |
nrzkt |
are on on master ? |
| 16:25 |
PilzAdam |
or push to your private repo |
| 16:26 |
nrzkt |
https://github.com/nerzhul/minetest/commit/451b091186cf6923f5728a0a30dd2a8fcc2b1f6c |
| 16:28 |
PilzAdam |
this does not fix the TNT problem |
| 16:28 |
nrzkt |
this disable packets, like the commit you show... |
| 16:29 |
PilzAdam |
oh, wait |
| 16:30 |
nrzkt |
oh ! |
| 16:30 |
hmmmm |
I wonder if celeron wanted to say something before |
| 16:30 |
PilzAdam |
well, now you get the "You died" dialog when you rejoin the server |
| 16:30 |
PilzAdam |
so not a proper fix |
| 16:30 |
celeron55 |
i'll just state my opinion on two things discussed and then go about something else: 1) generic stats seem like a thing that should be 0.5-only, but i may be wrong, 2) the factory pattern in 2375 is indeed ugly; rubenwardy should explain why it is needed if he thinks it should be merged as-is |
| 16:31 |
nrzkt |
hmmm |
| 16:31 |
nrzkt |
i think this is not the right fix. I need to restudy the old algorithm, but this PR is not the good PR. |
| 16:32 |
nrzkt |
s/PR/commit/ |
| 16:32 |
celeron55 |
(or, really, not just explain in the PR but write it as a comment in the code) |
| 16:32 |
hmmmm |
that was gregorycu's work |
| 16:33 |
Zeno` |
I don't think he'd appreciate you asking him to explain something |
| 16:33 |
Zeno` |
he'd take it as a mortal insult |
| 16:33 |
nrzkt |
xD |
| 16:33 |
nrzkt |
brb |
| 16:33 |
hmmmm |
we're not smart enough to understand it |
| 16:34 |
hmmmm |
only a true Javaman or C#man can see the beauty in such object-oriented design patterns |
| 16:34 |
celeron55 |
well sometimes the factory pattern makes things better |
| 16:34 |
Zeno` |
or idiots |
| 16:34 |
celeron55 |
but if it comes from the hands of a java guy, it's probably just there for fun |
| 16:34 |
celeron55 |
or, "fun" |
| 16:35 |
celeron55 |
well i mean "out of habit" |
| 16:35 |
hmmmm |
this is the reason why I kept overwriting calinou's attempts to remove the terasology link in the code style guide dev wiki |
| 16:35 |
Calinou |
and we can't stand your bitter attitude here |
| 16:35 |
hmmmm |
it might seem like shit-flinging, but it literally does serve as a perfect example of what we DON'T want |
| 16:36 |
hmmmm |
they are the antithesis of minetest |
| 16:36 |
celeron55 |
progress of tolerable quality is better than no progress; keep that in mind |
| 16:37 |
|
SopaXorzTaker joined #minetest-dev |
| 16:37 |
hmmmm |
I'd just prefer that would-be developers know ahead of time that their super-OOPed rewrite of <whatever> isn't generally welcome unless it actually brings concrete advantages |
| 16:38 |
ShadowNinja |
~tell nrzkt 2495 is not O.K., it has loads of copypasta. |
| 16:38 |
ShadowBot |
ShadowNinja: O.K. |
| 16:41 |
est31 |
ShadowNinja, can you merge #2482, and can another dev have a look at it? |
| 16:41 |
ShadowBot |
https://github.com/minetest/minetest/issues/2482 -- Fix bug that disabled game-based minetest.conf default setting by est31 |
| 16:41 |
est31 |
(perhaps other way round) |
| 16:42 |
ShadowNinja |
I don't like how nerzhul merged at least two ScriptAPI changes that I don't like before I could even look at then. |
| 16:43 |
ShadowNinja |
PRs should wait at *least* a day so that all of the devs have a change to look at it. |
| 16:43 |
ShadowNinja |
Unless it's very trivial of course. |
| 16:44 |
est31 |
perhaps merged faster, when the subsystem maintainer sais its ok? |
| 16:51 |
hmmmm |
ShadowNinja, I told him a couple times now... |
| 16:52 |
ShadowNinja |
est31: I'll merge it in a moment. |
| 16:53 |
ShadowNinja |
hmmmm: He makes some good changes, but he definitely has to wait a lot longer for proper review. |
| 16:55 |
VanessaE |
damn it, and he already left. |
| 16:56 |
VanessaE |
I have an "I told you so" for him :P |
| 16:56 |
VanessaE |
we discussed the set_hp/enable_damage issue over /msg earlier today. he was less than convinced of the source of the trouble... |
| 16:57 |
VanessaE |
I outlined a very simple way to trigger the bug. |
| 16:57 |
hmmmm |
"VanessaE quit your trolling and proove its a problem with my code" |
| 16:57 |
VanessaE |
heh |
| 16:57 |
VanessaE |
well I'm not convinced that HE is the one who fucked up :) but someone sure did and he seems to want to take responsibility for this part of the code anyway |
| 16:58 |
hmmmm |
=/ |
| 16:58 |
hmmmm |
I think he's convinced it's F'd up because the entire system is F'd up and not worth supporting because there's something Big New and Better around the corner that breaks all compatibility |
| 16:59 |
hmmmm |
but Better is subjective, and cutting compatibility has some very nasty effects |
| 16:59 |
VanessaE |
er... |
| 16:59 |
hmmmm |
do you like forks? 'cuz this is how you get forks |
| 16:59 |
VanessaE |
I thought the HP system worked just okay. |
| 16:59 |
hmmmm |
well the problem was that it's level-triggered and not edge-triggered |
| 16:59 |
VanessaE |
I mean yeah I'm sure it needs improvements. |
| 16:59 |
VanessaE |
right |
| 16:59 |
hmmmm |
like most things with the server |
| 16:59 |
hmmmm |
that's not exactly a good thing |
| 17:00 |
VanessaE |
and no, I really don't like forks. |
| 17:00 |
hmmmm |
history is repeating itself |
| 17:00 |
|
ElectronLibre joined #minetest-dev |
| 17:01 |
hmmmm |
but instead of a big desktop environment supported by thousands of people, it's a tiny video game :) |
| 17:01 |
Zeno` |
things have been generally broken since https://github.com/minetest/minetest/commit/64ff966bae99813229dff6629fd9131a91ba7484 |
| 17:02 |
Zeno` |
so there are 2 options: a) live with it; b) add hacks to hacks |
| 17:03 |
Zeno` |
or maybe 3. c) fix it properly |
| 17:04 |
VanessaE |
c) revert the commit, rewrite it so that it does its job right, commit the result |
| 17:04 |
VanessaE |
(all in one go, of course) |
| 17:04 |
Zeno` |
the problem is all the "fixes" added since then |
| 17:04 |
VanessaE |
true |
| 17:04 |
Zeno` |
to address problems that were not problems before then |
| 17:05 |
VanessaE |
meanwhile there are much worse bugs going totally ignored :-/ |
| 17:06 |
Zeno` |
err what was the bug before that commit? |
| 17:06 |
VanessaE |
I don't mean stuff in this particular category |
| 17:06 |
VanessaE |
I'm thinking elsewhere in the engine |
| 17:06 |
hmmmm |
the static objected storage thing |
| 17:06 |
hmmmm |
s/objected/object/ |
| 17:06 |
VanessaE |
that's one yeah |
| 17:10 |
ShadowNinja |
Should 467f (apply_damage()) be reverted? |
| 17:13 |
Zeno` |
why? |
| 17:19 |
|
Hunterz joined #minetest-dev |
| 17:21 |
ShadowNinja |
Zeno`: Because it isn't a proper fix and doesn't add any functionality that set_hp/geh_hp don't have. |
| 17:24 |
est31 |
I'm not sure, but first reading and then setting requires a lock, while applying some value can be stored in a buffer and taken care of later on. |
| 17:25 |
est31 |
but I dont have the context |
| 17:33 |
|
MinetestForFun joined #minetest-dev |
| 17:41 |
|
Krock joined #minetest-dev |
| 17:41 |
PilzAdam |
ShadowNinja, yes; but it can be added in 0.5-dev |
| 17:46 |
Krock |
Comments for #2493 please |
| 17:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/2493 -- Connect rails with connect_to_raillike again by SmallJoker |
| 17:52 |
|
MinetestForFun_ joined #minetest-dev |
| 18:11 |
|
rubenwardy joined #minetest-dev |
| 18:22 |
|
Tablet_One joined #minetest-dev |
| 18:25 |
Krock |
okay, https://github.com/minetest/minetest/pull/2493#issuecomment-83088393 is definitely too high for me. I've absolutely no idea how to extend Map::addNodeAndUpdate() with those codes |
| 18:30 |
|
nrzkt joined #minetest-dev |
| 18:32 |
nrzkt |
back. Reading the log. My commit changes the sending method for _HP packet. But it seem a little thing is missing somewhere. Because looping and using variables for all players on asyncrunstep is not a good method. I changed the method to trigger packet sending on event but it seems there is something wrong with servers with enable_damage == false. |
| 18:33 |
nrzkt |
and i understand what changes before this commit and after. Before we never modify the HP if enable_damage == false |
| 18:34 |
nrzkt |
but we already send the packet, even if HP aren't modified. And we also send the packet is player HP > old player HPs |
| 18:34 |
nrzkt |
but if new hp > old hp we modify the HPs and send the packet |
| 18:36 |
|
Calinou joined #minetest-dev |
| 18:41 |
nrzkt |
PilzAdam ? |
| 18:41 |
|
Calinou joined #minetest-dev |
| 18:44 |
nrzkt |
PilzAdam, can you try https://github.com/nerzhul/minetest/commit/d1fa13c83ea855a9c76817e56fd8a5dbf0045246 please ? |
| 18:45 |
|
Calinou_ joined #minetest-dev |
| 18:47 |
VanessaE |
nrzkt: did you try the test method I gave you? |
| 18:47 |
nrzkt |
I don't receive anything |
| 18:47 |
nrzkt |
you talk in MP ? |
| 18:48 |
nrzkt |
i'm not on same computer, i lost my historic |
| 18:48 |
nrzkt |
if i remember a simple set_hp(0), right ? |
| 18:53 |
nrzkt |
hmmmm, please talk on me when i'm there, not when i'm back. And please help the project with commits, not knifes |
| 18:54 |
VanessaE |
nrzkt: in theory, that alone would do it yeah |
| 19:03 |
|
DFeniks joined #minetest-dev |
| 19:08 |
|
Miner_48er joined #minetest-dev |
| 19:10 |
|
ElectronLibre joined #minetest-dev |
| 19:11 |
|
sofar joined #minetest-dev |
| 19:18 |
|
MinetestForFun_ joined #minetest-dev |
| 19:40 |
|
JeDaYosh- joined #minetest-dev |
| 19:45 |
|
JeDaYoshi joined #minetest-dev |
| 20:04 |
|
Jordach joined #minetest-dev |
| 20:24 |
Calinou |
forum is having issues |
| 20:24 |
Calinou |
can't log in |
| 20:24 |
rubenwardy |
Reset cache |
| 20:24 |
rubenwardy |
I had problems too |
| 20:25 |
Calinou |
fixed |
| 20:30 |
|
rubenwardy joined #minetest-dev |
| 20:51 |
|
MinetestForFun_ joined #minetest-dev |
| 21:15 |
|
Anchakor_ joined #minetest-dev |
| 21:21 |
|
est31 joined #minetest-dev |
| 21:36 |
|
ElectronLibre left #minetest-dev |
| 21:39 |
est31 |
~tell nrzkt perhaps update this file? https://github.com/minetest/minetest/blob/944ffe9e532a3b2be686ef28c33313148760b1c9/doc/README.android |
| 21:39 |
ShadowBot |
est31: O.K. |
| 21:48 |
|
Lunatrius joined #minetest-dev |
| 21:50 |
|
est31 joined #minetest-dev |
| 22:18 |
|
disablec1 joined #minetest-dev |
| 22:25 |
|
MinetestForFun_ joined #minetest-dev |
| 22:37 |
|
Tablet_One joined #minetest-dev |
| 23:09 |
|
Ritchie joined #minetest-dev |
| 23:30 |
|
Tablet_One joined #minetest-dev |
| 23:32 |
|
VargaD joined #minetest-dev |
| 23:39 |
|
Tablet_Two joined #minetest-dev |
