Minetest logo

IRC log for #minetest-dev, 2014-12-27

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:08 paramat http://i.imgur.com/bwge8zu.png mgv7 with a .conf modified noise parameter
00:28 exio4 joined #minetest-dev
00:29 n4x joined #minetest-dev
00:38 kahrl https://github.com/kahrl/gettext-msvc
00:39 kahrl ^ WIP, for example msgfmt.exe does not yet get built, but the dll files are built flawlessly as far as I can tell
00:41 kahrl in the end I want it to be possible to build minetest and its deps from scratch in MSVC without having to trust some binaries from the internet
00:42 kahrl the other problem with that might be OpenAL
00:42 kahrl is the only way to get OpenAL32.dll really to get the closed source stuff from creative?
01:40 Megaf joined #minetest-dev
01:46 n4x joined #minetest-dev
03:04 n4x joined #minetest-dev
03:05 exio4 joined #minetest-dev
03:09 paramat left #minetest-dev
03:13 Miner_48er joined #minetest-dev
04:20 kaeza joined #minetest-dev
04:23 n4x joined #minetest-dev
04:34 MinerDad joined #minetest-dev
05:14 mrtux joined #minetest-dev
05:31 sol_invictus joined #minetest-dev
05:32 hmmmm I think we should start committing some stuff
05:32 hmmmm Zeno`, is this ready?  https://github.com/Zeno-/minetest/commit/​e517f0368b0f8b6bff49081541c0f0443e99b66c
05:37 VanessaE hmmmm: also check http://irc.minetest.ru/min​etest/2014-12-27#i_4080520
05:38 hmmmm 4gb...
05:38 VanessaE short version, acerspyro was getting crashes with this one world, turned out to be a param2 value that was out of range.  kahrl made a quick one-liner to work around it, but he considers it a hack.
05:39 hmmmm in any case, param2 bits used should be masked
05:39 hmmmm that's the proper solution
05:40 VanessaE out of range for the particular drawtype that is (a nodebox).
05:41 n4x joined #minetest-dev
05:42 exio4 joined #minetest-dev
05:53 gregorycu joined #minetest-dev
05:54 gregorycu Nobody really gives a shit, but I'll be on holiday for 11 days, starting tomorrow, no IRC
05:54 gregorycu tell Zeno' I've gone on holiday for 11 days bro
06:01 hmmmm no problem
06:07 Wayward_One joined #minetest-dev
06:10 Wayward_One joined #minetest-dev
06:12 harrison joined #minetest-dev
06:22 Wayward_One joined #minetest-dev
07:00 n4x joined #minetest-dev
07:00 exio4 joined #minetest-dev
07:13 hmmmm https://github.com/kwolekr/minetest/commit​/b67f37f27ea7d89b2098fa9fcc2533fa1091e695
07:13 hmmmm rate hate masterb8
07:38 hmmmm anybody around? :/
07:38 hmmmm I need to commit this so I could commit a fix
08:08 Hunterz joined #minetest-dev
08:16 paramat joined #minetest-dev
08:17 * paramat is around
08:18 paramat that will conflict with my new biome api, but i could always rewrite my commits if you need that merged asap
08:20 paramat actually no problem go ahead, you won't want to rewrite all that based on my commits =)
08:20 exio4 joined #minetest-dev
08:21 paramat my new biome api is almost ready for review https://github.com/paramat/​minetest/commits/biomeapi2
08:23 paramat but it's unfinished, i still need to edit mapgen_v7.cpp
08:25 paramat this is in preparation for generatebiomes and dusttopnodes being moved into the biome manager
08:26 Miner_48er joined #minetest-dev
08:51 kilbith joined #minetest-dev
08:53 Krock joined #minetest-dev
09:09 paramat left #minetest-dev
09:11 Calinou joined #minetest-dev
09:31 jin_xi joined #minetest-dev
09:40 exio4 joined #minetest-dev
09:41 n4x joined #minetest-dev
10:02 ImQ009 joined #minetest-dev
10:10 celeron55 joined #minetest-dev
10:36 FR^2 joined #minetest-dev
10:57 exio4 joined #minetest-dev
11:10 psedlak joined #minetest-dev
11:39 n4x joined #minetest-dev
12:07 Zeno` joined #minetest-dev
12:13 n4x joined #minetest-dev
12:15 exio4 joined #minetest-dev
12:45 Megaf Hi folks
12:45 Megaf I'm thinking about moving my server from master to stable-0.4 now that we have 0.4.11 released
12:45 Megaf Do you think this is a good idea?
12:46 Krock joined #minetest-dev
12:49 sfan5 Megaf: shouldn't break anything
13:03 ImQ009 joined #minetest-dev
13:23 fz72 joined #minetest-dev
13:28 n4x joined #minetest-dev
13:28 exio4 joined #minetest-dev
13:29 PilzAdam joined #minetest-dev
13:34 PilzAdam hi, how is the release going?
13:36 sfan5 it was released already
13:37 PilzAdam why is the feature freeze still in /topic ?
13:37 PilzAdam why is the stable-0.4. branch in minetest_game not updated?
13:38 sfan5 dunno
13:38 Topic for #minetest-dev is now Minetest core development and maintenance. Chit-chat goes to #minetest. Consider this instead of /msg celeron55. http://irc.minetest.ru/minetest-dev/ http://dev.minetest.net/
13:39 kilbith and why the linux repos are not yet updated ?
13:43 PilzAdam kilbith, which ones?
13:43 kilbith ubuntu, arch...
13:43 PilzAdam I can issue a stable build on launchpad, I guess...
13:44 PilzAdam http://dev.minetest.net/Releasing_Minetes​t#Notify_other_known_package_maintainers
13:46 kilbith sfan5: you're on Arch Linux, right ?
13:51 PilzAdam okay, PPA is building
13:52 PilzAdam sfan5, should I update the minetest_game stable-0.4 branch?
13:52 kilbith thanks
13:52 sfan5 kilbith: yes
13:52 sfan5 PilzAdam: yes
13:53 selat joined #minetest-dev
13:55 PilzAdam sfan5, I have a list of PRs for minetest_game, that I'd like to have merged
13:55 PilzAdam do you have time to look at them?
13:55 sfan5 maybe
13:56 PilzAdam game#376 game#390 game#387
13:56 ShadowBot https://github.com/minetes​t/minetest_game/issues/376 -- More cleanup by PilzAdam
13:56 ShadowBot https://github.com/minetes​t/minetest_game/issues/390 -- Add Obsidian / Obsidian Brick stairs & slabs by CraigyDavi
13:56 ShadowBot https://github.com/minetes​t/minetest_game/issues/387 -- Add straw by kilbith3
13:56 kilbith the PR for straw is still uncomplete
13:57 PilzAdam the cleanup needs to be merged ASAP, since rebasing it is a PITA
13:57 PilzAdam kilbith, you mean the credit for the texture? I can add that when merging
13:58 kilbith yes, and the flammable=4
13:58 roniz joined #minetest-dev
14:00 kilbith and remove "drop = farming:straw" -- useless
14:05 PilzAdam https://github.com/PilzAdam/minetest_game/com​mit/97bef0f747c0c24bf07dc6033f002a3e91767858
14:05 PilzAdam is it ok like this?
14:05 kilbith perfect
14:05 Zeno` https://github.com/PilzAdam/minetest_game/co​mmit/820667a4b2730a3e2303e9882ecaf227c6c9066​8#diff-4c0fc0806e6a443774cea3aea5f3febeR660      <--- What is 7?
14:06 PilzAdam Zeno`, the viscosity of lava (?)
14:07 Zeno` What I mean is, why is LAVA_VISC deprecated?
14:07 T4im joined #minetest-dev
14:07 PilzAdam I don't see a reason to add global constants for random nodedef fields
14:09 Zeno` If that reasoning is followed, LIGHT_MAX may as well be removed as well
14:10 PilzAdam yeah, it should be
14:10 PilzAdam dunno why I kept it...
14:10 PilzAdam :-/ ubuntu 12.04 build fails to build: https://launchpadlibrarian.net/193537189/b​uildlog_ubuntu-precise-i386.minetest_0.4.1​1-0ppa1~ubuntu12.04.1_FAILEDTOBUILD.txt.gz
14:17 kilbith 14.04 is OK ?
14:18 PilzAdam yes, https://launchpadlibrarian.net/193537379/​buildlog_ubuntu-trusty-i386.minetest_0.4.​11-0ppa1~ubuntu14.04.1_UPLOADING.txt.gz
14:19 kilbith hmm, no 64bits builds ?
14:20 PilzAdam the 64 bit builds are the same, 12.04 fails, 14.04 is fine
14:20 kilbith ok !
14:20 selat joined #minetest-dev
14:22 shadowzone joined #minetest-dev
14:27 Amaz joined #minetest-dev
14:28 kahrl PilzAdam, http://forum.freeminer.org/thre​ads/singleplayer-times-out.61/ fifth post
14:28 kahrl is libsnappy-dev installed?
14:30 PilzAdam no
14:31 PilzAdam I don't know how to add it, though
14:51 exio4 joined #minetest-dev
14:53 n4x joined #minetest-dev
14:55 MinerDad joined #minetest-dev
15:06 luizrpgluiz joined #minetest-dev
15:06 luizrpgluiz dear developers, next year in 2015, I will buy my computer at Walmart site, setting it will be a core i3 intel with 8 GBs of ram and video card 9 Series Nividia, I hope this setting of quietly to play the game Minetest at least 30.60 frames per second.
15:07 luizrpgluiz this setting is good to run minetest the maximum setting of the game?
15:08 shadowzone It should be
15:08 shadowzone Sounds like my Dads PC
15:08 shadowzone and his can run 2 minetest servers with no lag.
15:08 jin_xi luizrpgluiz: ask this stuff in #minetest
15:20 Krock luizrpgluiz, if you compear with my PC, you would get 100 FPS with no problems
15:26 SudoAptGetPlay joined #minetest-dev
15:31 fz72 Hey there, I created a pull request #2016 to fix #1960 and to save some options ( hide mp, hide gamemods and selected mod)
15:31 ShadowBot https://github.com/minetest/minetest/issues/2016 -- Fix for worldconfig by fz72
15:31 ShadowBot https://github.com/minetest/minetest/issues/1960 -- mainmenu worldconfigure hide game and hide MP will uncheck each other
15:32 swaaws joined #minetest-dev
15:47 PilzAdam joined #minetest-dev
15:49 exio4 joined #minetest-dev
15:50 kilbith joined #minetest-dev
15:52 kaeza joined #minetest-dev
15:54 kilbith luizrpgluiz, your silly noise goes to #minetest
15:54 kilbith for the umpteenth time...
16:03 shadowzone joined #minetest-dev
16:13 hmmmm joined #minetest-dev
16:23 Sokomine joined #minetest-dev
16:43 hmmmm feature freeze is still in the topic because i have no ops in any of the channels.
16:43 pixelcrumbs joined #minetest-dev
16:43 hmmmm i don't have an account to edit the main webpage either.
16:43 hmmmm nobody here has access to the linux repos
16:44 hmmmm minetest_game isn't updated because somebody else is supposed to do that
16:45 VanessaE hmmmm: perhaps you should mention what we discussed last night.
16:45 roniz joined #minetest-dev
16:45 hmmmm gonna make a forum post for it.
16:45 VanessaE k
16:46 Calinou joined #minetest-dev
16:47 pixelcrumbs joined #minetest-dev
16:48 ImQ009 joined #minetest-dev
16:48 sfan5 -ChanServ- 3     hmmmm                  +AVot
16:48 sfan5 doesn't this mean you can get op?
16:49 shadowzone Yep
16:49 hmmmm was not aware of this change at all
16:49 shadowzone I think
16:50 prozacgod joined #minetest-dev
16:50 shadowzone hmmmm: try ;op
16:50 hmmmm ;op
16:50 shadowzone Weird
16:52 VanessaE hmmmm:  /cs op #minetest-dev
16:52 VanessaE should also work.,
16:52 VanessaE -,
16:53 hmmmm isn't there any sort of "help" prompt?
16:53 hmmmm this is ridiculous
16:58 n4x joined #minetest-dev
16:58 PilzAdam hmmmm, maybe you shouldn't release when nobody is around?
16:59 hmmmm well it was the release date on christmas like people wanted
16:59 PilzAdam the dev wiki says "This is mostly done by several core developers. "
16:59 hmmmm i was a strong advocate of releasing about a week earlier but people didn't like that
16:59 PilzAdam how many were here when you pushed the version bump?
17:00 hmmmm like 1 person.
17:00 hmmmm and then there was nobody doing the MSVC builds
17:00 PilzAdam then you shouldn't have released
17:00 hmmmm why?  dec 24th was the scheduled release date
17:00 hmmmm releasing it after christmas makes the whole point kind of moot.
17:01 hmmmm PilzAdam, I am making new policies and procedures for versioning, releasing, and maintenance
17:01 sfan5 hmmmm: /msg ChanServ help flags
17:01 hmmmm sfan5, I did /msg ChanServ help and it didn't respond
17:01 sfan5 it responds with notices or something
17:01 sfan5 look in every tab
17:01 hmmmm oh
17:02 hmmmm it happens to be in the #xfce tab..
17:02 PilzAdam releases are done by more than 1 core dev
17:02 PilzAdam you can't release alone
17:02 PilzAdam if you want to push a release, then get the people here, and don't simply push a version bump
17:02 hmmmm PilzAdam:  it shouldn't need more than one person.. and there should never be a delay due to old binaries
17:02 hmmmm or missing binaries
17:02 hmmmm all this bullshit should be done a week in advance
17:03 hmmmm when your feature freeze is 2 weeks... there is absolutely no excuse for this
17:05 VanessaE it also doesn't help when you can't *get* all the otherwise necessary people into here in the first place.
17:05 FungusAdam joined #minetest-dev
17:05 VanessaE where's BlockMen?  where's sapier?
17:06 VanessaE [12-27 12:05] <VanessaE> it also doesn't help when you can't *get* all the otherwise necessary people into here in the first place.
17:07 FungusAdam hmmmm, our release process may not be the fastest, but thats no reason to simply ignore it
17:08 hmmmm oh don't get me wrong - i'm not ignoring it
17:08 hmmmm i'm changing it so it doesn't suck
17:08 FungusAdam releasing without other core devs is ignoring it
17:11 ElectronLibre joined #minetest-dev
17:14 hmmmm i'm not sure if i should make a post on the forum, that'd attract uneducated responses
17:14 VanessaE make a post and one of us can lock it.
17:14 hmmmm that defeats the whole purpose
17:14 VanessaE well it has to be announced, doesn't it?
17:15 hmmmm if i wanted to announce something i'd just put it on the dev wiki
17:15 hmmmm i want a persistent discussion between developers only
17:15 hmmmm as of right now i'm not sure how we can do that
17:15 jin_xi pls lets add a mailing list already
17:15 VanessaE well
17:15 hmmmm yes
17:15 hmmmm let's
17:15 jin_xi forum + irc sucks so bad
17:15 VanessaE there's a section on the forum for devs/moderators only
17:15 hmmmm that's 3 people so far
17:16 VanessaE (idk if regular users can read it though)
17:16 hmmmm VanessaE, which section?  'cause I don't see it
17:16 VanessaE https://forum.minetest.net/viewforum.php?f=41
17:16 * VanessaE pokes Tesseract
17:16 T4im github issues might be more limited to developers as well, hmmmm
17:17 VanessaE nah, any random joe can comment as long as they take time to make a github account
17:18 VanessaE and indeed, you DO need to login (and presumably be of adequate status) to access that forum section I linked to
17:19 hmmmm my proposal to have a mailing list was shot down the first time
17:19 luizrpgluiz1 joined #minetest-dev
17:19 PilzAdam VanessaE, I cannot read that forum section
17:19 PilzAdam hmmmm, why do you want to talk to core devs only?
17:19 PilzAdam other people may have valid points
17:19 hmmmm because the average forumgoer is going to serve as noise vs. signal
17:20 hmmmm they really have no clue about software development processes
17:20 VanessaE PilzAdam: looks like you lack Developer status.  *pokes Tesseract again*
17:20 PilzAdam VanessaE, I do not
17:20 hmmmm VanessaE:  I have developer status and I can't see it
17:20 VanessaE hmmmm: I'm not against a mailing list, but it'll have the same problem as github issues - any random joe could get in and add to the discussion if they bother enough.
17:20 VanessaE hmmmm: not according to https://forum.minetest.net/​memberlist.php?mode=leaders
17:20 hmmmm it's way more technical though
17:21 hmmmm oh, i guess you have to be in the "leaders"
17:21 PilzAdam VanessaE, according to the forum, devs are not "leaders"
17:21 VanessaE hm, I guess not
17:22 VanessaE well that would need tweaked, or the mailing list prevails
17:23 PilzAdam hmmmm, not the forum then, but github seems good
17:23 PilzAdam all devs can moderate comments there, to remove useless noise
17:23 hmmmm in the meantime i'll post it in the general discussion forum section.  i guarantee we'll see anywhere from 10 to 30 pants-on-head retarded replies from non developer types
17:24 PilzAdam you shouldn't be so elitist
17:24 hmmmm github for discussion... eww
17:24 hmmmm i'm just being honest
17:24 VanessaE what policy do you want to have for managing the replies?
17:24 hmmmm from past experience i know the average forumgoer won't say anything productive
17:25 VanessaE delete-on-sight for useless/offtopic?  or just let it run?
17:25 hmmmm the former
17:25 kaeza we can just remove useless noise there, but some "forumgoer" may have some useful info to add
17:25 VanessaE ok
17:25 hmmmm if it could be managed i'd be more happy with using the forum
17:25 hmmmm but alas I have no moderator privileges sooo
17:26 PilzAdam hmmmm, btw, which other dev agreed to https://github.com/minetest/minetest/commi​t/565959db860ddfbfdb996a6d4e796abd5cf08d22 ?
17:27 jin_xi well, i think its problematic if you start removing messages. but do disable quickreply button in a dev forum
17:27 hmmmm me and me
17:27 Krock lol ^
17:27 PilzAdam hmmmm, that violates our commit rules
17:27 hmmmm the "2 approvals needed" is a good guideline but that's all it has ever been
17:28 PilzAdam 2 core devs are against it (me and Zeno)
17:28 PilzAdam revert it
17:28 hmmmm i'll be happy to revert it once the warnings are 'fixed'
17:28 PilzAdam you can't do what you want here
17:28 hmmmm it's time to change this too
17:28 hmmmm approval should be based off of something different
17:29 hmmmm in real life nobody's going to get 2 other developers to review your code in a timely manner
17:29 hmmmm instead of saying "ew god oh no let's revert it", why don't we have a discussion?
17:29 PilzAdam you push a lot of commits without notifying other devs or asking other devs for approval; you released without other devs for the second time
17:29 PilzAdam you can't do stuff like this
17:29 hmmmm well, i do.
17:30 Krock it doesn't make any difference to the gameplay whether the warnings are muted nor not.
17:30 hmmmm i pushed the majority of my commits in that burst with my own approval
17:30 hmmmm there's no way i would have been as productive if i needed to wait for others
17:30 PilzAdam I understand that you don't want to limit your productivity
17:30 hmmmm and then I did have people review them anyway - they missed huge, obvious bugs
17:30 PilzAdam in mapgen you have a free hand
17:31 hmmmm so what's the point of a review
17:31 PilzAdam but don't do this in other parts of the project
17:31 hmmmm well anyway
17:31 hmmmm PilzAdam, could you tell me specifically what impact that 'bad' commit had on you?
17:31 PilzAdam I agree with Zeno who says that the commit hides bugs
17:32 hmmmm (the answer is going to be nothing because it's totally an ideological objection)
17:32 PilzAdam you may want to talk with him about it
17:32 hmmmm but Zeno is wrong that it hid any bugs
17:32 hmmmm because for the version of gcc he uses, that warning isn't enabled unless you explicitly enable it or use -Wextra
17:32 hmmmm so he never even saw the problems until I brought them to light with that commit
17:33 PilzAdam I'm not a c or c++ guru, but I guess compiler warnings are there for a reason
17:34 hmmmm so if warnings are super bad, 1). why aren't we using lualint?  2). why aren't we using -Wextra and -pedantic and the like?
17:34 PilzAdam anyway, it's not about this single commit; you can do what you want with mapgen as long as you don't break my worlds; but please stick to the rules a bit more in the other parts
17:34 hmmmm I'm saying it right now, the current rules suck
17:34 PilzAdam they may, you still have to stick to them
17:34 PilzAdam (*until they are changed)
17:36 VanessaE changing the rules usually starts with someone "breaking" them first.
17:36 PilzAdam what?
17:36 PilzAdam thats bullshit
17:37 VanessaE it's not bullshit, it's history
17:37 VanessaE how many laws have been changed in the course of human history, where the change wasn't preceded by someone breaking said laws?
17:38 VanessaE hmmmm already said he's about to introduce a revamp of the release process, so the same thing has happened here
17:38 PilzAdam breaking the law is illegal, even if it's changed afterwards
17:38 jin_xi lol
17:38 jin_xi seriously, what the fuck
17:38 VanessaE O_o
17:38 Krock ^ maybe the reason why some people left and went to freeminer
17:38 shadowzone Krock:  +1
17:40 VanessaE s/release/development/
17:42 jin_xi so we gonna add punishment into dev process now PilzAdam
17:43 sfan5 wat
17:44 jin_xi for illegal commits, you know
17:47 hmmmm i don't actually enjoy working on meta-development but somebody's gotta do this dirty job
17:48 MinetestForFun joined #minetest-dev
18:07 exio4 joined #minetest-dev
18:08 exio4 joined #minetest-dev
18:09 hmmmm so still no comments on this?  https://github.com/kwolekr/minetest/commit​/b67f37f27ea7d89b2098fa9fcc2533fa1091e695
18:10 hmmmm see this is why the code reviewing model is FUBAR
18:13 VanessaE it'd be easier for people to comment on if it were in a pull request :)
18:13 hmmmm what's wrong with IRC
18:14 VanessaE nothing, from my perspective, but you know how hard it is to get even two active devs together around here.
18:14 VanessaE (particularly two who are well-versed enough in whatever the issue of the day is)
18:15 shadowzone Well, I am working on getting nearer and nearer to becoming a Dev and I'm online almost all day.
18:21 VanessaE hmmmm: I'm trying to read through that commit, but my ability to understand C++ is still rather limited (and forget trying to really understand the engine)
18:22 jin_xi i understand anyone who dislikes to review code like this. no discussion to refer to on what was done and why, gotta read it and figure it out first, then review the how its done part
18:24 ElectronLibre joined #minetest-dev
18:28 Miner59 joined #minetest-dev
18:30 Miner59 left #minetest-dev
18:34 PilzAdam hmmmm, you should create a pull request for that
18:35 PilzAdam not all devs read the IRC backlog, or care to respond to stuff that is older than some hours
18:36 PilzAdam also pull requests have a more organized way to discuss things, and you can easier get an overview
18:36 twoelk joined #minetest-dev
18:43 nore joined #minetest-dev
18:43 Wayward_One <Miner59> Hi, can a dev look at cavegen.cpp, line 125. Seems like a copy & paste mistake :-)
18:43 Wayward_One <Miner59> it says GENNOTIFY_LARGECAVE_BEGIN : GENNOTIFY_CAVE_BEGIN; but should be GENNOTIFY_LARGECAVE_END: GENNOTIFY_CAVE_END;, even the comment says it should be end
18:43 Wayward_One <Miner59> here is a link to the commit https://github.com/minetest/minetest/commi​t/5062b99cb0d252d9e377ff4560f7ecc9e66fd558
18:45 ElectronLibre left #minetest-dev
19:18 n4x joined #minetest-dev
19:29 casimir joined #minetest-dev
19:49 VanessaE [12-27 12:26] <MrMcyawn@VEFF> potato,potato,potato, [... string repeated countless times to force all connected clients into low-fps state ...]
19:49 VanessaE um, when is that going to be fixed?
19:55 hmmmm i don't get the problem from that
19:56 VanessaE posting a metric fuckton of text in a chat message causes it to span the entire screen
19:56 VanessaE and for some reason, it also drags the client's fps down
19:56 VanessaE the poster explicitly stated that he was attempting to do that, and I've had it happen on my own client before a few times.
19:57 VanessaE in really bad cases, the client will drop into the single-digit fps range
19:57 VanessaE until the chat message disappears, either by scrolling off or by hiding it with f2
19:59 ImQ009 joined #minetest-dev
20:03 PilzAdam VanessaE, write a mod that auto-bans too long (or repeating) chat messages
20:03 VanessaE ehm..
20:03 VanessaE that just avoids the bug, it doesn't fix it
20:04 PilzAdam slow performance isn't a bug
20:04 jin_xi its a feature
20:04 sol_invictus rolling on the floor
20:04 VanessaE slow performance as a result of a full screen of text most definitely IS a bug.
20:04 VanessaE the user (who was immediately banned by one of my admins) threatened to use that full screen of text to lag-out the target's client.
20:04 PilzAdam ah, I thought you wanted to limit the length of chat messages
20:05 VanessaE a limit on message length should also be considered.  ShadowNinja had a patch at one time, maybe still does, that would limit a post to a reasonable length, 512 or 1024 bytes I think.
20:05 VanessaE clipped on both the client and the server.
20:06 PilzAdam that shouldn't be done in core
20:06 PilzAdam a mod can do this
20:06 VanessaE that's not a mod's job.
20:06 PilzAdam the performance issue is the real issue here
20:06 VanessaE that's core functionality
20:06 VanessaE indeed so.
20:08 Krock IRC can kick users due to Excess Flood .. so why not MT too?
20:08 VanessaE precisely.
20:08 VanessaE and it doesn't take a script to do it, every ircd out there has that functionality.
20:11 casimir Could it be that the chat in general reduces the fps of the client, and with long messanges it is just so much that it becomes visible?
20:12 Krock generally, texts slowdown the FPS
20:12 Krock s/slowdown/reduce/
20:13 casimir I mean more that it should.
20:13 Krock I think the client tries to draw long messagess on the screen too and because there's more to draw, it uses more time
20:14 Krock = lower fps
20:37 prozacgod joined #minetest-dev
20:40 exio4 joined #minetest-dev
20:41 exio4_ joined #minetest-dev
21:31 casimir joined #minetest-dev
21:37 ElectronLibre joined #minetest-dev
21:40 n4x joined #minetest-dev
21:42 twoelk joined #minetest-dev
21:48 acerspyro joined #minetest-dev
21:51 PilzAdam acerspyro, your issue seems familiar to me: https://github.com/minetest/minetest/commi​t/56b9377c1c55a08eb5ae09c058f9f1cb8e9e4a73
21:51 zat joined #minetest-dev
21:53 acerspyro How come it still crashes?
21:56 PilzAdam seems like we don't do the check that facedir > 23 when we have a special drawtype (like mesh)
21:57 PilzAdam it should be added after content_mapblock.cpp:1732
21:58 PilzAdam I'd like to talk to RBA about that first, though
21:58 jin_xi mh are you sure bit masking works like this? https://github.com/minetest/minetest_game/co​mmit/1237bc3a4b3c6f435059d669345446fa44768f3​2#diff-861e2ac76c96c4fac6bb1e19f68f5cbfR40
21:58 PilzAdam maybe the check should be moved to MapNode::getFaceDir()
21:58 jin_xi looks really strange to me
21:59 PilzAdam jin_xi, to me too, but it should work
21:59 jin_xi hm
21:59 PilzAdam no guarantee, though
21:59 PilzAdam can you prove that it's wrong?
21:59 jin_xi no but id say you divide with 256 or so
21:59 jin_xi but what do i know, just looks strange ;)
22:00 PilzAdam dividing would give you the upper bits; I want the lower ones there
22:01 PilzAdam though, you'd need to shift the result of the devision
22:03 acerspyro Is there a hack I could use for now to prevent it from crashing?
22:05 PilzAdam copy the if block from mapblock_mesh
22:06 PilzAdam I create an issue
22:06 acerspyro https://gist.github.com/kahrl/d0a106bd79ddd0b8f2e2
22:06 PilzAdam or is there one already?
22:06 acerspyro I found this in my logs
22:06 PilzAdam yes, that should work
22:08 PilzAdam #2017
22:08 ShadowBot https://github.com/minetest/minetest/issues/2017 -- facedir > 23 causes segfault in client
22:19 PilzAdam sfan5, what about minetest_game changes in changelog?
22:19 sfan5 dunno
22:20 PilzAdam should I write it?
22:20 sfan5 yes
22:21 PilzAdam should I add sub-categories?
22:21 PilzAdam like textures, bugfixes, gameplay?
22:22 sfan5 yes
22:22 sfan5 anyway
22:23 sfan5 why are you asking me
22:23 sfan5 decide for yourself
22:23 Wayward_One joined #minetest-dev
22:24 acerspyro PilzAdam, the patch does work
22:25 PilzAdam sfan5, I'm not a minetest_game maintainer; I can't decide this
22:38 ElectronLibre left #minetest-dev
22:38 VanessaE please be advised that kahrl considers that patch a "hack".
22:40 VanessaE (I mean kahrl's gist)
22:55 exio4 joined #minetest-dev
23:01 PilzAdam sfan5, done http://dev.minetest.net/Chan​gelog#Vanilla_game_changes_.28minetest_game.29
23:01 sfan5 PilzAdam: I'm not a Changelog maintainer; I can't decide this
23:01 PilzAdam we have changelog maintainers?
23:02 sfan5 that was a joke
23:06 PilzAdam anyway, can you contact me when you have time to look at my list of pull requests?
23:06 kilbith you should be _game maintainer instead
23:06 kilbith the best thing that could happens to _game in 2015
23:09 kilbith seriously sfan5, we constantly have to shake you for things evolving
23:10 sfan5 are you complainting that i'm not MIA?
23:10 sfan5 i mean, BlockMen is missing and you are not complaining about him
23:10 kilbith half-MIA
23:12 sfan5 is that just about _game or generally
23:13 sfan5 I think I'm pretty far from being even half-MIA
23:13 ImQ009 joined #minetest-dev
23:16 PilzAdam joined #minetest-dev
23:18 kilbith and BlockMen shouldn't abandon his role like this
23:18 kilbith power of decision imply responsability
23:19 kilbith like deleguate temporily another dev when you think you'll be away for a long while
23:19 sfan5 you do realize this is a team of volunteers and not an enterprise software company?
23:22 kilbith i do, but it's getting to the point where all is strictly frozen from that team
23:23 kilbith the game one i mean
23:23 pro joined #minetest-dev
23:24 kilbith g'night !

| Channels | #minetest-dev index | Today | | Google Search | Plaintext