Time |
Nick |
Message |
00:41 |
|
proller joined #minetest-hub |
00:58 |
|
proller joined #minetest-hub |
04:00 |
|
MTDiscord joined #minetest-hub |
04:18 |
|
olliy joined #minetest-hub |
04:46 |
|
proller joined #minetest-hub |
04:53 |
|
calcul0n_ joined #minetest-hub |
05:18 |
|
sometalgoo joined #minetest-hub |
06:09 |
|
sometalgoo joined #minetest-hub |
07:41 |
MTDiscord |
<Niklp> 1. You mean "a".."b" is better than "a" .. "b"? 2. they're already converted |
09:20 |
|
MTDiscord1 joined #minetest-hub |
10:02 |
|
calcul0n__ joined #minetest-hub |
12:36 |
|
proller joined #minetest-hub |
13:57 |
|
olliy joined #minetest-hub |
19:32 |
Krock |
@Niklp whitespaces make it even more difficult to find the actual changes in your code. it already mixes maintenance and features, which is far from ideal |
19:32 |
Krock |
I see... yes, they're indeed already converted and can be deleted. looks about right, |
19:33 |
Krock |
I'd rather first merge PR 15 if you don't mind |
19:36 |
MTDiscord |
<Warr1024> Ideally a project should have whitespace standards that are enforced from the beginning and kept consistent, to ensure that whitespace-only changes are never accepted nor necessary. Barring that, you either pay the massive price of a "style normalization flag day", or you just suffer through what you've got and try to enforce stricter styles on only new code. |
19:36 |
MTDiscord |
<Warr1024> On a large, mature project, such a "flag day" is very expensive and needs some pretty strong justification. |
19:37 |
|
CWz joined #minetest-hub |
19:46 |
Krock |
we're talking about a repo that's seen 1 changed line in two years |
19:46 |
Krock |
enforcing whitespace rules is quite pointless there, and even more to to mix it with features into a PR |
20:35 |
MTDiscord |
<Niklp> Oke, I‘ll do this tomorrow |
22:34 |
|
panwolfram joined #minetest-hub |
23:46 |
|
proller joined #minetest-hub |