| Time |
Nick |
Message |
| 00:17 |
|
SFENCE joined #minetest-dev |
| 00:43 |
|
SFENCE joined #minetest-dev |
| 01:00 |
|
SFENCE joined #minetest-dev |
| 01:23 |
|
SFENCE joined #minetest-dev |
| 01:40 |
|
SFENCE joined #minetest-dev |
| 01:47 |
|
v-rob joined #minetest-dev |
| 01:59 |
|
SFENCE joined #minetest-dev |
| 02:19 |
|
SFENCE joined #minetest-dev |
| 02:44 |
|
SFENCE joined #minetest-dev |
| 02:56 |
|
untilted joined #minetest-dev |
| 03:00 |
|
SFENCE_arch joined #minetest-dev |
| 03:01 |
|
SFENCE joined #minetest-dev |
| 03:14 |
|
SFENCE joined #minetest-dev |
| 03:20 |
|
SFENCE joined #minetest-dev |
| 03:29 |
|
v-rob joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:06 |
v-rob |
Why is there just an if(TRUE) in CMakeLists.txt? https://github.com/minetest/minetest/blob/ac11a14509067604df23834d993a6251962db043/CMakeLists.txt#L94 |
| 04:32 |
|
SFENCE joined #minetest-dev |
| 04:49 |
|
SFENCE joined #minetest-dev |
| 05:13 |
|
SFENCE joined #minetest-dev |
| 05:27 |
|
SFENCE joined #minetest-dev |
| 06:05 |
|
SFENCE joined #minetest-dev |
| 06:35 |
|
YuGiOhJCJ joined #minetest-dev |
| 06:41 |
|
SFENCE joined #minetest-dev |
| 07:01 |
|
SFENCE joined #minetest-dev |
| 07:12 |
sfan5 |
same reason why there would be an if (1) in the code |
| 07:19 |
|
SFENCE joined #minetest-dev |
| 07:35 |
|
fluxionary joined #minetest-dev |
| 08:05 |
|
cranez joined #minetest-dev |
| 08:54 |
|
hwpplayer1 joined #minetest-dev |
| 09:53 |
|
vampirefrog joined #minetest-dev |
| 10:43 |
|
AwesomeAdam54321 joined #minetest-dev |
| 12:03 |
MTDiscord |
<josiah_wi> That looks pointless to me, I think that conditional can be removed. |
| 12:32 |
MTDiscord |
<warr1024> The question to ask about if(true)s is how long they've been there. It seems obvious somebody thought they might need to easily switch that code on and off, and wasn't confident it should remain there. You can remove the conditional if you're confident and don't mind having to do some extra digging if you want to find the boundaries of that section again. |
| 12:48 |
MTDiscord |
<josiah_wi> It's in git. Just remove it. It's as bad as having dead code. |
| 12:59 |
|
SFENCE_arch joined #minetest-dev |
| 13:12 |
|
hwpplayer1 joined #minetest-dev |
| 13:17 |
MTDiscord |
<warr1024> Don't remove things just because they're in git. Remove things when you are done using them. |
| 13:19 |
celeron55 |
if(true) is essentially the same as a comment stating "you may also want to try without this part in some cases" |
| 13:20 |
celeron55 |
so, saying it's bad is like saying comments are bad. which i do agree is true sometimes, but that's on a case-by-case basis |
| 13:22 |
celeron55 |
in this case, i think it should be removed. i don't think there's much point in trying to build without that portion |
| 13:37 |
|
SFENCE joined #minetest-dev |
| 14:47 |
|
hwpplayer1 joined #minetest-dev |
| 14:49 |
|
hwpplayer1 joined #minetest-dev |
| 15:01 |
MTDiscord |
<josiah_wi> I have seen before where a conditional is hardcoded to one truth value because the code is incomplete and it will be un-hardcoded later. |
| 15:02 |
MTDiscord |
<josiah_wi> I don't think that's the case here. There is no immediate plan to support external Irrlicht, is there? |
| 15:03 |
ROllerozxa |
there isn't, it's just a leftover of the irrlicht import |
| 15:03 |
ROllerozxa |
(irrlichtmt) |
| 15:04 |
ROllerozxa |
I assume it was left like that as a reminder that irrlichtmt should be even more integrated into the main codebase |
| 15:04 |
|
hwpplayer1 joined #minetest-dev |
| 15:04 |
sfan5 |
that's interpreting a lot into it |
| 15:05 |
MTDiscord |
<josiah_wi> There's no comment explaining why it was left in. |
| 15:06 |
|
untilted joined #minetest-dev |
| 15:06 |
MTDiscord |
<josiah_wi> It looks like a tiny oversight. But I don't think it's worth removing. There's not enough developer time to spend reviewing that. The fix is only worth a handful of minutes at most. |
| 15:22 |
|
SFENCE joined #minetest-dev |
| 15:40 |
|
SFENCE joined #minetest-dev |
| 16:16 |
|
loggingbot_ joined #minetest-dev |
| 16:16 |
|
Topic for #minetest-dev is now Minetest core development and maintenance. Chit chat goes to #minetest. https://dev.minetest.net/ https://irc.minetest.net/ https://github.com/minetest |
| 16:24 |
SFENCE_arch |
For 5.9.1, we have a problem at least for Windows build: https://github.com/minetest/minetest/pull/15137#issuecomment-2346738719 |
| 16:27 |
|
SFENCE joined #minetest-dev |
| 16:39 |
|
SFENCE joined #minetest-dev |
| 16:59 |
MTDiscord |
<josiah_wi> Wasn't there a recent refactoring of the mod searching code or something? I seem to remember that. |
| 17:07 |
|
SFENCE joined #minetest-dev |
| 17:15 |
|
SFENCE joined #minetest-dev |
| 17:33 |
MTDiscord |
<herowl> There was, and I did some more in #14543 |
| 17:33 |
ShadowBot |
https://github.com/minetest/minetest/issues/14543 -- Add gameid aliases by nauta-turbidus |
| 17:34 |
MTDiscord |
<herowl> Wait that's game searching code |
| 17:34 |
MTDiscord |
<herowl> Anyway something similar 🙃 |
| 17:49 |
|
Sokomine joined #minetest-dev |
| 19:45 |
|
SFENCE joined #minetest-dev |
| 19:48 |
|
v-rob joined #minetest-dev |
| 20:20 |
|
SFENCE joined #minetest-dev |
| 20:54 |
|
SFENCE joined #minetest-dev |
| 21:12 |
|
SFENCE joined #minetest-dev |
| 21:19 |
sfan5 |
~tell sfence the "real" official builds are the mingw ones anyway |
| 21:19 |
ShadowBot |
sfan5: OK. |
| 21:19 |
|
v-rob joined #minetest-dev |
| 21:21 |
|
vampirefrog joined #minetest-dev |
| 21:24 |
sfan5 |
merging #15136, #15098, #15087, #15062 in like 10m |
| 21:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/15136 -- Add SDL2 options to compiling README. by sfence |
| 21:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/15098 -- Only apply "touch_punch_gesture" when item has no on_use callback by grorp |
| 21:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/15087 -- [no squash] Fix network window size logic by sfan5 |
| 21:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/15062 -- Document negative saturation by nauta-turbidus |
| 21:26 |
|
SFENCE joined #minetest-dev |
| 21:32 |
sfan5 |
#14971 too for good measure |
| 21:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/14971 -- Allow requesting reconnect when mods kick player by Emojigit |
| 21:44 |
|
SFENCE joined #minetest-dev |
| 22:25 |
|
v-rob joined #minetest-dev |
| 22:33 |
|
panwolfram joined #minetest-dev |
| 23:02 |
|
SFENCE joined #minetest-dev |
| 23:05 |
|
Eragon joined #minetest-dev |
| 23:16 |
|
YuGiOhJCJ joined #minetest-dev |
| 23:27 |
|
SFENCE joined #minetest-dev |
