| Time |
Nick |
Message |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 05:52 |
|
YuGiOhJCJ joined #minetest-dev |
| 06:54 |
|
YuGiOhJCJ joined #minetest-dev |
| 08:06 |
|
d0p1 joined #minetest-dev |
| 08:22 |
|
Warr1024 joined #minetest-dev |
| 08:47 |
|
Warr1024 joined #minetest-dev |
| 13:05 |
|
wsor4035 joined #minetest-dev |
| 13:50 |
sfan5 |
psa: I created a "Security" label |
| 14:39 |
Krock |
Meeting in 20 minutes |
| 15:00 |
Krock |
ping celeron55 nrz @nrz0 sfan5 |
| 15:00 |
Krock |
today's meeting points: https://dev.minetest.net/Meetings#2024-07-21 |
| 15:00 |
Krock |
(waiting a few minutes for the people to notice) |
| 15:03 |
Krock |
First topic: 5.9. https://github.com/minetest/minetest/milestone/23 |
| 15:04 |
Krock |
I think currently this one's the most important: https://github.com/minetest/minetest/pull/14749#issuecomment-2222747966 |
| 15:05 |
Krock |
sfan5's comment seems like a good workaround. I could open a PR for that if it's what we'd want |
| 15:19 |
sfan5 |
oops |
| 15:20 |
sfan5 |
i think we can remove #14665 from the milestone too due to lack of reproducer |
| 15:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/14665 -- Minetest crashes on macOS and has no image |
| 15:20 |
sfan5 |
#14817 too, because it looks like it's not a recent regression after all |
| 15:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/14817 -- Animation blending no longer works |
| 15:21 |
Krock |
the macOS issue does not need a milestone at all |
| 15:21 |
sfan5 |
after that we just need to adress #14342 (via revert) and the rest of the issues look like they have a PR for them already |
| 15:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/14342 -- Send sound to players which comes to hear distance. by sfence |
| 15:24 |
Krock |
mm |
| 15:25 |
Krock |
There was another bugfix #14436 |
| 15:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/14436 -- Stop sounds if objects get out of range, but not if objects are removed by appgurueu |
| 15:25 |
Krock |
although that's not the root |
| 15:26 |
Krock |
or.. is it? |
| 15:26 |
sfan5 |
we either need to merge this *and* the other PR, or revert both |
| 15:27 |
sfan5 |
having just one results in bad behaviour for modders. as far as I understand |
| 15:27 |
Krock |
what's the issue number that we need to fix? |
| 15:27 |
Krock |
from what I can see, there is yet none |
| 15:30 |
Krock |
the issue that sfence's PR addresses is not new at all. I remember that looped sounds never played for newly joined players |
| 15:33 |
Krock |
honestly I lost track of these changes, where it might be best to discuss that with appgurueu when they're again around |
| 15:33 |
sfan5 |
hmm, yea |
| 15:35 |
Krock |
It would be best to have an issue opened for this if anyone's bothered with the current state |
| 15:35 |
sfan5 |
it sounds like I'm talking about #14422 actually and that's already fixed |
| 15:35 |
ShadowBot |
https://github.com/minetest/minetest/issues/14422 -- #14341 broke some mob death sounds |
| 15:35 |
sfan5 |
then there's no need to force this PR into 5.9 it seems |
| 15:36 |
Krock |
let's include a fix in 5.10 if there's any need for such |
| 15:36 |
sfan5 |
suure |
| 15:36 |
sfan5 |
just need to make sure we don't accidentally regress something in 5.9 |
| 15:37 |
Krock |
fair point, but I think neither of us has a plan whether there's a potential regression |
| 15:38 |
sfan5 |
yea |
| 15:40 |
Krock |
so that was in march. 2.5 months later and there's no new issue from them. At least based on that I suppose there's no important new bug |
| 15:41 |
Krock |
let's continue with the other milestone points. |
| 15:41 |
Krock |
there's various inventory movement issues. regressions but no blockers. the inventory movement is somewhat brittle, thus I'd prefer to not change it before release |
| 15:42 |
Krock |
namely #13961 and #14250 |
| 15:42 |
ShadowBot |
https://github.com/minetest/minetest/issues/13961 -- Strange behavior when dragging&dropping from MTG creative inventory (since #13146) |
| 15:42 |
ShadowBot |
https://github.com/minetest/minetest/issues/14250 -- Inventory items unresponsive after tab interaction until LMB click on formspec |
| 15:43 |
|
fluxionary joined #minetest-dev |
| 15:44 |
sfan5 |
so you want to remove #14656 from the milestone? |
| 15:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/14656 -- Fix strange behavior when dragging&dropping from MTG creative inventory by sfence |
| 15:44 |
sfan5 |
and #14832? |
| 15:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/14832 -- Inventory: only pick up stacks from the same list by SmallJoker |
| 15:46 |
Krock |
yes, and move the other issues to 5.10. |
| 15:46 |
Krock |
what do you think about that? |
| 15:48 |
sfan5 |
i haven't played much but those issues don't seem to be totally game-breaking |
| 15:48 |
sfan5 |
so in the interest of a faster release I'm tending towards yes |
| 15:48 |
Krock |
they're minor annoyances; and indeed not game breaking |
| 15:48 |
Krock |
okay. moving. |
| 15:50 |
Krock |
hm. However, having #14661 included would be helpful |
| 15:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/14661 -- Fix inventory items unresponsive after tab interaction until LMB click on formspec by sfence |
| 15:50 |
Krock |
it's not a perfectly fine solution but does work. Risk for regressions is low, as this code is only executed rarely. |
| 15:51 |
Krock |
re-testing before approval |
| 15:54 |
sfan5 |
sounds ok |
| 15:55 |
Krock |
#14852 looks like an easy "fix". We can still find a better way to mix colors later. |
| 15:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/14852 -- Restore buggy texture overlay modifier by Desour |
| 15:55 |
sfan5 |
agreed |
| 16:06 |
* sfan5 |
afk |
| 16:09 |
Krock |
Thank you for participating. I think we'll need another session with a few more attendees to finally get 5.9.0 out. |
| 16:48 |
|
nrz joined #minetest-dev |
| 17:38 |
sfan5 |
do we want to have #14820 in 5.9.0? it's low-risk |
| 17:38 |
ShadowBot |
https://github.com/minetest/minetest/issues/14820 -- Optionally hide player names on the serverlist (opt-in or opt-out?) by Emojigit |
| 17:40 |
Krock |
whereas trivial, it's a feature |
| 17:41 |
Krock |
going strictly by the rules, postponing would be the correct solution. I don't care, though. |
| 17:41 |
Krock |
it would need new translation |
| 18:45 |
MTDiscord |
<herowl> What about #14807 and #14815? |
| 18:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/14807 -- Add new vector utils (ceil, sign, abs, random_in_area) by kromka-chleba |
| 18:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/14815 -- Add squared distance to vector api by kno10 |
| 18:46 |
MTDiscord |
<wsor4035> those are features, and minetest is in feature freeze atm |
| 18:46 |
MTDiscord |
<herowl> Also #14823 |
| 18:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/14823 -- dev: add shell.nix by nerzhul |
| 18:46 |
MTDiscord |
<herowl> Wsor, read above :juanchi_face: |
| 18:47 |
sfan5 |
new script api features are wholly different than a minor server-only configuration setting |
| 18:50 |
MTDiscord |
<herowl> OK fine I took a second look. |
| 18:50 |
MTDiscord |
<herowl> I understand now |
| 20:01 |
MTDiscord |
<luatic> Another reason to say no to features in feature freeze, even if they are "low risk", is to limit the scope so we can focus on the rest. FWIW the serverlist player name anonymization PR could be seen as addressing ("fixing") a privacy concern ("bug"). |
| 22:32 |
|
panwolfram joined #minetest-dev |
| 23:05 |
|
Eragon joined #minetest-dev |
| 23:52 |
|
Noisytoot joined #minetest-dev |
