| Time |
Nick |
Message |
| 00:00 |
MTDiscord |
<warr1024> This is feeling like a #minetest conversation rather than a #minetest-dev one. |
| 00:00 |
MTDiscord |
<wsor4035> also 👆 |
| 00:00 |
nekobit |
well, it was something i wanted to contribute to minetest |
| 00:00 |
nekobit |
so i figured it fit here |
| 00:00 |
nekobit |
but i didnt know if it would be merged if i did such a thing. |
| 00:01 |
nekobit |
If it wouldn't fit, then I can make it a standalone program apart from minetest |
| 00:01 |
MTDiscord |
<wsor4035> maybe enabling/disalbing mods with a cli interface makes sense, the rest of it seems like its quite accomplishable/better done by eternal tooling |
| 00:01 |
MTDiscord |
<warr1024> It probably wouldn't be. Â If it were, then this might become the appropriate channel to discuss it once that was determined. Â As a general rule this channel is supposed to be low-traffic, mostly existing core devs driving the conversation. Â #minetest is more of a general umbrella. |
| 00:02 |
nekobit |
ill move there |
| 00:54 |
|
ShadowBot joined #minetest-dev |
| 01:20 |
|
ShadowBot joined #minetest-dev |
| 01:42 |
|
ShadowBot joined #minetest-dev |
| 02:04 |
|
YuGiOhJCJ joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:17 |
|
YuGiOhJCJ joined #minetest-dev |
| 08:22 |
|
Warr1024 joined #minetest-dev |
| 08:47 |
|
Warr1024 joined #minetest-dev |
| 10:30 |
|
grorp joined #minetest-dev |
| 10:33 |
grorp |
planning to merge #14703 and #14754 later |
| 10:33 |
ShadowBot |
https://github.com/minetest/minetest/issues/14703 -- SDL2: Support highdpi by grorp |
| 10:33 |
ShadowBot |
https://github.com/minetest/minetest/issues/14754 -- Fix broken default sneak keybind on macOS with SDL by grorp |
| 10:43 |
grorp |
#14342 hasn't had code changes since Apr 20, so I guess we should get rid of `Server::stopAttachedSounds` and related for the 5.9.0 release and try again in 5.10.0. @luatic what do you think? |
| 10:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/14342 -- Send sound to players which comes to hear distance. by sfence |
| 11:51 |
|
grorp left #minetest-dev |
| 13:48 |
|
SFENCE joined #minetest-dev |
| 14:01 |
|
SFENCE joined #minetest-dev |
| 14:01 |
Krock |
@grorp FYI #14757 is about math.round, not math.random. It seems this is a follow-up error. |
| 14:01 |
ShadowBot |
https://github.com/minetest/minetest/issues/14757 -- Fix math.round floating point bug by kromka-chleba |
| 14:02 |
Krock |
for functionality tests, a fixed table would be more reliable to use |
| 14:10 |
MTDiscord |
<luatic> it makes sense to test random numbers though |
| 14:10 |
MTDiscord |
<luatic> as well as edge cases |
| 15:33 |
|
fluxionary joined #minetest-dev |
| 15:44 |
[MTMatrix] |
<grorp> I meant math.round, just wrote the wrong thing because I read the wrong thing |
| 15:47 |
|
grorp joined #minetest-dev |
| 15:47 |
grorp |
merging |
| 15:53 |
|
fluxionary joined #minetest-dev |
| 15:55 |
|
grorp left #minetest-dev |
| 17:58 |
|
Daniele joined #minetest-dev |
| 18:15 |
MTDiscord |
<luatic> @grorp: fwiw I don't think sfence's PR is that far away from being mergeable. i'd say leave it on the milestone, if it doesn't make it and becomes the only thing holding up the 5.9 release we revert the other PR and try again in 5.10. |
| 18:16 |
sfan5 |
I would prefer not potentially making a mess of sounds just prior to 5.9 |
| 18:16 |
MTDiscord |
<luatic> in other words you'd revert the predecessor of that PR now and retry in 5.10? |
| 18:24 |
sfan5 |
yea |
| 18:35 |
[MTMatrix] |
<grorp> s/predecessor/predecessors/ |
| 18:40 |
[MTMatrix] |
<Zughy> Hurray, another thing I cannot implement in my server |
| 18:42 |
[MTMatrix] |
<Zughy> Can't Desour have a look at it, since they've worked on sounds before? If they're available, of course |
| 18:44 |
sfan5 |
it appears that the PR needs more than just small adjustments |
| 18:44 |
sfan5 |
but if someone does ths work: sure |
| 18:44 |
sfan5 |
the* |
| 18:56 |
MTDiscord |
<luatic> well, the rebase was trivial at least |
| 18:58 |
MTDiscord |
<luatic> okay i am never using github's web interface again |
| 18:59 |
MTDiscord |
<luatic> the editor specifically. it seems to be consistently messing up whitespace. |
| 19:10 |
[MTMatrix] |
<Zughy> luatic, be my saviour |
| 20:55 |
|
jonadab joined #minetest-dev |
| 22:32 |
|
panwolfram joined #minetest-dev |
| 23:05 |
|
Eragon joined #minetest-dev |
| 23:12 |
|
Eragon_ joined #minetest-dev |
| 23:29 |
MTDiscord |
<andrey2470t> Core devs, please take down "Action/change needed" from 14343 |
