Minetest logo

IRC log for #minetest-dev, 2024-01-23

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:29 appguru1 joined #minetest-dev
05:00 MTDiscord joined #minetest-dev
08:58 calcul0n joined #minetest-dev
09:48 json joined #minetest-dev
11:47 appguru joined #minetest-dev
12:11 rubenwardy Hi, any objections to linking an educator-run MT discord community in web#292 ? It may be expanding to Matrix as well soon. It's run by Lemente
12:11 ShadowBot https://github.com/minetest/minetest.github.io/issues/292 -- Update education page by rubenwardy
12:28 Farooq joined #minetest-dev
12:30 Farooq joined #minetest-dev
12:39 celeron55 rubenwardy: i don't see why not
12:40 celeron55 keeping it very factual and mainly just listing projects is a good idea. that way we don't over-promise
12:40 appguru joined #minetest-dev
12:42 Farooq joined #minetest-dev
13:12 appguru joined #minetest-dev
13:19 Farooq joined #minetest-dev
15:16 grorp joined #minetest-dev
16:02 pgimeno_ joined #minetest-dev
16:02 wsor40357 joined #minetest-dev
16:03 m42uko_ joined #minetest-dev
16:32 fluxionary_ joined #minetest-dev
16:54 fluxionary_ joined #minetest-dev
17:57 Desour joined #minetest-dev
20:10 grorp joined #minetest-dev
20:14 grorp sfan5: can I merge #14266? (2nd try)
20:14 ShadowBot https://github.com/minetest/minetest/issues/14266 -- Save the settings in more cases to avoid losing setting changes by grorp
20:14 sfan5 if it works
20:17 grorp i haven't managed to lose setting changes with it anymore 🤷
20:17 grorp but you can always do more testing
20:18 grorp do you think it would be better to ask some other people to test it first?
20:18 sfan5 I meant "runs, doesn't crash or error" not rigorous testing
20:19 grorp ah, well, that requirement is satisfied
20:21 grorp merging #14266 in 10 min then :)
20:21 ShadowBot https://github.com/minetest/minetest/issues/14266 -- Save the settings in more cases to avoid losing setting changes by grorp
20:23 sfan5 ~tell Desour #14298 might be interesting for you
20:23 ShadowBot sfan5: OK.
20:35 MTDiscord <bla8722> anyone else having problems since "Tool specific pointing and blocking pointable type" (5958714)? works in singleplayer but not on servers (tested YourLand, WunderWelt, Archtec). For most things I don´t get a selectionbox at all. strangely some stuff that shouldnt be pointable are with that commit, for example wielded light source nodes.
20:36 sfan5 sounds like the backwards-compatibility got messed up, please open a bug
20:36 MTDiscord <bla8722> k
20:41 appguru joined #minetest-dev
20:54 MTDiscord <bla8722> done https://github.com/minetest/minetest/issues/14299
21:02 MTDiscord <luatic> Currently compiling to reproduce. I have a hunch this could be a very easy fix (swapping two things in an enum around). Note to self & other core devs: We should test more outside of devtest singleplayer.
21:10 MTDiscord <luatic> Now compiling the proposed fix. It's in a header file unfortunately 🥲
21:16 MTDiscord <luatic> Works
21:17 MTDiscord <luatic> Proposed fix: https://gist.github.com/appgurueu/daaf1cf647fcd89d531287339d3b4e9f
21:17 MTDiscord <luatic> I'd push this in 10m if there's no opposition
21:18 MTDiscord <luatic> @bla8722 you might want to test this
21:19 MTDiscord <luatic> @celeron55 have you considered creating something like a "tester" team?
21:20 sfan5 if this issue exists: what about new engine and old client?
21:20 sfan5 s/engine/server/
21:20 MTDiscord <luatic> Swapping the enum values around should fix that too, I believe
21:20 MTDiscord <luatic> Though "blocking pointable" is funny
21:20 sfan5 planning to merge #14296 and #14286 (I added another trivial commit in there) in 10-20m
21:20 ShadowBot https://github.com/minetest/minetest/issues/14296 -- Allow fog color to be overriden (properly) by sfan5
21:20 MTDiscord <luatic> I believe the 2 should be coerced into a "true" bool for that though?
21:20 ShadowBot https://github.com/minetest/minetest/issues/14286 -- [no squash] General fixes & improvements (season 2) by sfan5
21:22 celeron55 @luatic: i think a tester team could fairly easily self organize
21:23 celeron55 but if people would like to use github team mentions or have the testers apply tags something, then for sure, it makes sense
21:23 celeron55 +or
21:27 MTDiscord <luatic> sfan5: Added a comment 'Note: Since (u8) 2 is truthy, older clients will understand this as "pointable=true", which is a reasonable fallback.' above POINTABLE_BLOCKING
21:29 MTDiscord <luatic> Older clients seeing "blocking" as "false" would be fine too IMO. It's just a feature they don't support. But "true" is a more graceful fallback.
21:30 MTDiscord <luatic> Anyways maybe I'll make this into a (trivial) PR so we can have some proper discussion
21:30 MTDiscord <bla8722> compiling might take a while
21:49 Sokomine er. hm. is this problem known? built latest dev couple of minutes ago. now can't right- or leftclick any more. placing a block worked. digging it doesn't. i do get selection boxes in the air shown
21:49 Sokomine ah. perhaps discussion is already about this topic. just wonder because i compiled maybe 10-20 minutes ago
21:55 MTDiscord <bla8722> @Lars your fix works for me
21:55 MTDiscord <bla8722> Sokomine: see https://github.com/minetest/minetest/issues/14299
21:56 Sokomine sadly current version doesn't fix the problem yet
22:04 Sokomine the patch looks good. works for me
22:19 MTDiscord <luatic> alright, thanks for the testing. pushing in 10m then.
22:32 MTDiscord <luatic> pushed
22:51 jonadab joined #minetest-dev
23:18 jonadab joined #minetest-dev
23:32 panwolfram joined #minetest-dev
23:43 jonadab joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext