| Time |
Nick |
Message |
| 03:50 |
|
v-rob joined #minetest-dev |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 06:45 |
|
calcul0n_ joined #minetest-dev |
| 07:34 |
|
v-rob joined #minetest-dev |
| 08:14 |
rubenwardy |
So, how's the release going? |
| 08:45 |
|
MTDiscord1 joined #minetest-dev |
| 09:03 |
sfan5 |
🤷 |
| 09:28 |
[MTMatrix] |
<Zughy> Is it possible to release today? Both for the jam and for my workshop tomorrow |
| 11:00 |
MTDiscord |
<jordan4ibanez> Someone grab sfan5 the release bazooka |
| 11:00 |
MTDiscord |
<jordan4ibanez> Slightly more kick than the release cannon |
| 11:42 |
|
vampirefrog joined #minetest-dev |
| 13:08 |
|
LizzyFleck joined #minetest-dev |
| 14:19 |
MTDiscord |
<warr1024> > 5.8 will include a number of improvements, but actually making it all the way through the process of releasing 5.8 is not planned until 5.9 |
| 14:53 |
|
grorp joined #minetest-dev |
| 15:11 |
MTDiscord |
<jordan4ibanez> Yeah, that sounds about right |
| 15:32 |
|
grorp1 joined #minetest-dev |
| 16:19 |
|
Warr1024 joined #minetest-dev |
| 16:25 |
|
Desour joined #minetest-dev |
| 16:26 |
|
Warr1024 joined #minetest-dev |
| 16:29 |
|
Warr1024 joined #minetest-dev |
| 16:50 |
|
srifqi joined #minetest-dev |
| 16:51 |
srifqi |
hello. i just realised that some strings have changed |
| 16:54 |
srifqi |
caused by commit 7f93268 (#14016) due to behaviour changes |
| 16:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/14016 -- [no squash] Return texture filter settings to previous state by sfan5 |
| 16:59 |
[MTMatrix] |
<Zughy> Is it that bad? |
| 17:00 |
srifqi |
there are 3 string changes if i count correctly |
| 17:00 |
srifqi |
all of them about texture filtering |
| 17:00 |
Krock |
I did not have much time yesterday. We can continue the release this evening |
| 17:01 |
Krock |
srifqi: this is nothing unusual and is always a caveat when PRs are merged close to release |
| 17:01 |
Krock |
Who's doing the Android builds, by the way? |
| 17:02 |
srifqi |
definitely not me as i don't have the required files |
| 17:02 |
|
grorp joined #minetest-dev |
| 17:03 |
|
v-rob joined #minetest-dev |
| 17:03 |
rubenwardy |
I can do Android builds |
| 17:04 |
grorp |
srifqi: do you mean the keystore password with "the required files"? |
| 17:04 |
srifqi |
yes |
| 17:04 |
rubenwardy |
thanks to nerzhul, everyone has the keystore |
| 17:04 |
rubenwardy |
🙃 |
| 17:05 |
rubenwardy |
Minetest? Ourtest |
| 17:05 |
srifqi |
it's in the repo, yes :) |
| 17:05 |
srifqi |
which steps are we in the checklist? |
| 17:06 |
srifqi |
entering release part, i assume |
| 17:08 |
Krock |
added some simple text to the GH release page |
| 17:09 |
|
appguru joined #minetest-dev |
| 17:09 |
Krock |
rubenwardy: might it also be possible for you to push the release commit and "resume with -dev" commits to master? |
| 17:09 |
rubenwardy |
~dev Releasing_Minetest |
| 17:09 |
ShadowBot |
Releasing Minetest - Minetest Developer Wiki -- http://dev.minetest.net/Releasing_Minetest |
| 17:10 |
Krock |
I can create a new forum topic unless someone already started with that |
| 17:12 |
Krock |
(will do that in 1 hour) |
| 17:14 |
rubenwardy |
ok, will run bump version then. Seems like there's no objections |
| 17:16 |
srifqi |
+1 |
| 17:22 |
rubenwardy |
done - making android build now |
| 17:28 |
srifqi |
by the way, can we rename APK files to be something like minetest-version-platform (minetest-5.8.0-arm64-v8a.apk)? |
| 17:29 |
srifqi |
or that would break something? |
| 17:29 |
rubenwardy |
I don't think it breaks anything, would just be updating homepage links |
| 17:32 |
srifqi |
minetest-5.8.0-android-arm64-v8a.apk (?) or .apk extension already tells that it is targeted for Android |
| 17:33 |
MTDiscord |
<warr1024> rather than just android, it might be nice to add android<version> or something with the actual minimum required version. Â But relying on .apk is not great, if you want somebody to look at a pile of files and immediately know what they're for (the fact that apk is the name of alpine linux's package manager doens't help). |
| 17:35 |
MTDiscord |
<luatic> "thanks to nerzhul, everyone has the keystore" - careful, this might break Google Play ToS or something |
| 17:36 |
grorp |
this unittest will always fail for release versions: https://github.com/minetest/minetest/blob/5.8.0/games/devtest/mods/unittests/get_version.lua |
| 17:36 |
grorp |
"version.hash" is undefined there, that's even documented |
| 17:37 |
ROllerozxa |
wait, did nerzhul leak the android signing key? |
| 17:37 |
grorp |
no, only the keystore. you still need the password. |
| 17:38 |
grorp |
(but it's bad anyway) |
| 17:39 |
grorp |
+1 for having APK names contain "minetest" and the version |
| 17:40 |
srifqi |
warr1024: the minimum version is rarely changed. last time it was increased was for 5.7.0 (#13205). it is currently API 21 (Android 5.0) |
| 17:40 |
ShadowBot |
https://github.com/minetest/minetest/issues/13205 -- Android: Increase minimum SDK version to 21 by srifqi |
| 17:41 |
rubenwardy |
oh we need to tag MTG too |
| 17:42 |
Krock |
do we? |
| 17:42 |
Krock |
it's no longer bound to the Minetest release cycle |
| 17:44 |
rubenwardy |
ok, looks like there's no max version so we don't need to tag MTG |
| 17:45 |
rubenwardy |
oh no there is |
| 17:45 |
rubenwardy |
removed |
| 17:45 |
rubenwardy |
it's now 5.7+ |
| 17:45 |
rubenwardy |
rather than 5.7 only |
| 17:45 |
Krock |
min_minetest_version = 5.8.0 Â in game.conf, or what do you mean? |
| 17:45 |
rubenwardy |
in ContentDB |
| 17:48 |
rubenwardy |
Android builds uploaded to GH, uploading to gplay now |
| 17:49 |
ROllerozxa |
should MTG become rolling release now? making a release for MTG would be a good idea anyways since there's been some bugfixes (and dupe exploit fixes) since 5.7.0 |
| 17:49 |
rubenwardy |
uploaded |
| 17:54 |
Krock |
merging master back to stable-5 to contain 5.8.0. |
| 17:59 |
rubenwardy |
MTG readme needs updating too |
| 18:01 |
MTDiscord |
<siliconsniffer> Screenshot idea: MTG with a sunset resembling the debundling? |
| 18:02 |
rubenwardy |
I'd prefer to focus on postives than negatives |
| 18:02 |
sfan5 |
windows builds missing, changelog link missing |
| 18:03 |
Krock |
tag and release is not linked |
| 18:03 |
rubenwardy |
added changelog |
| 18:03 |
rubenwardy |
+link |
| 18:03 |
Krock |
actually nvm. there's still the draft |
| 18:03 |
rubenwardy |
I don't have the ability to do windows builds |
| 18:03 |
Krock |
-> https://github.com/minetest/minetest/releases/tag/untagged-399367f3735e5334e1e8 |
| 18:03 |
sfan5 |
the windows builds already exist |
| 18:03 |
Krock |
^ rubenwardy |
| 18:03 |
rubenwardy |
ahh |
| 18:03 |
rubenwardy |
will copy them |
| 18:04 |
sfan5 |
and IMO the text should be clearer to tell package maintainers that MTG is not longer preinstalled and they shouldn't be re-adding it either |
| 18:04 |
Krock |
updated stable-5 |
| 18:05 |
sfan5 |
also because if they mess it up the "ask the user to reinstall mtg" logic will not work |
| 18:06 |
rubenwardy |
added windows builds and updated descriptions |
| 18:06 |
sfan5 |
ROllerozxa: dunno about in the future but right now MTG should still be released, we had changes after all |
| 18:07 |
Krock |
writing up the forum post .... |
| 18:07 |
Krock |
what's the progress of the blog post? |
| 18:08 |
rubenwardy |
I've got text, but need a cover image |
| 18:09 |
rubenwardy |
https://github.com/minetest/blog/pull/139 |
| 18:14 |
rubenwardy |
forum post can come before blog post though |
| 18:15 |
rubenwardy |
it's just social media that depends on blog post |
| 18:15 |
rubenwardy |
and that's all me |
| 18:17 |
Krock |
does the macos build need signing now? |
| 18:17 |
Krock |
from what I've seen that's only for M1 |
| 18:17 |
Krock |
(and newer?) |
| 18:17 |
Krock |
-> https://github.com/minetest/minetest/actions/runs/7090139077 |
| 18:18 |
rubenwardy |
So for the launchpad, the packaging repo doesn't seem to mention MTG other than in licenses - so presumably the packaging is all done by cmake, which is fine |
| 18:20 |
rubenwardy |
daily build passed with that |
| 18:35 |
Krock |
a WYSIWYG forum editor would be very nice. anyway. the first release post is up. |
| 18:41 |
Krock |
flagged the Alpine Linux package as outdated. someone already did the same for Arch Linux. which ones are still to do? |
| 18:44 |
Krock |
created issues for snap and Flatpak. we should be fine now. |
| 18:44 |
srifqi |
the download part of the forum post is new |
| 18:44 |
srifqi |
usually, the download part lists links |
| 18:45 |
Krock |
I didn't feel fancy to repeat the links there in case something has to change (e.g. macos signing issue) |
| 18:46 |
Krock |
hmm the link might actually stay the same. so that's actually not an issue. I'm just lazy then :3 |
| 18:46 |
Krock |
most of the people will get the notification to the main website in-game (windows users) and download it from there |
| 18:48 |
srifqi |
the newer is better, i think, since it also describes Android platforms |
| 18:56 |
srifqi |
or it could list all while also link to the files directly for each |
| 19:23 |
|
m42uko joined #minetest-dev |
| 19:23 |
|
nrz_ joined #minetest-dev |
| 19:26 |
|
diceLibrarian joined #minetest-dev |
| 19:37 |
|
nore joined #minetest-dev |
| 19:48 |
MTDiscord |
<luatic> Congrats on the release. Unfortunately two MTG changes (on the wiki changelog) have been misattributed to me, when I was really just the one who reviewed and merged them: (1) Add API for sapling growth (by aegroto); (2) Fix coral and kelp duping with mesecons' sticky piston (by zmv7). I'd fix this myself, but I don't have a Wiki account. |
| 19:48 |
MTDiscord |
<luatic> I'll take this opportunity to shoot @celeron55 a ping. Can I get a wiki account? |
| 19:49 |
|
YuGiOhJCJ joined #minetest-dev |
| 19:50 |
MTDiscord |
<luatic> Also, why do we treat the changelog as a separate thing that is managed on the Wiki? I think it would be sensible to have the changelog be a Markdown file in the repo. |
| 19:51 |
ROllerozxa |
luatic: I can make you a wiki account if you'd like |
| 19:51 |
celeron55 |
i was going to but go ahead |
| 19:51 |
ROllerozxa |
uh, wait, the changelog is on the developer wiki and not the regular wiki |
| 19:52 |
|
v-rob joined #minetest-dev |
| 19:53 |
celeron55 |
i agree the changelog isn't necessarily best suited for the wiki and could be in the repo. the plus side of being on the wiki is that people who don't want to deal with git or PRs can add details to it |
| 19:54 |
ROllerozxa |
(I ended up just doing the edit myself) |
| 19:56 |
MTDiscord |
<luatic> Thanks |
| 19:58 |
MTDiscord |
<.niklp> who can trigger a build for the official docker image on gitlab? (iirc the gitlab mirror is a few weeks out of date) |
| 20:01 |
sfan5 |
who knows if that still works, it's unmaintained really |
| 20:01 |
|
YuGiOhJCJ joined #minetest-dev |
| 20:02 |
MTDiscord |
<.niklp> and where's the 'offical' docker image then? |
| 20:03 |
ROllerozxa |
I've heard good things about warr1024's docker images |
| 20:09 |
MTDiscord |
<warr1024> My docker images have always been 100% minetest_game-free, though I suppose with this new release, that will no longer be a competitive advantage. |
| 21:20 |
rubenwardy |
Can someone review this as both MisterE and Green are away: https://github.com/minetest/blog/pull/139 |
| 21:20 |
rubenwardy |
blog#139 |
| 21:20 |
rubenwardy |
!title |
| 21:20 |
ShadowBot |
Add 5.8.0 post by rubenwardy · Pull Request #139 · minetest/blog · GitHub |
| 21:23 |
rubenwardy |
or I suppose the post could be left until later |
| 21:33 |
|
v-rob joined #minetest-dev |
| 21:36 |
rubenwardy |
web#290 |
| 21:36 |
ShadowBot |
https://github.com/minetest/minetest.github.io/issues/290 -- Update to 5.8.0 by rubenwardy |
| 22:04 |
[MTMatrix] |
<localhost> time to git pull? |
| 22:13 |
MTDiscord |
<jordan4ibanez> Hello again. I have fixed the node placement prediction collision detection, a basically nostalgic (for the wrong reasons) bug at this point. #14068. Would you prefer that I also fix the placement timer upon placement failure in the same commit? grorp has confirmed that this is an issue and I would like input before I go about fixing it |
| 22:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/14068 -- Fix node placement collision detection failure [The Ghost Node] by jordan4ibanez |
| 22:32 |
MTDiscord |
<jordan4ibanez> I fixed it with 2 lines so I guess disregard that question |
| 22:37 |
|
turtleman joined #minetest-dev |
| 23:33 |
|
panwolfram joined #minetest-dev |
