Time |
Nick |
Message |
00:12 |
|
YuGiOhJCJ joined #minetest-dev |
00:47 |
|
Noisytoot joined #minetest-dev |
04:00 |
|
MTDiscord joined #minetest-dev |
04:20 |
|
YuGiOhJCJ joined #minetest-dev |
05:48 |
|
Alias joined #minetest-dev |
06:59 |
|
calcul0n joined #minetest-dev |
07:50 |
Krock |
will merge #13952 in 20 minutes. it's not strictly a feature; just renaming. |
07:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/13952 -- Rename mtt_update to mod_translation_updater by srifqi |
07:52 |
Krock |
I would be grateful if someone could also test #13872 to fix up some item stack movement issues on Android. |
07:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/13872 -- Formspec: Allow multiple mouse button click for touch-screen by srifqi |
07:53 |
Krock |
if srifqi's apk files do not work for you, use the one generated by the buildbot and sign it manually (there's apps for that) so that it can be installed. remember to first remove the existing Minetest installation |
08:10 |
Krock |
merging rename PR |
08:11 |
Krock |
done |
09:22 |
|
Warr1024 joined #minetest-dev |
09:46 |
|
Warr1024 joined #minetest-dev |
10:51 |
|
appguru joined #minetest-dev |
12:41 |
|
erle_on_bed joined #minetest-dev |
12:42 |
|
erle_on_bed30 joined #minetest-dev |
12:48 |
|
erle_on_bed joined #minetest-dev |
12:55 |
|
erle_on_bed43 joined #minetest-dev |
13:02 |
|
erle_on_bed joined #minetest-dev |
13:10 |
|
erle_on_bed60 joined #minetest-dev |
13:23 |
|
grorp joined #minetest-dev |
13:57 |
|
Noisytoot joined #minetest-dev |
14:30 |
|
erle_on_bed joined #minetest-dev |
14:30 |
|
erle_on_bed80 joined #minetest-dev |
15:09 |
grorp |
I've left a review on #13872 |
15:09 |
ShadowBot |
https://github.com/minetest/minetest/issues/13872 -- Formspec: Allow multiple mouse button click for touch-screen by srifqi |
15:09 |
grorp |
#13906 is still looking for reviewers as well, so that we can finally debundle MTG |
15:09 |
ShadowBot |
https://github.com/minetest/minetest/issues/13906 -- Offer ContentDB updates for leftover bundled Minetest Game by grorp |
15:34 |
|
grorp left #minetest-dev |
16:45 |
|
Oblomov joined #minetest-dev |
17:31 |
|
grorp joined #minetest-dev |
17:39 |
grorp |
thank you, rubenwardy <3 |
17:40 |
grorp |
Merging #13948, #13862, #13906 in 15 min |
17:40 |
ShadowBot |
https://github.com/minetest/minetest/issues/13948 -- Clarify `get_translated_string` string argument by Zughy |
17:40 |
ShadowBot |
https://github.com/minetest/minetest/issues/13862 -- Resolves some warnings for Android version by srifqi |
17:40 |
ShadowBot |
https://github.com/minetest/minetest/issues/13906 -- Offer ContentDB updates for leftover bundled Minetest Game by grorp |
18:12 |
rubenwardy |
next up is #13818 |
18:12 |
ShadowBot |
https://github.com/minetest/minetest/issues/13818 -- Debundle Minetest Game by rollerozxa |
18:16 |
|
grorp left #minetest-dev |
18:16 |
|
Oblomov joined #minetest-dev |
18:38 |
pgimeno |
what will happen to users that have cURL disabled? |
18:40 |
pgimeno |
will minetest_game suddenly poof for us or something? |
18:45 |
rubenwardy |
depends on how you update |
18:47 |
rubenwardy |
but if MTG is uninstalled and you have MTG worlds, you'll see a dialog telling you to reinstall MTG but clicking the button will show an error saying CDB cannot be used as cURL is disabled |
18:47 |
rubenwardy |
if you're choosing to disable cURL, you're probably technically competent enough to get MTG yourself |
18:48 |
rubenwardy |
note that we don't _delete_ MTG - but the package manager might |
18:48 |
rubenwardy |
we just show warnings and offer a path to migrate to CDB-managed installs |
19:08 |
MTDiscord |
<josiah_wi> Could someone remove the Action / change needed label from #13939? |
19:08 |
ShadowBot |
https://github.com/minetest/minetest/issues/13939 -- Extract updateClouds method from updateFrame by JosiahWI |
19:23 |
|
imi joined #minetest-dev |
19:50 |
MTDiscord |
<josiah_wi> grorp, could you clarify which line it is that needs to be unwrapped? The line about the comment only spans one line. |
19:51 |
MTDiscord |
<josiah_wi> I only see one wrapped line in the whole method, and it is the one I already adjusted. |
20:00 |
[MTMatrix] |
<Zughy> Thank you srifqi for having been focusing on my issues recently <3 |
20:24 |
|
grorp joined #minetest-dev |
20:26 |
|
YuGiOhJCJ joined #minetest-dev |
20:37 |
grorp |
josiah_wi: I've replied on the PR |
20:39 |
MTDiscord |
<josiah_wi> Ahh, I see, the comment itself may have been intended as one sentence. Thanks for the feedback, grorp. |
20:42 |
|
grorp left #minetest-dev |
20:50 |
MTDiscord |
<josiah_wi> If Ruben reviews it as well and it gets merged, I can start the next one. I want to avoid flooding the PR list by putting multiple up at a time, and I'm re-evaluating where refactoring has the most impact after each change. 😉 |
22:42 |
|
appguru joined #minetest-dev |
23:32 |
|
panwolfram joined #minetest-dev |