| Time |
Nick |
Message |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 06:40 |
|
calcul0n joined #minetest-dev |
| 08:22 |
|
Warr1024 joined #minetest-dev |
| 08:46 |
|
Warr1024 joined #minetest-dev |
| 09:06 |
|
YuGiOhJCJ joined #minetest-dev |
| 11:55 |
|
calcul0n joined #minetest-dev |
| 12:43 |
erle |
i have done a thing that ROllerozxa suggested: https://github.com/minetest/minetest/pull/13915 |
| 12:43 |
erle |
would be nice if i could get some approvals so it can get in the 5.8.0 release |
| 12:44 |
erle |
it really is an improvement for me (and probably everyone else with bad contrast vision) |
| 12:53 |
ROllerozxa |
erle: thx for opening a PR for it |
| 12:54 |
erle |
well you hadn't done it in 16 hours, so … :D |
| 12:55 |
erle |
ROllerozxa any reason why you used video::SColor(200, 255, 255, 255)); instead of pure white (what i used) … ? |
| 12:58 |
rubenwardy |
pure white and pure black is usually bad in UI# |
| 12:59 |
rubenwardy |
not that Minetest follows that at all. Also, it's not on a pure black background |
| 13:00 |
rubenwardy |
https://uxplanet.org/basicdesign-never-use-pure-black-in-typography-36138a3327a6 |
| 13:03 |
erle |
rubenwardy true, but the rest of the stuff on buttons uses pure white |
| 13:03 |
rubenwardy |
the existing icons use prue white though |
| 13:03 |
rubenwardy |
yeah |
| 13:03 |
erle |
i just wanted a quick fix to go in 5.8.0 |
| 13:03 |
erle |
and this is the simplest thing that works |
| 13:04 |
erle |
ROllerozxa wants to overhaul this entire thing anyway |
| 13:04 |
erle |
but i guess that won't be done before 5.9.0 right? |
| 13:04 |
erle |
ROllerozxa minetest buttons with windows 95 style when |
| 13:08 |
celeron55 |
the comparison in that post looks to me almost like a gamma problem in vector font rendering |
| 13:08 |
celeron55 |
i wonder if it is, and a non-pure black works around it |
| 13:10 |
celeron55 |
(or to put it in other words, antialiasing in the wrong color space) |
| 13:11 |
erle |
celeron55 no, i just use redshift |
| 13:11 |
erle |
and i did not turn it off for the screenshot |
| 13:14 |
Krock |
will merge #13877 #13894 #13896 #13910 #13911 and #13914 in 15 minutes |
| 13:14 |
ShadowBot |
https://github.com/minetest/minetest/issues/13877 -- Remove deprecation mark on TGA texture format in lua_api.md by corarona |
| 13:14 |
ShadowBot |
https://github.com/minetest/minetest/issues/13894 -- Don't throw resize lock exception in destructor when removing nodemeta inventory by Desour |
| 13:14 |
ShadowBot |
https://github.com/minetest/minetest/issues/13896 -- Add Russian translation of builtin by alek13 |
| 13:14 |
ShadowBot |
https://github.com/minetest/minetest/issues/13910 -- CSM: Fix duplicate player names by SmallJoker |
| 13:14 |
ShadowBot |
https://github.com/minetest/minetest/issues/13911 -- GUI: Autofocus newly opened GUIModalMenu instances by SmallJoker |
| 13:14 |
ShadowBot |
https://github.com/minetest/minetest/issues/13914 -- Use hypertext[] for credits so that long lines are wrapped by grorp |
| 13:14 |
rubenwardy |
merge party |
| 13:15 |
Krock |
I'll yet not merge the trivial PR from erle yet to give it some time for people to have a look at it. |
| 13:15 |
[MTMatrix] |
<Zughy> artist here: go for it |
| 13:16 |
rubenwardy |
yeah seems like a no-brainer in the examples given, only problem would be if there's knock-on affects elsewhere (but I think I've checked all the different components) |
| 13:16 |
erle |
i'd think more about ”does this affect anything else we have not thought about” |
| 13:16 |
[MTMatrix] |
<Zughy> current formspecs are bad anyway. At least they're a bit more accessible with that PR |
| 13:16 |
erle |
i maintain that if everyone in the room agrees, one should still take a step back and search for reasons the thing might be back, to exclude it breaking something else. |
| 13:17 |
erle |
but i can't think of anything else right now |
| 13:18 |
rubenwardy |
I've followed the code and checked all the components that use that setting |
| 13:18 |
erle |
can games set the scrollbar and dropdown colors? |
| 13:18 |
erle |
if so, maybe some games rely on it being black? |
| 13:19 |
erle |
it, being the symbols |
| 13:19 |
rubenwardy |
only thing is that you might want to change EGDC_GRAY_WINDOW_SYMBOL as well, that's used in some situations |
| 13:19 |
rubenwardy |
namely when disabled |
| 13:20 |
rubenwardy |
although I don't think we have an API for disabling any components |
| 13:20 |
rubenwardy |
except fields |
| 13:24 |
erle |
does that happen anywhere in the default interface? |
| 13:27 |
ROllerozxa |
erle: couldn't remember if SColor's arguments are in ARGB or RGBA, the current colour is `video::SColor(200,10,10,10)` which made me think it was ARGB |
| 13:27 |
erle |
well there is skin->setColor(gui::EGDC_BUTTON_TEXT, video::SColor(255, 255, 255, 255)); below where i put it in |
| 13:29 |
Krock |
merging |
| 13:29 |
ROllerozxa |
`SColor (u32 a, u32 r, u32 g, u32 b)` |
| 13:29 |
erle |
bad naming, it should have been called A8R8G8B8_Color or something :P |
| 13:30 |
ROllerozxa |
yeah it's ARGB, so the first argument specifies the alpha. I suppose it doesn't hurt to make the symbol colour completely opaque |
| 13:31 |
ROllerozxa |
btw, changing that GUI skin colour also changes the colour of the checkbox symbol to white, unsure if that's bad contrast compared to a black checkbox symbol |
| 13:32 |
ROllerozxa |
(and on higher densities it gets replaced with a higher-res black checkbox texture) |
| 13:32 |
Krock |
merged. https://youtu.be/OItnW4aBXjU?feature=shared&t=20 |
| 13:34 |
erle |
ROllerozxa it looks like better contrast to me with default settings, but i can't say. i suggest to use the formula from WCAG 2.0 to check. |
| 13:34 |
erle |
ROllerozxa i take it back, that is DEFINITELY better contrast than the black symbol |
| 13:35 |
ROllerozxa |
I see. maybe the higher-res checkbox textures should be made white too then |
| 13:35 |
rubenwardy |
that would make sense |
| 13:35 |
erle |
sounds like a good idea, where is it? |
| 13:35 |
erle |
and how to trigger it even |
| 13:36 |
ROllerozxa |
textures/base/pack/checkbox_{16,32,64}.png |
| 13:36 |
ROllerozxa |
shows up on higher densities since the default checkbox symbol becomes too small then |
| 13:36 |
erle |
how to trigger these things? |
| 13:37 |
ROllerozxa |
the code for it is about right underneath where you set the symbol colour :P |
| 13:37 |
erle |
i mean minetest is famously weird in regards to DPI, so what do |
| 13:37 |
ROllerozxa |
https://github.com/minetest/minetest/blob/35ace0bb4c1109461bc6b0a7e6964899c8bed663/src/client/clientlauncher.cpp#L154 |
| 13:37 |
erle |
give me a moment |
| 13:37 |
ROllerozxa |
the `density` variable is based off of the display density as well as the gui scaling |
| 13:38 |
rubenwardy |
you can change the gui_scaling setting |
| 13:38 |
rubenwardy |
increase it |
| 13:39 |
erle |
thx |
| 13:39 |
erle |
i'll see if there are any other symbols |
| 13:40 |
erle |
seems to be the only one |
| 13:40 |
erle |
hey these are antialiased boooooooo |
| 13:41 |
erle |
brb figuring out how they were rendered |
| 13:43 |
erle |
https://github.com/minetest/minetest/pull/7834 lol |
| 13:43 |
erle |
> The images were exported from Inkscape using a SVG I created myself, which I can also include if desired. |
| 13:43 |
erle |
(SVG is not included in the commit) |
| 13:43 |
erle |
let's see if they can just be inverted |
| 13:43 |
ROllerozxa |
the checkbox SVG looks to be in android/icons/ |
| 13:44 |
ROllerozxa |
checkbox_tick.svg |
| 13:44 |
ROllerozxa |
that folder really could use being moved to misc/ or something |
| 13:47 |
|
appguru joined #minetest-dev |
| 13:48 |
erle |
ROllerozxa i just did invert in mtpaint and i'll see how it looks |
| 13:51 |
erle |
great, checkbox_16_white.png exists hehe |
| 13:51 |
erle |
(for other purposes) |
| 13:56 |
erle |
rubenwardy gui scaling does not seem to affect the size of the checkboxes (or how big do i have to make it? 3.0 and 4.0 still gave me small checkboxes) |
| 13:58 |
rubenwardy |
No idea, looks like 4 should work from the code |
| 13:58 |
rubenwardy |
Make sure you restart after changing settings |
| 13:58 |
erle |
oh that's it probably |
| 13:59 |
erle |
the thing is, the rest of the interface changes scale immediately when i set it |
| 13:59 |
erle |
this is a bit w eird |
| 13:59 |
erle |
works |
| 14:04 |
erle |
ROllerozxa rubenwardy i updated #13915 thank you both for the help |
| 14:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/13915 -- Set color of symbols on scrollbar and dropdown buttons to white by erlehmann |
| 14:04 |
erle |
oh no |
| 14:04 |
erle |
wait i need to push |
| 14:04 |
erle |
sorry |
| 14:04 |
erle |
now ;) |
| 14:06 |
rubenwardy |
You don't need to ping me everytime |
| 14:07 |
erle |
ok |
| 14:07 |
nrz |
Thanks sfan5 for the merge on irrmt |
| 14:11 |
erle |
what is the correct way to patch the german translations, given they are imported from somwhere? the settings dialog says “Rücktaste” (backspace) instead of “Zurück” (back) in the lower left. |
| 14:12 |
MTDiscord |
<mnh48> translations are done through weblate so go there |
| 14:13 |
erle |
where is “there”? |
| 14:13 |
MTDiscord |
<mnh48> weblate |
| 14:13 |
MTDiscord |
<mnh48> https://hosted.weblate.org/projects/minetest/ |
| 14:13 |
erle |
thanks |
| 16:09 |
|
Desour joined #minetest-dev |
| 17:05 |
|
Wuzzy joined #minetest-dev |
| 17:16 |
|
appguru joined #minetest-dev |
| 17:18 |
Wuzzy |
just completed the german translation on weblate ... i will now test if everything looks ok |
| 17:23 |
Wuzzy |
yikes. just 1 minute in testing, and already found a non-translatable word: "Accessibility" (in the settings) :-( |
| 17:25 |
Wuzzy |
aaand found another one... yeah i guess ill make a list. expect an issue soon |
| 17:35 |
erle |
Wuzzy bottom left of settings dialog should be “Zurück” and not “Rücktaste” |
| 17:41 |
erle |
Wuzzy why would the appropriate german word for accessability in the interface not be “Barrierefreiheit” … ? |
| 17:52 |
Wuzzy |
thanks about rücktaste (lol) |
| 17:54 |
Wuzzy |
"Accessibility" *can't* be translated on weblate although it was recently updated. maybe something went wrong with collecting the settings strings or it was forgotten to collect/update them? |
| 17:54 |
erle |
oh i see that's what you mean with untranslatable |
| 18:43 |
|
izzyb joined #minetest-dev |
| 18:46 |
[MTMatrix] |
<Zughy> Can we please get rid of the issue form? Desour "hates" it (last issue), I pretty much despise it as well. It's more noise than else |
| 18:48 |
sfan5 |
I haven't had to use it yet but my general opinion towards issue forms is more negative than positive |
| 18:54 |
rubenwardy |
the form it too specified, would be better with fewer fields |
| 18:56 |
erle |
i think it would be good if the optional stuff would just be part of an issue template |
| 18:56 |
erle |
or if everything would be, so i could copy and paste my config (which is always the same) |
| 18:56 |
erle |
well, almost always |
| 18:59 |
rubenwardy |
ie: active renderer, irrlicht device, OS, cpu model, gpu model should just be a single "System information" |
| 18:59 |
rubenwardy |
even better, just use the new "copy" in "About" for that |
| 19:00 |
Desour |
those info should at least go under one big header, and not take up half of the message in display size |
| 19:01 |
erle |
maybe minetest should output that info too |
| 19:35 |
erle |
so what's the opinion on the white checkmark that is already there? is this enough of a separate concern that it should not be unified with the new whict checkmarks? |
| 19:44 |
|
appguru joined #minetest-dev |
| 21:08 |
MTDiscord |
<josiah_wi> Could it be that part of the annoyance with the issue form is that it's designed for users who might not know what information is relevant to the issue? I can imagine a scenario where it might be good to have an issue form for someone who has little technical knowledge. But I agree that for developers it's a bit of a pain to have to fill out detailed, unrelated information every time. |
| 21:57 |
|
Noisytoot joined #minetest-dev |
| 22:35 |
|
panwolfram joined #minetest-dev |
| 23:20 |
|
Noisytoot joined #minetest-dev |
| 23:25 |
|
Noisytoot joined #minetest-dev |
