Time |
Nick |
Message |
00:40 |
|
proller joined #minetest-dev |
00:44 |
|
Noisytoot joined #minetest-dev |
02:42 |
|
tekakutli joined #minetest-dev |
03:39 |
|
YuGiOhJCJ joined #minetest-dev |
04:00 |
|
MTDiscord joined #minetest-dev |
04:03 |
|
MTDiscord joined #minetest-dev |
04:07 |
|
MTDiscord joined #minetest-dev |
04:10 |
|
MTDiscord1 joined #minetest-dev |
04:24 |
|
appguru joined #minetest-dev |
05:48 |
|
calcul0n joined #minetest-dev |
06:21 |
|
olliy joined #minetest-dev |
08:33 |
Zughy[m] |
Desour: please don't ask for changes in a PR that hasn't been supported by a core dev. It creates the false sense of security in the contributor and it makes triagers looks like bad people when the PR gets closed (in case no one supported it). I'm referring to #13566 |
08:33 |
ShadowBot |
https://github.com/minetest/minetest/issues/13566 -- Add ability to override item's point-range using meta by LandonAConway |
08:45 |
|
calcul0n joined #minetest-dev |
10:56 |
|
qur joined #minetest-dev |
10:59 |
|
qur joined #minetest-dev |
11:01 |
|
proller joined #minetest-dev |
11:19 |
|
proller joined #minetest-dev |
12:08 |
|
olliy joined #minetest-dev |
12:15 |
|
tekakutli joined #minetest-dev |
12:20 |
|
olliy joined #minetest-dev |
12:59 |
|
appguru joined #minetest-dev |
13:36 |
pgimeno |
regarding markdown and special symbols, I believe that the backslash works as an escape for special symbols |
13:38 |
|
qur joined #minetest-dev |
14:59 |
MTDiscord |
<luatic> indeed; normally I'd expect everything that has a strict syntax and needs to be followed verbatim (e.g. anything that isn't code) to use inline code blocks (backticks) though |
15:57 |
|
v-rob joined #minetest-dev |
16:22 |
|
Alias joined #minetest-dev |
17:26 |
|
v-rob joined #minetest-dev |
17:48 |
|
diceLibrarian joined #minetest-dev |
18:06 |
|
qur joined #minetest-dev |
19:12 |
|
appguru joined #minetest-dev |
19:16 |
|
appguru joined #minetest-dev |
19:35 |
|
tekakutli joined #minetest-dev |
19:51 |
|
qur joined #minetest-dev |
20:03 |
|
imi joined #minetest-dev |
20:48 |
|
qur joined #minetest-dev |
20:57 |
|
Desour joined #minetest-dev |
21:26 |
imi |
where does minetest.string_to_area come from? is there a minetest=core line somewhere? |
21:27 |
rubenwardy |
yes, minetest = core |
21:27 |
MTDiscord |
<savilli> Exactly this line in init.lua |
21:34 |
imi |
I can't change the specification of any funtions in core. Can I? If I do so it will be rejected, won't it? |
21:34 |
rubenwardy |
core and minetest are the same table, you can override into it as you please |
21:34 |
rubenwardy |
not that it's always a good idea |
21:35 |
imi |
of what if I make an iterface change that is backwards compatible? |
21:35 |
rubenwardy |
you could override and completely break the API if you wanted. People wouldn't install your mod though |
21:36 |
imi |
well, I want to submit a PR regarding minetest.string_to_area |
21:36 |
imi |
and I want my PR to be accepted :p |
21:37 |
imi |
on error returns with nil, nil, "descriptive error" -- would that be accepted? |
21:37 |
imi |
previously it returned with nil,nil on error |
21:37 |
MTDiscord |
<savilli> We don't do that here |
21:38 |
imi |
ok so 100% no changes in api |
21:38 |
imi |
I guess |
21:39 |
MTDiscord |
<savilli> 100% no accepted PRs |
21:39 |
imi |
let me show you what I want to submit az a PR: |
21:39 |
MTDiscord |
<savilli> Jokes aside, you should start with an issue |
21:40 |
imi |
https://onecompiler.com/lua/3zbh8h8xp |
21:42 |
imi |
comments explain the issue I'm having, there's some lua code functionality implemented, and also some comments regardin why I think my solution is good from a (mod) developer perspective (and admin as well) |
21:42 |
imi |
and also you have just seen it running :) |
21:54 |
sfan5 |
we really need to revise our issue template (or close issues if they do not provide the information), it took way too much back and forth in #13582 to discover that the reporter is using a view range of 4000 |
21:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/13582 -- 5.7.0 is extremely slow on Linux |
22:18 |
imi |
should I submit my issue to MT or MT game? |
22:35 |
|
panwolfram joined #minetest-dev |
22:39 |
MTDiscord |
<savilli> MT |
22:47 |
Zughy[m] |
sfan5: I'm a fan of the former (just close). The template is clear, if they delete it, it's at their own risk |
22:50 |
MTDiscord |
<savilli> The template doesn't ask to paste minetest.conf tho |
23:42 |
|
Alias joined #minetest-dev |
23:43 |
|
epoch joined #minetest-dev |
23:44 |
epoch |
so, I was just thinking of something in relation to #7400 that might make "linking" to minetest servers slightly less painful |
23:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/7400 -- Support minetest:// custom browser protocol |
23:46 |
epoch |
if webpages used https://www.w3.org/TR/web-share/ to "link" to minetest servers, it would open a share dialog on browsers (except firefox) |
23:46 |
epoch |
and minetest could be a share target |
23:47 |
epoch |
I figure I should make a PoC I guess |
23:50 |
epoch |
since a lot of people don't actually install minetest and just run it from a dir, the bits to grab the minetest: handler should probably be a button inside like, the settings tab |
23:50 |
epoch |
instead of trying to tie it into an installer script that won't get ran |
23:51 |
epoch |
this would allow people to have multiple versions and flip between which one they want as the default handler |
23:56 |
|
proller joined #minetest-dev |