| Time |
Nick |
Message |
| 00:05 |
|
tekakutli joined #minetest-dev |
| 00:25 |
|
imi joined #minetest-dev |
| 00:57 |
|
ShadowBot joined #minetest-dev |
| 02:26 |
|
YuGiOhJCJ joined #minetest-dev |
| 02:38 |
|
YuGiOhJCJ joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:06 |
MTDiscord |
<josiah_wi> Ah, wonderful, there's an unhandled exception in minetestserver that I somehow exposed by running the unittests in a docker container. |
| 04:10 |
|
fluxionary joined #minetest-dev |
| 04:13 |
MTDiscord |
<josiah_wi> I would like feedback on https://github.com/minetest/minetest/pull/13573. |
| 04:20 |
|
imi joined #minetest-dev |
| 05:00 |
|
calcul0n joined #minetest-dev |
| 05:47 |
|
tekakutli joined #minetest-dev |
| 06:26 |
|
appguru joined #minetest-dev |
| 08:04 |
|
appguru joined #minetest-dev |
| 11:17 |
|
YuGiOhJCJ joined #minetest-dev |
| 11:43 |
|
proller joined #minetest-dev |
| 11:58 |
sfan5 |
when was vector.new added again? 5.0 probably right? |
| 11:58 |
sfan5 |
if we had better documentation it would contain this information |
| 12:09 |
sfan5 |
0.4.8 actually lmao |
| 12:32 |
rubenwardy |
agreed, version info like that would be nice |
| 12:32 |
rubenwardy |
wasn't that one of the goals of minetest_docs? |
| 13:58 |
|
Noisytoot joined #minetest-dev |
| 14:04 |
|
appguru joined #minetest-dev |
| 14:08 |
|
appguru joined #minetest-dev |
| 15:19 |
|
fluxionary joined #minetest-dev |
| 16:18 |
|
appguru joined #minetest-dev |
| 16:56 |
|
proller joined #minetest-dev |
| 17:02 |
|
v-rob joined #minetest-dev |
| 17:19 |
MTDiscord |
<josiah_wi> We have an ipv6 unit test that can only run out of a docker container on Linux hosts after the experimental ipv6 support has been manually enabled. |
| 17:20 |
MTDiscord |
<josiah_wi> Maybe it would be better classified as an integration test. I'm wondering whether it would be better to disable the test on docker, or try to move it to some kind of integration suite. |
| 17:39 |
sfan5 |
which unit test would that be? |
| 17:48 |
|
v-rob joined #minetest-dev |
| 18:04 |
|
appguru joined #minetest-dev |
| 18:18 |
MTDiscord |
<josiah_wi> TtstIPv6Socket |
| 18:18 |
MTDiscord |
<josiah_wi> TestIPv6Socket* |
| 18:21 |
sfan5 |
it already has a graceful fallback |
| 18:22 |
MTDiscord |
<josiah_wi> By graceful fallback do you mean throwing an unhandled exception in the server and resulting in a test run failure? |
| 18:24 |
sfan5 |
no |
| 18:25 |
|
schwarzwald[m] joined #minetest-dev |
| 18:26 |
*Â schwarzwald[m] |
posted a file: (13KiB) < https://libera.ems.host/_matrix/media/v3/download/matrix.org/MnOCjnqMzPtJzsaTBhpYIOcC/log.txt > |
| 18:26 |
MTDiscord |
<josiah_wi> That's the log. I'll look into it and see whether I can add a regression test. |
| 18:27 |
sfan5 |
seems weird that it can open and bind the socket and everything but fails to send the packet |
| 18:30 |
sfan5 |
needs more investigation |
| 18:34 |
MTDiscord |
<josiah_wi> I ran fresh copy of the same build configuration on the host Manjaro VM and the test passed there. It does seem to be related to docker's ipv6 restrictions. The log shows the related ipv4 test passing. |
| 19:00 |
MTDiscord |
<josiah_wi> The error is "Address not available", which doesn't seem to be documented in the man page for sendto. |
| 19:06 |
MTDiscord |
<josiah_wi> The error code is probably from bind indicating that the requested address is not available from the local machine. Interesting. |
| 19:07 |
MTDiscord |
<josiah_wi> I've been on the computer since 5 am (it's now 2 pm) so I should take a break from this. At least there's some progress. |
| 19:39 |
MTDiscord |
<luatic> rubenwardy: no, documenting decade-old features was never a goal; we're currently targeting latest master, and even that we can not keep up with... |
| 19:39 |
MTDiscord |
<luatic> documenting the age of these features was never a goal* |
| 19:41 |
MTDiscord |
<greenxenith> Though it isn't a bad one to add to a future list |
| 20:09 |
sfan5 |
it's not about documenting that the feature is a decade old |
| 20:09 |
sfan5 |
vector.new is a bad example |
| 20:10 |
sfan5 |
but for other functions is very valid to wonder "was this added in 5.5" when you're e.g. targeting your game or mod at two minor versions back |
| 20:16 |
MTDiscord |
<luatic> indeed |
| 21:00 |
|
fluxionary joined #minetest-dev |
| 21:12 |
|
fluxionary joined #minetest-dev |
| 21:34 |
|
pmp-p joined #minetest-dev |
| 22:32 |
|
panwolfram joined #minetest-dev |
| 22:49 |
|
Desour joined #minetest-dev |
| 23:34 |
|
proller joined #minetest-dev |
| 23:57 |
|
AliasAlreadyTake joined #minetest-dev |
