| Time |
Nick |
Message |
| 00:02 |
|
tekakutli joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 06:05 |
|
calcul0n joined #minetest-dev |
| 06:49 |
|
tekakutli joined #minetest-dev |
| 07:07 |
|
YuGiOhJCJ joined #minetest-dev |
| 08:50 |
|
ivanbu joined #minetest-dev |
| 09:17 |
|
olliy joined #minetest-dev |
| 09:17 |
|
proller joined #minetest-dev |
| 09:35 |
|
olliy joined #minetest-dev |
| 10:28 |
|
Guest54 joined #minetest-dev |
| 10:44 |
sfan5 |
can we merge #13078 |
| 10:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/13078 -- AppImageBuilder.yml: add script section and update to Jammy by cat-master21 |
| 10:48 |
|
Alias joined #minetest-dev |
| 10:56 |
sfan5 |
its just some maintenance/fix stuff to a build script, not worth holding up |
| 10:56 |
rubenwardy |
lgtm |
| 10:58 |
Zughy[m] |
As someone suggested a few days ago, we could do that for every Jude PR having one approval, it's a kind of exception |
| 10:59 |
rubenwardy |
there's only one PR like that |
| 10:59 |
rubenwardy |
#13017 |
| 10:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/13017 -- Implement `minetest.get_node` and `minetest.get_node_or_nil` with LuaJIT FFI by TurkeyMcMac |
| 11:00 |
rubenwardy |
oh I suppose you mean future one approvals too |
| 11:21 |
Zughy[m] |
Yes |
| 11:49 |
rubenwardy |
merging #13078 in 10 |
| 11:49 |
ShadowBot |
https://github.com/minetest/minetest/issues/13078 -- AppImageBuilder.yml: add script section and update to Jammy by cat-master21 |
| 11:50 |
rubenwardy |
!tell Desour #13320 and/or #13234 can be merged if you self-approve |
| 11:50 |
ShadowBot |
rubenwardy: OK. |
| 11:51 |
rubenwardy |
Krock: #13360 and/or #12595 can be merged if you self-approve |
| 11:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/13360 -- InventoryManager: Disallow resizing or deleting inventory lists that are in use by SmallJoker |
| 11:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/12595 -- [MANUAL SQUASH] Inventory: Fix order of callbacks when swapping items by SmallJoker |
| 11:58 |
Zughy[m] |
Reminder that every issue in #12480 has been addressed and that it's best to merge it as soon as we can. We just need an approval/review 🙏 |
| 11:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/12480 -- [Manual Squash] Redesign/unify mainmenu settings interface by rubenwardy |
| 11:59 |
Zughy[m] |
we're also close to 90 PRs again, nice! Let's go, people |
| 12:43 |
|
olliy joined #minetest-dev |
| 12:50 |
Zughy[m] |
also, erle (or Guest54 I guess): if you want to contribute, there are two issues about the TGA nodes you implemented. I'm pretty sure you can fix them easily https://github.com/minetest/minetest/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+TGA |
| 12:51 |
Guest54 |
good idea, thanks |
| 12:57 |
Guest54 |
Zughy[m] since you do texture stuff, i suspect that any imagemagick convert(1) bug similar to #12570 (images get flipped upside down when using imagemagick, it seems to happen to everyone sooner or later) can be solved by passing `-auto-orient` – presumably because it triggers the bug *twice* (i.e. the image is right side up). |
| 12:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/12570 -- “TGA Type 2 (uncompressed RGB) top-bottom Test Node” devtest node texture is flipped upside down |
| 13:00 |
Guest54 |
ig i have to try to figure out how to explain the test nodes too |
| 13:05 |
rubenwardy |
I think Zughy wanted to you to do it, not talk more about it |
| 13:06 |
Zughy[m] |
^ |
| 13:07 |
Guest54 |
ok |
| 13:52 |
pgimeno |
what does ImageMagick have to do with anything there? |
| 13:54 |
pgimeno |
does Minetest use it internally or something? |
| 13:59 |
MTDiscord |
<Niklp> minetest uses libpng not Imagemagick |
| 14:02 |
Guest54 |
minetest does not use imagemagick – but i used imagemagick to generate the tga test images. i just told zughy about the bug because zughy does textures and you basically run into “i converted a file using imagemagick and it got flipped upside down” at some point if you use imagemagick, so it was just a friendly word of advice. |
| 14:06 |
pgimeno |
the image in the repo is certainly upside down |
| 14:06 |
pgimeno |
I've seen quite some TGA encoders produce erroneous images |
| 14:09 |
MTDiscord |
<luatic> Niklp: For obvious reasons, Minetest does not use libpng to read TGAs |
| 14:11 |
MTDiscord |
<Niklp> I meant libpng for most of the images. The question was not what lib minetest uses for TGAs |
| 14:13 |
pgimeno |
https://github.com/minetest/minetest/blob/master/games/devtest/mods/testnodes/textures/testnodes_tga_type2_16bpp_tb.tga is the image in question |
| 14:16 |
Guest54 |
pgimeno there is no faulty TGA encoding here – the only thing that happened is that imagemagick used to work correctly, but they refucktored their code to treat scanline order and image orientation the same. the result is that every time your output and input to convert(1) have different conventions for how bytes are saved in the file imagemagick |
| 14:16 |
Guest54 |
randomly flips your file. |
| 14:17 |
Guest54 |
anyways, i will fix it |
| 14:17 |
Guest54 |
and if you want an elaborate explanation, ask me in query |
| 14:18 |
pgimeno |
anyway, imagemagick lost my trust more than 20 years ago |
| 14:23 |
Guest54 |
well, given the devs insist that the correct response to “seemingly randomly flipping images upside down or rotating them” is “we do not consider this a bug” and closing the issue, i can understand that lol |
| 15:06 |
|
fluxionary joined #minetest-dev |
| 15:13 |
|
Desour joined #minetest-dev |
| 15:14 |
rubenwardy |
pretty trivial PR #13428 Â . Â Went through the new settings menu looking for things that looked wrong - bad labels, incorrect defaults, bad placement |
| 15:14 |
ShadowBot |
https://github.com/minetest/minetest/issues/13428 -- Update settingtypes by rubenwardy |
| 16:13 |
rubenwardy |
sfan5:  moving from  `opengl,gles,gles2,` to `,opengl,gles,gles2` fixed the issue, bizzare |
| 16:53 |
|
Desour joined #minetest-dev |
| 16:57 |
|
Fleckenstein joined #minetest-dev |
| 17:19 |
|
crazyR joined #minetest-dev |
| 17:46 |
|
tekakutli joined #minetest-dev |
| 18:44 |
rubenwardy |
merging https://github.com/minetest/irrlicht/pull/192 in 10 |
| 18:44 |
rubenwardy |
irrlicht#192 |
| 18:44 |
rubenwardy |
irr#192 |
| 18:44 |
ShadowBot |
https://github.com/minetest/irrlicht/issues/192 -- Fix ComboBox changing on scroll when in a scroll container by rubenwardy |
| 18:45 |
|
Fleckenstein joined #minetest-dev |
| 18:57 |
Desour |
rubenwardy: ring ring ring |
| 18:58 |
rubenwardy |
classic |
| 18:58 |
rubenwardy |
done |
| 18:58 |
Desour |
merging #12861, #13320, #13234 in 5 |
| 18:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/12861 -- Store whether window is maximized by Desour |
| 18:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/13320 -- Fix background[] pos-offset lower-right-corner being at least (1,1) by Desour |
| 18:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/13234 -- Throw Hopcroft-Karp at shapeless craft recipes by Desour |
| 18:59 |
rubenwardy |
woo |
| 19:10 |
Desour |
done. |
| 19:13 |
rubenwardy |
merging trivial bug fix #13429 in 10 |
| 19:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/13429 -- Prevent installing mods when there is no base game by rubenwardy |
| 19:34 |
rubenwardy |
pushing another trivial bug fix in 10: https://github.com/rubenwardy/minetest/commit/b89077187b22ba7e8ca4c3ff95aeb49caff75b7b |
| 19:34 |
rubenwardy |
!title |
| 19:34 |
ShadowBot |
Fix ContentDB page not being reset when changing type · rubenwardy/minetest b890771 · GitHub |
| 19:44 |
rubenwardy |
done |
| 20:06 |
|
proller joined #minetest-dev |
| 20:23 |
|
Fleckenstein joined #minetest-dev |
| 20:31 |
|
diceLibrarian joined #minetest-dev |
| 20:32 |
|
proller joined #minetest-dev |
| 20:39 |
|
YuGiOhJCJ joined #minetest-dev |
| 20:44 |
|
tekakutli joined #minetest-dev |
| 21:21 |
rubenwardy |
Desour: did you want to take another look at #13428 |
| 21:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/13428 -- Update settingtypes by rubenwardy |
| 21:21 |
rubenwardy |
thought this PR would be more straightforward than it was :D |
| 21:22 |
Desour |
nope, it's fine |
| 21:22 |
rubenwardy |
merging in 10 then |
| 21:22 |
Desour |
(just didn't approve so that sfan5 can take a 2nd look) |
| 21:43 |
|
Desour joined #minetest-dev |
| 22:10 |
|
tekakutli joined #minetest-dev |
| 23:10 |
|
proller joined #minetest-dev |
| 23:20 |
|
proller joined #minetest-dev |
| 23:37 |
|
AliasAlreadyTake joined #minetest-dev |
