| Time |
Nick |
Message |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:49 |
|
calcul0n joined #minetest-dev |
| 05:04 |
|
YuGiOhJCJ joined #minetest-dev |
| 05:17 |
|
YuGiOhJCJ joined #minetest-dev |
| 07:17 |
|
Noisytoot joined #minetest-dev |
| 08:22 |
|
YuGiOhJCJ joined #minetest-dev |
| 08:48 |
|
Noisytoot joined #minetest-dev |
| 09:05 |
|
Noisytoot joined #minetest-dev |
| 09:28 |
|
Noisytoot joined #minetest-dev |
| 10:03 |
|
calcul0n_ joined #minetest-dev |
| 10:08 |
|
Noisytoot joined #minetest-dev |
| 10:44 |
|
Noisytoot joined #minetest-dev |
| 11:44 |
|
proller joined #minetest-dev |
| 11:49 |
|
proller joined #minetest-dev |
| 13:00 |
|
Taoki joined #minetest-dev |
| 13:21 |
|
Noisytoot joined #minetest-dev |
| 13:27 |
|
Noisytoot joined #minetest-dev |
| 13:29 |
|
Fixer joined #minetest-dev |
| 14:06 |
|
calcul0n joined #minetest-dev |
| 14:20 |
|
Noisytoot joined #minetest-dev |
| 14:32 |
|
Noisytoot joined #minetest-dev |
| 14:40 |
|
srifqi joined #minetest-dev |
| 14:42 |
|
Noisytoot joined #minetest-dev |
| 14:52 |
|
Noisytoot joined #minetest-dev |
| 15:24 |
|
Noisytoot joined #minetest-dev |
| 15:41 |
|
fluxionary joined #minetest-dev |
| 17:17 |
|
fluxionary joined #minetest-dev |
| 17:29 |
|
calcul0n joined #minetest-dev |
| 17:34 |
|
sofar joined #minetest-dev |
| 17:35 |
|
sofar joined #minetest-dev |
| 17:37 |
|
sofar joined #minetest-dev |
| 17:38 |
|
sofar joined #minetest-dev |
| 18:12 |
|
Noisytoot joined #minetest-dev |
| 19:11 |
|
Noisytoot joined #minetest-dev |
| 19:32 |
sfan5 |
celeron55_: can we have a rule that I can merge maintenance PRs after 30 days of inaction |
| 19:41 |
kilbith |
you're the most involved, for me it makes sense that you have a little more privileges than the others |
| 19:42 |
Warr1024 |
At my work, we often use a rule that as long as one engineer wants to merge a change, and they solicit objections and wait a bit, if everybody stays silent, then that's treated as silent approval, because often you just can't find 2 people who have an opinion at all. Might as well make 30 days with 1 approval and no objections count as equivalent |
| 19:42 |
Warr1024 |
to a second approval. |
| 19:47 |
Pexin |
then the merge breaks something unanticipated and a bunch of people suddenly have an opinion ;] |
| 19:48 |
Pexin |
"well lesson learned then. pay attention next time!" |
| 19:51 |
Warr1024 |
Indeed. |
| 19:56 |
|
proller joined #minetest-dev |
| 20:01 |
sfan5 |
rubenwardy: there's probably one thing about it, namely since we have x86 builds now the version code needs to be bumped by 4 not 2 |
| 20:01 |
sfan5 |
is that accurate? |
| 20:02 |
rubenwardy |
Hmmm maybe. I didn't upload them in the last release |
| 20:02 |
rubenwardy |
Actually, I used an app bundle so maybe the +2 thing isn't needed |
| 20:03 |
sfan5 |
¯\_(ツ)_/¯ |
| 20:17 |
MTDiscord |
<luatic> Pexin: TBF sfan5 has a very good track record of rarely breaking things |
| 20:26 |
nrz |
👋 regarding the roadmap, it seems you wanted a bit refacto. I published a 1h30 PR to refacto one part of not very nice legacy code to a nicer one (pretty straight forward change): #12885 |
| 20:26 |
ShadowBot |
https://github.com/minetest/minetest/issues/12885 -- [NOSQUASH] refacto: Reduce exposure of StaticObjectList & Lighting by nerzhul |
| 20:26 |
nrz |
no function change, just put responsibility in action for StaticObjectList and Lighting to prevent bad uses |
| 20:27 |
nrz |
+ some codestyles cleanups (not all but some ez on the research path) |
| 20:28 |
nrz |
i hope this one won't be forgotten in hell 😄 it's relatively readable, i didn't took time to do a 1k line modification this time haha |
| 20:29 |
nrz |
when merged i will continue the cleanup around m_static_objects on mapblock, i think i have a good way to reduce its exposure, but it's not so straightfoward and i'd prefer to have #12885 merged to validate the refacto path is fine to continue |
| 20:29 |
ShadowBot |
https://github.com/minetest/minetest/issues/12885 -- [NOSQUASH] refacto: Reduce exposure of StaticObjectList & Lighting by nerzhul |
| 20:33 |
kilbith |
I'm sure hmmmm will love all these cleanups |
| 20:33 |
kilbith |
/s |
| 21:01 |
|
Noisytoot joined #minetest-dev |
| 22:34 |
|
panwolfram joined #minetest-dev |
| 23:58 |
|
fossdev2 joined #minetest-dev |
