| Time |
Nick |
Message |
| 00:00 |
|
jwmhjwmh joined #minetest-dev |
| 00:27 |
schwarzwald[m] |
IrrlichtMt has quite a few warnings on MSVC about narrowing 64bit return values to 32bit. |
| 00:43 |
ensayia |
Does anyone have insight on defining biomes in decoration specs? Following the guide I was sure I did it right, but I did not want to file a big report if it's a known issue. |
| 00:44 |
ensayia |
They do not seem to work at all, at least it was placing them in biomes I had not specified. |
| 01:00 |
|
Soni joined #minetest-dev |
| 01:43 |
|
schwarzwald[m] joined #minetest-dev |
| 01:46 |
|
Zughy[m] joined #minetest-dev |
| 02:01 |
|
programmerjake joined #minetest-dev |
| 02:05 |
|
k327[m] joined #minetest-dev |
| 03:07 |
|
troller joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:49 |
|
calcul0n_ joined #minetest-dev |
| 05:24 |
|
jwmhjwmh joined #minetest-dev |
| 07:46 |
sfan5 |
mod development is a topic for #minetest btw |
| 07:47 |
sfan5 |
if something is too unclear don't worry about filing a bug report, the documentation on this isn't that good |
| 08:54 |
|
YuGiOhJCJ joined #minetest-dev |
| 09:19 |
|
olliy joined #minetest-dev |
| 09:55 |
|
appguru joined #minetest-dev |
| 10:05 |
|
Goobax[m] joined #minetest-dev |
| 10:16 |
|
jwmhjwmh joined #minetest-dev |
| 10:19 |
jwmhjwmh |
As a core dev, can I approve my own PRs, provided I actually review the code? |
| 10:19 |
|
MisterE[m] joined #minetest-dev |
| 10:19 |
|
programmerjake joined #minetest-dev |
| 10:19 |
|
Zughy[m] joined #minetest-dev |
| 10:19 |
|
schwarzwald[m] joined #minetest-dev |
| 10:20 |
|
TrailBreaker[m] joined #minetest-dev |
| 10:20 |
|
fgaz joined #minetest-dev |
| 10:20 |
|
k327[m] joined #minetest-dev |
| 10:20 |
|
Whanake[m] joined #minetest-dev |
| 10:20 |
|
_Zaizen_Old[m] joined #minetest-dev |
| 10:21 |
appguru |
jwmhjwmh: I believe it is assumed that you approve your PRs by default as soon as you submit them for review. One approval suffices. |
| 10:21 |
jwmhjwmh |
Cool. |
| 10:25 |
rubenwardy |
you can approve your own PRs, but you don't approve them by default |
| 10:26 |
rubenwardy |
you can implicitly improve them by merging your own PR once you get another approval |
| 10:28 |
|
HuguesRoss joined #minetest-dev |
| 10:32 |
jwmhjwmh |
Thanks for the info. |
| 10:33 |
jwmhjwmh |
Merging #12802 in 15m. |
| 10:33 |
ShadowBot |
https://github.com/minetest/minetest/issues/12802 -- Add lighting test and benchmark by TurkeyMcMac |
| 10:37 |
rubenwardy |
nice |
| 10:38 |
MTDiscord |
<luatic> 🎉 congrats on becoming a core dev |
| 10:40 |
jwmhjwmh |
Thanks! |
| 10:50 |
Zughy[m] |
Congratulations! |
| 10:52 |
Zughy[m] |
Also, being a core dev, your PRs are automatically approved for the roadmap. And you've got two more PRs with one approval that you can merge + a two approvals PR |
| 10:52 |
MTDiscord |
<ROllerozxa> woo, new coredev time! |
| 10:53 |
Zughy[m] |
The one approval PRs belonging to you, of course |
| 10:56 |
Zughy[m] |
Last but not least, remember to review people's PRs too, don't focus only on your plans (I'm saying this just in case). Enjoy 🎉 |
| 10:59 |
jwmhjwmh |
Thanks for the tips. |
| 10:59 |
Zughy[m] |
Krock: possible close then? https://github.com/minetest/minetest/pull/9776#issuecomment-1257262652 |
| 11:03 |
jwmhjwmh |
Merging #12445 in 20 minutes. |
| 11:03 |
ShadowBot |
https://github.com/minetest/minetest/issues/12445 -- Modify PUC Lua to wrap C++ exceptions by TurkeyMcMac |
| 11:10 |
appguru |
gonna drop here #12379 - as of sfan5's latest review I believe it is pretty much approval-ready |
| 11:10 |
ShadowBot |
https://github.com/minetest/minetest/issues/12379 -- Allow rotating entity selectionboxes by appgurueu |
| 11:13 |
nrz_ |
who is this new coredev, never saw this nickname on IRC 🙂 |
| 11:13 |
MTDiscord |
<ROllerozxa> turkeymcmac |
| 11:13 |
Zughy[m] |
TurkeyMcMac on GitHub |
| 11:17 |
nrz_ |
ok, he did a Krock-erie 😄 |
| 11:27 |
kilbith |
"don't focus only on your plans" -> yes, that's important to note |
| 11:27 |
kilbith |
there are some cheap CPUs ending by 55 that fail to understand this |
| 11:31 |
|
appguru joined #minetest-dev |
| 11:48 |
MTDiscord |
<ROllerozxa> phenom955 |
| 12:25 |
sfan5 |
appguru: I think I've lost track of PRs where I did only code review and promised testing "next time" |
| 12:35 |
ensayia |
sfan5 I appreciate your input and will move my next question over to #minetest but do you think you could answer what I asked? |
| 12:37 |
|
Taoki joined #minetest-dev |
| 12:47 |
|
Fixer joined #minetest-dev |
| 13:41 |
Zughy[m] |
Reminder to list 3 points for the next roadmap in these days, since it should be available right after 5.7 is released #12746 (AKA don't do it when a couple of days are missing from 5.7 release) |
| 13:41 |
ShadowBot |
https://github.com/minetest/minetest/issues/12746 -- Roadmap brainstorm (5.8+) |
| 13:41 |
Zughy[m] |
*are left |
| 14:04 |
|
Warr1024 joined #minetest-dev |
| 14:25 |
rubenwardy |
Should probably do a retrospective before discussing the next roadmap |
| 14:29 |
Zughy[m] |
Here's a summary: UI slightly advancing towards something good (point 1), big refactoring and optimisation (point 2), entities still bad as they were before (point 3) |
| 14:36 |
|
jwmhjwmh joined #minetest-dev |
| 14:47 |
MTDiscord |
<MisterE> I'd also like to resuggest the easy-to-add feature of telling a client to connect to another server. Before it connects, it asks the player if they would like to connect to the new server, and displays the server details. There is also a checkbox to connect to this server without asking in the future. Clicking that checkbox stores the server info in the settings so the client knows not to ask first in the future. |
| 14:47 |
rubenwardy |
the roadmap isn't usually about specific features |
| 14:47 |
rubenwardy |
the expect would be mega non-trivial features, like SSCSM and expanded world size |
| 14:47 |
rubenwardy |
*exception |
| 15:24 |
|
appguru joined #minetest-dev |
| 15:40 |
|
Desour joined #minetest-dev |
| 16:08 |
sfan5 |
ensayia: "if you feel like you're doing it right but it doesn't work open an issue" was my answer |
| 16:47 |
Zughy[m] |
MisterE: if you have requests, write them in the issue, not here |
| 16:50 |
rubenwardy |
that request is offtopic though |
| 16:51 |
rubenwardy |
implementing that probably wouldn't even be that hard, relatively |
| 16:51 |
rubenwardy |
I swear someone hada PR for it |
| 16:52 |
rubenwardy |
although, I'm struggling to find the issue now |
| 17:00 |
|
vampirefrog joined #minetest-dev |
| 17:09 |
|
vampirefrog joined #minetest-dev |
| 17:13 |
|
jojje joined #minetest-dev |
| 17:14 |
|
olliy joined #minetest-dev |
| 17:17 |
ensayia |
They way you worded it I read it as "if you're not sure, don't file a report". Got it now. |
| 17:18 |
|
Alias joined #minetest-dev |
| 17:19 |
sfan5 |
oh hmm, I guess that was ambigous |
| 17:21 |
|
Fixer_ joined #minetest-dev |
| 17:35 |
|
troller joined #minetest-dev |
| 18:07 |
|
jwmhjwmh joined #minetest-dev |
| 18:26 |
|
diceLibrarian joined #minetest-dev |
| 18:44 |
|
Noisytoot joined #minetest-dev |
| 18:45 |
|
Noisytoot joined #minetest-dev |
| 18:51 |
|
Noisytoot joined #minetest-dev |
| 19:19 |
|
Noisytoot joined #minetest-dev |
| 19:27 |
|
Noisytoot joined #minetest-dev |
| 19:35 |
|
Noisytoot joined #minetest-dev |
| 19:44 |
|
Noisytoot joined #minetest-dev |
| 19:46 |
|
jwmhjwmh joined #minetest-dev |
| 20:06 |
|
troller joined #minetest-dev |
| 20:43 |
jwmhjwmh |
Merging #12562 in 20 minutes. |
| 20:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/12562 -- Avoid duplication of mod metadata in memory by TurkeyMcMac |
| 20:49 |
|
troller joined #minetest-dev |
| 21:21 |
|
Noisytoot joined #minetest-dev |
| 21:26 |
Zughy[m] |
(pretty sure you can lower down the waiting if you want to, and it''s not mandatory anyway) |
| 21:27 |
Zughy[m] |
Reminder that #7865 is almost 4 year old and it only needs one approval |
| 21:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/7865 -- Add crosshair support for Android by srifqi |
| 21:30 |
jwmhjwmh |
I'll review that if I can get the android build working on my phone. |
| 21:34 |
|
Noisytoot joined #minetest-dev |
| 21:53 |
|
YuGiOhJCJ joined #minetest-dev |
| 22:01 |
|
Desour joined #minetest-dev |
| 22:05 |
MTDiscord |
<savilli> Since we're talking about reviews with one approval, maybe you have time for #11885 too? |
| 22:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/11885 -- Add unittests for item movement code by savilli |
| 22:16 |
jwmhjwmh |
I'll add it to my list. |
| 22:19 |
MTDiscord |
<savilli> Yay |
| 22:35 |
|
panwolfram joined #minetest-dev |
| 23:05 |
|
AliasAlreadyTake joined #minetest-dev |
| 23:22 |
jwmhjwmh |
Merging #12807 in 5m. |
| 23:22 |
ShadowBot |
https://github.com/minetest/minetest/issues/12807 -- Fix liquid drawtype faces sometimes not rendering by Wuzzy2 |
| 23:52 |
|
ensayia left #minetest-dev |
| 23:58 |
|
jwmhjwmh joined #minetest-dev |
