| Time |
Nick |
Message |
| 02:13 |
|
jwmhjwmh joined #minetest-dev |
| 02:21 |
|
Sokomine joined #minetest-dev |
| 03:32 |
|
v-rob joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 05:38 |
|
calcul0n joined #minetest-dev |
| 06:17 |
|
v-rob joined #minetest-dev |
| 06:25 |
|
Noisytoot joined #minetest-dev |
| 06:33 |
|
Noisytoot joined #minetest-dev |
| 06:36 |
|
Noisytoot joined #minetest-dev |
| 06:58 |
|
Noisytoot joined #minetest-dev |
| 06:58 |
|
v-rob joined #minetest-dev |
| 07:56 |
|
Noisytoot joined #minetest-dev |
| 07:56 |
|
v-rob joined #minetest-dev |
| 08:07 |
|
Noisytoot joined #minetest-dev |
| 08:22 |
|
Warr10249 joined #minetest-dev |
| 08:29 |
|
Noisytoot_ joined #minetest-dev |
| 09:01 |
|
Fixer joined #minetest-dev |
| 09:04 |
|
Warr1024 joined #minetest-dev |
| 09:50 |
|
appguru joined #minetest-dev |
| 10:03 |
|
Whanake[m] joined #minetest-dev |
| 11:09 |
sfan5 |
also uh |
| 11:09 |
sfan5 |
can we maybe get some reviews going here https://github.com/minetest/minetest/pulls/TurkeyMcMac |
| 11:09 |
sfan5 |
lots of important PRs in there |
| 11:10 |
sfan5 |
at this rate I will have to fork Minetest myself to merge all the important stuff |
| 11:27 |
|
appguru joined #minetest-dev |
| 11:33 |
|
jwmhjwmh joined #minetest-dev |
| 11:42 |
|
proller joined #minetest-dev |
| 11:47 |
kilbith |
I'd follow that move with you |
| 11:51 |
|
fluxionary joined #minetest-dev |
| 12:12 |
nrz_ |
Sfan5 i try to take time to check when coming back home. Do you have very Prior ones ? |
| 12:19 |
Zughy[m] |
also consider asking TurkeyMcMac if they want to become a core dev, if you think they're up for the task |
| 12:29 |
sfan5 |
nrz_: basically all the ones which already have an approval |
| 13:10 |
|
vampirefrog joined #minetest-dev |
| 13:10 |
|
olliy joined #minetest-dev |
| 13:15 |
|
Noisytoot joined #minetest-dev |
| 13:18 |
sfan5 |
rubenwardy, Krock: 5.6.1 today? |
| 13:18 |
sfan5 |
also merging #12710 in 10m |
| 13:18 |
ShadowBot |
https://github.com/minetest/minetest/issues/12710 -- Client mapblocks: do frustum culling via planes by Desour |
| 13:25 |
Zughy[m] |
sfan5: is the Waiting label new? How does it differ from Action / Change needed? |
| 13:26 |
sfan5 |
yes I just added it, check the label description |
| 13:47 |
|
olliy joined #minetest-dev |
| 13:52 |
|
appguru joined #minetest-dev |
| 13:52 |
rubenwardy |
Waiting is usually called "Blocked" |
| 13:53 |
appguru |
sfan5: I'll address your other review comments on the bone override PR eventually, but that will have to wait a week or two. I've addressed the comments on the rotatable selectionbox PR; it should be fine now. |
| 13:58 |
sfan5 |
no hurry |
| 14:36 |
|
olliy joined #minetest-dev |
| 14:51 |
|
jwmhjwmh joined #minetest-dev |
| 15:29 |
nrz_ |
sfan5 #12776 approved, you can merge when you wan,t |
| 15:29 |
ShadowBot |
https://github.com/minetest/minetest/issues/12776 -- Allow getmetatable in CSM by TurkeyMcMac |
| 15:31 |
Zughy[m] |
Wait, why can't you merge ? |
| 15:32 |
nrz_ |
i can merge, i have rights yes :p |
| 15:32 |
nrz_ |
merged #12776 then |
| 15:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/12776 -- Allow getmetatable in CSM by TurkeyMcMac |
| 15:32 |
nrz_ |
commented #12739, a simple question |
| 15:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/12739 -- Add callback on_mapblocks_changed by TurkeyMcMac |
| 15:33 |
MTDiscord |
<luatic> nrz_: The cost is LuaJIT, basically |
| 15:34 |
MTDiscord |
<luatic> (also besides that, the function is simple enough that the effort required to duplicate it is comparable to the effort required to expose it from C++ to Lua) |
| 15:37 |
|
Desour joined #minetest-dev |
| 15:38 |
nrz_ |
merging #12707 |
| 15:38 |
ShadowBot |
https://github.com/minetest/minetest/issues/12707 -- C exception safety by TurkeyMcMac |
| 15:46 |
nrz_ |
merging #12444 |
| 15:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/12444 -- Content ID caching in Lua by TurkeyMcMac |
| 15:49 |
|
olliy1or joined #minetest-dev |
| 16:00 |
|
jwmhjwmh joined #minetest-dev |
| 16:39 |
nrz_ |
merging #12576 |
| 16:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/12576 -- Document minetest.parse_relative_number by Wuzzy2 |
| 16:39 |
nrz_ |
and i think i'm over on the reviews for now |
| 16:39 |
Krock |
it makes little sense if you announce merges after the actual merge.... |
| 17:26 |
MTDiscord |
<savilli> Merging in -5 minutes |
| 18:23 |
|
olliy joined #minetest-dev |
| 18:32 |
nrz_ |
Krock, i missed a point ? |
| 19:24 |
Zughy[m] |
nrz_: you're supposed to announce the merge 5-10 minutes before actually merging it |
| 19:25 |
Zughy[m] |
even if I personally don't understand why the waiting. Fear of overlapping with some other commit? |
| 19:25 |
sfan5 |
N.B.: there's actually no such requirement, not sure who started this |
| 19:38 |
MTDiscord |
<luatic> so is the waiting all a cargo cult in the end? |
| 19:38 |
MTDiscord |
<luatic> I've rarely seen an objection during said 5-10 mins |
| 19:40 |
rubenwardy |
looks like the requirement is only for merging trivial bug fixes |
| 19:43 |
Krock |
> Tell people openly what you do, and if someone finds a problem in what you do, allow resolving to take its time. |
| 19:43 |
Krock |
it's indeed not written anywhere, but I believe it's giving a last time to check, even though it's rarely to never a problem |
| 19:44 |
Krock |
and the point in announcing merges/pushes is that there's not two people at once modifying master |
| 19:57 |
|
appguru joined #minetest-dev |
| 20:24 |
nrz_ |
Zughy, me neither, i never did this, especially when another coredev request some of us to do reviews ? |
| 20:24 |
nrz_ |
if i remember it was for the era when github didn't permit live rebase |
| 20:24 |
nrz_ |
and the engine was very active, to prevent merge conflict between 2 PR on the same code |
| 20:25 |
|
jwmhjwmh joined #minetest-dev |
| 21:32 |
|
jwmhjwmh joined #minetest-dev |
| 22:35 |
|
panwolfram joined #minetest-dev |
