Minetest logo

IRC log for #minetest-dev, 2022-04-07

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:02 Baytuch joined #minetest-dev
04:00 MTDiscord joined #minetest-dev
04:12 bigfoot547 joined #minetest-dev
05:49 calcul0n joined #minetest-dev
09:51 HuguesRoss48 joined #minetest-dev
11:15 qur joined #minetest-dev
11:41 Fixer joined #minetest-dev
12:33 proller joined #minetest-dev
12:36 rubenwardy #7629
12:36 ShadowBot https://github.com/minetest/minetest/issues/7629 -- Run Minetest update checker on startup by SmallJoker
12:36 rubenwardy anyone know how flags are based in to Android? It doesn't seem to be detecting the new option in cmake_config.h
12:37 sfan5 all manual, in config.h
12:38 rubenwardy huh
12:38 rubenwardy The variable is DEVELOPMENT_MODE
12:38 rubenwardy so I suppose it needs to be passed in the same way as VERSION_MAJOR
12:39 sfan5 btw eyes needed #11683 #12015 #12148 #12047 #11545
12:39 ShadowBot https://github.com/minetest/minetest/issues/11683 -- Compile Lua as C++ by TurkeyMcMac
12:39 ShadowBot https://github.com/minetest/minetest/issues/12015 -- [no squash] Various minor fixes by ShadowNinja
12:39 ShadowBot https://github.com/minetest/minetest/issues/12148 -- Disentangle map implementations by TurkeyMcMac
12:39 ShadowBot https://github.com/minetest/minetest/issues/12047 -- Add helper functions to make tool usable n times by Wuzzy2
12:39 ShadowBot https://github.com/minetest/minetest/issues/11545 -- Animated particlespawners by velartrill
12:59 erle #12047 is very good
12:59 ShadowBot https://github.com/minetest/minetest/issues/12047 -- Add helper functions to make tool usable n times by Wuzzy2
12:59 erle a friend of mine called it “bresenham's axe” ;)
13:00 erle seems to be missing tests though
14:02 MTDiscord <Hugues Ross> 11545 has been on my todo list since you mentioned it, but unfortunately some life stuff has cut my time this week. If no-one else gets to it by the weekend I'll give it a pass then
14:14 rubenwardy ShadowNinja: is #12015 ready to merge from your perspective?
14:14 ShadowBot https://github.com/minetest/minetest/issues/12015 -- [no squash] Various minor fixes by ShadowNinja
14:23 Extex joined #minetest-dev
14:36 proller and this ready: https://github.com/minetest/minetest/pull/11910
14:42 rubenwardy merging #11683 in 10
14:42 ShadowBot https://github.com/minetest/minetest/issues/11683 -- Compile Lua as C++ by TurkeyMcMac
15:04 Zughy[m] https://forum.minetest.net/viewtopic.php?f=3&amp;t=27975
15:18 appguru joined #minetest-dev
15:45 Extex joined #minetest-dev
15:58 Extex joined #minetest-dev
18:52 x2048 joined #minetest-dev
19:15 x2048 sfan5: #12148 looks good, I added second approval. I guess I can just merge it now...
19:15 ShadowBot https://github.com/minetest/minetest/issues/12148 -- Disentangle map implementations by TurkeyMcMac
19:46 Extex joined #minetest-dev
20:05 sfan5 yea
20:06 MTDiscord <x2048> done
20:22 x2048 Pushing https://gist.github.com/x2048/12018ea6959e5c3451997951a5d77185 in a few minutes, based on comments in #12166
20:22 ShadowBot https://github.com/minetest/minetest/issues/12166 -- Adjust PSM distortion to use entire SM texture by x2048
20:37 proller joined #minetest-dev
20:54 proller joined #minetest-dev
21:07 x2048 Pushing a fix for https://github.com/minetest/minetest/runs/5875604365?check_suite_focus=true in a few minutes
21:12 sfan5 looks like the workflow file whitelist needs to be adjusted so unittests run if you touch only devtest
21:14 x2048 .github/workflows/lua_lint.yml ?
21:14 x2048 nope
21:17 sfan5 it's in build.yml
21:19 x2048 Like this https://gist.github.com/x2048/03cad2f03b1cd771e3d6d36e5516bb26 ?
21:21 sfan5 yea
21:21 sfan5 and builtin/**.lua too I guess
21:22 sfan5 though there's only a single workflow to which that applies
21:22 sfan5 so maybe makes sense to split
21:26 x2048 you mean move clang_3_9 into a different workflow?
21:27 sfan5 if necessary yes
21:27 sfan5 or rather duplicating it
21:28 sfan5 then we could have one workflow whose focus is test-running Lua like that
21:30 x2048 what about renaming lua_lint.yml into lua.yml and adding clang_3_9 there?
21:30 x2048 (and expanding lua lint to devtest)
21:30 sfan5 would have to look closer to make concrete suggestions
21:40 x2048 I made #12184 to start discussion.
21:40 ShadowBot https://github.com/minetest/minetest/issues/12184 -- Run automated tests when lua files change by x2048
22:32 panwolfram joined #minetest-dev
22:45 proller joined #minetest-dev
23:02 proller joined #minetest-dev
23:24 AliasStillTaken joined #minetest-dev
23:27 MTDiscord <MisterE> sfan5, what does m_lock mean (its a boolean) regarding formspec code?
23:28 MTDiscord <MisterE> https://github.com/minetest/minetest/blob/21f17e871ea3de419f682a8088337ba6ae1d015e/src/gui/guiFormSpecMenu.cpp#L3204
23:29 MTDiscord <Jordach> L3229 explains what it's for
23:29 MTDiscord <MisterE> yes, "fixed-size mode"
23:29 MTDiscord <MisterE> what is that
23:29 MTDiscord <MisterE> full screen?
23:30 MTDiscord <MisterE> and also, there is the variable m_locksize, which seems to to be the screensize if fixed-size mode is on
23:31 MTDiscord <MisterE> I guess my question is, "what makes fixed size mode occur?"
23:58 TheCoffeMaker joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext