Minetest logo

IRC log for #minetest-dev, 2021-07-10

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
01:01 MTDiscord <Warr1024> I can probably think of a lot of ways it could be done that are all acceptable, some probably better.  I don't want to try to optimize it more than it already is though because that way lies the bikeshedding.  What Wuzzy has is good enough.  In fact, if it's TOO good then it wouldn't be consistent with the rest of the configuration system...
01:03 MTDiscord <Warr1024> The implementation looks clean and straightforward, and if people really hate the design then there's still one more approval to clear.
01:07 Wuzzy btw do you know how sun tonemap works
01:08 Wuzzy i desperately cant get it to work 🙁
01:11 MTDiscord <Jordach> it's pain btw
01:12 MTDiscord <Jordach> it seems to be a linear curve and not a plain ramp
01:30 Wuzzy no, i mean it cant get it to work *at all*
01:30 Wuzzy no matter what i do, sun color never changes
01:31 Wuzzy is tonemap broken?
01:31 MTDiscord <Jordach> i should mention it only accepts red channel
01:31 MTDiscord <Jordach> it pretty much ignores anything else
01:31 Wuzzy ooffffffffffffffffff
01:31 MTDiscord <Jordach> like how dawn/dusk blending ignores other channels than blue
01:31 Wuzzy documentation desperately needed!!
01:31 MTDiscord <Jordach> RBA never documented that
01:31 MTDiscord <Jordach> i'd actually be for nuking it
01:32 Wuzzy nooooo 🙁
01:32 Wuzzy unless it really is broken lol
01:32 Wuzzy whats strange... i tried a rainbow tonemap just for the lulz. still nothing. hmmmmmm
01:33 MTDiscord <Jordach> 512x1px
01:33 Wuzzy that i also used...
01:33 Wuzzy does it matter which PNG type is used?
01:33 MTDiscord <Jordach> uhhhhhhh
01:33 MTDiscord <Jordach> i only tested RGBA PNG\
01:33 Wuzzy ok
01:33 Wuzzy maybe thats the reason
01:33 MTDiscord <Jordach> indexed is for suckas
01:38 Wuzzy still nothing... wtf
01:43 Wuzzy ohhhhhhhhhh. tonemap only works if you overwrite hte sun texture. if you use default sun, it does nothing ...
01:48 Wuzzy Jordach: Apparently my rainbow tonemap works fine. so your claim about red channel limitation is wrong, i guess?!
01:49 MTDiscord <Jordach> it never worked for me before
01:49 MTDiscord <Jordach> like this may have been as early as 2018
01:52 Wuzzy is there a default sun_tonemap.png or is it hardcoded?
02:01 MTDiscord <Jordach> https://forum.minetest.net/viewtopic.php?f=18&amp;t=9140
02:11 Wuzzy thx!!
02:11 Wuzzy i feel like those should be added to the mt repository, at least for reference/example
02:19 MTDiscord <Jordach> probably should
02:19 MTDiscord <Jordach> i'm likely to verify everything with MT is smooth as butter building under macOS shortly
02:19 MTDiscord <Jordach> will probably go fix things
02:20 MTDiscord <Jordach> with dawn/dusk blending
02:23 Wuzzy ok i think i figured out how tonemaps works now. thx
02:24 MTDiscord <Jordach> they don't seem to make logical sense
02:24 Wuzzy my problem was that i didnt provide sun.png... i probably will push a doumentation update eventually...
02:24 MTDiscord <Jordach> that said i'll probably do some work on sky.cpp later
02:25 Wuzzy cool
02:25 MTDiscord <Jordach> namely fixing the dawn/dusk faults, adding support for mesh-based skyboxes, making tonemaps respond to the internal 0-1 representation of time
02:29 MTDiscord <Jordach> for those with questions about meshbased skyboxes: not to worry
02:30 MTDiscord <Jordach> irrlicht smoothly interpolates between keyframes
02:30 MTDiscord <Jordach> so it is possible to have a "mesh" version
02:33 Wuzzy cool
02:34 Wuzzy and i have been working on various paramtype2 / drawtype stuff. many prs now
02:50 Extex joined #minetest-dev
05:32 Lone_Wolf joined #minetest-dev
06:25 Extex joined #minetest-dev
06:25 Alias2 joined #minetest-dev
06:25 queria joined #minetest-dev
06:25 specing joined #minetest-dev
06:25 nrz joined #minetest-dev
06:25 MTDiscord joined #minetest-dev
06:25 behalebabo joined #minetest-dev
06:25 olliy joined #minetest-dev
06:25 LW joined #minetest-dev
06:25 m42uko joined #minetest-dev
06:25 sofar joined #minetest-dev
06:25 ShadowBot joined #minetest-dev
06:25 jonadab joined #minetest-dev
06:25 Calinou joined #minetest-dev
06:25 ShadowNinja joined #minetest-dev
06:25 Thomas-S joined #minetest-dev
06:25 pgimeno joined #minetest-dev
06:25 wsor4035 joined #minetest-dev
06:25 freshreplicant[m joined #minetest-dev
06:25 sfan5 joined #minetest-dev
06:25 ssieb joined #minetest-dev
06:25 ivanbu joined #minetest-dev
06:25 basxto joined #minetest-dev
06:25 beanzilla joined #minetest-dev
06:25 Pexin joined #minetest-dev
06:25 luk3yx joined #minetest-dev
06:25 Shara joined #minetest-dev
06:25 dzho joined #minetest-dev
06:25 nore joined #minetest-dev
06:25 clavi joined #minetest-dev
06:25 BuckarooBanzai joined #minetest-dev
06:25 rubenwardy joined #minetest-dev
06:25 \ joined #minetest-dev
06:25 cheapie joined #minetest-dev
06:25 pmp-p joined #minetest-dev
06:25 Krock joined #minetest-dev
07:28 YuGiOhJCJ joined #minetest-dev
09:02 appguru joined #minetest-dev
09:28 specing_ joined #minetest-dev
09:47 entuland joined #minetest-dev
10:47 Fixer joined #minetest-dev
11:31 calcul0n joined #minetest-dev
11:44 sfan5 merging #11408 soon
11:44 ShadowBot https://github.com/minetest/minetest/issues/11408 -- Use `persistence` instead of `persist` in NoiseParams examples. by Kalabasa
12:15 calcul0n_ joined #minetest-dev
12:19 Krock sfan5: how soon? I'd like to push https://github.com/minetest/minetest/issues/11408 15 minutes after
12:19 Krock err I mean https://krock-works.uk.to/u/patches/0001-Script-API-Fix-segfault-in-remove_detached_inventory.patch
12:19 sfan5 I planned for 10m but evidently I forgot
12:20 Krock alright :)
12:34 Krock pushing segfault fix
12:59 MTDiscord <appguru> thanks
14:44 appguru joined #minetest-dev
15:00 hecks joined #minetest-dev
15:48 Extex joined #minetest-dev
16:53 sfan5 reminder that #11287 still needs an approval
16:53 ShadowBot https://github.com/minetest/minetest/issues/11287 -- Take advantage of IrrlichtMt target by JosiahWI
17:00 HiliganFootFoot joined #minetest-dev
17:04 Extex joined #minetest-dev
18:59 Fixer_ joined #minetest-dev
19:25 lhofhansl joined #minetest-dev
19:25 lhofhansl I think #11385 and #11393 are ready. If someone else could have a look that'd be cool.
19:25 ShadowBot https://github.com/minetest/minetest/issues/11385 -- Improve shadow rendering with non-default camera FOV by x2048
19:25 ShadowBot https://github.com/minetest/minetest/issues/11393 -- Avoid draw list and shadow map update in the same frame to reduce dtime jitter by x2048
21:05 v-rob joined #minetest-dev
21:15 hecks joined #minetest-dev
21:27 specing_ joined #minetest-dev
21:36 v-rob joined #minetest-dev
22:20 Lone_Wolf joined #minetest-dev
22:56 MTDiscord <Warr1024> #11439 is about as obvious as it's possible to get: 1-character documentation typo.  Any reason I shouldn't just squash and merge this right away?  If I don't hear anything in the next few minutes I'll assume it's alright and go ahead.
22:56 ShadowBot https://github.com/minetest/minetest/issues/11439 -- Fix typo in lua_api.txt by hecktest
23:31 v-rob hecks and Warr1024: things as simple as #11439 don't even need a pull request; you can just show the patch you're doing on IRC and push directly a few minutes later. See "https://dev.minetest.net/Git_Guidelines#Rule_1_in_practice"
23:31 ShadowBot https://github.com/minetest/minetest/issues/11439 -- Fix typo in lua_api.txt by hecktest
23:32 hecks k
23:37 v-rob Anyhow, merged
23:41 AliasAlreadyTake joined #minetest-dev
23:57 v-rob joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext