| Time |
Nick |
Message |
| 00:02 |
|
T4im joined #minetest-dev |
| 00:26 |
|
T4im joined #minetest-dev |
| 00:28 |
|
AntumD joined #minetest-dev |
| 01:34 |
|
benrob0329 joined #minetest-dev |
| 02:10 |
|
BrBridge joined #minetest-dev |
| 02:18 |
|
BrBridge joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:14 |
|
luk3yx left #minetest-dev |
| 04:44 |
|
BrBridge_ joined #minetest-dev |
| 07:42 |
|
hlqkj joined #minetest-dev |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 08:44 |
|
Kray joined #minetest-dev |
| 08:50 |
|
absurb joined #minetest-dev |
| 10:10 |
|
YuGiOhJCJ joined #minetest-dev |
| 10:31 |
|
proller joined #minetest-dev |
| 11:07 |
|
MarwolTuk joined #minetest-dev |
| 11:47 |
|
hlqkj joined #minetest-dev |
| 11:50 |
|
calcul0n_ joined #minetest-dev |
| 13:29 |
|
silver_est joined #minetest-dev |
| 14:00 |
|
hlqkj joined #minetest-dev |
| 14:55 |
|
absurb joined #minetest-dev |
| 15:19 |
|
Fixer joined #minetest-dev |
| 15:54 |
|
Fleckenstein joined #minetest-dev |
| 16:13 |
|
proller joined #minetest-dev |
| 16:56 |
|
proller joined #minetest-dev |
| 17:06 |
MTDiscord |
<josiah_wi> irrlicht/#31 has finally passed the CI. |
| 17:06 |
BrBridge_ |
<ShadowBot> https://github.com/minetest/minetest/issues/31 -- GUI Tooltips |
| 17:08 |
|
absurb_ joined #minetest-dev |
| 17:23 |
BrBridge_ |
<ShadowNinja> irr#31 |
| 17:23 |
BrBridge_ |
<ShadowBot> https://github.com/minetest/irrlicht/issues/31 -- Improved IrrlichtMt target structure by JosiahWI |
| 17:23 |
|
appguru joined #minetest-dev |
| 17:23 |
|
sofar left #minetest-dev |
| 17:24 |
MTDiscord |
<josiah_wi> Thanks. |
| 17:25 |
Krock |
will merge #11286 in 15 minutes |
| 17:25 |
BrBridge_ |
<ShadowBot> https://github.com/minetest/minetest/issues/11286 -- Fix client crash by savilli |
| 17:39 |
Krock |
merging |
| 18:06 |
|
Fixer joined #minetest-dev |
| 18:10 |
sfan5 |
@josiah_wi these are my suggested changes for your PR http://sprunge.us/zhML2e?diff |
| 18:10 |
sfan5 |
I've tested it on an older cmake version and on android, works |
| 18:11 |
MTDiscord |
<josiah_wi> Is there a way to apply those as a patch? |
| 18:11 |
MTDiscord |
<josiah_wi> I have never done that before so it's new ground. |
| 18:12 |
sfan5 |
github allows me to push them directly into your PR |
| 18:12 |
sfan5 |
if you don't have any comments I can do that |
| 18:13 |
MTDiscord |
<josiah_wi> They all look good to me, I think you can go ahead. |
| 18:14 |
MTDiscord |
<josiah_wi> Oh one thing why are JPEG and ZLIB include dirs listed? |
| 18:14 |
MTDiscord |
<josiah_wi> I believe that's redundant. |
| 18:15 |
sfan5 |
why? |
| 18:15 |
sfan5 |
I thought target_include_directories PRIVATE needs to list everything used by the source |
| 18:16 |
MTDiscord |
<josiah_wi> Zlib and JPEG are linked as targets, so the include dirs are propagated to the target. |
| 18:16 |
sfan5 |
ah |
| 18:17 |
sfan5 |
I turned those back into "normal" includes |
| 18:17 |
MTDiscord |
<josiah_wi> PNG is not so that's why it's listed explicitly. |
| 18:17 |
sfan5 |
since the JPEG target does not exist on old CMake and I wasn't sure with zlib |
| 18:18 |
MTDiscord |
<josiah_wi> I thought PING didn't, pretty sure I double checked the others after you mentioned it. |
| 18:19 |
MTDiscord |
<josiah_wi> PNG* |
| 18:21 |
sfan5 |
it builds fine now in any case |
| 18:22 |
MTDiscord |
<josiah_wi> Great! I'm pretty excited it's finally working. |
| 18:23 |
MTDiscord |
<josiah_wi> Thank you a lot for your suggestions and pointing out mistakes I made. |
| 18:24 |
|
hlqkj joined #minetest-dev |
| 18:36 |
MTDiscord |
<josiah_wi> Is it important that we maintain the ability to build the server without installing the IrrlichtMt library? |
| 18:38 |
sfan5 |
absolutely |
| 18:39 |
|
Sokomine joined #minetest-dev |
| 18:45 |
MTDiscord |
<josiah_wi> I missed something, I should've experimented with this earlier. |
| 18:46 |
MTDiscord |
<josiah_wi> There's no IRRLICHTMT_FOUND because the Config script doesn't do the standard args thing. |
| 18:48 |
sfan5 |
can't you check if the target is defined? |
| 18:48 |
MTDiscord |
<josiah_wi> Oh yeah, thanks. |
| 19:18 |
MTDiscord |
<Liso> +1 |
| 19:54 |
MTDiscord |
<josiah_wi> #11287 is ready for review although it looks like I need to update the CI scripts somehow. |
| 19:54 |
BrBridge_ |
<ShadowBot> https://github.com/minetest/minetest/issues/11287 -- Take advantage of IrrlichtMt target by JosiahWI |
| 20:00 |
sfan5 |
#11276 can also be made to work with this setup, right? |
| 20:03 |
|
proller joined #minetest-dev |
| 20:10 |
MTDiscord |
<josiah_wi> Yes. It will need a merge but I've already tested it as a subdirectory and it worked. find_package and add_subdirectory should have the exact same result. |
| 20:12 |
sfan5 |
ok great |
| 20:13 |
|
Pexin left #minetest-dev |
| 20:36 |
|
T4im joined #minetest-dev |
| 20:37 |
|
Fixer joined #minetest-dev |
| 20:55 |
|
hlqkj_ joined #minetest-dev |
| 21:40 |
|
proller joined #minetest-dev |
| 23:00 |
|
proller joined #minetest-dev |
