Minetest logo

IRC log for #minetest-dev, 2021-05-05

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:23 Kray joined #minetest-dev
01:32 Kimapr joined #minetest-dev
03:03 LoneWolfHT Possibly water_game?
03:05 LoneWolfHT Or maybe not, unless I misread this https://github.com/lefty-studios/water_game/blob/d1db8877c69333ff5ebb87b49b66787b606e6871/mods/water/mapgen.lua#L1
03:07 LoneWolfHT This is how hades sets it I thinkhttps://repo.or.cz/minetest_hades/hades_revisited.git/blob/HEAD:/mods/hades_mapgen/init.lua#l48
03:07 LoneWolfHT * https://repo.or.cz/minetest_hades/hades_revisited.git/blob/HEAD:/mods/hades_mapgen/init.lua#l48
03:12 LoneWolfHT Checked RunOrFall, Raining Nodes, Juanchi Game, Voxel Knights, and Aftermath. Didn't see anything
03:13 LoneWolfHT + drift_game & Labyrinth
03:57 systwi joined #minetest-dev
03:58 dennisjenkins joined #minetest-dev
04:00 MTDiscord joined #minetest-dev
05:42 sfan5 LoneWolfHT: core.set_mapgen_setting() would be the correct way
05:42 sfan5 (unless that has a bug=
06:20 calcul0n joined #minetest-dev
07:54 ivanbu joined #minetest-dev
08:00 ShadowNinja joined #minetest-dev
08:43 Kimapr joined #minetest-dev
09:14 Fixer joined #minetest-dev
11:54 proller joined #minetest-dev
11:57 entuland joined #minetest-dev
12:14 calcul0n joined #minetest-dev
12:20 calcul0n joined #minetest-dev
12:22 hlqkj joined #minetest-dev
12:22 calcul0n_ joined #minetest-dev
12:25 calcul0n joined #minetest-dev
12:52 tech_exorcist joined #minetest-dev
13:24 hlqkj joined #minetest-dev
13:39 hlqkj_ joined #minetest-dev
13:59 MTDiscord1 joined #minetest-dev
14:00 hlqkj joined #minetest-dev
14:01 MTDiscord joined #minetest-dev
14:08 hlqkj_ joined #minetest-dev
14:23 Kimapr joined #minetest-dev
15:04 appguru joined #minetest-dev
15:48 sfan5 simple PR that's useful for CI -> #11220
15:48 ShadowBot https://github.com/minetest/minetest/issues/11220 -- [NO SQUASH] Add basic client-server test to CI by sfan5
16:51 absurb joined #minetest-dev
17:58 Taoki joined #minetest-dev
19:24 kilbith joined #minetest-dev
19:25 kilbith my client segfaults everytime when I try to to download a mod from CDB: https://pastebin.ubuntu.com/p/xcmxBQP6Yh/
19:25 kilbith I guess this is due to last nerzhul's refactor since `extractZipFile` has been moved there
19:26 nerzhul it's iso functional
19:26 nerzhul or i missed something
19:26 nerzhul is stack trace related ?
19:26 troller joined #minetest-dev
19:26 kilbith what do you mean by iso functional?
19:29 sfan5 Thread 1 "minetest" received signal SIGSEGV, Segmentation fault.
19:29 sfan5 Client::extractZipFile (this=0x0, ...) at client/client.cpp:730
19:29 nerzhul this null ?
19:30 nerzhul ah okay i totally understand...
19:30 sfan5 moving it to the Client class is wrong, the client does not exist at the time this function is needed
19:30 nerzhul yep
19:30 nerzhul exactly
19:30 nerzhul if we can make it static it can solve the issue
19:30 nerzhul i missed the right context of the function
19:30 nerzhul i cannot patch it now, someone can propose the fix ?
19:33 kilbith this function should be extern even
19:33 kilbith this potentially can be used from a lot of places
19:35 rubenwardy extractZipFile is only used in the main menu, and not in the client
19:35 rubenwardy makes sense to be a util though
19:38 Jordach joined #minetest-dev
19:41 kilbith_ joined #minetest-dev
20:09 paxom joined #minetest-dev
20:17 nerzhul yep, right :)
20:38 sfan5 merging #11220 in 10m
20:38 ShadowBot https://github.com/minetest/minetest/issues/11220 -- [NO SQUASH] Add basic client-server test to CI by sfan5
21:06 kilbith_ joined #minetest-dev
21:15 ircSparky joined #minetest-dev
21:15 ircSparky joined #minetest-dev
21:30 proller__ joined #minetest-dev
21:44 proller joined #minetest-dev
21:51 troller joined #minetest-dev
21:57 kilbith_ I wonder how v-rob progresses with his formspec rewrite
21:58 kilbith_ got no news for a long time
21:58 Kimapr joined #minetest-dev
22:03 Foz joined #minetest-dev
22:17 MTDiscord <exe_virus> Wait so what's the fix for the extractZipFailure? Static function?
23:44 kilbith__ joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext