| Time |
Nick |
Message |
| 00:23 |
|
Kimapr joined #minetest-dev |
| 00:27 |
|
v-rob joined #minetest-dev |
| 00:34 |
v-rob |
Anyone have any PRs for me to review? I'm on a roll today. |
| 00:34 |
v-rob |
Preferably no CMake or IrrlichtMt |
| 00:40 |
pgimeno |
bad timing, most other developers are sleeping now :) |
| 00:40 |
v-rob |
Yeah, timezones are a pain |
| 00:41 |
v-rob |
I usually don't have time until around now |
| 00:42 |
pgimeno |
maybe someone will !tell you ideas for the next time you log in... or maybe not |
| 00:43 |
v-rob |
If they do, I'll review them. If someone requests a review of me, I will always get to them if I have the knowledge (although it might take a week or so) |
| 00:44 |
MTDiscord |
<Jonathon> Can you review rubens physics pr? |
| 00:44 |
v-rob |
Sure, as soon as I finish the one I'm on |
| 00:53 |
|
cheapie joined #minetest-dev |
| 00:54 |
|
cheapie joined #minetest-dev |
| 01:20 |
MTDiscord |
<josiah_wi> v-rob Are you interested in some help reviewing PRs? I would like to learn how to do code review well, but maybe there isn't anything I can do to help speed up the process. :-/ |
| 01:23 |
v-rob |
Hmm |
| 01:23 |
v-rob |
The difficult part is that non-core devs don't have approval rights |
| 01:24 |
v-rob |
Usually, PRs are perfectly fine or only need small changes, but still need two core devs |
| 01:26 |
v-rob |
So, core dev time is kind of wasted by looking through PRs that are essentially fine the way they are, but we can't do without the reviews in case we run into one of the PRs that does need changes. It's a tricky dilemma. |
| 01:27 |
|
AntumDeluge joined #minetest-dev |
| 01:27 |
MTDiscord |
<josiah_wi> Yeah. Maybe I'll work on a clang tidy that I can use to style-check PRs. |
| 01:27 |
v-rob |
Actually, I have an idea |
| 01:30 |
pgimeno |
it's not just about PR code quality, but also about whether the PR is desired and fits within the roadmap |
| 01:30 |
v-rob |
People like you could review PRs and basically tell the core devs if the PR will be easy to review since it's mostly fine. That way, the core devs will still have reviewing authority, but can take down the PR count by reviewing the ones people have said seem good. |
| 01:31 |
v-rob |
Roadmap decisions are pretty simple, we just need the rest of approvals for the roadmap PR |
| 01:33 |
MTDiscord |
<josiah_wi> pgimento hit the heart of the matter. The hard part for me is that I don't know graphics coding and I don't know how to tell whether a PR is desirable. |
| 01:56 |
rubenwardy |
non-devs reviewing does also help, it saves time by finding the easier issues |
| 01:58 |
|
kilbith joined #minetest-dev |
| 02:10 |
|
Kimapr2 joined #minetest-dev |
| 02:37 |
|
v-rob joined #minetest-dev |
| 03:29 |
|
v-rob joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:03 |
|
Kimapr joined #minetest-dev |
| 04:54 |
|
Baytuch joined #minetest-dev |
| 06:03 |
nerzhul |
v-rob you can check my refacto PR :) |
| 06:03 |
nerzhul |
and hello everyone :D |
| 06:03 |
nerzhul |
or sfan5 can check it as it's pretty straightforward. I may work on additional commits today, unfortunately such PR are commit interdependenant :( |
| 06:13 |
|
Seirdy joined #minetest-dev |
| 07:08 |
|
olliy joined #minetest-dev |
| 07:51 |
nerzhul |
i added more commits this morning on #11234, i hope another have time to review this pretty boring refactor PR which fix some bad designs on client (not all, but it's the beginning) :) |
| 07:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/11234 -- [NOSQUASH] refacto: don't permit to access to RenderingEngine::filesystem widely by nerzhul |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 08:23 |
|
hlqkj joined #minetest-dev |
| 09:17 |
|
Fixer joined #minetest-dev |
| 09:23 |
|
calcul0n_ joined #minetest-dev |
| 09:39 |
|
proller joined #minetest-dev |
| 11:54 |
|
calcul0n__ joined #minetest-dev |
| 12:07 |
|
tech_exorcist joined #minetest-dev |
| 12:38 |
|
MTDiscord1 joined #minetest-dev |
| 12:39 |
|
MTDiscord2 joined #minetest-dev |
| 12:55 |
|
ircSparky joined #minetest-dev |
| 12:55 |
|
ircSparky joined #minetest-dev |
| 13:27 |
|
Fixer joined #minetest-dev |
| 14:17 |
|
hlqkj joined #minetest-dev |
| 15:05 |
|
absurb_ joined #minetest-dev |
| 15:34 |
Sokomine |
hm, compiling latest mt gives me errors regarding postgresql? mostly undefined references. perhaps it wants a newer version of postgres? |
| 16:00 |
Sokomine |
ah. didn't find the right irrlicht because its now called irrlichtmt. ok. problem solved |
| 17:24 |
nerzhul |
yep got the same issue but mine was client crashing haha |
| 17:33 |
MTDiscord |
<Jordach> nerzhul was it during main menu init |
| 17:41 |
MTDiscord |
<Jordach> Someone in the regular Minetest irc noted similar issues when trying to init mainmenu |
| 17:53 |
nerzhul |
yep it was the same Jordach, the library change in cmakecache fixed it :) |
| 18:05 |
|
ivanbu joined #minetest-dev |
| 18:10 |
MTDiscord |
<Jordach> Why doesn’t make clean remove the CMake cache ill never understand |
| 18:11 |
nerzhul |
because it's not a cmake command ? :p |
| 18:11 |
MTDiscord |
<Jordach> Make clean indicates a clean environment |
| 18:11 |
MTDiscord |
<Jordach> I would expect it to remove outdated settings |
| 18:11 |
nerzhul |
it clean build artifacts, fortunately not build env, you don't want to re-setup each time :D |
| 18:11 |
MTDiscord |
<josiah_wi> It doesn't remove the cache because it contains build settings. |
| 18:12 |
pgimeno |
a distclean probably should |
| 18:12 |
sfan5 |
^ |
| 18:12 |
sfan5 |
but cmake doesn't implement distclean |
| 18:12 |
MTDiscord |
<josiah_wi> You shouldn't ever have to remove the Cache. |
| 18:12 |
pgimeno |
then no, I guess |
| 18:22 |
|
hlqkj joined #minetest-dev |
| 18:41 |
|
proller joined #minetest-dev |
| 19:42 |
|
systwi joined #minetest-dev |
| 19:44 |
|
systwi joined #minetest-dev |
| 19:56 |
|
Newbyte joined #minetest-dev |
| 19:59 |
|
systwi joined #minetest-dev |
| 20:06 |
|
systwi joined #minetest-dev |
| 20:08 |
|
systwi joined #minetest-dev |
| 20:11 |
|
systwi joined #minetest-dev |
| 21:05 |
|
entuland joined #minetest-dev |
| 21:07 |
|
entuland joined #minetest-dev |
| 21:21 |
|
entuland joined #minetest-dev |
| 21:40 |
|
hlqkj joined #minetest-dev |
| 21:46 |
|
proller joined #minetest-dev |
| 22:32 |
entuland |
hello everyone - getting "/tmp/minetest/src/network/connection.cpp:3f9: processReliableSendCommand: An engine assumption 'c.data.getSize() < 0x8000*512' failed." on 5.4.1 with a brand new world loading these two mods: https://github.com/entuland/wesh and https://github.com/entuland/lua-matrix - any idea how I could troubleshoot it? version 5.3.0 had no problems with it |
| 22:37 |
entuland |
getting a fresh copy of my own code from the repo solved the problem, I'll try to narrow down what I have changed on my local copy to trigger that error |
