| Time |
Nick |
Message |
| 00:05 |
rubenwardy |
pushing trivial bug fix in 10: https://github.com/rubenwardy/minetest/commit/6591597430c8a06c579e2631fcdbb022ae12160d |
| 00:32 |
|
Fixer_ joined #minetest-dev |
| 00:44 |
|
Wuzzy joined #minetest-dev |
| 01:18 |
|
Miner_48er joined #minetest-dev |
| 02:30 |
|
Miner_48er joined #minetest-dev |
| 03:03 |
|
fluxflux_ joined #minetest-dev |
| 03:39 |
kilbith |
got another random segfault but hard to reproduce |
| 03:42 |
kilbith |
got it |
| 03:47 |
kilbith |
https://github.com/minetest/minetest/issues/10934 |
| 03:58 |
|
ircSparky joined #minetest-dev |
| 03:58 |
|
ircSparky joined #minetest-dev |
| 04:02 |
|
Taoki joined #minetest-dev |
| 04:04 |
kilbith |
fixed: https://github.com/minetest/minetest/issues/10934#issuecomment-774851295 |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 08:51 |
MTDiscord |
<appguru> It should be noted that #10152 has caused minor breakage of backwards compatibility regarding the hiding of nametags, which used to be possible without setting alpha to zero. |
| 08:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/10152 -- Semi-transparent background for nametags by Zughy |
| 09:33 |
rubenwardy |
Technically, that never hid nametags. It rendered invisible text |
| 09:34 |
rubenwardy |
I suppose that freetype probably doesn't do much if it's just whitespace |
| 09:34 |
rubenwardy |
Although, fun fact: whitespace isn't always empty |
| 09:35 |
rubenwardy |
Irrelevant fun fact |
| 09:39 |
Zughy[m]1 |
we've been through this already and again, this is not my PR's fault: https://github.com/minetest/minetest/issues/10778#issuecomment-757179770 |
| 10:23 |
|
YuGiOhJCJ joined #minetest-dev |
| 10:57 |
|
calcul0n_ joined #minetest-dev |
| 11:03 |
|
YuGiOhJCJ2 joined #minetest-dev |
| 11:31 |
MTDiscord |
<appguru> Zughy: this is just a matter of view. Your PR did in fact break behavior; yes, it did render the nametag before, but that would not have been visible for an empty or space-only nametag, so it was fine (albeit probably not optimal for performance). For an empty nametag, nothing should be drawn, which used to work properly; now, a box is drawn. |
| 11:33 |
Zughy[m]1 |
Which again, is not my fault. What (ruben and) I did was an improvement and, according to the comments, it gives me the impression you're perceiving the glass as half empty |
| 11:33 |
MTDiscord |
<appguru> Maybe I am pessimist, idk, but anways Zughy, here's the change I propose: https://github.com/minetest/minetest/pull/10152#discussion_r571975716 |
| 11:33 |
rubenwardy |
it would need to trim first |
| 11:34 |
MTDiscord |
<appguru> not really |
| 11:34 |
rubenwardy |
!= "" is already taken into account |
| 11:34 |
ShadowBot |
rubenwardy: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command). |
| 11:34 |
rubenwardy |
!= " " isn't |
| 11:34 |
MTDiscord |
<appguru> != "" is not taken into account |
| 11:34 |
rubenwardy |
yes it is |
| 11:34 |
MTDiscord |
<appguru> It draws a tiny box if I set the nametag to that |
| 11:34 |
rubenwardy |
for players, that resets to the player name |
| 11:34 |
MTDiscord |
<appguru> Nope |
| 11:34 |
rubenwardy |
for entities, that never adds a nametag |
| 11:34 |
MTDiscord |
<appguru> Only if you use set_properties |
| 11:34 |
MTDiscord |
<appguru> But set_nametag_attributes allows setting an empty nametag for a player |
| 11:35 |
rubenwardy |
anyway, I'm currently working on a PR which A) adds a setting and B) adds `nametag_bgcolor |
| 11:36 |
MTDiscord |
<appguru> nice |
| 11:36 |
MTDiscord |
<appguru> We should add some kind of limited server-sent settings |
| 11:38 |
rubenwardy |
OK, this makes no sense |
| 11:38 |
|
proller joined #minetest-dev |
| 11:38 |
rubenwardy |
I've added an optional class, but somehow a present color is casting to zero and then a null optional |
| 11:45 |
Zughy[m]1 |
<rubenwardy "anyway, I'm currently working on"> about B: so would this force the color chose by the user on every nametag bg? |
| 11:45 |
MTDiscord |
<appguru> Well I guess it would have a reasonable default value |
| 11:45 |
Zughy[m]1 |
Or is something that mods can change? |
| 11:46 |
MTDiscord |
<appguru> I think that's what he's implementing |
| 11:46 |
MTDiscord |
<appguru> Please fix the empty boxes en passant ruben |
| 11:47 |
rubenwardy |
#10937 |
| 11:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/10937 -- Add nametag background setting and object property by rubenwardy |
| 11:51 |
rubenwardy |
oh ffs |
| 11:52 |
rubenwardy |
I assigned to the wrong variable |
| 11:52 |
rubenwardy |
noob mistake |
| 11:55 |
rubenwardy |
also, fyi, set_nametag_attributes just sets object properties |
| 12:08 |
rubenwardy |
Note that I add PRs and issues to the milestone even if unconfirmed because they should at least be checked before release |
| 12:08 |
rubenwardy |
/discussed |
| 12:25 |
MTDiscord |
<appguru> "also, fyi, set_nametag_attributes just sets object properties" - yes, but it circumvents the empty nametag check |
| 12:31 |
|
Fixer joined #minetest-dev |
| 12:43 |
rubenwardy |
fake news, they do exactly the same thing - they both put text into `nametag` |
| 13:06 |
|
numzero joined #minetest-dev |
| 13:09 |
Zughy[m]1 |
"fake news" lel |
| 13:12 |
rubenwardy |
set_properties: https://github.com/minetest/minetest/blob/master/src/script/common/c_content.cpp#L305 |
| 13:12 |
rubenwardy |
set_nametag_attributes: https://github.com/minetest/minetest/blob/master/src/script/lua_api/l_object.cpp#L740-L741 |
| 13:13 |
rubenwardy |
both set directly into `nametag` |
| 13:14 |
rubenwardy |
the only difference is that the latter requires the nametag string to be present |
| 13:14 |
rubenwardy |
well, the latter will always set the nametag |
| 13:14 |
rubenwardy |
it defaults to "" |
| 13:21 |
|
numzero_ joined #minetest-dev |
| 14:27 |
|
kilbith joined #minetest-dev |
| 15:12 |
|
Fleckenstein joined #minetest-dev |
| 15:29 |
|
Wuzzy joined #minetest-dev |
| 15:37 |
Wuzzy |
Bugfix PR: #10742 |
| 15:37 |
ShadowBot |
https://github.com/minetest/minetest/issues/10742 -- Fix world-aligned node rendering at bottom by Wuzzy2 |
| 15:57 |
|
Fixer joined #minetest-dev |
| 16:19 |
|
Beton joined #minetest-dev |
| 16:29 |
pgimeno |
as a reminder, I tested 10742 and it works. To reproduce, use devtest, last page of creative chest, item 'Tiled node (World aligned)'. If it works correctly, it displays always the same numbers in the same X/Z coordinates and repeats every 16. If it's broken, the numbers will change as you add nodes in the east-west direction. |
| 16:29 |
rubenwardy |
#10742 |
| 16:29 |
ShadowBot |
https://github.com/minetest/minetest/issues/10742 -- Fix world-aligned node rendering at bottom by Wuzzy2 |
| 16:32 |
pgimeno |
very safe because it only affects the case where dir is {0, -1, 0) i.e. bottom face |
| 16:33 |
pgimeno |
I can't vouch for the correctness of the calculations, but qualitatively it works |
| 16:38 |
|
Fixer joined #minetest-dev |
| 16:42 |
|
kyuss joined #minetest-dev |
| 16:58 |
|
amk joined #minetest-dev |
| 16:59 |
|
kilbith joined #minetest-dev |
| 17:35 |
|
pmp-p joined #minetest-dev |
| 17:56 |
Krock |
https://github.com/minetest/minetest/issues/10934#issuecomment-774851295 tested. will push in 10 minutes |
| 18:01 |
|
pmp-p joined #minetest-dev |
| 18:02 |
Krock |
regarding use_texture_alpha. might is be necessary to introduce a new nodedef field for that? mods that solve the 5.4.0 warnings no longer work on 5.3.0 due to altered types |
| 18:03 |
Krock |
(different topic than the warning spam) |
| 18:05 |
Krock |
pushing patch.... |
| 18:43 |
|
kilbith joined #minetest-dev |
| 19:04 |
|
Fixer_ joined #minetest-dev |
| 19:25 |
|
kilbith joined #minetest-dev |
| 19:27 |
sfan5 |
well that's what the feature flag is for |
| 19:31 |
Krock |
oh right! thanks, I missed that one |
| 19:42 |
|
proller joined #minetest-dev |
| 19:47 |
|
homthack joined #minetest-dev |
| 20:07 |
|
kilbith joined #minetest-dev |
| 20:14 |
|
kilbith_ joined #minetest-dev |
| 21:31 |
|
numzero joined #minetest-dev |
| 21:31 |
|
kilbith_ joined #minetest-dev |
| 22:00 |
|
numzero_ joined #minetest-dev |
| 22:13 |
|
kilbith_ joined #minetest-dev |
| 22:19 |
kilbith_ |
https://forum.minetest.net/viewtopic.php?p=389990#p389990 |
| 22:20 |
kilbith_ |
I think it's the 2nd time I read that animations are broken |
| 23:10 |
|
kilbith__ joined #minetest-dev |
| 23:25 |
|
Ritchie joined #minetest-dev |
| 23:35 |
|
kilbith joined #minetest-dev |
