Time |
Nick |
Message |
00:45 |
|
Seirdy joined #minetest-dev |
01:44 |
MTDiscord |
<exe_virus> Does feature freeze mean that mtg PRs won't be merged? |
01:55 |
MTDiscord |
<Lone_Wolf> MTG isn't accepting features |
01:59 |
|
Seirdy joined #minetest-dev |
03:39 |
MTDiscord |
<exe_virus> True, mine is maintenance |
03:39 |
MTDiscord |
<exe_virus> Mine are* maintenance. Specifically shrinking media size in half |
03:46 |
MTDiscord |
<exe_virus> So, I don't know the answer to this even though I program a lot: If minetest declares a pointer in the engine code, will that be a 64 bit (8 Byte) pointer or 4 Byte pointer? |
04:05 |
|
flux__ joined #minetest-dev |
04:35 |
MTDiscord |
<exe_virus> Ah, 64 bit is always 8 byte pointers. |
05:00 |
|
MTDiscord joined #minetest-dev |
05:15 |
MTDiscord |
<exe_virus> Huh, I've only recently started learning how to test code better, currently I'm using mallocstats() for memory usage, does anyone have good suggestions for profiling which functions are on the critical path of a code? |
06:11 |
|
olliy joined #minetest-dev |
08:00 |
|
ShadowNinja joined #minetest-dev |
08:49 |
|
nephele joined #minetest-dev |
08:49 |
nephele |
sfan5: did you plan to also rework the use_texture_alpha for objects? |
10:19 |
|
calcul0n_ joined #minetest-dev |
10:29 |
|
proller joined #minetest-dev |
10:35 |
sfan5 |
nephele: no |
10:37 |
|
Icedream joined #minetest-dev |
11:09 |
|
calcul0n__ joined #minetest-dev |
11:13 |
|
Beton joined #minetest-dev |
11:31 |
sfan5 |
question: should enable_damage only control the "default" (like with creative_mode) or prevent damage from being enabled entirely |
11:32 |
sfan5 |
? |
11:36 |
sfan5 |
okay changing it to do the former would be more work so it'll be the latter |
11:56 |
|
Topic for #minetest-dev is now FEATURE FREEZE IN EFFECT SINCE 2021-01-30. | Minetest core development and maintenance. Chit-chat goes to #minetest. https://irc.minetest.net/minetest-dev/ https://dev.minetest.net/ |
12:03 |
|
Fixer joined #minetest-dev |
12:20 |
|
Wuzzy joined #minetest-dev |
13:11 |
MTDiscord |
<exe_virus> Makes sense, good call |
13:13 |
sfan5 |
Krock: do we know if any mods use set_armor_groups to enable damage when it's usually disabled? |
13:14 |
Krock |
I don't. To be fair, it's a rather new feature (5.1.0 IIRC), hence not used often in general |
13:14 |
Krock |
let alone this case where damage is disabled by default |
13:15 |
Krock |
it's rather used on the other case, to protect admins from damage |
13:19 |
sfan5 |
yeah that'll still work |
13:25 |
|
numzero joined #minetest-dev |
13:43 |
|
MTDiscord1 joined #minetest-dev |
13:50 |
Zughy[m]1 |
chiming in just to say great job with issues and PRs lately. Keep up the good work guys |
13:50 |
sfan5 |
I wouldn't say "great", it's just better than usual |
13:51 |
Zughy[m]1 |
issues went from 979 to 937 ? |
13:51 |
Zughy[m]1 |
in two days |
13:53 |
sfan5 |
if anyone went through issues sorted by oldest first I'm sure there's many more that are not longer applicable |
14:16 |
sfan5 |
merging game#2804, game#2800 in 5m |
14:16 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2804 -- Correct door model dimensions by An0n3m0us |
14:16 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2800 -- Correct name of acacia mese postlight by An0n3m0us |
14:16 |
sfan5 |
oh and game#2799 |
14:16 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2799 -- Add missing nodes to list by An0n3m0us |
14:30 |
|
nephele left #minetest-dev |
15:33 |
Wuzzy |
oh lol. so I am now part of the minetest organization on GitHub. but what does that mean? |
15:39 |
sfan5 |
weren't you chosen to help with issue triage? |
16:12 |
rubenwardy |
yeah, this was weeks ago |
16:12 |
rubenwardy |
info: https://dev.minetest.net/Git_Guidelines#Issue_and_Pull-Request_Management |
16:14 |
rubenwardy |
months |
16:18 |
sfan5 |
#10887 |
16:18 |
ShadowBot |
https://github.com/minetest/minetest/issues/10887 -- Cache client IP in RemoteClient so it can always be retrieved by sfan5 |
16:18 |
sfan5 |
okay that's enough for today |
16:19 |
sfan5 |
well maybe not I spotted some dead code I could remove earlier |
16:39 |
sfan5 |
hm I guess I could also import translations in a few hours |
16:39 |
sfan5 |
since that should usually be done at the start of the feature freeze |
16:51 |
Krock |
you're on fire. won't stop you from doing the translation updates :) |
16:51 |
rubenwardy |
Yeah. Also, release candidate |
18:28 |
|
olliy joined #minetest-dev |
19:21 |
MTDiscord |
<appguru> ias we are eventually moving away from Irrlicht, we might want to use OpenSceneGraph: http://www.openscenegraph.org |
19:24 |
numzero |
we aren’t |
19:24 |
numzero |
we are hopefully moving away from *mainstream* Irrlicht |
19:26 |
MTDiscord |
<Flamore> We're just forking irrlicht to fix irrlicht-side problems and probably improve some stuff :^) |
19:39 |
rubenwardy |
Well, after many hacks the ContentDB dialog in the mainmenu now loads in 1.2 seconds rather than 10 |
19:43 |
sfan5 |
will do translation import now |
20:15 |
sfan5 |
will push what's in https://github.com/minetest/minetest/commits/test to master in a few minutes unless build fails |
20:15 |
|
lhofhansl joined #minetest-dev |
20:17 |
|
numzero joined #minetest-dev |
20:23 |
sfan5 |
man the GUI fonts really are too big at the default window size |
20:26 |
|
amk joined #minetest-dev |
20:38 |
sfan5 |
weblate says the english translation has 495,032,623 comments |
20:38 |
sfan5 |
I hope that's not right |
20:39 |
sfan5 |
now it's 480,148,903 ?! |
20:40 |
sfan5 |
well no idea where it has that number from |
20:41 |
rubenwardy |
what does comment mean in this situation? |
20:42 |
sfan5 |
comments on a translation to discuss e.g. context, not the translation itself |
20:42 |
|
fluxflux_ joined #minetest-dev |
20:42 |
sfan5 |
but in any case weblate is open for translations again ¯\_(ツ)_/¯ |
20:43 |
rubenwardy |
btw, I contacted weblate support to delete the 100s of empty translations last week |
20:43 |
rubenwardy |
so that should help |
20:43 |
rubenwardy |
I wonder if the comments thing could be similarly abused |
20:44 |
sfan5 |
During rebase I dropped all "added language FOO via weblate" + "deleted language FOO via weblate" commits anyway |
20:44 |
sfan5 |
"$1 and $2 dependencies will be installed." is this even proper english? what does it mean? |
20:45 |
rubenwardy |
Mobs Animals and 3 dependencies will be installed |
20:46 |
sfan5 |
ohhhh |
20:46 |
sfan5 |
I tried to fit numbers or names in both but that didn't work |
20:52 |
sfan5 |
"Base Game" translates really weirdly |
20:54 |
Krock |
Grundlagenspiel |
20:55 |
sfan5 |
please no |
20:55 |
rubenwardy |
ha, I like how people correct my typos in weblate comments |
20:56 |
rubenwardy |
well, bad grammar |
20:57 |
rubenwardy |
"Ruben Wardy has been asked about this on the Unofficial Minetest Discord server. Waiting for a response." I don't believe he has |
20:59 |
rubenwardy |
oh this was last year it's possible |
21:00 |
sfan5 |
Fadenkreuzundurchsichtigkeit :s |
21:00 |
rubenwardy |
are there any rules on words you can merge? |
21:01 |
sfan5 |
anything goes pretty much |
21:02 |
kb1000 |
Well, there are things that just don't make any sense |
21:03 |
Krock |
sfan5: a job for Wuzzy. it's great. |
21:24 |
|
Andrey01 joined #minetest-dev |
21:25 |
MTDiscord |
<Flamore> baza ludo: |
21:27 |
Andrey01 |
hello, does minetest engine (on C++ side) have any embedded a function that would return a sign of a number? Maybe in 'util' folder somewhere? |
21:27 |
rubenwardy |
you can use (x > 0) ? 1 : -1 |
21:27 |
rubenwardy |
well, not quite right |
21:28 |
Andrey01 |
but I would like a function |
21:28 |
sfan5 |
because? |
21:28 |
Andrey01 |
in any case, afaik the standard library doesnt have that |
21:29 |
rubenwardy |
it's pretty trivial |
21:29 |
rubenwardy |
oh wow |
21:29 |
rubenwardy |
apparently you can write it as (x > 0) - (x < 0) |
21:29 |
rubenwardy |
and that returns -1 0 1 |
21:30 |
Andrey01 |
hmm |
21:30 |
rubenwardy |
booleans as integers be weird |
21:30 |
rubenwardy |
Andrey01: https://stackoverflow.com/questions/1903954/is-there-a-standard-sign-function-signum-sgn-in-c-c |
21:33 |
Andrey01 |
I don`t quite understand that construction that you suggested, rubenwardy, and that was suggested in stackoverfow |
21:34 |
rubenwardy |
booleans implicitly convert to integers. False to 0, true to 1 |
21:34 |
rubenwardy |
that's all you need to know |
21:34 |
Andrey01 |
ah, that`s it... |
21:35 |
Andrey01 |
thanks, I`ll try |
21:35 |
rubenwardy |
I tend to avoid implicit conversion from boolean to int or viceversa, and I'd definitely put this code in an inline function as it's fairly obscure |
21:35 |
rubenwardy |
well, it's a nice way of doing it but not immediately obvious when reading the code |
21:37 |
Andrey01 |
although, (x > 0) ? 1 : ((x < 0) ? -1 : 0) is not bad way, too, more obvious, however longer |
22:18 |
|
Wuzzy joined #minetest-dev |
23:43 |
|
amk joined #minetest-dev |
23:49 |
|
Fixer_ joined #minetest-dev |