Time |
Nick |
Message |
05:00 |
|
MTDiscord joined #minetest-dev |
07:20 |
|
onebot_ joined #minetest-dev |
07:29 |
|
olliy joined #minetest-dev |
08:00 |
|
ShadowNinja joined #minetest-dev |
08:12 |
|
huichilobos joined #minetest-dev |
08:18 |
nerzhul |
Krock did you get time for my simple MR ? |
09:30 |
|
calcul0n__ joined #minetest-dev |
09:57 |
|
Wuzzy joined #minetest-dev |
10:06 |
|
Lunatrius joined #minetest-dev |
10:53 |
|
ssieb joined #minetest-dev |
13:30 |
|
proller joined #minetest-dev |
13:51 |
|
Fixer joined #minetest-dev |
14:07 |
|
pmp-p joined #minetest-dev |
14:30 |
|
olliy joined #minetest-dev |
15:02 |
|
pmp-p joined #minetest-dev |
15:31 |
|
Foz joined #minetest-dev |
15:32 |
|
pmp-p joined #minetest-dev |
17:03 |
|
pmp-p joined #minetest-dev |
17:26 |
|
olliy joined #minetest-dev |
17:31 |
|
pmp-p joined #minetest-dev |
17:38 |
|
pmp-p joined #minetest-dev |
17:58 |
|
pmp-p joined #minetest-dev |
18:05 |
Krock |
nerzhul: will test soon |
18:05 |
nerzhul |
ty |
18:15 |
|
fluxflux joined #minetest-dev |
18:24 |
|
homthack joined #minetest-dev |
18:53 |
nerzhul |
Krock if i fix style i can merge ? :) |
18:53 |
Krock |
yes |
19:24 |
|
pmp-p joined #minetest-dev |
19:32 |
|
Wuzzy joined #minetest-dev |
19:41 |
|
pmp-p joined #minetest-dev |
19:49 |
|
pmp-p joined #minetest-dev |
19:56 |
|
calcul0n joined #minetest-dev |
21:26 |
|
kilbith joined #minetest-dev |
21:26 |
kilbith |
rubenwardy: this commit has wrong author: https://github.com/minetest/minetest/commit/08ee9794f |
21:27 |
kilbith |
code's been borrowed from https://github.com/minetest/minetest/pull/9569 |
21:27 |
rubenwardy |
I didn't merge that |
21:27 |
rubenwardy |
I imagine it says m yname because I made suggestions |
21:27 |
kilbith |
ah |
21:27 |
kilbith |
Krock ^ |
21:28 |
rubenwardy |
you need to be careful with GitHub squashes when you have borrowed code, because it puts the PR author not the commit author as the sqiashed commit author |
21:28 |
rubenwardy |
sigh that was a long sentence |
21:29 |
kilbith |
(I can't stand that runs is in the git log for real) |
21:29 |
Krock |
oops |
21:30 |
kilbith |
Krock: can you change that? |
21:30 |
Krock |
I could but it's too late |
21:31 |
kilbith |
rubenwardy, mind you to exclude him from the credits when it's time |
21:31 |
rubenwardy |
yeah |
21:31 |
MTDiscord |
<Knot Abbot> lol |
21:32 |
sfan5 |
small contributions won't make it to the credits menu if you mean that |
21:32 |
sfan5 |
and for the changelog it'd make sense to list it with the correct authorship, yes |
21:32 |
rubenwardy |
Yeah, exactly |
21:35 |
|
pmp-p joined #minetest-dev |
21:55 |
|
pmp-p joined #minetest-dev |
22:08 |
|
T4im joined #minetest-dev |
22:08 |
|
T4im joined #minetest-dev |
22:09 |
|
T4im joined #minetest-dev |
22:10 |
|
T4im joined #minetest-dev |
22:12 |
|
T4im joined #minetest-dev |
22:13 |
|
pmp-p joined #minetest-dev |
22:43 |
|
T4im joined #minetest-dev |
23:36 |
|
m42uko joined #minetest-dev |
23:41 |
|
T4im joined #minetest-dev |
23:46 |
|
T4im joined #minetest-dev |
23:59 |
|
T4im joined #minetest-dev |