Time |
Nick |
Message |
00:40 |
|
kilbith joined #minetest-dev |
00:58 |
|
olliy joined #minetest-dev |
05:00 |
|
MTDiscord joined #minetest-dev |
05:02 |
|
Miner_48er joined #minetest-dev |
05:37 |
|
YuGiOhJCJ joined #minetest-dev |
08:00 |
|
ShadowNinja joined #minetest-dev |
09:02 |
|
calcul0n_ joined #minetest-dev |
10:23 |
|
proller joined #minetest-dev |
10:50 |
|
Fixer joined #minetest-dev |
11:03 |
|
calcul0n__ joined #minetest-dev |
11:35 |
|
olliy joined #minetest-dev |
12:39 |
|
hecks joined #minetest-dev |
13:20 |
|
appguru joined #minetest-dev |
13:38 |
|
lisac joined #minetest-dev |
14:55 |
|
olliy joined #minetest-dev |
15:33 |
|
kilbith joined #minetest-dev |
15:35 |
kilbith |
sfan5: is there a function that take a texture string w/ modifiers and outputs a video::ITexture* in our codebase? |
15:35 |
sfan5 |
src/client/tile.cpp is responsible |
15:36 |
sfan5 |
I guess you want m_tsrc->getTexture? |
15:37 |
kilbith |
wait |
15:37 |
kilbith |
need to switch on linux first |
15:39 |
|
kilbith joined #minetest-dev |
15:40 |
kilbith |
sfan5: https://github.com/minetest/minetest/blob/master/src/gui/guiFormSpecMenu.cpp#L2790 |
15:40 |
kilbith |
yet modifiers aren't applied there |
15:41 |
sfan5 |
what does "aren't applied" mean? they don't just vanish |
15:41 |
sfan5 |
getTexture() is definitely the right one, it's used everywhere else |
15:41 |
sfan5 |
if I had to guess I'd say the modifers somehow get lost during formspec parsing |
15:42 |
kilbith |
so what does explain that? https://forum.minetest.net/viewtopic.php?f=47&t=25935 |
15:43 |
sfan5 |
doesn't the [ need to be escaped? |
15:43 |
kilbith |
it has been |
15:43 |
sfan5 |
but if it works with image[] but not model[] then idk |
15:43 |
kilbith |
shrugs |
15:44 |
sfan5 |
the only potential issue I see is the parsing |
15:44 |
sfan5 |
the bug must be somewhere in there |
15:48 |
|
hecks joined #minetest-dev |
15:53 |
|
rain1 joined #minetest-dev |
15:57 |
kilbith |
fixed |
15:57 |
kilbith |
that was easy |
15:58 |
kilbith |
sfan5: https://paste.ubuntu.com/p/r5fWNsQG2t/ |
15:58 |
kilbith |
can be merged as trivial |
15:59 |
sfan5 |
shouldn't that happen in the parser? |
15:59 |
kilbith |
https://i.imgur.com/wd5fgYf.png |
15:59 |
kilbith |
this is in the parse |
15:59 |
kilbith |
r |
15:59 |
sfan5 |
fetching textures in the parser seems weird then |
16:00 |
sfan5 |
if you tell me which git name+email I can attach to that I'll push it |
16:00 |
kilbith |
image[] does the same |
16:01 |
kilbith |
Jean-Patrick Guerrero <jeanpatrick.guerrerogmail.com> |
16:04 |
sfan5 |
done |
16:17 |
|
kilbith joined #minetest-dev |
18:13 |
|
kilbith joined #minetest-dev |
18:28 |
|
homthack joined #minetest-dev |
18:49 |
|
kilbith_ joined #minetest-dev |
19:11 |
|
fluxflux joined #minetest-dev |
19:57 |
|
Taoki joined #minetest-dev |
20:02 |
|
YuGiOhJCJ joined #minetest-dev |
23:04 |
rubenwardy |
Should searching and pagination in the ContentDB dialog be moved to the server? |
23:04 |
rubenwardy |
The benefit is faster loading and better searching because the server can make do of libraries. Currently, barely any info is sent to the client because it's one API response |
23:05 |
rubenwardy |
for example, tags aren't available on the client |
23:05 |
rubenwardy |
The server has support for fulltext search - this is where you know about natural language and word variations |
23:05 |
rubenwardy |
The disadvantage is that it's harder to code support on the client |
23:06 |
rubenwardy |
it's also quite annoying if the client keeps freezing on page turns |
23:08 |
rubenwardy |
Doing things async with the mainmenu and formspecs is a bit painful |
23:11 |
MTDiscord |
<Techy5> I dunno if this is a known issue, thoughts? https://github.com/minetest/minetest/issues/10769 |
23:13 |
rubenwardy |
another disadvantage of pagination is detecting updates - you can't Update All if all packages aren't loaded |