Minetest logo

IRC log for #minetest-dev, 2019-12-12

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:04 pgimeno_ joined #minetest-dev
00:18 Ruslan1 joined #minetest-dev
00:43 xerox123 joined #minetest-dev
01:32 ANAND Oh nice!
02:04 Miner_48er joined #minetest-dev
02:15 nephele joined #minetest-dev
02:30 pmp-p joined #minetest-dev
04:14 Kimapr_ joined #minetest-dev
04:17 Kimapr joined #minetest-dev
05:12 ssieb joined #minetest-dev
07:34 pyrollo joined #minetest-dev
07:41 thrym_ left #minetest-dev
08:38 ShadowNinja joined #minetest-dev
08:54 proller joined #minetest-dev
09:38 proller joined #minetest-dev
09:51 realzies joined #minetest-dev
10:07 proller joined #minetest-dev
10:42 pmp-p joined #minetest-dev
11:00 proller joined #minetest-dev
11:12 AntumDeluge joined #minetest-dev
11:26 Fixer joined #minetest-dev
11:30 tuedel joined #minetest-dev
12:19 Kimapr joined #minetest-dev
12:48 HDMI_STECKDOSE joined #minetest-dev
13:06 tomraceror joined #minetest-dev
13:13 Kimapr joined #minetest-dev
13:42 HDMI_STECKDOSE joined #minetest-dev
13:52 CrazyDave joined #minetest-dev
13:53 CrazyDave left #minetest-dev
14:34 BrunoMine joined #minetest-dev
15:50 Calinou joined #minetest-dev
16:25 Wuzzy joined #minetest-dev
17:21 Krock joined #minetest-dev
17:40 HDMI_STECKDOSE joined #minetest-dev
17:40 Krock wow rubenwardy, that was quick
17:41 Krock although this will require running Minetest with the default settings and DPI to compare it with the "official" screenshots
17:43 rubenwardy Settings are baked in
17:43 rubenwardy I didn't consider dpi
17:43 rubenwardy Will need to override it
17:45 Krock you can also add image tolerance by downscaling it
17:46 Krock linear scaling will hide details
17:47 behalebabo joined #minetest-dev
17:55 Calinou you might not want to perform "binding" automated tests using screenshots in general
17:55 Calinou posting screenshots in pull requests as comments might be a better idea
17:55 Calinou https://bartwronski.com/2019/08/14/how-not-to-test-graphics-algorithms/
18:00 rubenwardy The better approach isn't possible with our code without big rewrites, making the thing useless
18:01 rubenwardy There will need to be manual intervention, but that's fine. It's a lot less time than bugs being introduced
18:01 rubenwardy Perhaps it should comment any failing screenshots in the thread only, and not mark the build as failed
18:04 Krock Calinou: good intentions are there, but you cannot do that with a rendering engine
18:04 Krock multiple components have to interact with eachother and be rendered to check whether it looks okay
18:05 tomraceror joined #minetest-dev
18:06 Calinou indeed, I'm arguing we shouldn't perform automated checks for screenshots :)
18:06 Calinou the ROI just isn't there due to the false positives
18:06 Calinou keeping screenshots for archiving can be very useful though, so you can easily bisect regressions
18:07 Krock right. comparison would best be done by eye
18:07 Krock otherwise it will be impossible to "pass" the tests on GUI bugfixes
18:08 rubenwardy The intention is for some comparison to be done by eye, but for most of it to be done in bulk
18:15 rubenwardy Perhaps it doesn't need to be automated by CI, it could be ran by a developer when testing
18:27 erlehmann_ joined #minetest-dev
18:39 tomraceror joined #minetest-dev
18:59 erlehmann joined #minetest-dev
19:02 erlehmann joined #minetest-dev
19:06 nobody joined #minetest-dev
19:08 nornagon joined #minetest-dev
19:11 fluxflux joined #minetest-dev
19:19 nobody left #minetest-dev
19:46 ssieb joined #minetest-dev
20:30 NoctisLa1 joined #minetest-dev
20:40 proller joined #minetest-dev
20:50 proller joined #minetest-dev
22:17 proller joined #minetest-dev
23:00 ssieb joined #minetest-dev
23:00 ssieb joined #minetest-dev
23:10 Lone-Star joined #minetest-dev
23:18 Lone-Star left #minetest-dev
23:20 nornagon joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext