| Time |
Nick |
Message |
| 00:33 |
|
Cornelia joined #minetest-dev |
| 00:49 |
|
twoelk left #minetest-dev |
| 01:42 |
|
YuGiOhJCJ joined #minetest-dev |
| 02:22 |
|
ANAND joined #minetest-dev |
| 03:13 |
|
YuGiOhJCJ joined #minetest-dev |
| 07:59 |
|
Wuzzy joined #minetest-dev |
| 08:06 |
Wuzzy |
Does the feature freeze in Minetest imply a string freeze? If yes, I can provide to you the missing strings to MTG. |
| 08:06 |
Wuzzy |
missing German translations* |
| 08:31 |
Wuzzy |
please look at this crash-fixing PR, thanks: https://github.com/minetest/minetest/pull/9000 |
| 08:37 |
|
ShadowNinja joined #minetest-dev |
| 09:07 |
|
ensonic joined #minetest-dev |
| 09:21 |
|
tomraceror joined #minetest-dev |
| 09:32 |
|
Gokearl joined #minetest-dev |
| 09:44 |
|
Krock joined #minetest-dev |
| 10:14 |
|
tomraceror joined #minetest-dev |
| 11:00 |
Wuzzy |
Is it still possible to add/change setting descriptions for 5.1.0 or is it too late because of string freeze? |
| 11:08 |
Krock |
there's no string freeze yet |
| 11:20 |
|
Fixer joined #minetest-dev |
| 11:20 |
Krock |
will merge #8958 and #8922 in 20 minutes. latter needs an MTG update afterwards |
| 11:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/8958 -- Allow grep-ing for on_grant and on_revoke by DS-Minetest |
| 11:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/8922 -- Fix error message caused by adding new parameter to background by rubenwardy |
| 11:25 |
Krock |
also #8871. Unlikely to break anything |
| 11:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/8871 -- Move Quicktune code to util/ by ClobberXD |
| 11:39 |
Krock |
merging |
| 11:41 |
Krock |
done |
| 11:49 |
|
kilbith joined #minetest-dev |
| 11:50 |
kilbith |
I'm kinda disapointed that neither hypertext[] or craftguide won't slip into 5.1 |
| 11:51 |
kilbith |
I don't think we'll bother to fix the code style ever again and I'm afraid to say that the next release will be pretty boring because of that |
| 12:01 |
Krock |
to be fair, it's also a massive PR with much work spent on it |
| 12:01 |
Krock |
it surely won't die, and I'd like to see it in 5.2.0 |
| 12:02 |
Krock |
if you don't have time to change the code style, someone else (maybe me) will adopt it |
| 12:03 |
kilbith |
that's fine by me then |
| 12:10 |
Wuzzy |
do you have an style codeline that people can just paste into their console? |
| 12:11 |
Wuzzy |
style → astyle |
| 12:11 |
Wuzzy |
code style fixes are boooooooooooring |
| 12:11 |
Krock |
excuse me what? |
| 12:17 |
Wuzzy |
astyle |
| 12:17 |
Wuzzy |
never heard of that? |
| 12:17 |
Wuzzy |
astyle is a program to automatically apply code style stuff |
| 12:18 |
Wuzzy |
Do you have a command line for astyle that people can just paste n their console to fix all the code style automagically? would safe infinite amounts of boring work |
| 12:23 |
kilbith |
https://i.imgur.com/nQ5MLSc.png |
| 12:23 |
kilbith |
https://github.com/minetest/minetest_game/blob/master/mods/creative/inventory.lua#L113 |
| 12:23 |
kilbith |
minetest.colorize is broken |
| 12:24 |
sfan5 |
uh oh indeed |
| 12:24 |
sfan5 |
wonder who broke it |
| 12:24 |
Wuzzy |
to be precise: minetest.colorize is broken for label[] |
| 12:24 |
Wuzzy |
i believe it never worked for label[] |
| 12:25 |
kilbith |
it didn't |
| 12:25 |
kilbith |
*it did |
| 12:25 |
Wuzzy |
uh-oh then that's a regression |
| 12:25 |
kilbith |
realized it brokes in craftguide recently too |
| 12:26 |
sfan5 |
ok that was easy |
| 12:26 |
sfan5 |
it's this commit >> https://github.com/minetest/minetest/commit/2c9edefde3d941b1efa5c93a087814d6bc3509e6 |
| 12:26 |
celeron55 |
the problem with automatic style tools like astyle is that none i've seen so far are capable of MT's style rules |
| 12:27 |
Wuzzy |
? |
| 12:27 |
Wuzzy |
change MT's style rules then? XD |
| 12:28 |
celeron55 |
they all have their preferred style that has weird unconfigurable stuff |
| 12:28 |
Wuzzy |
? |
| 12:28 |
celeron55 |
and then just give fine options for fine tuning random portions of it, not all |
| 12:28 |
celeron55 |
-fine |
| 12:28 |
Wuzzy |
ok this is bad |
| 12:29 |
Wuzzy |
indeed ? |
| 12:29 |
celeron55 |
i recall astyle doesn't even support C++11 |
| 12:29 |
celeron55 |
a single lambda will break it |
| 12:29 |
Wuzzy |
boo! |
| 12:29 |
Wuzzy |
i never really liked astyle either |
| 12:29 |
celeron55 |
maybe it's been improved though |
| 12:30 |
Krock |
oh no it was me again who broke it |
| 12:31 |
|
Gokearl left #minetest-dev |
| 12:36 |
Krock |
also " getStyleForElement("label", spec.fname);" .. hmm, there's no fname |
| 12:40 |
kilbith |
isn't that `flabel` instead? |
| 12:42 |
Krock |
no, it should be the element name, but there's no such property for labels. hence it'll be just an empty string |
| 12:43 |
rubenwardy |
kilbith: I'm very close to approving hypertext, so I'd be surprised if it's not in 5.2 |
| 12:43 |
* Krock |
should probably test the color stuff with freetype enabled when testing on master |
| 12:43 |
rubenwardy |
over time, I've cared less and less about code style |
| 12:43 |
rubenwardy |
code style reviews are lazy |
| 12:44 |
rubenwardy |
Wuzzy: it may be style related, as style allows you to set the base color, but colorize should still apply on top of that |
| 12:44 |
kilbith |
I expected 5.1 to be the big formspec release tbh |
| 12:45 |
rubenwardy |
same |
| 12:45 |
rubenwardy |
it's better to release regularly than spend until January working on it |
| 12:46 |
rubenwardy |
"regularly" ha |
| 12:46 |
rubenwardy |
well, I guess 6 months since the last release is regular, just not frequent |
| 12:49 |
kilbith |
I'd like to re-open the dynamic shadows PR at some point too |
| 12:49 |
Wuzzy |
good for having a proper release schedule instead of delaying a release forever cuz of one missing feature |
| 12:49 |
Krock |
we could also wait a year to make it like a second 5.0.0 release with all sorts of new features and bugfixes, but sorter cycles are better IMO |
| 12:49 |
Krock |
*shorter |
| 12:50 |
rubenwardy |
I should update my roadmap |
| 12:51 |
rubenwardy |
things I want to do currently: Better mainmenu with support for per-game customisation, dependency installation in CDB (urgh), font sizes in labels, labels with sizes and alignment |
| 12:51 |
rubenwardy |
what I should do currently: fix bugs |
| 12:53 |
Krock |
will push https://krock-works.uk.to/u/patches/0001-label-Fix-broken-colors-since-2c9edef.patch in 15 minutes unless there are objections |
| 12:53 |
rubenwardy |
oh lol |
| 12:53 |
kilbith |
the mainmenu shall be the showcase of the last GUI features |
| 12:54 |
rubenwardy |
yeah |
| 12:54 |
rubenwardy |
it'll use formspec styling and re-coordinates |
| 13:03 |
celeron55 |
i just tried to set up uncrustify to format MT's codebase... and lo and behold, it stops indenting comments inside a class when it sees ~ChatBuffer() = default; inside |
| 13:03 |
celeron55 |
these things just won't work |
| 13:03 |
celeron55 |
in buildat i added my own post processor to run after uncrustify which re-indents everything |
| 13:03 |
celeron55 |
it worked fairly well |
| 13:06 |
Calinou |
why not clang-format? |
| 13:06 |
Calinou |
it's not perfect by any measure still, there's lots of things it can't enforce |
| 13:07 |
Krock |
clang-format is really horrible in certain situations |
| 13:07 |
Krock |
such as continued lines and indention |
| 13:09 |
Krock |
pushing fix |
| 13:20 |
sfan5 |
how do we handle translations in feature freeze? |
| 13:20 |
sfan5 |
more specifically, mtg has two outstanding translation PRs |
| 13:20 |
sfan5 |
it'd be quite nice to get them in for 5.1 (if they can be reviewing appropriately), but does the freeze permit that? |
| 13:21 |
sfan5 |
s/reviewing/reviewed/ |
| 13:21 |
Krock |
yes |
| 13:21 |
Krock |
they might be features, but are unlikely to break anything |
| 13:22 |
Krock |
rubenwardy also wanted to update the engine translations recently. I can do that as well if he doesn't have time for it |
| 13:22 |
rubenwardy |
aren't they bug fixes? |
| 13:22 |
celeron55 |
so, check this https://github.com/celeron55/minetest/commit/48515b9b2e0f19819da97eeba8fea503eb84629f |
| 13:22 |
rubenwardy |
translations are usually merged during feature freezes anyway |
| 13:22 |
Krock |
rubenwardy: sfan5 is talking about italian client side translations |
| 13:22 |
celeron55 |
the thing to check in automatic code style changes is whether it does something utterly stupid |
| 13:22 |
sfan5 |
Krock: (and spanish) |
| 13:23 |
Krock |
and spanish |
| 13:23 |
celeron55 |
not whether it matches perfectly to official or personal preferences |
| 13:23 |
Krock |
oh. I had to look up what the other was :3 |
| 13:23 |
celeron55 |
usually these do something stupid and it doesn't come even close to preferences |
| 13:24 |
Krock |
/<tab> is stupid in first place |
| 13:24 |
Krock |
* // |
| 13:25 |
Krock |
and pointers in function return values should be on the other side as well, to follow the general pointer placement rules |
| 13:25 |
celeron55 |
well for firsts none of these tools understand that comments can be commented-out code |
| 13:25 |
Krock |
which code formatter is that? |
| 13:25 |
celeron55 |
that's easy, but wasn't specified in our rules |
| 13:26 |
celeron55 |
https://github.com/celeron55/minetest/commit/259c0f25da3fcc00a34a5b3681de6af35fa94041 |
| 13:26 |
celeron55 |
it's mostly uncrustify, but afterwards helped by a piece of python crap written by me |
| 13:26 |
celeron55 |
uncrustify is good at fomatting but not very good at indenting |
| 13:27 |
Krock |
so to say - weak rules first, then correct what uncrustify can't do? |
| 13:27 |
celeron55 |
uncrustify does everything, including things it can't, and then it re-indents everything |
| 13:27 |
celeron55 |
i mean the python script re-indents everything |
| 13:29 |
celeron55 |
>well for firsts none of these tools understand that comments can be commented-out code |
| 13:29 |
celeron55 |
altough, my python script does indent commented out code, as long as it's multi line commented |
| 13:29 |
Krock |
ah |
| 13:29 |
celeron55 |
IIRC |
| 13:29 |
celeron55 |
(that was a thing i wanted) |
| 13:31 |
celeron55 |
the end result of uncrustify is completely re-formatted aside from comments, and even they get their line breaks redone |
| 13:34 |
|
tomraceror joined #minetest-dev |
| 13:38 |
celeron55 |
>that's easy, but |
| 13:39 |
celeron55 |
well, not easy, because at least the version of uncrustify i'm using doesn't understand ClientInterface::getClientNoEx is a function |
| 13:40 |
celeron55 |
it thinks it's a "word" |
| 13:40 |
celeron55 |
so then fixing it breaks normal pointer variable definitions |
| 13:40 |
celeron55 |
so, in this case i'd just change the stle |
| 13:40 |
celeron55 |
style* |
| 13:42 |
|
nepugia joined #minetest-dev |
| 13:44 |
celeron55 |
anyway, there's a challenge; try to do better than that hack |
| 13:45 |
celeron55 |
https://github.com/celeron55/minetest/commits/autostyle1 |
| 13:46 |
celeron55 |
you can also try commenting out the python scripts at the end of util/codestyle.sh |
| 13:47 |
|
Cornelia joined #minetest-dev |
| 13:50 |
Krock |
#8464 removing the docs for now, or marking it as deprecated would be the best solution I suppose |
| 13:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/8464 -- Remove tool filtering |
| 14:02 |
|
tomraceror joined #minetest-dev |
| 14:09 |
Wuzzy |
Krock: I'd rather go with marking at deprecated since it was already in docs in 5.0.0 |
| 14:10 |
Wuzzy |
just removing the docs would be really confusing, i guess |
| 14:10 |
Wuzzy |
IMO deprecation is also my favourite solution. Oddly, sfan5 is opposed. ? |
| 14:11 |
sfan5 |
where did you read that? |
| 14:11 |
rubenwardy |
I support deprecation |
| 14:11 |
rubenwardy |
groups are a much better way to do this |
| 14:11 |
rubenwardy |
and more consistent with the rest of the API |
| 14:11 |
Wuzzy |
i read that ... between the lines? ummm my mind must be broken today ? |
| 14:12 |
Wuzzy |
groups... exactly! that was the entire point. obviously out of reach now |
| 14:19 |
|
turtleman joined #minetest-dev |
| 14:26 |
|
nepugia joined #minetest-dev |
| 14:32 |
celeron55 |
the lua code in question is soon 8 years old |
| 14:32 |
celeron55 |
and written by the legendary kahrl |
| 14:32 |
celeron55 |
(commented in the issue) |
| 14:34 |
|
Cornelia joined #minetest-dev |
| 14:49 |
|
nepugia joined #minetest-dev |
| 14:54 |
|
Cornelia joined #minetest-dev |
| 15:01 |
Wuzzy |
woah |
| 15:01 |
Wuzzy |
and first time documented in 5.0 only. haha |
| 15:24 |
|
HDMI_STECKDOSE joined #minetest-dev |
| 15:27 |
|
paramat joined #minetest-dev |
| 15:39 |
|
Cornelia joined #minetest-dev |
| 15:57 |
|
tomraceror joined #minetest-dev |
| 16:18 |
|
Cornelia joined #minetest-dev |
| 16:22 |
|
nepugia joined #minetest-dev |
| 16:27 |
|
Cornelia joined #minetest-dev |
| 16:43 |
ANAND |
Do we have an RC for 5.1.0? |
| 16:43 |
ANAND |
An official one, that is |
| 16:46 |
paramat |
for #8464 i support deprecating and discouraging use, for 5.1.0, since it will probably be removed later |
| 16:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/8464 -- Remove tool filtering |
| 16:50 |
p_gimeno |
ANAND: I'd say it's too soon for RCs since it's barely in feature freeze anyway |
| 16:52 |
Krock |
there's one on the forums |
| 16:52 |
Krock |
see News (or so) |
| 16:53 |
p_gimeno |
official? |
| 16:53 |
ANAND |
p_gimeno: Right, I thought I missed an RC announcement bc Wuzzy mentions 5.1.0-RC1 in #9005 |
| 16:53 |
ShadowBot |
https://github.com/minetest/minetest/issues/9005 -- Waving liquid render bug if solid block is above liquid |
| 16:53 |
ANAND |
Oh, so there is one? |
| 16:53 |
Krock |
https://forum.minetest.net/viewtopic.php?f=18&t=23386 |
| 16:58 |
ANAND |
Nice |
| 16:58 |
p_gimeno |
calling that RC1 with known issues that are planned to be fixed in the final version, is somewhat rushed. It mostly defeats the meaning of "release candidate". |
| 17:14 |
Krock |
inb4 RC2 |
| 17:20 |
|
nepugia joined #minetest-dev |
| 17:22 |
|
Cornelia joined #minetest-dev |
| 17:24 |
Krock |
btw: 5 topics in Builds await deletion, users inclusive |
| 17:34 |
|
ensonic joined #minetest-dev |
| 17:47 |
Krock |
will merge #8974 in 10 minutes (or so) |
| 17:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/8974 -- Textures: Load base pack only as last fallback by SmallJoker |
| 17:56 |
Krock |
merging |
| 18:08 |
|
Cornelia joined #minetest-dev |
| 18:33 |
Wuzzy |
Krock: this patch in #8974 works fine for me |
| 18:33 |
ShadowBot |
https://github.com/minetest/minetest/issues/8974 -- Textures: Load base pack only as last fallback by SmallJoker |
| 18:33 |
Wuzzy |
thanks |
| 18:34 |
Krock |
considering that it was made to fix that issue confirms that it does its job |
| 18:34 |
Krock |
IIRC there's still another PR to move some textures |
| 18:35 |
Krock |
but I don't think that's for 5.1.0 |
| 18:35 |
Wuzzy |
Doees this now unlock https://github.com/minetest/minetest/pull/8845? |
| 18:35 |
Wuzzy |
(if we could pretend there is no feature freeze :D) |
| 18:36 |
Krock |
ah. That PR |
| 18:42 |
|
Cornelia joined #minetest-dev |
| 18:48 |
|
paramat joined #minetest-dev |
| 18:53 |
paramat |
soon i'll make a PR to document tool filtering as deprecated |
| 18:54 |
Wuzzy |
Party!! |
| 19:28 |
|
Cornelia joined #minetest-dev |
| 19:43 |
|
nepugia joined #minetest-dev |
| 20:17 |
|
proller joined #minetest-dev |
| 20:41 |
|
Cornelia joined #minetest-dev |
| 21:24 |
|
Cornelia joined #minetest-dev |
| 21:29 |
|
paramat joined #minetest-dev |
| 22:06 |
|
Cornelia joined #minetest-dev |
| 22:40 |
|
Cornelia joined #minetest-dev |
| 23:31 |
|
Cornelia joined #minetest-dev |
| 23:42 |
|
Cornelia joined #minetest-dev |
