| Time |
Nick |
Message |
| 01:40 |
ANAND |
#8871 |
| 01:40 |
ShadowBot |
https://github.com/minetest/minetest/issues/8871 -- Move Quicktune code to util/ by ClobberXD |
| 01:40 |
ANAND |
^ Moves unused code to a more suitable part of the code base |
| 01:40 |
ANAND |
It's already got one approval |
| 01:45 |
pmp-p |
so for client api modding i'd like json(or any) to export NaN tagged pointers for functions/userdata instead of null. is it possible from pure lua ? |
| 02:38 |
ANAND |
sfan5: Any other concerns regarding #7557? Will test again today, to ensure it still works. |
| 02:38 |
ShadowBot |
https://github.com/minetest/minetest/issues/7557 -- Add support for per-player FOV overrides and multipliers by ClobberXD |
| 03:31 |
|
ssieb joined #minetest-dev |
| 07:47 |
ANAND |
It still works after the recent changes |
| 07:47 |
ANAND |
See https://github.com/minetest/minetest/pull/7557#issuecomment-530236423 |
| 08:42 |
|
ShadowNinja joined #minetest-dev |
| 09:58 |
|
Cornelia joined #minetest-dev |
| 10:04 |
|
proller joined #minetest-dev |
| 10:17 |
|
proller joined #minetest-dev |
| 10:26 |
|
troller joined #minetest-dev |
| 10:47 |
sfan5 |
ANAND: nah should be fine |
| 11:41 |
|
proller joined #minetest-dev |
| 11:57 |
|
Fixer joined #minetest-dev |
| 12:05 |
|
proller joined #minetest-dev |
| 12:09 |
|
lisac joined #minetest-dev |
| 12:41 |
ANAND |
sfan5: Thanks. Would you be able to approve the PR? |
| 12:47 |
|
Cornelia joined #minetest-dev |
| 13:00 |
|
Cornelia joined #minetest-dev |
| 13:22 |
p_gimeno |
pmp-p: pointers? you can't fit a pointer in a Lua number. Pointers can be 64 bits in 64-bit platforms; Lua numbers only have 52 bits. |
| 13:23 |
p_gimeno |
You can have pointers in FFI via LuaJIT, but that's LuaJIT-specific, not Lua-generic. |
| 13:27 |
p_gimeno |
Anyway, I don't see how you can encode NaN in JSON, see https://stackoverflow.com/questions/1423081/json-left-out-infinity-and-nan-json-status-in-ecmascript |
| 13:29 |
pmp-p |
p_gimeno: i don't want to fit it in a number but within a rpc record for export , and regenerate from the other way |
| 13:29 |
pmp-p |
p_gimeno: isn't there something more generic than luajit-ffi ? |
| 13:30 |
pmp-p |
though that would be ok since minetest uses that |
| 13:31 |
p_gimeno |
Lua's lightuserdata is intended as a generic pointer, but LuaJIT deprecated it because it causes problems in some platforms due to LuaJIT's internal organization |
| 13:31 |
pmp-p |
since lua use nan tagging i don't see the point to box pointers for rpc |
| 13:31 |
pmp-p |
that would kill perf |
| 13:32 |
|
Cornelia joined #minetest-dev |
| 13:32 |
p_gimeno |
I'm at a loss at what you're trying to do. Anyway, keep in mind that Minetest supports both LuaJIT and PUC Lua, and AFAIK PUC Lua is still used in the official distribution for some platforms |
| 13:33 |
pmp-p |
in µpython i use a global flag for the repr/tostring conversion set just before serializing and the json encoder fallback to that on complex types |
| 13:33 |
pmp-p |
i'd like to do the same in lua |
| 13:34 |
p_gimeno |
could we discuss this by PM? I'm uncomfortable because this is hardly on-topic |
| 13:35 |
pmp-p |
client api modding is OT ? |
| 13:36 |
pmp-p |
that's only for client side it's loopback rpc |
| 13:36 |
pmp-p |
ie when flag is set string representation of object is an encoded pointer but that's relative to client only |
| 13:37 |
p_gimeno |
details on what the best approach to accomplish a given generic task is, has very little to do with Minetest development, and hardly any developer or people who track development will be interested in the discussion, or that's my estimation |
| 13:39 |
pmp-p |
"API is currently not stable and can change" so i see no point in discarding one idea or another |
| 13:39 |
pmp-p |
as stated there https://wiki.minetest.net/Mods#Client-Side_Mods |
| 13:40 |
pmp-p |
or there https://dev.minetest.net/Client_scripting_plans |
| 13:45 |
pmp-p |
p_gimeno: i can see some key points missing from current listing if anyone is insterested |
| 13:45 |
pmp-p |
but anyway thx for the ffi clue maybe i'll get further with https://stackoverflow.com/questions/29948314/how-to-get-memory-address-in-lua |
| 14:18 |
|
Cornelia joined #minetest-dev |
| 14:21 |
|
Lia joined #minetest-dev |
| 14:27 |
|
tomraceror joined #minetest-dev |
| 15:46 |
|
HDMI_STECKDOSE joined #minetest-dev |
| 15:53 |
|
tomraceror joined #minetest-dev |
| 16:10 |
|
HDMI_STECKDOSE joined #minetest-dev |
| 17:13 |
|
Krock joined #minetest-dev |
| 17:33 |
|
ensonic joined #minetest-dev |
| 18:07 |
|
Lone-Star joined #minetest-dev |
| 18:10 |
|
ANAND joined #minetest-dev |
| 18:46 |
Krock |
sfan5: how did you parse the gettext calls (S) in https://github.com/minetest/minetest_game/pull/2471/files#r323180439 ? |
| 18:47 |
sfan5 |
I didn't |
| 18:48 |
Krock |
ah yes. the translation itself works as expected, but the parser scripts cannot evaluate all combinations |
| 18:49 |
Krock |
Panquesito7 did something wrong anyway |
| 18:50 |
Krock |
string is string, S does not care where it comes from |
| 18:50 |
Krock |
too bad that nore's parsing script was abandoned/rejected |
| 18:55 |
sfan5 |
I think I'll fix it as suggested by Wuzzy for butterflies, dyes and use the dummy S() method for stairs, wool |
| 18:56 |
sfan5 |
hidden butterflies don't need a description do they? |
| 18:56 |
Krock |
no, they don't |
| 18:57 |
Krock |
"you hacker you" |
| 18:59 |
sfan5 |
>inventory_image = "insects_butterfly_"..name..".png", |
| 18:59 |
sfan5 |
this looks incorrect |
| 19:01 |
|
paramat joined #minetest-dev |
| 19:01 |
sfan5 |
hm actually the other method is fine for dyes too |
| 19:13 |
sfan5 |
game#2471 should now actually be ready |
| 19:13 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2471 -- Fix and improve translation strings by sfan5 |
| 19:15 |
paramat |
i'll merge game#2064 in a few hours and after i fix the luacheck stuff, in case anyone else wants to look at that |
| 19:15 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2064 -- Add initial environmental sounds mod with flowing water sounds by paramat |
| 19:15 |
|
ssieb joined #minetest-dev |
| 20:56 |
|
proller joined #minetest-dev |
| 21:10 |
|
fluxflux joined #minetest-dev |
| 23:38 |
|
paramat joined #minetest-dev |
| 23:45 |
paramat |
merging game#2064 |
| 23:45 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2064 -- Add initial environmental sounds mod with flowing water sounds by paramat |
