| Time |
Nick |
Message |
| 00:39 |
|
Cornelia joined #minetest-dev |
| 01:02 |
|
ANAND joined #minetest-dev |
| 02:53 |
|
Cornelia joined #minetest-dev |
| 03:19 |
|
pmpp joined #minetest-dev |
| 03:21 |
|
Warr1024 joined #minetest-dev |
| 03:21 |
|
Warr1024 joined #minetest-dev |
| 03:22 |
Warr1024 |
Is anyone aware of a race condition between ABM's modifying the world (i.e. via set_node, remove_node, swap_node) and players digging/placing? |
| 03:23 |
Warr1024 |
I've run into a situation where I place down a stack of nodes, and then an ABM modifies them dynamically, and if I try to dig them all up while the ABM is running, it replaces some nodes after I've dug them |
| 03:23 |
Warr1024 |
so if I dig up the whole patch, I end up with more than I started out with. |
| 03:23 |
|
fluxflux joined #minetest-dev |
| 03:24 |
Warr1024 |
I do a get_node to check to see if the nodes have changed to no longer match the ABM right before changing them, but it doesn't fix anything. |
| 03:24 |
Warr1024 |
Seems like there must be a race between threads doing read/write cycles on the map. |
| 03:24 |
Warr1024 |
Is this a known issue? Should I try to put together a minimal test case? |
| 03:25 |
Warr1024 |
I found https://github.com/minetest/minetest/issues/8378, but it doesn't seem to be the same thing; in particular, that issue has get_node returning the wrong node, whereas I'm seeing the right node, but wrong behavior. |
| 03:39 |
|
Ruslan1 joined #minetest-dev |
| 03:44 |
Warr1024 |
Hmm, nevermind, it looks like I found a mod bug that was causing it :-P |
| 03:45 |
|
fluxflux joined #minetest-dev |
| 04:04 |
|
fluxflux joined #minetest-dev |
| 04:08 |
|
Cornelia joined #minetest-dev |
| 04:34 |
|
Lone_Wolf joined #minetest-dev |
| 06:39 |
|
vesper11 joined #minetest-dev |
| 06:57 |
ANAND |
Please remove the WIP label from #8817 and #8834 |
| 06:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/8817 -- [no squash] Settings: Prevent unnecessary writes by checking for modification by ClobberXD |
| 06:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/8834 -- [no squash] Send ActiveObjects along with definitions once connection is established by ClobberXD |
| 06:58 |
ANAND |
I've not marked the former as "ready for review" to prevent an accidental merge without removing a bunch of debug statements |
| 06:58 |
ANAND |
Thanks in advance |
| 07:09 |
|
Cornelia joined #minetest-dev |
| 07:42 |
|
ssieb joined #minetest-dev |
| 08:22 |
|
Enricoo joined #minetest-dev |
| 08:42 |
|
ShadowNinja joined #minetest-dev |
| 09:11 |
rubenwardy |
Warr1024 the server thread is a single thread. Player interactions will never happen whilst lua is running. As part of the server step, it receives all packets and handles them - this will be when lua is ran for player interactions. ABMs are part of the environment update, so a different part of the server step |
| 09:12 |
rubenwardy |
The client is separate to the server though, so I suspect that this is a bug in your mod |
| 09:15 |
|
Krock joined #minetest-dev |
| 09:30 |
|
nepugia joined #minetest-dev |
| 09:33 |
|
EnricoXL joined #minetest-dev |
| 09:35 |
Krock |
merging #8857 in 10 minutes |
| 09:35 |
ShadowBot |
https://github.com/minetest/minetest/issues/8857 -- Document world format version 28 (private nodemeta) by DS-Minetest |
| 09:36 |
|
EnricoXL joined #minetest-dev |
| 09:39 |
|
proller joined #minetest-dev |
| 10:04 |
|
EnricoXL left #minetest-dev |
| 10:05 |
|
Enricoo joined #minetest-dev |
| 10:15 |
ANAND |
One more approval required for #8767 and #8271 |
| 10:15 |
ShadowBot |
https://github.com/minetest/minetest/issues/8767 -- Fix rotation of attached particlespawner [no squash pls; ketchup ok] by ClobberXD |
| 10:15 |
ShadowBot |
https://github.com/minetest/minetest/issues/8271 -- Fix breath statbar scaling; defer breath_bar hiding by one second by ClobberXD |
| 10:25 |
ANAND |
Rebased #7557 (for the thousandth time ._.) |
| 10:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/7557 -- Add support for per-player FOV overrides and multipliers by ClobberXD |
| 10:26 |
ANAND |
Oh yea, that PR has one approval too. :D |
| 10:30 |
ANAND |
A *lot* has changed in #7587 after sofar's approval, and I don't think the approval still holds. |
| 10:30 |
ShadowBot |
https://github.com/minetest/minetest/issues/7587 -- Implement on_wielditem_change callback registration by ClobberXD |
| 10:36 |
|
Fixer joined #minetest-dev |
| 10:48 |
|
Krock joined #minetest-dev |
| 10:48 |
Krock |
ANAND: incremental inv is quite recent, so proto version 38 could still be used |
| 10:53 |
ANAND |
Oh ok, makes sense :) |
| 10:54 |
Krock |
8767 is quite trivial, I wonder why it's still not reviewed a 2nd time |
| 10:54 |
sfan5 |
agree with that |
| 10:54 |
ANAND |
Reverted proto version bump |
| 10:56 |
ANAND |
Rebasing #7587 is a nightmare. Thanks for #8677, Krock :P |
| 10:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/7587 -- Implement on_wielditem_change callback registration by ClobberXD |
| 10:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/8677 -- Unify wield item handling by SmallJoker |
| 10:57 |
Krock |
np |
| 10:57 |
ANAND |
lol |
| 10:57 |
ANAND |
I wasn't really happy with the implementation. Now I get to redo it :) |
| 10:58 |
sfan5 |
Krock: 8767 is a bit hard to follow due to all the code style changes |
| 11:01 |
|
tomraceror joined #minetest-dev |
| 11:03 |
ANAND |
sfan5: I've separated the code-style changes from the actual bug-fix |
| 11:03 |
Krock |
ah yes |
| 11:03 |
sfan5 |
there were still a few in the first commit |
| 11:03 |
ANAND |
Ah |
| 11:03 |
ANAND |
my bad, sorry |
| 11:23 |
|
Enricoo joined #minetest-dev |
| 11:34 |
|
Ruslan1 joined #minetest-dev |
| 11:39 |
|
aldum joined #minetest-dev |
| 12:36 |
|
YuGiOhJCJ joined #minetest-dev |
| 12:45 |
|
ircbot37 joined #minetest-dev |
| 12:46 |
Krock |
merging 8857 ... |
| 13:02 |
|
ircbot59 joined #minetest-dev |
| 13:03 |
|
ircbot19 joined #minetest-dev |
| 13:11 |
|
nepugia joined #minetest-dev |
| 13:31 |
|
Enricoo joined #minetest-dev |
| 14:29 |
Krock |
ANAND: is #8834 still wip? |
| 14:29 |
ShadowBot |
https://github.com/minetest/minetest/issues/8834 -- [no squash] Send ActiveObjects along with definitions once connection is established by ClobberXD |
| 14:55 |
|
aldum joined #minetest-dev |
| 15:03 |
|
Lone_Wolf joined #minetest-dev |
| 15:25 |
|
fluxflux joined #minetest-dev |
| 15:28 |
|
Wuzzy joined #minetest-dev |
| 15:57 |
|
behalebabo joined #minetest-dev |
| 16:02 |
|
Lone_Wolf joined #minetest-dev |
| 16:10 |
|
Ruslan1 joined #minetest-dev |
| 16:29 |
ANAND |
Krock: No, #8834 is ready for review |
| 16:29 |
ShadowBot |
https://github.com/minetest/minetest/issues/8834 -- [no squash] Send ActiveObjects along with definitions once connection is established by ClobberXD |
| 16:30 |
ANAND |
I've also tested it by printing a debug message in Client::sendPlayerPos, within the LocalPlayer::isDead if block |
| 16:40 |
ANAND |
sfan5: https://github.com/minetest/minetest/pull/7557#discussion_r319729836 |
| 16:40 |
ANAND |
I'm yet to test this, but I'm sure it'd work |
| 16:54 |
Krock |
will merge #8767 in 10 minutes |
| 16:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/8767 -- Fix rotation of attached particlespawner [no squash pls; ketchup ok] by ClobberXD |
| 17:05 |
Krock |
merging |
| 17:07 |
|
srifqi joined #minetest-dev |
| 17:10 |
|
nerzhul joined #minetest-dev |
| 17:10 |
Krock |
(done) |
| 17:10 |
p_gimeno |
thanks |
| 17:11 |
p_gimeno |
and thanks ANAND for hosting the PR |
| 17:11 |
|
nerzhul joined #minetest-dev |
| 17:14 |
|
Cornelia joined #minetest-dev |
| 17:25 |
Krock |
saturday again.. anyone here for a meeting? https://dev.minetest.net/Meetings#2019-0X-XX |
| 17:26 |
rubenwardy |
i'm here |
| 17:44 |
|
paramat joined #minetest-dev |
| 17:44 |
paramat |
i'm here |
| 18:04 |
|
Cornelia joined #minetest-dev |
| 18:06 |
nepugia |
Hi paramat |
| 18:09 |
|
Player-2 joined #minetest-dev |
| 18:19 |
|
proller joined #minetest-dev |
| 18:21 |
paramat |
O/ |
| 18:32 |
paramat |
simple PR game#2457 |
| 18:32 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2457 -- Creative: Override the hand instead of re-registering by paramat |
| 18:34 |
sfan5 |
tested? |
| 18:38 |
paramat |
yes :) |
| 18:42 |
|
Lone_Wolf joined #minetest-dev |
| 18:43 |
paramat |
thanks, merging |
| 19:01 |
|
Cornelia joined #minetest-dev |
| 19:02 |
srifqi |
I was reading #7614 and coded something to add it (maybe): https://github.com/srifqi/minetest/tree/set_sky_more |
| 19:02 |
ShadowBot |
https://github.com/minetest/minetest/issues/7614 -- Add sun/moon and maybe stars to set_sky |
| 19:10 |
|
pauloue joined #minetest-dev |
| 19:16 |
|
srifqi left #minetest-dev |
| 19:19 |
|
paramat joined #minetest-dev |
| 19:22 |
paramat |
#7847 has been waiting a while, needs 1 more approval |
| 19:22 |
ShadowBot |
https://github.com/minetest/minetest/issues/7847 -- Don't use separate checkbox to disable flag by srifqi |
| 19:44 |
nepugia |
paramat, i made the pr for the default stack sizes, or well i wrote the code |
| 19:45 |
nepugia |
My intention for the patch is to give server admins an easier way to set the default stack size for their server, i had talked to some who did not like the default either, but they did not want to maintain a patchset against buildin or mt itself just for a setting, which is understandable |
| 19:46 |
nepugia |
from an abi standpoint other aproaches to enforece or change stack sizes would work just as well as they worked before |
| 19:47 |
paramat |
ok |
| 19:54 |
Krock |
Did not test the checkbox PR, but the code looks good. |
| 19:55 |
paramat |
i tested it quite a lot, seems to work fine |
| 19:57 |
Krock |
good to hear. will probably check tomorrow too |
| 20:11 |
nepugia |
paramat, >Being done by a mod actually has advantages over using a global setting. |
| 20:11 |
nepugia |
I would be interested in what those might be |
| 20:12 |
nepugia |
For me one advantage of the settings based approach is that one does not accidentally overide mods with the loop which purposefully set a different stack value |
| 20:13 |
nepugia |
Also the claim that it makes little difference to a server owner i would challenge, setting a setting is easy, figuring out the api to loop over all mods and respect mods that need special care properly is hard |
| 20:27 |
paramat |
yes good points, my claim assumes the case where there are no conflicting mods. but still, i think it's better that mods sort that out |
| 20:29 |
nepugia |
No conflicting mods would be ideal indeed |
| 20:33 |
|
Cornelia joined #minetest-dev |
| 20:42 |
|
Ruslan1 joined #minetest-dev |
| 21:04 |
|
fruitsnack joined #minetest-dev |
| 21:11 |
nepugia |
still, even in a homogonous enviroment i would prefer the setting |
| 21:35 |
paramat |
it will probably be merged, it seems to have support from 2 core devs, i can't stop it :) |
| 21:39 |
nepugia |
Hmm, is benrob a dev? |
| 21:40 |
sfan5 |
no |
| 21:40 |
nepugia |
I wonder who the second core dev would be that supports it then |
| 21:41 |
nepugia |
oh well, not that important |
| 21:49 |
|
proller joined #minetest-dev |
| 22:12 |
paramat |
rubenwardy indicated support in the original MTG issue |
| 22:13 |
paramat |
https://github.com/minetest/minetest_game/issues/1724 |
| 23:01 |
|
paramat joined #minetest-dev |
| 23:02 |
|
nepugia_ joined #minetest-dev |
| 23:05 |
|
Ruslan1 joined #minetest-dev |
| 23:12 |
|
Cornelia joined #minetest-dev |
| 23:29 |
|
Cornelia joined #minetest-dev |
| 23:57 |
|
ssieb joined #minetest-dev |
