Minetest logo

IRC log for #minetest-dev, 2019-06-29

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:30 paramat joined #minetest-dev
01:15 YuGiOhJCJ joined #minetest-dev
01:16 cheapie joined #minetest-dev
01:16 rdococ joined #minetest-dev
01:44 Cornelia joined #minetest-dev
01:59 ssieb joined #minetest-dev
02:20 Cornelia joined #minetest-dev
02:25 Cornelia joined #minetest-dev
02:43 xerox123 joined #minetest-dev
02:43 xerox123_ joined #minetest-dev
02:49 YuGiOhJCJ joined #minetest-dev
02:49 paramat joined #minetest-dev
08:27 Puka joined #minetest-dev
09:49 rdococ joined #minetest-dev
10:04 proller joined #minetest-dev
11:21 proller joined #minetest-dev
11:43 Fixer joined #minetest-dev
12:40 calcul0n joined #minetest-dev
13:09 Krock joined #minetest-dev
14:07 LoneWolfHT joined #minetest-dev
14:37 pauloue joined #minetest-dev
14:50 Lunatrius joined #minetest-dev
15:30 Wuzzy joined #minetest-dev
15:35 CaptainAmazing95 joined #minetest-dev
15:45 Icedream joined #minetest-dev
16:00 Krock there goes my afternoon #8641
16:01 ShadowBot https://github.com/minetest/minetest/issues/8641 -- Clean up and fix freetype=false crashes by SmallJoker
16:20 ANAND joined #minetest-dev
16:24 rubenwardy Is there any reason that freetype isn't a hard requirement?
16:27 nerzhul i think it should be yes
16:46 Nelly joined #minetest-dev
17:22 paramat joined #minetest-dev
17:41 Krock whatever. the code needed a cleanup anyway
17:41 Krock it's already a hard dependency for client builds, or guiFormSpecMenu wouldn't compile
17:45 Krock How about a meeting today? paramat, rubenwardy, nerzhul ?
17:47 rubenwardy Sure
17:51 Krock one more?
17:53 Krock nore, sofar perhaps?
18:00 paramat i'm here from now on
18:04 nerzhul if yo uwant ask questions i'm not so far
18:11 paramat he's not sofar =)
18:32 pauloue joined #minetest-dev
18:33 pauloue joined #minetest-dev
18:39 Krock Well great. Missed the activity entirely.
18:40 Krock > Is 5.0.2 needed for the newlines in setting name bug?
18:40 Krock Source: https://dev.minetest.net/Meetings
18:40 Krock I don't think so. Not broken enough to release a new version for that
18:41 rubenwardy Asked because it could be a security issue
18:42 Krock yes it is, but the only news is now that people might see it as fixed in the logs
18:42 Krock I believe this bug existed for a very long time already, without anyone noticing it
18:42 Krock better roll out 5.1.0 after the formspec changes are done
18:48 Krock > What is needed to have good mobs in Minetest / Minetest Game?
18:48 Krock This was already discussed earlier, with VE. They must offer at least as much functionalities so players would use it
18:49 paramat i can't judge the newlines setting thing
18:49 Krock Did anyone already ask Tenplus1 whether we could integrate his mod into MTG?
18:50 Krock last time it was a fight about code style and when to fix it. Please not this topic again this time
18:50 paramat see my comments in the thread for this topic
18:50 Krock sorry, thread? missing link on the wiki
18:50 Krock nvm. private Minetest organisation post
18:51 paramat yes
18:52 rubenwardy One big issue is the shitty built-in pathfinder
18:52 Krock yep. that really need to improve first
18:52 Krock seen the issue recently about the lag spikes. eww
18:52 paramat so i'm ok with using mobs redo as long as it's checked first and altered if necessary. we'll need to maintain our own version for sure
18:53 paramat oh and remove blood =)
18:54 Krock better make it optional
18:55 Krock kids and adults have different opinions on that for more intense gameplay
18:55 paramat i can't see why, it's unnecessary
18:55 paramat just extra code to maintain
18:55 Krock it's eyecandy
18:55 Krock > 2 lines of particlespawner
18:55 Krock like, really?
18:55 paramat it's also unpleasant and violent, not suitable for MTG
18:55 rubenwardy I don't think the blood is needed
18:56 rubenwardy It can be done in a mod to make it more realistic
18:59 paramat i'm a mature adult and even i find blood particles repulsive =)
18:59 Krock okay
19:00 Krock > How best to manage Unarelith's refactors
19:00 paramat no-one's asked tenplus1 yet no
19:00 Krock noted the comments. will update the wiki page at the end
19:01 Krock who added this point? If it's about the formspec, it has to wait
19:02 rubenwardy It was me
19:02 rubenwardy Obviously that has to wait
19:02 Krock moving into the PR priority list
19:02 rubenwardy But do we allocate a time and block areas completely whilst it's being refactored?
19:03 rubenwardy Also applies to the game pr
19:03 Krock how would you want to block it?
19:03 Krock as in: not reviewing?
19:04 rubenwardy In the same way we're blocking the formspec refractors: not review PRs when others have greater priority
19:05 Krock okay. sounds good, but the contributors should easily see such planned area blocking
19:05 Krock not sure though, how and where to show that
19:06 Krock Using "Projects" might work. Sorting PRs is possible there too
19:08 paramat which refactor are you talkng about?
19:08 paramat but yes, blocking is ok for me as long as work goes ahead soon
19:09 paramat "who added this point? If it's about the formspec, it has to wait" what are you referring to?
19:11 Krock https://github.com/minetest/minetest/projects/6
19:12 Krock paramat: the list point "Unarelith's refactors"
19:12 paramat all i see on the wiki is 'How best to manage Unarelith's refactors'
19:13 Krock > Combine pathfinder issues into a single issue
19:13 Krock paramat: yes, that's why I asked
19:13 Krock it's about https://github.com/minetest/minetest/pull/7970
19:13 Krock rubenwardy added the point because it's also a PR which causes major conflicts in the formspec code
19:14 paramat ok
19:14 paramat ah ok
19:14 paramat misunderstood
19:15 Krock regarding the Pathfinder. So it would become similar to the sneak issues report
19:15 Krock it's all related to one function, so think it's fine to combine them.
19:16 Krock would anyone like to collect & close the relevant issues to create a new, general issue about it?
19:16 rubenwardy I don't have internet access currently
19:16 rubenwardy But don't mind doing that
19:16 rubenwardy There's 7 issues
19:17 rubenwardy My flatmate took the router, so no WiFi. Moving into new place tomorrow
19:17 paramat combining issues seems ok to me
19:17 paramat oh well i'm not sure
19:18 paramat if they're seperate issues, they should be seperate
19:18 paramat ?
19:19 paramat combined issues are known to a pain
19:19 paramat *to be a pain
19:20 Krock slap that flatmate. how mean from them
19:20 paramat some are near-duplicates though that can be combined
19:21 Krock paramat: it could also be an overview list. In case the pathfinder is written from scratch, all of them could be closed anyway
19:21 paramat use your good judgement =)
19:21 paramat my experience is overview issues are also a pain to maintain
19:21 paramat but neutral
19:23 paramat i think close #4933 no response and was closed by author earlier
19:23 ShadowBot https://github.com/minetest/minetest/issues/4933 -- Improve occlusion culling accuracy. by lhofhansl
19:25 paramat #4888 doesn't seem essential but is a bugfix, no conflicts, just needs reviews, i think keep open
19:25 ShadowBot https://github.com/minetest/minetest/issues/4888 -- Handle multiple deserialization of a block's entities by Rogier-5
19:26 paramat don't know why #5680 is 'possible close', see my comment, just needs reviews or disapproval
19:26 ShadowBot https://github.com/minetest/minetest/issues/5680 -- Add minetest.get_artificial_light and minetest.get_natural_light by HybridDog
19:29 Krock WTF Github
19:29 Krock how dare you refreshing the page after I click "No thanks"
19:30 paramat if #5653 needs altering it will need adopting. 'possible close' seems unsuitable, it just needs review =)
19:30 ShadowBot https://github.com/minetest/minetest/issues/5653 -- Add 'once_per_session' to the LBM definition. Default is 'false'. by BluebirdGreycoat
19:33 Krock needs review plus rebase
19:34 Krock not important enough for me
19:34 paramat closing #7233 no response from author
19:34 ShadowBot https://github.com/minetest/minetest/issues/7233 -- [WIP] Support 6 textures for more drawtypes by numberZero
19:34 Krock too bad, but okay
19:36 paramat i don't think numberzero likes to work on MT anymore =)
19:36 paramat they sound rather fed up
19:38 Krock his experimental rendering changes had a hard life
19:38 Krock one of the oldest Possible Close PRs: #4888
19:38 ShadowBot https://github.com/minetest/minetest/issues/4888 -- Handle multiple deserialization of a block's entities by Rogier-5
19:39 paramat yes the frustration is very understandable
19:39 Krock apparently still open. it makes sense to clear the array before populating it with the saved contents again
19:39 Krock no idea how I forgot about this PR
19:40 paramat removed 'possible close'
19:41 paramat closed #4933
19:41 ShadowBot https://github.com/minetest/minetest/issues/4933 -- Improve occlusion culling accuracy. by lhofhansl
19:44 Krock okay. Updated the wiki page. Let's see when the next meeting will be..
19:45 paramat anyway, 'Does 1 disapproval block a PR? '
19:45 paramat i think it should not
19:46 paramat unless of course it is a valid and unarguable technical point thta means something can't be merged
19:46 Krock indeed
19:47 paramat *that
19:54 rubenwardy I think that 1 disapproval should delay a pr
19:54 rubenwardy But not block forever
19:55 paramat i somewhat agree, a disapproval will tend to require more discussion
19:56 DS-minetest joined #minetest-dev
19:58 DS-minetest Could #8530 please be added to the formspec pr priority list?
19:58 ShadowBot https://github.com/minetest/minetest/issues/8530 -- Add scrollbaroptions FormSpec element by v-rob
20:24 Krock thanks. added
20:30 DS-minetest Krock: could it be moved one or two priorities up? it's not so big and scroll_container without settable min and max is a bit weird
20:31 Krock thing is, maybe it could be integrated into style[]
20:32 DS-minetest nah, the integrated scrollbars for example should not be "styled" this way
21:23 LoneWolfHT joined #minetest-dev
21:23 yohkara joined #minetest-dev
21:26 pauloue joined #minetest-dev
21:29 indiana joined #minetest-dev
22:36 YuGiOhJCJ joined #minetest-dev
23:27 paramat joined #minetest-dev
23:42 behalebabo joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext