Time |
Nick |
Message |
01:29 |
|
LoneWolfHT joined #minetest-dev |
01:43 |
|
ssieb joined #minetest-dev |
01:49 |
|
yohkara joined #minetest-dev |
02:17 |
|
Cornelia joined #minetest-dev |
02:29 |
|
deezl joined #minetest-dev |
04:02 |
|
YuGiOhJCJ joined #minetest-dev |
04:55 |
|
pauloue joined #minetest-dev |
06:32 |
|
ANAND joined #minetest-dev |
09:49 |
|
calcul0n joined #minetest-dev |
09:54 |
|
Wuzzy joined #minetest-dev |
10:33 |
|
proller joined #minetest-dev |
10:51 |
|
Fixer joined #minetest-dev |
11:13 |
|
calcul0n joined #minetest-dev |
11:50 |
|
Fixer joined #minetest-dev |
12:24 |
|
proller joined #minetest-dev |
12:45 |
|
proller joined #minetest-dev |
13:19 |
|
proller joined #minetest-dev |
14:17 |
|
pauloue joined #minetest-dev |
14:34 |
|
proller joined #minetest-dev |
14:57 |
|
DS-minetest joined #minetest-dev |
15:06 |
|
proller joined #minetest-dev |
15:31 |
|
Fixer joined #minetest-dev |
15:36 |
|
LoneWolfHT joined #minetest-dev |
15:47 |
|
LoneWolfHT joined #minetest-dev |
15:56 |
|
Fixer joined #minetest-dev |
16:16 |
|
twoelk joined #minetest-dev |
16:20 |
|
tomraceror joined #minetest-dev |
16:22 |
tomraceror |
is the translation for mintest german done? |
17:07 |
|
Krock joined #minetest-dev |
17:10 |
|
DS-minetest_ joined #minetest-dev |
17:48 |
|
Icedream joined #minetest-dev |
18:03 |
Krock |
why is there initializeSecurity() and initializeSecurityClient() ?? Both ought to do the same |
18:03 |
sfan5 |
do they do the same though? |
18:03 |
Krock |
no, debug.traceback for stack backtrace is missing, for example |
18:04 |
Krock |
doing side-by-side comparison now |
18:06 |
rubenwardy |
Krock: client security needs to be more secure |
18:06 |
Krock |
yes, just seen that "io" is locked out |
18:07 |
Krock |
still, these functions should be unified due to the amount of shared code |
18:07 |
rubenwardy |
I agree |
18:07 |
rubenwardy |
the client API should be whitelist based |
18:07 |
rubenwardy |
but it's less critical for the server API to be so |
18:17 |
Krock |
oh. #8626 is probably caused by incomplete mod loading |
18:17 |
ShadowBot |
https://github.com/minetest/minetest/issues/8626 -- Can't join server when a message is sent on the server |
18:17 |
Krock |
the Lua environment might already be set up, but not builtin |
18:17 |
Krock |
since the mod loading only happens after receiving the CSM packet |
18:18 |
Krock |
*CSM restrictions packet |
18:23 |
Krock |
runCallbacksRaw() +if (m_type == ScriptingType::Client && !getClient()->modsLoaded()) return; |
18:23 |
Krock |
this does the trick for me. Crashes no longer occur |
18:24 |
Krock |
-> *PR" |
18:24 |
rubenwardy |
sounds correct |
18:24 |
rubenwardy |
there are other variations of runCallbakcs |
18:24 |
rubenwardy |
they may just call the raw version though |
18:24 |
Krock |
for example? |
18:25 |
rubenwardy |
oh nevermind |
18:25 |
rubenwardy |
I was thinking of the enum passed to it |
18:30 |
Krock |
testing... |
18:34 |
rubenwardy |
https://github.com/minetest/minetest/pull/7895#issuecomment-500287136 |
18:34 |
rubenwardy |
do people need this for this PR to be merged? |
18:37 |
Krock |
oh. looks like CSM's on_client_ready will become useless |
18:38 |
twoelk |
just out of interest, why can mods installed on a server crash clients on weak hardware? |
18:39 |
Krock |
I don't care whether it's a single commit or not |
18:39 |
rubenwardy |
it potentially makes it easier to not introduce makes, however I'd have to redo the PR |
18:39 |
Krock |
twoelk: race conditions? yet I didn't observe any |
18:39 |
Krock |
take the diff to the original file |
18:39 |
Krock |
commit the original file, apply diff. done. |
18:40 |
Krock |
there's even a "ignore space changes" option in the web diff |
18:40 |
|
BuckarooBanzai5 joined #minetest-dev |
18:41 |
rubenwardy |
oh yeah |
18:42 |
rubenwardy |
also, pushed a fix to #7895 |
18:42 |
ShadowBot |
https://github.com/minetest/minetest/issues/7895 -- Add luacheck to check builtin by rubenwardy |
19:25 |
Krock |
looks good now |
19:50 |
|
LoneWolfHT joined #minetest-dev |
20:01 |
|
LoneWolfHT left #minetest-dev |
20:02 |
|
Lone_Wolf joined #minetest-dev |
20:06 |
|
LoneWolfHT joined #minetest-dev |
20:15 |
|
ssieb joined #minetest-dev |
20:32 |
|
Icedream joined #minetest-dev |
20:45 |
|
fwhcat joined #minetest-dev |
21:09 |
|
paramat joined #minetest-dev |
21:33 |
|
proller joined #minetest-dev |
22:50 |
|
twoelk left #minetest-dev |
22:56 |
rubenwardy |
simple PR: #8383 |
22:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/8383 -- Add formspec styling using a style[] tag by rubenwardy |
22:57 |
rubenwardy |
err |
22:57 |
rubenwardy |
#8611 |
22:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/8611 -- Add support for set_formspec_prepend in main menu by rubenwardy |
22:57 |
rubenwardy |
actually, if anyone has time reviewing #8524 would be better |
22:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/8524 -- Add compatible, consistent coordinate system to FormSpecs. by v-rob |
23:21 |
|
pauloue joined #minetest-dev |